RubyGems - fassbinder - Versions diffs - 0.0.5 → 0.0.6 - Mend

fassbinder 0.0.5 → 0.0.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (7) hide show

data/README.md +1 -1
data/fassbinder.gemspec +2 -2
data/fassbinder.jpg +0 -0
data/lib/fassbinder/response.rb +62 -46
data/lib/fassbinder/version.rb +1 -1
data/spec/fassbinder/response_spec.rb +6 -4
metadata +5 -4

data/README.md CHANGED Viewed

@@ -1,4 +1,4 @@
 Fassbinder
 ==========
-![Fassbinder](http://www.ejournal.at/artsite/fassbinder.jpg)
+![Fassbinder](https://github.com/papercavalier/fassbinder/raw/master/fassbinder.jpg)

data/fassbinder.gemspec CHANGED Viewed

@@ -19,8 +19,8 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ['lib']
-  s.add_dependency('kosher', '~> 0.2.10')
-  s.add_dependency('sucker', '~> 1.3.1')
+  s.add_dependency('kosher', '~> 0.2.14')
+  s.add_dependency('sucker', '~> 1.4.0')
   s.add_development_dependency('rspec', '~> 2.5.0')
   s.add_development_dependency('ruby-debug19', '~> 0.11.6')
   s.add_development_dependency('vcr', '~> 1.7.0')

data/fassbinder.jpg ADDED Viewed

Binary file

data/lib/fassbinder/response.rb CHANGED Viewed

@@ -1,4 +1,8 @@
 module Fassbinder
+  # And I don't believe that melodramatic feelings are laughable - they should
+  # be taken absolutely seriously.
+  #
   class Response
     def initialize(response, locale)
       raise InvalidResponseError unless response.valid?
@@ -7,53 +11,17 @@ module Fassbinder
       @locale   = locale
     end
-    # And I don't believe that melodramatic feelings are laughable -
-    # they should be taken absolutely seriously.
-    def snapshots
-      @response.map('Item') do |doc|
-        Kosher::Snapshot.new(
-          'amazon.' + Sucker::Request::HOSTS[@locale].match(/[^.]+$/).to_s,
-          nil,
-          doc['ASIN'],
-          doc['SalesRank'].to_i,
-          doc['Offers']['TotalOffers'].to_i,
-          [doc['Offers']['Offer']].flatten.compact.map do |doc|
-            if doc['OfferListing']['Price']['CurrencyCode'] == 'JPY'
-              doc['OfferListing']['Price']['Amount'] = doc['OfferListing']['Price']['Amount'].to_i * 100
-            end
+    # Yields each snapshot to given block.
+    #
+    def each
+      @response.each('Item') { |doc| yield parse(doc) }
+    end
-            Kosher::Offer.new(
-              doc['OfferListing']['OfferListingId'],
-              Kosher::Item.new(doc['OfferListing']['Price']['Amount'].to_i,
-                               doc['OfferListing']['Price']['CurrencyCode'],
-                               doc['OfferListing']['Quantity'].to_i,
-                               Kosher::Condition.new(case doc['OfferAttributes']['SubCondition']
-                                                     when 'new'        then 1
-                                                     when 'mint'       then 2
-                                                     when 'verygood'   then 3
-                                                     when 'good'       then 4
-                                                     when 'acceptable' then 5
-                                                     else 6
-                                                     end),
-                               Kosher::Description.new(doc['OfferAttributes']['ConditionNote'].to_s)),
-              Kosher::Seller.new(doc['Merchant']['MerchantId'],
-                                 doc['Merchant']['Name'],
-                                 doc['Merchant']['AverageFeedbackRating'].to_f,
-                                 Kosher::Location.new((doc['Merchant']['Location']['CountryCode'] rescue nil), (doc['Merchant']['Location']['StateCode'] rescue nil))),
-              Kosher::Shipping.new(doc['OfferListing']['IsEligibleForSuperSaverShipping'] == '1' ?
-                                     0 : (case @locale
-                                          when :us then 399
-                                          when :uk then 280
-                                          when :de then 299
-                                          when :ca then 649
-                                          when :fr then 300
-                                          when :jp then 25000
-                                          end),
-                                   doc['OfferListing']['Price']['CurrencyCode'],
-                                   Kosher::Availability.new(doc['OfferListing']['AvailabilityAttributes']['MaximumHours'].to_i))
-            )
-          end
-        )
+    # Returns an array of snapshots.
+    #
+    def to_a
+      @response.map('Item') do |doc|
+        parse(doc)
       end
     end
@@ -62,5 +30,53 @@ module Fassbinder
         error['Message'].scan(/[0-9A-Z]{10}/).first rescue nil
       end.compact
     end
+    private
+    def parse(doc)
+      Kosher::Snapshot.new(
+        'amazon.' + Sucker::Request::HOSTS[@locale].match(/[^.]+$/).to_s,
+        nil,
+        doc['ASIN'],
+        doc['SalesRank'].to_i,
+        doc['Offers']['TotalOffers'].to_i,
+        [doc['Offers']['Offer']].flatten.compact.map do |doc|
+          if doc['OfferListing']['Price']['CurrencyCode'] == 'JPY'
+            doc['OfferListing']['Price']['Amount'] = doc['OfferListing']['Price']['Amount'].to_i * 100
+          end
+          Kosher::Offer.new(
+            doc['OfferListing']['OfferListingId'],
+            Kosher::Item.new(doc['OfferListing']['Price']['Amount'].to_i,
+                             doc['OfferListing']['Price']['CurrencyCode'],
+                             doc['OfferListing']['Quantity'].to_i,
+                             Kosher::Condition.new(case doc['OfferAttributes']['SubCondition']
+                                                   when 'new'        then 1
+                                                   when 'mint'       then 2
+                                                   when 'verygood'   then 3
+                                                   when 'good'       then 4
+                                                   when 'acceptable' then 5
+                                                   else 6
+                                                   end),
+                             Kosher::Description.new(doc['OfferAttributes']['ConditionNote'].to_s)),
+            Kosher::Seller.new(doc['Merchant']['MerchantId'],
+                               doc['Merchant']['Name'],
+                               doc['Merchant']['AverageFeedbackRating'].to_f,
+                               Kosher::Location.new((doc['Merchant']['Location']['CountryCode'] rescue nil), (doc['Merchant']['Location']['StateCode'] rescue nil))),
+            Kosher::Shipping.new(doc['OfferListing']['IsEligibleForSuperSaverShipping'] == '1' ?
+                                   0 : (case @locale
+                                        when :us then 399
+                                        when :uk then 280
+                                        when :de then 299
+                                        when :ca then 649
+                                        when :fr then 300
+                                        when :jp then 25000
+                                        end),
+                                 doc['OfferListing']['Price']['CurrencyCode'],
+                                 Kosher::Availability.new(doc['OfferListing']['AvailabilityAttributes']['MaximumHours'].to_i))
+          )
+        end
+      )
+    end
   end
 end

data/lib/fassbinder/version.rb CHANGED Viewed

@@ -1,3 +1,3 @@
 module Fassbinder
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/spec/fassbinder/response_spec.rb CHANGED Viewed

@@ -31,10 +31,12 @@ module Fassbinder
       end
     end
-    describe "#snapshots" do
-      it "should return snapshots" do
-        response.snapshots.count.should eql 19
-        response.snapshots.first.should be_a Kosher::Snapshot
+    describe "#to_a" do
+      it "returns an array of snapshots" do
+        snapshots = response.to_a
+        snapshots.count.should eql 19
+        snapshots.first.should be_a Kosher::Snapshot
       end
     end

metadata CHANGED Viewed

@@ -2,7 +2,7 @@
 name: fassbinder
 version: !ruby/object:Gem::Version
   prerelease:
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Paper Cavalier
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
-date: 2011-03-10 00:00:00 +00:00
+date: 2011-03-17 00:00:00 +00:00
 default_executable:
 dependencies:
 - !ruby/object:Gem::Dependency
@@ -21,7 +21,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.2.10
+        version: 0.2.14
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency
@@ -32,7 +32,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: 1.4.0
   type: :runtime
   version_requirements: *id002
 - !ruby/object:Gem::Dependency
@@ -94,6 +94,7 @@ files:
 - README.md
 - Rakefile
 - fassbinder.gemspec
+- fassbinder.jpg
 - lib/fassbinder.rb
 - lib/fassbinder/request.rb
 - lib/fassbinder/response.rb