fassbinder 0.0.2 → 0.0.3

data/.gitignore

@@ -4,4 +4,4 @@ pkg/*
 .rvmrc
 .rspec
 Gemfile.lock
-amazon.yml
+*.yml

data/fassbinder.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ['lib']
 
-  s.add_dependency('kosher', '~> 0.2.7')
+  s.add_dependency('kosher', '~> 0.2.8')
   s.add_dependency('sucker', '~> 1.3.1')
   s.add_development_dependency('rspec', '~> 2.5.0')
   s.add_development_dependency('ruby-debug19', '~> 0.11.6')

data/lib/fassbinder/request.rb

@@ -16,7 +16,7 @@ module Fassbinder
     end
 
     def get
-      ResponseWrapper.new(super, locale)
+      Response.new(super, locale)
     end
   end
 end

data/lib/fassbinder/{response_wrapper.rb → response.rb}

@@ -1,5 +1,5 @@
 module Fassbinder
-  class ResponseWrapper
+  class Response
     def initialize(response, locale)
       raise InvalidResponseError unless response.valid?
 
@@ -9,12 +9,13 @@ module Fassbinder
 
     # And I don't believe that melodramatic feelings are laughable -
     # they should be taken absolutely seriously.
-    def items
+    def snapshots
       @response.map('Item') do |doc|
-        Item.new(
+        Kosher::Snapshot.new(
+          nil,
           doc['ASIN'],
-          doc['Offers']['TotalOffers'].to_i,
           doc['SalesRank'].to_i,
+          doc['Offers']['TotalOffers'].to_i,
           [doc['Offers']['Offer']].flatten.compact.map do |doc|
             if doc['OfferListing']['Price']['CurrencyCode'] == 'JPY'
               doc['OfferListing']['Price']['Amount'] = doc['OfferListing']['Price']['Amount'].to_i * 100
@@ -60,9 +61,5 @@ module Fassbinder
         error['Message'].scan(/[0-9A-Z]{10}/).first rescue nil
       end.compact
     end
-
-    def response
-      @response
-    end
   end
 end

data/lib/fassbinder/version.rb

@@ -1,3 +1,3 @@
 module Fassbinder
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/lib/fassbinder.rb

@@ -1,7 +1,9 @@
 require 'kosher'
 require 'sucker'
 
-require 'fassbinder/errors'
-require 'fassbinder/item'
 require 'fassbinder/request'
-require 'fassbinder/response_wrapper'
+require 'fassbinder/response'
+
+module Fassbinder
+  class InvalidResponseError < StandardError; end
+end

data/spec/fassbinder/response_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+module Fassbinder
+  describe Response do
+    use_vcr_cassette 'batch-request'
+
+    let(:asins) do
+      # The last ASIN does not exist.
+      %w{
+        0816614024 0143105825 0485113600 0816616779 0942299078
+        0816614008 144006654X 0486400360 0486417670 087220474X
+        0486454398 0268018359 1604246014 184467598X 0312427182
+        1844674282 0745640974 0745646441 0826489540 2081232191 }
+    end
+
+    let(:response) do
+      request = Request.new(credentials)
+      request.locale = :us
+      request.batchify(asins)
+      request.get
+    end
+
+    describe ".new" do
+      it "raises an error if response is not valid" do
+        response = mock('Response')
+        response.stub!(:valid?).and_return(false)
+
+        expect do
+          Response.new(response, :us)
+        end.to raise_error InvalidResponseError
+      end
+    end
+
+    describe "#snapshots" do
+      it "should return snapshots" do
+        debugger
+        response.snapshots.count.should eql 19
+        response.snapshots.first.should be_a Kosher::Snapshot
+      end
+    end
+
+    describe "#errors" do
+      it "should return ASINs that are not found" do
+        response.errors.count.should eql 1
+        response.errors.first.should eql '2081232191'
+      end
+    end
+  end
+end

metadata

@@ -2,7 +2,7 @@
 name: fassbinder
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors: 
 - Paper Cavalier
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-09 00:00:00 +00:00
+date: 2011-03-10 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -21,7 +21,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 0.2.7
+        version: 0.2.8
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
@@ -96,12 +96,11 @@ files:
 - fassbinder.gemspec
 - lib/fassbinder.rb
 - lib/fassbinder/errors.rb
-- lib/fassbinder/item.rb
 - lib/fassbinder/request.rb
-- lib/fassbinder/response_wrapper.rb
+- lib/fassbinder/response.rb
 - lib/fassbinder/version.rb
 - spec/fassbinder/request_spec.rb
-- spec/fassbinder/response_wrapper_spec.rb
+- spec/fassbinder/response_spec.rb
 - spec/spec_helper.rb
 - spec/support/credentials.rb
 - spec/support/vcr.rb
@@ -135,7 +134,7 @@ specification_version: 3
 summary: Wraps Amazon in a loving embrace.
 test_files: 
 - spec/fassbinder/request_spec.rb
-- spec/fassbinder/response_wrapper_spec.rb
+- spec/fassbinder/response_spec.rb
 - spec/spec_helper.rb
 - spec/support/credentials.rb
 - spec/support/vcr.rb

data/lib/fassbinder/item.rb

@@ -1,4 +0,0 @@
-module Fassbinder
-  class Item < Struct.new(:asin, :count, :rank, :offers)
-  end
-end

data/spec/fassbinder/response_wrapper_spec.rb

@@ -1,49 +0,0 @@
-require 'spec_helper'
-
-module Fassbinder
-  describe ResponseWrapper do
-    describe ".new" do
-      it "raises an error if response is not valid" do
-        response = mock('Response')
-        response.stub!(:valid?).and_return(false)
-
-        expect do
-          ResponseWrapper.new(response, :us)
-        end.to raise_error InvalidResponseError
-      end
-    end
-
-    describe "#books" do
-      use_vcr_cassette 'batch-request'
-
-      let(:asins) do
-        # The last ASIN does not exist.
-        %w{
-          0816614024 0143105825 0485113600 0816616779 0942299078
-          0816614008 144006654X 0486400360 0486417670 087220474X
-          0486454398 0268018359 1604246014 184467598X 0312427182
-          1844674282 0745640974 0745646441 0826489540 2081232191 }
-      end
-
-      let(:response_wrapper) do
-        request = Request.new(credentials)
-        request.locale = :us
-        request.batchify(asins)
-        request.get
-      end
-
-      it "should return found books" do
-        debugger
-        response_wrapper.items.count.should eql 19
-        response_wrapper.items.first.should be_a Book
-      end
-    end
-
-    describe "#errors" do
-      it "should return ASINs that are not found" do
-        algorithm.errors.count.should eql 1
-        algorithm.errors.first.should eql '2081232191'
-      end
-    end
-  end
-end