faraday 2.7.5 → 2.7.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ddb207e6f8b639db4a4f162edd714b008e84ba8a967dc2c94977aaea1d87e7fe
-  data.tar.gz: 6e624ee223ee7322caa02e03faf735ff5733eafefeb2d1f289388211228ea42b
+  metadata.gz: 577d9d7b4585ac946a788742a72828cb20a627e843754a195a12c9b60df7fcf1
+  data.tar.gz: 4f87ff29ceda48a5f5f3bf14ea07a8b04bb0bdc521cec478ec570fc7beaf8ef9
 SHA512:
-  metadata.gz: 218f458603cb4401eb89ac7fa4300cd34f8aadc41325d31e63f05b6ffe6e4a94c6408f3a0dcbb738b7ab9a7cafce373f6b3f0d4be8ea0c044d9c87eeae5b9a52
-  data.tar.gz: b6859a02105b9ea6559dc6fd54554c3c035a1b135e7e7dbcc842325273a3ba7ca0bcdf477d9ec3185a7e016ab0e1ad85debb87c978484113691aa7888fe85a35
+  metadata.gz: b2585b9b639bcb64bb963264224c88c1716e890c485e9ac9c356d1f6f8547ed67718c78ee26e88ea93392757686c30f5cc1f17a75f645959bfde0aeffae4a346
+  data.tar.gz: d036376b82bf8bd6459220c06fe8151a374f5914d6b16fd2633c62620dcde1f15911abffa250859269139b7aec035de2a0953f661a8fc50cfe7ba55b2f93928c

data/README.md

@@ -12,7 +12,8 @@ requests. Instead, you probably want to have a look at [Awesome Faraday][awesome
 ## Getting Started
 
 The best starting point is the [Faraday Website][website], with its introduction and explanation.
-Need more details? See the [Faraday API Documentation][apidoc] to see how it works internally.
+
+Need more details? See the [Faraday API Documentation][apidoc] to see how it works internally, or take a look at [Advanced techniques for calling HTTP APIs in Ruby](https://mattbrictson.com/blog/advanced-http-techniques-in-ruby) blog post from @mattbrictson 🚀
 
 ## Supported Ruby versions
 

data/Rakefile

@@ -2,6 +2,8 @@
 
 require 'rspec/core/rake_task'
 
-RSpec::Core::RakeTask.new(:spec)
+RSpec::Core::RakeTask.new(:spec) do |task|
+  task.ruby_opts = %w[-W]
+end
 
 task default: :spec

data/lib/faraday/error.rb

@@ -29,15 +29,21 @@ module Faraday
     end
 
     def response_status
-      @response[:status] if @response
+      return unless @response
+
+      @response.is_a?(Faraday::Response) ? @response.status : @response[:status]
     end
 
     def response_headers
-      @response[:headers] if @response
+      return unless @response
+
+      @response.is_a?(Faraday::Response) ? @response.headers : @response[:headers]
     end
 
     def response_body
-      @response[:body] if @response
+      return unless @response
+
+      @response.is_a?(Faraday::Response) ? @response.body : @response[:body]
     end
 
     protected

data/lib/faraday/options.rb

@@ -174,6 +174,7 @@ module Faraday
 
       memoized_attributes[key.to_sym] = block
       class_eval <<-RUBY, __FILE__, __LINE__ + 1
+        remove_method(key) if method_defined?(key, false)
         def #{key}() self[:#{key}]; end
       RUBY
     end

data/lib/faraday/request/instrumentation.rb

@@ -6,11 +6,13 @@ module Faraday
     class Instrumentation < Faraday::Middleware
       # Options class used in Request::Instrumentation class.
       Options = Faraday::Options.new(:name, :instrumenter) do
+        remove_method :name
         # @return [String]
         def name
           self[:name] ||= 'request.faraday'
         end
 
+        remove_method :instrumenter
         # @return [Class]
         def instrumenter
           self[:instrumenter] ||= ActiveSupport::Notifications

data/lib/faraday/request.rb

@@ -42,6 +42,7 @@ module Faraday
       end
     end
 
+    remove_method :params=
     # Replace params, preserving the existing hash type.
     #
     # @param hash [Hash] new params
@@ -53,6 +54,7 @@ module Faraday
       end
     end
 
+    remove_method :headers=
     # Replace request headers, preserving the existing hash type.
     #
     # @param hash [Hash] new headers

data/lib/faraday/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Faraday
-  VERSION = '2.7.5'
+  VERSION = '2.7.7'
 end

data/spec/faraday/error_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Faraday::ClientError do
+RSpec.describe Faraday::Error do
   describe '.initialize' do
     subject { described_class.new(exception, response) }
     let(:response) { nil }
@@ -12,8 +12,10 @@ RSpec.describe Faraday::ClientError do
       it { expect(subject.response).to be_nil }
       it { expect(subject.message).to eq(exception.message) }
       it { expect(subject.backtrace).to eq(exception.backtrace) }
-      it { expect(subject.inspect).to eq('#<Faraday::ClientError wrapped=#<RuntimeError: test>>') }
+      it { expect(subject.inspect).to eq('#<Faraday::Error wrapped=#<RuntimeError: test>>') }
       it { expect(subject.response_status).to be_nil }
+      it { expect(subject.response_headers).to be_nil }
+      it { expect(subject.response_body).to be_nil }
     end
 
     context 'with response hash' do
@@ -22,8 +24,10 @@ RSpec.describe Faraday::ClientError do
       it { expect(subject.wrapped_exception).to be_nil }
       it { expect(subject.response).to eq(exception) }
       it { expect(subject.message).to eq('the server responded with status 400') }
-      it { expect(subject.inspect).to eq('#<Faraday::ClientError response={:status=>400}>') }
+      it { expect(subject.inspect).to eq('#<Faraday::Error response={:status=>400}>') }
       it { expect(subject.response_status).to eq(400) }
+      it { expect(subject.response_headers).to be_nil }
+      it { expect(subject.response_body).to be_nil }
     end
 
     context 'with string' do
@@ -32,8 +36,10 @@ RSpec.describe Faraday::ClientError do
       it { expect(subject.wrapped_exception).to be_nil }
       it { expect(subject.response).to be_nil }
       it { expect(subject.message).to eq('custom message') }
-      it { expect(subject.inspect).to eq('#<Faraday::ClientError #<Faraday::ClientError: custom message>>') }
+      it { expect(subject.inspect).to eq('#<Faraday::Error #<Faraday::Error: custom message>>') }
       it { expect(subject.response_status).to be_nil }
+      it { expect(subject.response_headers).to be_nil }
+      it { expect(subject.response_body).to be_nil }
     end
 
     context 'with anything else #to_s' do
@@ -42,8 +48,10 @@ RSpec.describe Faraday::ClientError do
       it { expect(subject.wrapped_exception).to be_nil }
       it { expect(subject.response).to be_nil }
       it { expect(subject.message).to eq('["error1", "error2"]') }
-      it { expect(subject.inspect).to eq('#<Faraday::ClientError #<Faraday::ClientError: ["error1", "error2"]>>') }
+      it { expect(subject.inspect).to eq('#<Faraday::Error #<Faraday::Error: ["error1", "error2"]>>') }
       it { expect(subject.response_status).to be_nil }
+      it { expect(subject.response_headers).to be_nil }
+      it { expect(subject.response_body).to be_nil }
     end
 
     context 'with exception string and response hash' do
@@ -53,8 +61,25 @@ RSpec.describe Faraday::ClientError do
       it { expect(subject.wrapped_exception).to be_nil }
       it { expect(subject.response).to eq(response) }
       it { expect(subject.message).to eq('custom message') }
-      it { expect(subject.inspect).to eq('#<Faraday::ClientError response={:status=>400}>') }
+      it { expect(subject.inspect).to eq('#<Faraday::Error response={:status=>400}>') }
       it { expect(subject.response_status).to eq(400) }
+      it { expect(subject.response_headers).to be_nil }
+      it { expect(subject.response_body).to be_nil }
+    end
+
+    context 'with exception and response object' do
+      let(:exception) { RuntimeError.new('test') }
+      let(:body) { { test: 'test' } }
+      let(:headers) { { 'Content-Type' => 'application/json' } }
+      let(:response) { Faraday::Response.new(status: 400, response_headers: headers, response_body: body) }
+
+      it { expect(subject.wrapped_exception).to eq(exception) }
+      it { expect(subject.response).to eq(response) }
+      it { expect(subject.message).to eq(exception.message) }
+      it { expect(subject.backtrace).to eq(exception.backtrace) }
+      it { expect(subject.response_status).to eq(400) }
+      it { expect(subject.response_headers).to eq(headers) }
+      it { expect(subject.response_body).to eq(body) }
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: faraday
 version: !ruby/object:Gem::Version
-  version: 2.7.5
+  version: 2.7.7
 platform: ruby
 authors:
 - "@technoweenie"
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-23 00:00:00.000000000 Z
+date: 2023-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday-net_http
@@ -131,7 +131,7 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://lostisland.github.io/faraday
-  changelog_uri: https://github.com/lostisland/faraday/releases/tag/v2.7.5
+  changelog_uri: https://github.com/lostisland/faraday/releases/tag/v2.7.7
   source_code_uri: https://github.com/lostisland/faraday
   bug_tracker_uri: https://github.com/lostisland/faraday/issues
 post_install_message: