faraday 1.9.3 → 2.0.0.alpha.pre.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/CHANGELOG.md +111 -1
- data/README.md +16 -9
- data/examples/client_test.rb +1 -1
- data/lib/faraday/adapter/test.rb +2 -0
- data/lib/faraday/adapter.rb +0 -5
- data/lib/faraday/connection.rb +3 -84
- data/lib/faraday/encoders/nested_params_encoder.rb +2 -2
- data/lib/faraday/error.rb +7 -0
- data/lib/faraday/file_part.rb +122 -0
- data/lib/faraday/logging/formatter.rb +1 -0
- data/lib/faraday/middleware.rb +0 -1
- data/lib/faraday/middleware_registry.rb +15 -79
- data/lib/faraday/options.rb +3 -3
- data/lib/faraday/param_part.rb +53 -0
- data/lib/faraday/rack_builder.rb +1 -1
- data/lib/faraday/request/authorization.rb +26 -40
- data/lib/faraday/request/instrumentation.rb +2 -0
- data/lib/faraday/request/json.rb +55 -0
- data/lib/faraday/request/multipart.rb +108 -0
- data/lib/faraday/request/retry.rb +241 -0
- data/lib/faraday/request/url_encoded.rb +2 -0
- data/lib/faraday/request.rb +13 -29
- data/lib/faraday/response/json.rb +54 -0
- data/lib/faraday/response/logger.rb +4 -4
- data/lib/faraday/response/raise_error.rb +9 -1
- data/lib/faraday/response.rb +8 -19
- data/lib/faraday/utils/headers.rb +1 -1
- data/lib/faraday/utils.rb +9 -4
- data/lib/faraday/version.rb +1 -1
- data/lib/faraday.rb +8 -45
- data/spec/faraday/connection_spec.rb +78 -51
- data/spec/faraday/options/env_spec.rb +2 -2
- data/spec/faraday/rack_builder_spec.rb +5 -43
- data/spec/faraday/request/authorization_spec.rb +14 -36
- data/spec/faraday/request/instrumentation_spec.rb +5 -7
- data/spec/faraday/request/json_spec.rb +111 -0
- data/spec/faraday/request/multipart_spec.rb +302 -0
- data/spec/faraday/request/retry_spec.rb +254 -0
- data/spec/faraday/request_spec.rb +0 -11
- data/spec/faraday/response/json_spec.rb +117 -0
- data/spec/faraday/response/raise_error_spec.rb +7 -4
- data/spec/faraday/utils_spec.rb +1 -1
- data/spec/support/fake_safe_buffer.rb +1 -1
- data/spec/support/shared_examples/request_method.rb +5 -5
- metadata +26 -151
- data/lib/faraday/adapter/typhoeus.rb +0 -15
- data/lib/faraday/autoload.rb +0 -87
- data/lib/faraday/dependency_loader.rb +0 -37
- data/lib/faraday/request/basic_authentication.rb +0 -20
- data/lib/faraday/request/token_authentication.rb +0 -20
- data/spec/faraday/adapter/em_http_spec.rb +0 -49
- data/spec/faraday/adapter/em_synchrony_spec.rb +0 -18
- data/spec/faraday/adapter/excon_spec.rb +0 -49
- data/spec/faraday/adapter/httpclient_spec.rb +0 -73
- data/spec/faraday/adapter/net_http_spec.rb +0 -64
- data/spec/faraday/adapter/patron_spec.rb +0 -18
- data/spec/faraday/adapter/rack_spec.rb +0 -8
- data/spec/faraday/adapter/typhoeus_spec.rb +0 -7
- data/spec/faraday/response/middleware_spec.rb +0 -68
- data/spec/support/webmock_rack_app.rb +0 -68
@@ -0,0 +1,54 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
require 'json'
|
4
|
+
|
5
|
+
module Faraday
|
6
|
+
class Response
|
7
|
+
# Parse response bodies as JSON.
|
8
|
+
class Json < Middleware
|
9
|
+
def initialize(app = nil, parser_options: nil, content_type: /\bjson$/, preserve_raw: false)
|
10
|
+
super(app)
|
11
|
+
@parser_options = parser_options
|
12
|
+
@content_types = Array(content_type)
|
13
|
+
@preserve_raw = preserve_raw
|
14
|
+
end
|
15
|
+
|
16
|
+
def on_complete(env)
|
17
|
+
process_response(env) if parse_response?(env)
|
18
|
+
end
|
19
|
+
|
20
|
+
private
|
21
|
+
|
22
|
+
def process_response(env)
|
23
|
+
env[:raw_body] = env[:body] if @preserve_raw
|
24
|
+
env[:body] = parse(env[:body])
|
25
|
+
rescue StandardError, SyntaxError => e
|
26
|
+
raise Faraday::ParsingError.new(e, env[:response])
|
27
|
+
end
|
28
|
+
|
29
|
+
def parse(body)
|
30
|
+
::JSON.parse(body, @parser_options || {}) unless body.strip.empty?
|
31
|
+
end
|
32
|
+
|
33
|
+
def parse_response?(env)
|
34
|
+
process_response_type?(env) &&
|
35
|
+
env[:body].respond_to?(:to_str)
|
36
|
+
end
|
37
|
+
|
38
|
+
def process_response_type?(env)
|
39
|
+
type = response_type(env)
|
40
|
+
@content_types.empty? || @content_types.any? do |pattern|
|
41
|
+
pattern.is_a?(Regexp) ? type.match?(pattern) : type == pattern
|
42
|
+
end
|
43
|
+
end
|
44
|
+
|
45
|
+
def response_type(env)
|
46
|
+
type = env[:response_headers][CONTENT_TYPE].to_s
|
47
|
+
type = type.split(';', 2).first if type.index(';')
|
48
|
+
type
|
49
|
+
end
|
50
|
+
end
|
51
|
+
end
|
52
|
+
end
|
53
|
+
|
54
|
+
Faraday::Response.register_middleware(json: Faraday::Response::Json)
|
@@ -1,6 +1,7 @@
|
|
1
1
|
# frozen_string_literal: true
|
2
2
|
|
3
3
|
require 'forwardable'
|
4
|
+
require 'logger'
|
4
5
|
require 'faraday/logging/formatter'
|
5
6
|
|
6
7
|
module Faraday
|
@@ -11,10 +12,7 @@ module Faraday
|
|
11
12
|
class Logger < Middleware
|
12
13
|
def initialize(app, logger = nil, options = {})
|
13
14
|
super(app)
|
14
|
-
logger ||=
|
15
|
-
require 'logger'
|
16
|
-
::Logger.new($stdout)
|
17
|
-
end
|
15
|
+
logger ||= ::Logger.new($stdout)
|
18
16
|
formatter_class = options.delete(:formatter) || Logging::Formatter
|
19
17
|
@formatter = formatter_class.new(logger: logger, options: options)
|
20
18
|
yield @formatter if block_given?
|
@@ -31,3 +29,5 @@ module Faraday
|
|
31
29
|
end
|
32
30
|
end
|
33
31
|
end
|
32
|
+
|
33
|
+
Faraday::Response.register_middleware(logger: Faraday::Response::Logger)
|
@@ -44,13 +44,21 @@ module Faraday
|
|
44
44
|
body: env.body,
|
45
45
|
request: {
|
46
46
|
method: env.method,
|
47
|
+
url: env.url,
|
47
48
|
url_path: env.url.path,
|
48
|
-
params: env
|
49
|
+
params: query_params(env),
|
49
50
|
headers: env.request_headers,
|
50
51
|
body: env.request_body
|
51
52
|
}
|
52
53
|
}
|
53
54
|
end
|
55
|
+
|
56
|
+
def query_params(env)
|
57
|
+
env.request.params_encoder ||= Faraday::Utils.default_params_encoder
|
58
|
+
env.params_encoder.decode(env.url.query)
|
59
|
+
end
|
54
60
|
end
|
55
61
|
end
|
56
62
|
end
|
63
|
+
|
64
|
+
Faraday::Response.register_middleware(raise_error: Faraday::Response::RaiseError)
|
data/lib/faraday/response.rb
CHANGED
@@ -5,25 +5,9 @@ require 'forwardable'
|
|
5
5
|
module Faraday
|
6
6
|
# Response represents an HTTP response from making an HTTP request.
|
7
7
|
class Response
|
8
|
-
# Used for simple response middleware.
|
9
|
-
class Middleware < Faraday::Middleware
|
10
|
-
# Override this to modify the environment after the response has finished.
|
11
|
-
# Calls the `parse` method if defined
|
12
|
-
# `parse` method can be defined as private, public and protected
|
13
|
-
def on_complete(env)
|
14
|
-
return unless respond_to?(:parse, true) && env.parse_body?
|
15
|
-
|
16
|
-
env.body = parse(env.body)
|
17
|
-
end
|
18
|
-
end
|
19
|
-
|
20
8
|
extend Forwardable
|
21
9
|
extend MiddlewareRegistry
|
22
10
|
|
23
|
-
register_middleware File.expand_path('response', __dir__),
|
24
|
-
raise_error: [:RaiseError, 'raise_error'],
|
25
|
-
logger: [:Logger, 'logger']
|
26
|
-
|
27
11
|
def initialize(env = nil)
|
28
12
|
@env = Env.from(env) if env
|
29
13
|
@on_complete_callbacks = []
|
@@ -42,6 +26,7 @@ module Faraday
|
|
42
26
|
def headers
|
43
27
|
finished? ? env.response_headers : {}
|
44
28
|
end
|
29
|
+
|
45
30
|
def_delegator :headers, :[]
|
46
31
|
|
47
32
|
def body
|
@@ -53,10 +38,10 @@ module Faraday
|
|
53
38
|
end
|
54
39
|
|
55
40
|
def on_complete(&block)
|
56
|
-
if
|
57
|
-
@on_complete_callbacks << block
|
58
|
-
else
|
41
|
+
if finished?
|
59
42
|
yield(env)
|
43
|
+
else
|
44
|
+
@on_complete_callbacks << block
|
60
45
|
end
|
61
46
|
self
|
62
47
|
end
|
@@ -99,3 +84,7 @@ module Faraday
|
|
99
84
|
end
|
100
85
|
end
|
101
86
|
end
|
87
|
+
|
88
|
+
require 'faraday/response/json'
|
89
|
+
require 'faraday/response/logger'
|
90
|
+
require 'faraday/response/raise_error'
|
@@ -111,7 +111,7 @@ module Faraday
|
|
111
111
|
def parse(header_string)
|
112
112
|
return unless header_string && !header_string.empty?
|
113
113
|
|
114
|
-
headers = header_string.split(
|
114
|
+
headers = header_string.split("\r\n")
|
115
115
|
|
116
116
|
# Find the last set of response headers.
|
117
117
|
start_index = headers.rindex { |x| x.start_with?('HTTP/') } || 0
|
data/lib/faraday/utils.rb
CHANGED
@@ -1,5 +1,7 @@
|
|
1
1
|
# frozen_string_literal: true
|
2
2
|
|
3
|
+
require 'base64'
|
4
|
+
require 'uri'
|
3
5
|
require 'faraday/utils/headers'
|
4
6
|
require 'faraday/utils/params_hash'
|
5
7
|
|
@@ -51,6 +53,12 @@ module Faraday
|
|
51
53
|
@default_params_encoder ||= NestedParamsEncoder
|
52
54
|
end
|
53
55
|
|
56
|
+
def basic_header_from(login, pass)
|
57
|
+
value = Base64.encode64("#{login}:#{pass}")
|
58
|
+
value.delete!("\n")
|
59
|
+
"Basic #{value}"
|
60
|
+
end
|
61
|
+
|
54
62
|
class << self
|
55
63
|
attr_writer :default_params_encoder
|
56
64
|
end
|
@@ -71,10 +79,7 @@ module Faraday
|
|
71
79
|
end
|
72
80
|
|
73
81
|
def default_uri_parser
|
74
|
-
@default_uri_parser ||=
|
75
|
-
require 'uri'
|
76
|
-
Kernel.method(:URI)
|
77
|
-
end
|
82
|
+
@default_uri_parser ||= Kernel.method(:URI)
|
78
83
|
end
|
79
84
|
|
80
85
|
def default_uri_parser=(parser)
|
data/lib/faraday/version.rb
CHANGED
data/lib/faraday.rb
CHANGED
@@ -4,16 +4,10 @@ require 'cgi'
|
|
4
4
|
require 'date'
|
5
5
|
require 'set'
|
6
6
|
require 'forwardable'
|
7
|
-
require 'faraday/middleware_registry'
|
8
|
-
require 'faraday/dependency_loader'
|
9
|
-
|
10
|
-
unless defined?(::Faraday::Timer)
|
11
|
-
require 'timeout'
|
12
|
-
::Faraday::Timer = Timeout
|
13
|
-
end
|
14
|
-
|
15
7
|
require 'faraday/version'
|
16
8
|
require 'faraday/methods'
|
9
|
+
require 'faraday/error'
|
10
|
+
require 'faraday/middleware_registry'
|
17
11
|
require 'faraday/utils'
|
18
12
|
require 'faraday/options'
|
19
13
|
require 'faraday/connection'
|
@@ -23,26 +17,8 @@ require 'faraday/middleware'
|
|
23
17
|
require 'faraday/adapter'
|
24
18
|
require 'faraday/request'
|
25
19
|
require 'faraday/response'
|
26
|
-
require 'faraday/
|
27
|
-
require 'faraday/
|
28
|
-
|
29
|
-
# External Middleware gems and their aliases
|
30
|
-
require 'faraday/multipart'
|
31
|
-
require 'faraday/retry'
|
32
|
-
Faraday::Request::Multipart = Faraday::Multipart::Middleware
|
33
|
-
Faraday::Request::Retry = Faraday::Retry::Middleware
|
34
|
-
|
35
|
-
# External Adapters gems
|
36
|
-
unless defined?(JRUBY_VERSION)
|
37
|
-
require 'faraday/em_http'
|
38
|
-
require 'faraday/em_synchrony'
|
39
|
-
end
|
40
|
-
require 'faraday/excon'
|
41
|
-
require 'faraday/httpclient'
|
42
|
-
require 'faraday/net_http'
|
43
|
-
require 'faraday/net_http_persistent'
|
44
|
-
require 'faraday/patron'
|
45
|
-
require 'faraday/rack'
|
20
|
+
require 'faraday/file_part'
|
21
|
+
require 'faraday/param_part'
|
46
22
|
|
47
23
|
# This is the main namespace for Faraday.
|
48
24
|
#
|
@@ -57,6 +33,8 @@ require 'faraday/rack'
|
|
57
33
|
# conn.get '/'
|
58
34
|
#
|
59
35
|
module Faraday
|
36
|
+
CONTENT_TYPE = 'Content-Type'
|
37
|
+
|
60
38
|
class << self
|
61
39
|
# The root path that Faraday is being loaded from.
|
62
40
|
#
|
@@ -71,7 +49,7 @@ module Faraday
|
|
71
49
|
|
72
50
|
# @overload default_adapter
|
73
51
|
# Gets the Symbol key identifying a default Adapter to use
|
74
|
-
# for the default {Faraday::Connection}. Defaults to `:
|
52
|
+
# for the default {Faraday::Connection}. Defaults to `:test`.
|
75
53
|
# @return [Symbol] the default adapter
|
76
54
|
# @overload default_adapter=(adapter)
|
77
55
|
# Updates default adapter while resetting {.default_connection}.
|
@@ -118,19 +96,6 @@ module Faraday
|
|
118
96
|
Faraday::Connection.new(url, options, &block)
|
119
97
|
end
|
120
98
|
|
121
|
-
# @private
|
122
|
-
# Internal: Requires internal Faraday libraries.
|
123
|
-
#
|
124
|
-
# @param libs [Array] one or more relative String names to Faraday classes.
|
125
|
-
# @return [void]
|
126
|
-
def require_libs(*libs)
|
127
|
-
libs.each do |lib|
|
128
|
-
require "#{lib_path}/#{lib}"
|
129
|
-
end
|
130
|
-
end
|
131
|
-
|
132
|
-
alias require_lib require_libs
|
133
|
-
|
134
99
|
# Documented elsewhere, see default_adapter reader
|
135
100
|
def default_adapter=(adapter)
|
136
101
|
@default_connection = nil
|
@@ -185,7 +150,5 @@ module Faraday
|
|
185
150
|
self.ignore_env_proxy = false
|
186
151
|
self.root_path = File.expand_path __dir__
|
187
152
|
self.lib_path = File.expand_path 'faraday', __dir__
|
188
|
-
self.default_adapter = :
|
189
|
-
|
190
|
-
require_lib 'autoload' unless ENV['FARADAY_NO_AUTOLOAD']
|
153
|
+
self.default_adapter = :test
|
191
154
|
end
|
@@ -1,5 +1,15 @@
|
|
1
1
|
# frozen_string_literal: true
|
2
2
|
|
3
|
+
class CustomEncoder
|
4
|
+
def encode(params)
|
5
|
+
params.map { |k, v| "#{k.upcase}-#{v.to_s.upcase}" }.join(',')
|
6
|
+
end
|
7
|
+
|
8
|
+
def decode(params)
|
9
|
+
params.split(',').map { |pair| pair.split('-') }.to_h
|
10
|
+
end
|
11
|
+
end
|
12
|
+
|
3
13
|
shared_examples 'initializer with url' do
|
4
14
|
context 'with simple url' do
|
5
15
|
let(:address) { 'http://sushi.com' }
|
@@ -103,6 +113,12 @@ RSpec.describe Faraday::Connection do
|
|
103
113
|
it { expect(subject.params).to eq('a' => 3, 'b' => '2') }
|
104
114
|
end
|
105
115
|
|
116
|
+
context 'with basic_auth in url' do
|
117
|
+
let(:url) { 'http://Aladdin:open%20sesame@sushi.com/fish' }
|
118
|
+
|
119
|
+
it { expect(subject.headers['Authorization']).to eq('Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==') }
|
120
|
+
end
|
121
|
+
|
106
122
|
context 'with custom headers' do
|
107
123
|
let(:options) { { headers: { user_agent: 'Faraday' } } }
|
108
124
|
|
@@ -124,7 +140,7 @@ RSpec.describe Faraday::Connection do
|
|
124
140
|
context 'with block' do
|
125
141
|
let(:conn) do
|
126
142
|
Faraday::Connection.new(params: { 'a' => '1' }) do |faraday|
|
127
|
-
faraday.adapter :
|
143
|
+
faraday.adapter :test
|
128
144
|
faraday.url_prefix = 'http://sushi.com/omnom'
|
129
145
|
end
|
130
146
|
end
|
@@ -141,28 +157,6 @@ RSpec.describe Faraday::Connection do
|
|
141
157
|
end
|
142
158
|
end
|
143
159
|
|
144
|
-
describe 'basic_auth' do
|
145
|
-
subject { conn }
|
146
|
-
|
147
|
-
context 'calling the #basic_auth method' do
|
148
|
-
before { subject.basic_auth 'Aladdin', 'open sesame' }
|
149
|
-
|
150
|
-
it { expect(subject.headers['Authorization']).to eq('Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==') }
|
151
|
-
end
|
152
|
-
|
153
|
-
context 'adding basic auth info to url' do
|
154
|
-
let(:url) { 'http://Aladdin:open%20sesame@sushi.com/fish' }
|
155
|
-
|
156
|
-
it { expect(subject.headers['Authorization']).to eq('Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==') }
|
157
|
-
end
|
158
|
-
end
|
159
|
-
|
160
|
-
describe '#token_auth' do
|
161
|
-
before { subject.token_auth('abcdef', nonce: 'abc') }
|
162
|
-
|
163
|
-
it { expect(subject.headers['Authorization']).to eq('Token nonce="abc", token="abcdef"') }
|
164
|
-
end
|
165
|
-
|
166
160
|
describe '#build_exclusive_url' do
|
167
161
|
context 'with relative path' do
|
168
162
|
subject { conn.build_exclusive_url('sake.html') }
|
@@ -556,26 +550,32 @@ RSpec.describe Faraday::Connection do
|
|
556
550
|
end
|
557
551
|
|
558
552
|
context 'performing a request' do
|
559
|
-
|
553
|
+
let(:url) { 'http://example.com' }
|
554
|
+
let(:conn) do
|
555
|
+
Faraday.new do |f|
|
556
|
+
f.adapter :test do |stubs|
|
557
|
+
stubs.get(url) do
|
558
|
+
[200, {}, 'ok']
|
559
|
+
end
|
560
|
+
end
|
561
|
+
end
|
562
|
+
end
|
560
563
|
|
561
564
|
it 'dynamically checks proxy' do
|
562
565
|
with_env 'http_proxy' => 'http://proxy.com:80' do
|
563
|
-
conn = Faraday.new
|
564
566
|
expect(conn.proxy.uri.host).to eq('proxy.com')
|
565
567
|
|
566
|
-
conn.get(
|
568
|
+
conn.get(url) do |req|
|
567
569
|
expect(req.options.proxy.uri.host).to eq('proxy.com')
|
568
570
|
end
|
569
571
|
end
|
570
572
|
|
571
|
-
conn.get(
|
573
|
+
conn.get(url)
|
572
574
|
expect(conn.instance_variable_get('@temp_proxy')).to be_nil
|
573
575
|
end
|
574
576
|
|
575
577
|
it 'dynamically check no proxy' do
|
576
578
|
with_env 'http_proxy' => 'http://proxy.com', 'no_proxy' => 'example.com' do
|
577
|
-
conn = Faraday.new
|
578
|
-
|
579
579
|
expect(conn.proxy.uri.host).to eq('proxy.com')
|
580
580
|
|
581
581
|
conn.get('http://example.com') do |req|
|
@@ -605,7 +605,6 @@ RSpec.describe Faraday::Connection do
|
|
605
605
|
|
606
606
|
context 'after manual changes' do
|
607
607
|
before do
|
608
|
-
subject.basic_auth('', '')
|
609
608
|
subject.headers['content-length'] = 12
|
610
609
|
subject.params['b'] = '2'
|
611
610
|
subject.options[:open_timeout] = 10
|
@@ -645,9 +644,16 @@ RSpec.describe Faraday::Connection do
|
|
645
644
|
describe 'request params' do
|
646
645
|
context 'with simple url' do
|
647
646
|
let(:url) { 'http://example.com' }
|
648
|
-
let
|
647
|
+
let(:stubs) { Faraday::Adapter::Test::Stubs.new }
|
649
648
|
|
650
|
-
|
649
|
+
before do
|
650
|
+
conn.adapter(:test, stubs)
|
651
|
+
stubs.get('http://example.com?a=a&p=3') do
|
652
|
+
[200, {}, 'ok']
|
653
|
+
end
|
654
|
+
end
|
655
|
+
|
656
|
+
after { stubs.verify_stubbed_calls }
|
651
657
|
|
652
658
|
it 'test_overrides_request_params' do
|
653
659
|
conn.get('?p=2&a=a', p: 3)
|
@@ -669,15 +675,22 @@ RSpec.describe Faraday::Connection do
|
|
669
675
|
context 'with url and extra params' do
|
670
676
|
let(:url) { 'http://example.com?a=1&b=2' }
|
671
677
|
let(:options) { { params: { c: 3 } } }
|
678
|
+
let(:stubs) { Faraday::Adapter::Test::Stubs.new }
|
679
|
+
|
680
|
+
before do
|
681
|
+
conn.adapter(:test, stubs)
|
682
|
+
end
|
672
683
|
|
673
684
|
it 'merges connection and request params' do
|
674
|
-
|
685
|
+
expected = 'http://example.com?a=1&b=2&c=3&limit=5&page=1'
|
686
|
+
stubs.get(expected) { [200, {}, 'ok'] }
|
675
687
|
conn.get('?page=1', limit: 5)
|
676
|
-
|
688
|
+
stubs.verify_stubbed_calls
|
677
689
|
end
|
678
690
|
|
679
691
|
it 'allows to override all params' do
|
680
|
-
|
692
|
+
expected = 'http://example.com?b=b'
|
693
|
+
stubs.get(expected) { [200, {}, 'ok'] }
|
681
694
|
conn.get('?p=1&a=a', p: 2) do |req|
|
682
695
|
expect(req.params[:a]).to eq('a')
|
683
696
|
expect(req.params['c']).to eq(3)
|
@@ -685,47 +698,61 @@ RSpec.describe Faraday::Connection do
|
|
685
698
|
req.params = { b: 'b' }
|
686
699
|
expect(req.params['b']).to eq('b')
|
687
700
|
end
|
688
|
-
|
701
|
+
stubs.verify_stubbed_calls
|
689
702
|
end
|
690
703
|
|
691
704
|
it 'allows to set params_encoder for single request' do
|
692
|
-
encoder =
|
693
|
-
|
694
|
-
|
695
|
-
end
|
696
|
-
stubbed = stub_request(:get, 'http://example.com/?A-1,B-2,C-3,FEELING-BLUE')
|
705
|
+
encoder = CustomEncoder.new
|
706
|
+
expected = 'http://example.com/?A-1,B-2,C-3,FEELING-BLUE'
|
707
|
+
stubs.get(expected) { [200, {}, 'ok'] }
|
697
708
|
|
698
|
-
conn.get('/', feeling: 'blue') do |req|
|
709
|
+
conn.get('/', a: 1, b: 2, c: 3, feeling: 'blue') do |req|
|
699
710
|
req.options.params_encoder = encoder
|
700
711
|
end
|
701
|
-
|
712
|
+
stubs.verify_stubbed_calls
|
702
713
|
end
|
703
714
|
end
|
704
715
|
|
705
716
|
context 'with default params encoder' do
|
706
|
-
let
|
707
|
-
|
717
|
+
let(:stubs) { Faraday::Adapter::Test::Stubs.new }
|
718
|
+
|
719
|
+
before do
|
720
|
+
conn.adapter(:test, stubs)
|
721
|
+
stubs.get('http://example.com?color%5B%5D=blue&color%5B%5D=red') do
|
722
|
+
[200, {}, 'ok']
|
723
|
+
end
|
724
|
+
end
|
725
|
+
|
726
|
+
after { stubs.verify_stubbed_calls }
|
708
727
|
|
709
728
|
it 'supports array params in url' do
|
710
|
-
conn.get('http://example.com?color[]=
|
729
|
+
conn.get('http://example.com?color[]=blue&color[]=red')
|
711
730
|
end
|
712
731
|
|
713
732
|
it 'supports array params in params' do
|
714
|
-
conn.get('http://example.com', color: %w[red
|
733
|
+
conn.get('http://example.com', color: %w[blue red])
|
715
734
|
end
|
716
735
|
end
|
717
736
|
|
718
737
|
context 'with flat params encoder' do
|
719
738
|
let(:options) { { request: { params_encoder: Faraday::FlatParamsEncoder } } }
|
720
|
-
let
|
721
|
-
|
739
|
+
let(:stubs) { Faraday::Adapter::Test::Stubs.new }
|
740
|
+
|
741
|
+
before do
|
742
|
+
conn.adapter(:test, stubs)
|
743
|
+
stubs.get('http://example.com?color=blue&color=red') do
|
744
|
+
[200, {}, 'ok']
|
745
|
+
end
|
746
|
+
end
|
747
|
+
|
748
|
+
after { stubs.verify_stubbed_calls }
|
722
749
|
|
723
750
|
it 'supports array params in params' do
|
724
|
-
conn.get('http://example.com', color: %w[red
|
751
|
+
conn.get('http://example.com', color: %w[blue red])
|
725
752
|
end
|
726
753
|
|
727
754
|
context 'with array param in url' do
|
728
|
-
let(:url) { 'http://example.com?color[]=
|
755
|
+
let(:url) { 'http://example.com?color[]=blue&color[]=red' }
|
729
756
|
|
730
757
|
it do
|
731
758
|
conn.get('/')
|
@@ -29,12 +29,12 @@ RSpec.describe Faraday::Env do
|
|
29
29
|
|
30
30
|
it 'retains custom members' do
|
31
31
|
env[:foo] = 'custom 1'
|
32
|
-
env[:bar] = :
|
32
|
+
env[:bar] = :custom2
|
33
33
|
env2 = Faraday::Env.from(env)
|
34
34
|
env2[:baz] = 'custom 3'
|
35
35
|
|
36
36
|
expect(env2[:foo]).to eq('custom 1')
|
37
|
-
expect(env2[:bar]).to eq(:
|
37
|
+
expect(env2[:bar]).to eq(:custom2)
|
38
38
|
expect(env[:baz]).to be_nil
|
39
39
|
end
|
40
40
|
|
@@ -12,13 +12,11 @@ RSpec.describe Faraday::RackBuilder do
|
|
12
12
|
|
13
13
|
class Apple < Handler
|
14
14
|
end
|
15
|
+
|
15
16
|
class Orange < Handler
|
16
17
|
end
|
17
|
-
class Banana < Handler
|
18
|
-
end
|
19
18
|
|
20
|
-
class
|
21
|
-
dependency 'zomg/i_dont/exist'
|
19
|
+
class Banana < Handler
|
22
20
|
end
|
23
21
|
|
24
22
|
subject { conn.builder }
|
@@ -127,24 +125,6 @@ RSpec.describe Faraday::RackBuilder do
|
|
127
125
|
subject.use(:apple)
|
128
126
|
expect(subject.handlers).to eq([Apple])
|
129
127
|
end
|
130
|
-
|
131
|
-
it 'allows to register with symbol' do
|
132
|
-
Faraday::Middleware.register_middleware(apple: :Apple)
|
133
|
-
subject.use(:apple)
|
134
|
-
expect(subject.handlers).to eq([Apple])
|
135
|
-
end
|
136
|
-
|
137
|
-
it 'allows to register with string' do
|
138
|
-
Faraday::Middleware.register_middleware(apple: 'Apple')
|
139
|
-
subject.use(:apple)
|
140
|
-
expect(subject.handlers).to eq([Apple])
|
141
|
-
end
|
142
|
-
|
143
|
-
it 'allows to register with Proc' do
|
144
|
-
Faraday::Middleware.register_middleware(apple: -> { Apple })
|
145
|
-
subject.use(:apple)
|
146
|
-
expect(subject.handlers).to eq([Apple])
|
147
|
-
end
|
148
128
|
end
|
149
129
|
|
150
130
|
context 'when having two handlers' do
|
@@ -176,24 +156,6 @@ RSpec.describe Faraday::RackBuilder do
|
|
176
156
|
end
|
177
157
|
end
|
178
158
|
|
179
|
-
context 'when having a handler with broken dependency' do
|
180
|
-
let(:conn) do
|
181
|
-
Faraday::Connection.new do |builder|
|
182
|
-
builder.adapter :test do |stub|
|
183
|
-
stub.get('/') { |_| [200, {}, ''] }
|
184
|
-
end
|
185
|
-
end
|
186
|
-
end
|
187
|
-
|
188
|
-
before { subject.use(Broken) }
|
189
|
-
|
190
|
-
it 'raises an error while making a request' do
|
191
|
-
expect { conn.get('/') }.to raise_error(RuntimeError) do |err|
|
192
|
-
expect(err.message).to match(%r{missing dependency for Broken: .+ -- zomg/i_dont/exist})
|
193
|
-
end
|
194
|
-
end
|
195
|
-
end
|
196
|
-
|
197
159
|
context 'when middleware is added with named arguments' do
|
198
160
|
let(:conn) { Faraday::Connection.new {} }
|
199
161
|
|
@@ -220,7 +182,7 @@ RSpec.describe Faraday::RackBuilder do
|
|
220
182
|
end
|
221
183
|
end
|
222
184
|
|
223
|
-
context 'when a
|
185
|
+
context 'when a middleware is added with named arguments' do
|
224
186
|
let(:conn) { Faraday::Connection.new {} }
|
225
187
|
|
226
188
|
let(:cat_request) do
|
@@ -247,11 +209,11 @@ RSpec.describe Faraday::RackBuilder do
|
|
247
209
|
end
|
248
210
|
end
|
249
211
|
|
250
|
-
context 'when a
|
212
|
+
context 'when a middleware is added with named arguments' do
|
251
213
|
let(:conn) { Faraday::Connection.new {} }
|
252
214
|
|
253
215
|
let(:fish_response) do
|
254
|
-
Class.new(Faraday::
|
216
|
+
Class.new(Faraday::Middleware) do
|
255
217
|
attr_accessor :name
|
256
218
|
|
257
219
|
def initialize(app, name:)
|