faraday 0.17.4 → 1.8.0

data/spec/faraday/request_spec.rb

@@ -0,0 +1,120 @@
+# frozen_string_literal: true
+
+RSpec.describe Faraday::Request do
+  let(:conn) do
+    Faraday.new(url: 'http://sushi.com/api',
+                headers: { 'Mime-Version' => '1.0' },
+                request: { oauth: { consumer_key: 'anonymous' } })
+  end
+  let(:http_method) { :get }
+  let(:block) { nil }
+
+  subject { conn.build_request(http_method, &block) }
+
+  context 'when nothing particular is configured' do
+    it { expect(subject.http_method).to eq(:get) }
+    it { expect(subject.to_env(conn).ssl.verify).to be_falsey }
+  end
+
+  context 'when HTTP method is post' do
+    let(:http_method) { :post }
+
+    it { expect(subject.http_method).to eq(:post) }
+  end
+
+  describe 'deprecate method for HTTP method' do
+    let(:http_method) { :post }
+    let(:expected_warning) do
+      %r{WARNING: `Faraday::Request#method` is deprecated; use `#http_method` instead. It will be removed in or after version 2.0.\n`Faraday::Request#method` called from .+/spec/faraday/request_spec.rb:\d+.}
+    end
+
+    it { expect(subject.method).to eq(:post) }
+
+    it { expect { subject.method }.to output(expected_warning).to_stderr }
+  end
+
+  context 'when setting the url on setup with a URI' do
+    let(:block) { proc { |req| req.url URI.parse('foo.json?a=1') } }
+
+    it { expect(subject.path).to eq(URI.parse('foo.json')) }
+    it { expect(subject.params).to eq('a' => '1') }
+    it { expect(subject.to_env(conn).url.to_s).to eq('http://sushi.com/api/foo.json?a=1') }
+  end
+
+  context 'when setting the url on setup with a string path and params' do
+    let(:block) { proc { |req| req.url 'foo.json', 'a' => 1 } }
+
+    it { expect(subject.path).to eq('foo.json') }
+    it { expect(subject.params).to eq('a' => 1) }
+    it { expect(subject.to_env(conn).url.to_s).to eq('http://sushi.com/api/foo.json?a=1') }
+  end
+
+  context 'when setting the url on setup with a path including params' do
+    let(:block) { proc { |req| req.url 'foo.json?b=2&a=1#qqq' } }
+
+    it { expect(subject.path).to eq('foo.json') }
+    it { expect(subject.params).to eq('a' => '1', 'b' => '2') }
+    it { expect(subject.to_env(conn).url.to_s).to eq('http://sushi.com/api/foo.json?a=1&b=2') }
+  end
+
+  context 'when setting a header on setup with []= syntax' do
+    let(:block) { proc { |req| req['Server'] = 'Faraday' } }
+    let(:headers) { subject.to_env(conn).request_headers }
+
+    it { expect(subject.headers['Server']).to eq('Faraday') }
+    it { expect(headers['mime-version']).to eq('1.0') }
+    it { expect(headers['server']).to eq('Faraday') }
+  end
+
+  context 'when setting the body on setup' do
+    let(:block) { proc { |req| req.body = 'hi' } }
+
+    it { expect(subject.body).to eq('hi') }
+    it { expect(subject.to_env(conn).body).to eq('hi') }
+  end
+
+  context 'with global request options set' do
+    let(:env_request) { subject.to_env(conn).request }
+
+    before do
+      conn.options.timeout = 3
+      conn.options.open_timeout = 5
+      conn.ssl.verify = false
+      conn.proxy = 'http://proxy.com'
+    end
+
+    it { expect(subject.options.timeout).to eq(3) }
+    it { expect(subject.options.open_timeout).to eq(5) }
+    it { expect(env_request.timeout).to eq(3) }
+    it { expect(env_request.open_timeout).to eq(5) }
+
+    context 'and per-request options set' do
+      let(:block) do
+        proc do |req|
+          req.options.timeout = 10
+          req.options.boundary = 'boo'
+          req.options.oauth[:consumer_secret] = 'xyz'
+          req.options.context = {
+            foo: 'foo',
+            bar: 'bar'
+          }
+        end
+      end
+
+      it { expect(subject.options.timeout).to eq(10) }
+      it { expect(subject.options.open_timeout).to eq(5) }
+      it { expect(env_request.timeout).to eq(10) }
+      it { expect(env_request.open_timeout).to eq(5) }
+      it { expect(env_request.boundary).to eq('boo') }
+      it { expect(env_request.context).to eq(foo: 'foo', bar: 'bar') }
+      it do
+        oauth_expected = { consumer_secret: 'xyz', consumer_key: 'anonymous' }
+        expect(env_request.oauth).to eq(oauth_expected)
+      end
+    end
+  end
+
+  it 'supports marshal serialization' do
+    expect(Marshal.load(Marshal.dump(subject))).to eq(subject)
+  end
+end

data/spec/faraday/response/logger_spec.rb

@@ -0,0 +1,220 @@
+# frozen_string_literal: true
+
+require 'stringio'
+require 'logger'
+
+RSpec.describe Faraday::Response::Logger do
+  let(:string_io) { StringIO.new }
+  let(:logger) { Logger.new(string_io) }
+  let(:logger_options) { {} }
+  let(:conn) do
+    rubbles = ['Barney', 'Betty', 'Bam Bam']
+
+    Faraday.new do |b|
+      b.response :logger, logger, logger_options do |logger|
+        logger.filter(/(soylent green is) (.+)/, '\1 tasty')
+        logger.filter(/(api_key:).*"(.+)."/, '\1[API_KEY]')
+        logger.filter(/(password)=(.+)/, '\1=[HIDDEN]')
+      end
+      b.adapter :test do |stubs|
+        stubs.get('/hello') { [200, { 'Content-Type' => 'text/html' }, 'hello'] }
+        stubs.post('/ohai') { [200, { 'Content-Type' => 'text/html' }, 'fred'] }
+        stubs.post('/ohyes') { [200, { 'Content-Type' => 'text/html' }, 'pebbles'] }
+        stubs.get('/rubbles') { [200, { 'Content-Type' => 'application/json' }, rubbles] }
+        stubs.get('/filtered_body') { [200, { 'Content-Type' => 'text/html' }, 'soylent green is people'] }
+        stubs.get('/filtered_headers') { [200, { 'Content-Type' => 'text/html' }, 'headers response'] }
+        stubs.get('/filtered_params') { [200, { 'Content-Type' => 'text/html' }, 'params response'] }
+        stubs.get('/filtered_url') { [200, { 'Content-Type' => 'text/html' }, 'url response'] }
+      end
+    end
+  end
+
+  before do
+    logger.level = Logger::DEBUG
+  end
+
+  it 'still returns output' do
+    resp = conn.get '/hello', nil, accept: 'text/html'
+    expect(resp.body).to eq('hello')
+  end
+
+  context 'without configuration' do
+    let(:conn) do
+      Faraday.new do |b|
+        b.response :logger
+        b.adapter :test do |stubs|
+          stubs.get('/hello') { [200, { 'Content-Type' => 'text/html' }, 'hello'] }
+        end
+      end
+    end
+
+    it 'defaults to stdout' do
+      expect(Logger).to receive(:new).with($stdout).and_return(Logger.new(nil))
+      conn.get('/hello')
+    end
+  end
+
+  context 'with default formatter' do
+    let(:formatter) { instance_double(Faraday::Logging::Formatter, request: true, response: true, filter: []) }
+
+    before { allow(Faraday::Logging::Formatter).to receive(:new).and_return(formatter) }
+
+    it 'delegates logging to the formatter' do
+      expect(formatter).to receive(:request).with(an_instance_of(Faraday::Env))
+      expect(formatter).to receive(:response).with(an_instance_of(Faraday::Env))
+      conn.get '/hello'
+    end
+  end
+
+  context 'with custom formatter' do
+    let(:formatter_class) do
+      Class.new(Faraday::Logging::Formatter) do
+        def request(_env)
+          info 'Custom log formatter request'
+        end
+
+        def response(_env)
+          info 'Custom log formatter response'
+        end
+      end
+    end
+
+    let(:logger_options) { { formatter: formatter_class } }
+
+    it 'logs with custom formatter' do
+      conn.get '/hello'
+
+      expect(string_io.string).to match('Custom log formatter request')
+      expect(string_io.string).to match('Custom log formatter response')
+    end
+  end
+
+  it 'logs method and url' do
+    conn.get '/hello', nil, accept: 'text/html'
+    expect(string_io.string).to match('GET http:/hello')
+  end
+
+  it 'logs request headers by default' do
+    conn.get '/hello', nil, accept: 'text/html'
+    expect(string_io.string).to match(%(Accept: "text/html))
+  end
+
+  it 'logs response headers by default' do
+    conn.get '/hello', nil, accept: 'text/html'
+    expect(string_io.string).to match(%(Content-Type: "text/html))
+  end
+
+  it 'does not log request body by default' do
+    conn.post '/ohai', 'name=Unagi', accept: 'text/html'
+    expect(string_io.string).not_to match(%(name=Unagi))
+  end
+
+  it 'does not log response body by default' do
+    conn.post '/ohai', 'name=Toro', accept: 'text/html'
+    expect(string_io.string).not_to match(%(fred))
+  end
+
+  it 'logs filter headers' do
+    conn.headers = { 'api_key' => 'ABC123' }
+    conn.get '/filtered_headers', nil, accept: 'text/html'
+    expect(string_io.string).to match(%(api_key:))
+    expect(string_io.string).to match(%([API_KEY]))
+    expect(string_io.string).not_to match(%(ABC123))
+  end
+
+  it 'logs filter url' do
+    conn.get '/filtered_url?password=hunter2', nil, accept: 'text/html'
+    expect(string_io.string).to match(%([HIDDEN]))
+    expect(string_io.string).not_to match(%(hunter2))
+  end
+
+  context 'when not logging request headers' do
+    let(:logger_options) { { headers: { request: false } } }
+
+    it 'does not log request headers if option is false' do
+      conn.get '/hello', nil, accept: 'text/html'
+      expect(string_io.string).not_to match(%(Accept: "text/html))
+    end
+  end
+
+  context 'when not logging response headers' do
+    let(:logger_options) { { headers: { response: false } } }
+
+    it 'does not log response headers if option is false' do
+      conn.get '/hello', nil, accept: 'text/html'
+      expect(string_io.string).not_to match(%(Content-Type: "text/html))
+    end
+  end
+
+  context 'when logging request body' do
+    let(:logger_options) { { bodies: { request: true } } }
+
+    it 'log only request body' do
+      conn.post '/ohyes', 'name=Tamago', accept: 'text/html'
+      expect(string_io.string).to match(%(name=Tamago))
+      expect(string_io.string).not_to match(%(pebbles))
+    end
+  end
+
+  context 'when logging response body' do
+    let(:logger_options) { { bodies: { response: true } } }
+
+    it 'log only response body' do
+      conn.post '/ohyes', 'name=Hamachi', accept: 'text/html'
+      expect(string_io.string).to match(%(pebbles))
+      expect(string_io.string).not_to match(%(name=Hamachi))
+    end
+  end
+
+  context 'when logging request and response bodies' do
+    let(:logger_options) { { bodies: true } }
+
+    it 'log request and response body' do
+      conn.post '/ohyes', 'name=Ebi', accept: 'text/html'
+      expect(string_io.string).to match(%(name=Ebi))
+      expect(string_io.string).to match(%(pebbles))
+    end
+
+    it 'log response body object' do
+      conn.get '/rubbles', nil, accept: 'text/html'
+      expect(string_io.string).to match(%([\"Barney\", \"Betty\", \"Bam Bam\"]\n))
+    end
+
+    it 'logs filter body' do
+      conn.get '/filtered_body', nil, accept: 'text/html'
+      expect(string_io.string).to match(%(soylent green is))
+      expect(string_io.string).to match(%(tasty))
+      expect(string_io.string).not_to match(%(people))
+    end
+  end
+
+  context 'when using log_level' do
+    let(:logger_options) { { bodies: true, log_level: :debug } }
+
+    it 'logs request/request body on the specified level (debug)' do
+      logger.level = Logger::DEBUG
+      conn.post '/ohyes', 'name=Ebi', accept: 'text/html'
+      expect(string_io.string).to match(%(name=Ebi))
+      expect(string_io.string).to match(%(pebbles))
+    end
+
+    it 'logs headers on the debug level' do
+      logger.level = Logger::DEBUG
+      conn.get '/hello', nil, accept: 'text/html'
+      expect(string_io.string).to match(%(Content-Type: "text/html))
+    end
+
+    it 'does not log request/response body on the info level' do
+      logger.level = Logger::INFO
+      conn.post '/ohyes', 'name=Ebi', accept: 'text/html'
+      expect(string_io.string).not_to match(%(name=Ebi))
+      expect(string_io.string).not_to match(%(pebbles))
+    end
+
+    it 'does not log headers on the info level' do
+      logger.level = Logger::INFO
+      conn.get '/hello', nil, accept: 'text/html'
+      expect(string_io.string).not_to match(%(Content-Type: "text/html))
+    end
+  end
+end

data/spec/faraday/response/middleware_spec.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+RSpec.describe Faraday::Response::Middleware do
+  let(:conn) do
+    Faraday.new do |b|
+      b.use custom_middleware
+      b.adapter :test do |stub|
+        stub.get('ok') { [200, { 'Content-Type' => 'text/html' }, '<body></body>'] }
+        stub.get('not_modified') { [304, nil, nil] }
+        stub.get('no_content') { [204, nil, nil] }
+      end
+    end
+  end
+
+  context 'with a custom ResponseMiddleware' do
+    let(:custom_middleware) do
+      Class.new(Faraday::Response::Middleware) do
+        def parse(body)
+          body.upcase
+        end
+      end
+    end
+
+    it 'parses the response' do
+      expect(conn.get('ok').body).to eq('<BODY></BODY>')
+    end
+  end
+
+  context 'with a custom ResponseMiddleware and private parse' do
+    let(:custom_middleware) do
+      Class.new(Faraday::Response::Middleware) do
+        private
+
+        def parse(body)
+          body.upcase
+        end
+      end
+    end
+
+    it 'parses the response' do
+      expect(conn.get('ok').body).to eq('<BODY></BODY>')
+    end
+  end
+
+  context 'with a custom ResponseMiddleware but empty response' do
+    let(:custom_middleware) do
+      Class.new(Faraday::Response::Middleware) do
+        def parse(_body)
+          raise 'this should not be called'
+        end
+      end
+    end
+
+    it 'raises exception for 200 responses' do
+      expect { conn.get('ok') }.to raise_error(StandardError)
+    end
+
+    it 'doesn\'t call the middleware for 204 responses' do
+      expect_any_instance_of(custom_middleware).not_to receive(:parse)
+      expect(conn.get('no_content').body).to be_nil
+    end
+
+    it 'doesn\'t call the middleware for 304 responses' do
+      expect_any_instance_of(custom_middleware).not_to receive(:parse)
+      expect(conn.get('not_modified').body).to be_nil
+    end
+  end
+end

data/spec/faraday/response/raise_error_spec.rb

@@ -24,27 +24,36 @@ RSpec.describe Faraday::Response::RaiseError do
     expect { conn.get('ok') }.not_to raise_error
   end
 
-  it 'raises Faraday::ClientError for 400 responses' do
-    expect { conn.get('bad-request') }.to raise_error(Faraday::ClientError) do |ex|
+  it 'raises Faraday::BadRequestError for 400 responses' do
+    expect { conn.get('bad-request') }.to raise_error(Faraday::BadRequestError) do |ex|
       expect(ex.message).to eq('the server responded with status 400')
       expect(ex.response[:headers]['X-Reason']).to eq('because')
       expect(ex.response[:status]).to eq(400)
+      expect(ex.response_status).to eq(400)
+      expect(ex.response_body).to eq('keep looking')
+      expect(ex.response_headers['X-Reason']).to eq('because')
     end
   end
 
-  it 'raises Faraday::ClientError for 401 responses' do
-    expect { conn.get('unauthorized') }.to raise_error(Faraday::ClientError) do |ex|
+  it 'raises Faraday::UnauthorizedError for 401 responses' do
+    expect { conn.get('unauthorized') }.to raise_error(Faraday::UnauthorizedError) do |ex|
       expect(ex.message).to eq('the server responded with status 401')
       expect(ex.response[:headers]['X-Reason']).to eq('because')
       expect(ex.response[:status]).to eq(401)
+      expect(ex.response_status).to eq(401)
+      expect(ex.response_body).to eq('keep looking')
+      expect(ex.response_headers['X-Reason']).to eq('because')
     end
   end
 
-  it 'raises Faraday::ClientError for 403 responses' do
-    expect { conn.get('forbidden') }.to raise_error(Faraday::ClientError) do |ex|
+  it 'raises Faraday::ForbiddenError for 403 responses' do
+    expect { conn.get('forbidden') }.to raise_error(Faraday::ForbiddenError) do |ex|
       expect(ex.message).to eq('the server responded with status 403')
       expect(ex.response[:headers]['X-Reason']).to eq('because')
       expect(ex.response[:status]).to eq(403)
+      expect(ex.response_status).to eq(403)
+      expect(ex.response_body).to eq('keep looking')
+      expect(ex.response_headers['X-Reason']).to eq('because')
     end
   end
 
@@ -53,30 +62,42 @@ RSpec.describe Faraday::Response::RaiseError do
       expect(ex.message).to eq('the server responded with status 404')
       expect(ex.response[:headers]['X-Reason']).to eq('because')
       expect(ex.response[:status]).to eq(404)
+      expect(ex.response_status).to eq(404)
+      expect(ex.response_body).to eq('keep looking')
+      expect(ex.response_headers['X-Reason']).to eq('because')
     end
   end
 
-  it 'raises Faraday::ConnectionFailed for 407 responses' do
-    expect { conn.get('proxy-error') }.to raise_error(Faraday::ConnectionFailed) do |ex|
-      expect(ex.message).to eq('407 "Proxy Authentication Required "')
+  it 'raises Faraday::ProxyAuthError for 407 responses' do
+    expect { conn.get('proxy-error') }.to raise_error(Faraday::ProxyAuthError) do |ex|
+      expect(ex.message).to eq('407 "Proxy Authentication Required"')
       expect(ex.response[:headers]['X-Reason']).to eq('because')
       expect(ex.response[:status]).to eq(407)
+      expect(ex.response_status).to eq(407)
+      expect(ex.response_body).to eq('keep looking')
+      expect(ex.response_headers['X-Reason']).to eq('because')
     end
   end
 
-  it 'raises Faraday::ClientError for 409 responses' do
-    expect { conn.get('conflict') }.to raise_error(Faraday::ClientError) do |ex|
+  it 'raises Faraday::ConflictError for 409 responses' do
+    expect { conn.get('conflict') }.to raise_error(Faraday::ConflictError) do |ex|
       expect(ex.message).to eq('the server responded with status 409')
       expect(ex.response[:headers]['X-Reason']).to eq('because')
       expect(ex.response[:status]).to eq(409)
+      expect(ex.response_status).to eq(409)
+      expect(ex.response_body).to eq('keep looking')
+      expect(ex.response_headers['X-Reason']).to eq('because')
     end
   end
 
-  it 'raises Faraday::ClientError for 422 responses' do
-    expect { conn.get('unprocessable-entity') }.to raise_error(Faraday::ClientError) do |ex|
+  it 'raises Faraday::UnprocessableEntityError for 422 responses' do
+    expect { conn.get('unprocessable-entity') }.to raise_error(Faraday::UnprocessableEntityError) do |ex|
       expect(ex.message).to eq('the server responded with status 422')
       expect(ex.response[:headers]['X-Reason']).to eq('because')
       expect(ex.response[:status]).to eq(422)
+      expect(ex.response_status).to eq(422)
+      expect(ex.response_body).to eq('keep looking')
+      expect(ex.response_headers['X-Reason']).to eq('because')
     end
   end
 
@@ -85,6 +106,9 @@ RSpec.describe Faraday::Response::RaiseError do
       expect(ex.message).to eq('http status could not be derived from the server response')
       expect(ex.response[:headers]['X-Reason']).to eq('nil')
       expect(ex.response[:status]).to be_nil
+      expect(ex.response_status).to be_nil
+      expect(ex.response_body).to eq('fail')
+      expect(ex.response_headers['X-Reason']).to eq('nil')
     end
   end
 
@@ -93,14 +117,53 @@ RSpec.describe Faraday::Response::RaiseError do
       expect(ex.message).to eq('the server responded with status 499')
       expect(ex.response[:headers]['X-Reason']).to eq('because')
       expect(ex.response[:status]).to eq(499)
+      expect(ex.response_status).to eq(499)
+      expect(ex.response_body).to eq('keep looking')
+      expect(ex.response_headers['X-Reason']).to eq('because')
     end
   end
 
-  it 'raises Faraday::ClientError for 500 responses' do
-    expect { conn.get('server-error') }.to raise_error(Faraday::ClientError) do |ex|
+  it 'raises Faraday::ServerError for 500 responses' do
+    expect { conn.get('server-error') }.to raise_error(Faraday::ServerError) do |ex|
       expect(ex.message).to eq('the server responded with status 500')
       expect(ex.response[:headers]['X-Error']).to eq('bailout')
       expect(ex.response[:status]).to eq(500)
+      expect(ex.response_status).to eq(500)
+      expect(ex.response_body).to eq('fail')
+      expect(ex.response_headers['X-Error']).to eq('bailout')
+    end
+  end
+
+  describe 'request info' do
+    let(:conn) do
+      Faraday.new do |b|
+        b.response :raise_error
+        b.adapter :test do |stub|
+          stub.post('request?full=true', request_body, request_headers) do
+            [400, { 'X-Reason' => 'because' }, 'keep looking']
+          end
+        end
+      end
+    end
+    let(:request_body) { JSON.generate({ 'item' => 'sth' }) }
+    let(:request_headers) { { 'Authorization' => 'Basic 123' } }
+
+    subject(:perform_request) do
+      conn.post 'request' do |req|
+        req.headers['Authorization'] = 'Basic 123'
+        req.params[:full] = true
+        req.body = request_body
+      end
+    end
+
+    it 'returns the request info in the exception' do
+      expect { perform_request }.to raise_error(Faraday::BadRequestError) do |ex|
+        expect(ex.response[:request][:method]).to eq(:post)
+        expect(ex.response[:request][:url_path]).to eq('/request')
+        expect(ex.response[:request][:params]).to eq({ 'full' => 'true' })
+        expect(ex.response[:request][:headers]).to match(a_hash_including(request_headers))
+        expect(ex.response[:request][:body]).to eq(request_body)
+      end
     end
   end
 end

data/spec/faraday/response_spec.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+RSpec.describe Faraday::Response do
+  subject { Faraday::Response.new(env) }
+
+  let(:env) do
+    Faraday::Env.from(status: 404, body: 'yikes',
+                      response_headers: { 'Content-Type' => 'text/plain' })
+  end
+
+  it { expect(subject.finished?).to be_truthy }
+  it { expect { subject.finish({}) }.to raise_error(RuntimeError) }
+  it { expect(subject.success?).to be_falsey }
+  it { expect(subject.status).to eq(404) }
+  it { expect(subject.body).to eq('yikes') }
+  it { expect(subject.headers['Content-Type']).to eq('text/plain') }
+  it { expect(subject['content-type']).to eq('text/plain') }
+
+  describe '#apply_request' do
+    before { subject.apply_request(body: 'a=b', method: :post) }
+
+    it { expect(subject.body).to eq('yikes') }
+    it { expect(subject.env[:method]).to eq(:post) }
+  end
+
+  describe '#to_hash' do
+    let(:hash) { subject.to_hash }
+
+    it { expect(hash).to be_a(Hash) }
+    it { expect(hash[:status]).to eq(subject.status) }
+    it { expect(hash[:response_headers]).to eq(subject.headers) }
+    it { expect(hash[:body]).to eq(subject.body) }
+  end
+
+  describe 'marshal serialization support' do
+    subject { Faraday::Response.new }
+    let(:loaded) { Marshal.load(Marshal.dump(subject)) }
+
+    before do
+      subject.on_complete {}
+      subject.finish(env.merge(params: 'moo'))
+    end
+
+    it { expect(loaded.env[:params]).to be_nil }
+    it { expect(loaded.env[:body]).to eq(env[:body]) }
+    it { expect(loaded.env[:response_headers]).to eq(env[:response_headers]) }
+    it { expect(loaded.env[:status]).to eq(env[:status]) }
+  end
+
+  describe '#on_complete' do
+    subject { Faraday::Response.new }
+
+    it 'parse body on finish' do
+      subject.on_complete { |env| env[:body] = env[:body].upcase }
+      subject.finish(env)
+
+      expect(subject.body).to eq('YIKES')
+    end
+
+    it 'can access response body in on_complete callback' do
+      subject.on_complete { |env| env[:body] = subject.body.upcase }
+      subject.finish(env)
+
+      expect(subject.body).to eq('YIKES')
+    end
+
+    it 'can access response body in on_complete callback' do
+      callback_env = nil
+      subject.on_complete { |env| callback_env = env }
+      subject.finish({})
+
+      expect(subject.env).to eq(callback_env)
+    end
+  end
+end