faraday-retry 2.2.1 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4215b6f0b7dd61fa8702103e77d6373cace2c46b469defeb0ed93ce94aa26e6c
-  data.tar.gz: 295faca61565e49a36a7f03201d6aee90b6a353c40d22a8bf8e1f6b1c729c041
+  metadata.gz: 7e0d25040c1d5a44f97588ae549113ddc1f5605575982a9914bbcf04ba75479e
+  data.tar.gz: 9894f02b5c148166cf87eba7b80399ab52d6ab52d62a754c7cdb923cb77b55d6
 SHA512:
-  metadata.gz: 5b8f2bee0e35492efc578659ce28a0b947374c8cafdba07606d953c417e8844128248a639392e4ad60c682528c0d478d3a894ca688e1f72965172633aee3be7f
-  data.tar.gz: 148ac2094f76cd59ea9278a4d1948b3211f0c2abc1876b6f10fbdd88a384257dfdfab33f9a1cf102ed23352b5b0dd2e9f1f4d533cd8459c4b86d1f5e7578a053
+  metadata.gz: 6166b5f81ddc21739eb1654a2e8aa55191ecb275f4299d752980df1b7220c7698703fadeee074454da963ca0877dd00283105f0e1f423e6043735f042c984ea2
+  data.tar.gz: c6e11e52b1007c9dc6bca895b89a06638b4269bc7f19f89d5916e6c81136958c49f2095dd6cc8bc2e1391ba4dcd47d5879931cdf19a68a8f0608a0e11c82bc05

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+_nothing yet_
+
+## v2.2.1 (2024-04-15)
+
 * Avoid deprecation warning about ::UploadIO constant when used without faraday-multipart gem [PR #37](https://github.com/lostisland/faraday-retry/pull/37) [@iMacTia]
 * Documentation update [PR #30](https://github.com/lostisland/faraday-retry/pull/30) [@olleolleolle]
 * Documentation update [PR #32](https://github.com/lostisland/faraday-retry/pull/32) Thanks, [@Drowze]!

data/README.md

@@ -1,6 +1,6 @@
 # Faraday Retry
 
-[![CI](https://github.com/lostisland/faraday-retry/actions/workflows/ci.yaml/badge.svg)](https://github.com/lostisland/faraday-retry/actions/workflows/ci.yaml)
+[![CI](https://github.com/lostisland/faraday-retry/actions/workflows/ci.yml/badge.svg)](https://github.com/lostisland/faraday-retry/actions/workflows/ci.yml)
 [![Gem](https://img.shields.io/gem/v/faraday-retry.svg?style=flat-square)](https://rubygems.org/gems/faraday-retry)
 [![License](https://img.shields.io/github/license/lostisland/faraday-retry.svg?style=flat-square)](LICENSE.md)
 
@@ -149,8 +149,8 @@ retry_options = {
 
 ### Call a block on every retry
 
-You can specify a proc object through the `retry_block` option that will be called before every
-retry, before  There are many different applications for this feature, spacing from instrumentation to monitoring.
+You can specify a proc object through the `retry_block` option that will be called before every retry.
+There are many different applications for this feature, ranging from instrumentation to monitoring.
 
 The block is passed keyword arguments with contextual information: Request environment, middleware options, current number of retries, exception, and amount of time we will wait before retrying. (retry_block is called before the wait time happens)
 
@@ -163,6 +163,27 @@ retry_options = {
 }
 ```
 
+### Call a block after retries have been exhausted
+
+You can specify a lambda object through the `exhausted_retries_block` option that will be called after all retries are exhausted.
+This block will be called once.
+
+The block is passed keyword arguments with contextual information and passed your data:
+* Request environment,
+* exception,
+* middleware options
+* and your data.
+
+In a lambda you can pass any logic for further work.
+
+For example, you might want to update user by request query.
+
+```ruby
+retry_options = {
+  exhausted_retries_block: -> (user_id:, env:, exception:, options:) { User.find_by!(id: user_id).do_admin! }
+}
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies.

data/lib/faraday/retry/middleware.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative 'retryable'
+
 module Faraday
   module Retry
     # This class provides the main implementation for your middleware.
@@ -15,6 +17,8 @@ module Faraday
     #   (see "retry" middleware: https://github.com/lostisland/faraday/blob/main/lib/faraday/request/retry.rb#L142).
     #   IMPORTANT: Remember to call `@app.call(env)` or `super` to not interrupt the middleware chain!
     class Middleware < Faraday::Middleware
+      include Retryable
+
       DEFAULT_EXCEPTIONS = [
         Errno::ETIMEDOUT, 'Timeout::Error',
         Faraday::TimeoutError, Faraday::RetriableResponse
@@ -27,7 +31,8 @@ module Faraday
                                            :backoff_factor, :exceptions,
                                            :methods, :retry_if, :retry_block,
                                            :retry_statuses, :rate_limit_retry_header,
-                                           :rate_limit_reset_header, :header_parser_block)
+                                           :rate_limit_reset_header, :header_parser_block,
+                                           :exhausted_retries_block)
 
         DEFAULT_CHECK = ->(_env, _exception) { false }
 
@@ -78,6 +83,10 @@ module Faraday
         def retry_statuses
           Array(self[:retry_statuses] ||= [])
         end
+
+        def exhausted_retries_block
+          self[:exhausted_retries_block] ||= proc {}
+        end
       end
 
       # @param app [#call]
@@ -124,6 +133,13 @@ module Faraday
       #   the the value of the retry header and should return the number of
       #   seconds to wait before retrying the request. This is useful if the
       #   value of the header is not a number of seconds or a RFC 2822 formatted date.
+      # @option options [Block] :exhausted_retries_block block will receive
+      #   when all attempts are exhausted. The block will be yielded keyword arguments:
+      #     * env [Faraday::Env]: Request environment
+      #     * exception [Exception]: exception that triggered the retry,
+      #       will be the synthetic `Faraday::RetriableResponse` if the
+      #       retry was triggered by something other than an exception.
+      #     * options [Faraday::Options]: middleware options
       def initialize(app, options = nil)
         super(app)
         @options = Options.from(options)
@@ -147,32 +163,14 @@ module Faraday
       def call(env)
         retries = @options.max
         request_body = env[:body]
-        begin
+
+        with_retries(env: env, options: @options, retries: retries, body: request_body, errmatch: @errmatch) do
           # after failure env[:body] is set to the response body
           env[:body] = request_body
+
           @app.call(env).tap do |resp|
             raise Faraday::RetriableResponse.new(nil, resp) if @options.retry_statuses.include?(resp.status)
           end
-        rescue @errmatch => e
-          if retries.positive? && retry_request?(env, e)
-            retries -= 1
-            rewind_files(request_body)
-            if (sleep_amount = calculate_sleep_amount(retries + 1, env))
-              @options.retry_block.call(
-                env: env,
-                options: @options,
-                retry_count: @options.max - (retries + 1),
-                exception: e,
-                will_retry_in: sleep_amount
-              )
-              sleep sleep_amount
-              retry
-            end
-          end
-
-          raise unless e.is_a?(Faraday::RetriableResponse)
-
-          e.response
         end
       end
 

data/lib/faraday/retry/retryable.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module Faraday
+  # Adds the ability to retry a request based on settings and errors that have occurred.
+  module Retryable
+    def with_retries(env:, options:, retries:, body:, errmatch:)
+      yield
+    rescue errmatch => e
+      exhausted_retries(options, env, e) if retries_zero?(retries, env, e)
+
+      if retries.positive? && retry_request?(env, e)
+        retries -= 1
+        rewind_files(body)
+        if (sleep_amount = calculate_sleep_amount(retries + 1, env))
+          options.retry_block.call(
+            env: env,
+            options: options,
+            retry_count: options.max - (retries + 1),
+            exception: e,
+            will_retry_in: sleep_amount
+          )
+          sleep sleep_amount
+          retry
+        end
+      end
+
+      raise unless e.is_a?(Faraday::RetriableResponse)
+
+      e.response
+    end
+
+    private
+
+    def retries_zero?(retries, env, exception)
+      retries.zero? && retry_request?(env, exception)
+    end
+
+    def exhausted_retries(options, env, exception)
+      options.exhausted_retries_block.call(
+        env: env,
+        exception: exception,
+        options: options
+      )
+    end
+  end
+end

data/lib/faraday/retry/version.rb

@@ -2,6 +2,6 @@
 
 module Faraday
   module Retry
-    VERSION = '2.2.1'
+    VERSION = '2.3.2'
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: faraday-retry
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.3.2
 platform: ruby
 authors:
 - Mattia Giuffrida
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-04-15 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -151,17 +150,17 @@ files:
 - lib/faraday/retriable_response.rb
 - lib/faraday/retry.rb
 - lib/faraday/retry/middleware.rb
+- lib/faraday/retry/retryable.rb
 - lib/faraday/retry/version.rb
 homepage: https://github.com/lostisland/faraday-retry
 licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/lostisland/faraday-retry/issues
-  changelog_uri: https://github.com/lostisland/faraday-retry/blob/v2.2.1/CHANGELOG.md
-  documentation_uri: http://www.rubydoc.info/gems/faraday-retry/2.2.1
+  changelog_uri: https://github.com/lostisland/faraday-retry/blob/v2.3.2/CHANGELOG.md
+  documentation_uri: http://www.rubydoc.info/gems/faraday-retry/2.3.2
   homepage_uri: https://github.com/lostisland/faraday-retry
   source_code_uri: https://github.com/lostisland/faraday-retry
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -179,8 +178,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Catches exceptions and retries each request a limited number of times
 test_files: []