faraday-http-cache 1.2.2 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0a62aee8278ee280538fcda4370c230496f9aa26
-  data.tar.gz: ed354b7f472d84e17c996d2a97c61da81f41bc92
+  metadata.gz: 591c5305967c1a77f52be280ad1c2b31f8b6c1d5
+  data.tar.gz: b7a40463bdffe22b23ad0a602b225f1df3041bd8
 SHA512:
-  metadata.gz: fe2d52575496d9f73201deff62c664611c664148a2bde2f01adc1d63074c35ff6dda1103d19171dcb1f114fc1eb563d4235abc7e2439a5d8a6cf0ab88d761a8a
-  data.tar.gz: a7c46d882287552df02f7f3f3baf25c9182ac16c47905bef51520e41895d1baebc81f10ea33798d93c51df85593f16c6829fa7169a71df41c12940f81351986c
+  metadata.gz: 20567be380e251d4c16d9b3ba1a3f15feca47c1d3f2130f2f262c0e42c07180bd92179c71ae812dbedf44c779af4ade72c7a1fdaaccab706b876e917d4e477b5
+  data.tar.gz: 1d2c5ab40e991aa6acd2862d40f2fb44ca0741c4f0c708f7751805340bc941cbeda505d07be1d021b8375381fc952e9fbcbe4f507ad9719cfa311d5b7337139e

data/README.md

@@ -1,6 +1,6 @@
 # Faraday Http Cache
 
-[![Build Status](https://secure.travis-ci.org/plataformatec/faraday-http-cache.png?branch=master)](https://travis-ci.org/plataformatec/faraday-http-cache)
+[![Build Status](https://secure.travis-ci.org/plataformatec/faraday-http-cache.svg?branch=master)](https://travis-ci.org/plataformatec/faraday-http-cache)
 
 a [Faraday](https://github.com/lostisland/faraday) middleware that respects HTTP cache,
 by checking expiration and validation of the stored responses.
@@ -30,7 +30,7 @@ end
 ```
 
 The middleware accepts a `store` option for the cache backend responsible for recording
-the API responses that should be stored. Stores should respond to `write` and `read`,
+the API responses that should be stored. Stores should respond to `write`, `read` and `delete`,
 just like an object from the `ActiveSupport::Cache` API.
 
 ```ruby

data/lib/faraday/http_cache/response.rb

@@ -49,7 +49,7 @@ module Faraday
       #
       # Returns true if the response is fresh, otherwise false.
       def fresh?
-        ttl && ttl > 0
+        !cache_control.no_cache? && ttl && ttl > 0
       end
 
       # Internal: Checks if the Response returned a 'Not Modified' status.

data/spec/http_cache_spec.rb

@@ -190,6 +190,14 @@ describe Faraday::HttpCache do
     end
   end
 
+  context 'when the response has a "no-cache" directive' do
+    it 'always revalidate the cached response' do
+      client.get('no_cache')
+      expect(client.get('no_cache').body).to eq('2')
+      expect(client.get('no_cache').body).to eq('3')
+    end
+  end
+
   it 'logs that a GET response is stored' do
     expect(logger).to receive(:debug) { |&block| expect(block.call).to eq('HTTP Cache: [GET /get] miss, store') }
     client.get('get')

data/spec/response_spec.rb

@@ -72,13 +72,21 @@ describe Faraday::HttpCache::Response do
       expect(response).to be_fresh
     end
 
-    it 'is not fresh when the ttl has expired' do
+    it 'is not fresh if the ttl has expired' do
       date = (Time.now - 500).httpdate
       headers = { 'Cache-Control' => 'max-age=400', 'Date' => date }
       response = Faraday::HttpCache::Response.new(response_headers: headers)
 
       expect(response).not_to be_fresh
     end
+
+    it 'is not fresh if Cache Control has "no-cache"' do
+      date = (Time.now - 200).httpdate
+      headers = { 'Cache-Control' => 'max-age=400, no-cache', 'Date' => date }
+      response = Faraday::HttpCache::Response.new(response_headers: headers)
+
+      expect(response).not_to be_fresh
+    end
   end
 
   it 'sets the "Date" header if is not present' do

data/spec/support/test_app.rb

@@ -109,6 +109,10 @@ class TestApp < Sinatra::Base
     end
   end
 
+  get '/no_cache' do
+    [200, { 'Cache-Control' => 'max-age=200, no-cache', 'ETag' => settings.counter.to_s }, increment_counter]
+  end
+
   get '/vary' do
     [200, { 'Cache-Control' => 'max-age=50', 'Vary' => 'User-Agent' }, increment_counter]
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faraday-http-cache
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.3.0
 platform: ruby
 authors:
 - Lucas Mazza
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-27 00:00:00.000000000 Z
+date: 2016-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -72,7 +72,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A Faraday middleware that stores and validates cache expiration.