faraday-http-cache 1.2.0 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ed664b05e7052722cfb0f9d0ba7336b6de8ea5b7
-  data.tar.gz: fece9174d01e39d9e63c92f0ae6ba28c676a3504
+  metadata.gz: 0a62aee8278ee280538fcda4370c230496f9aa26
+  data.tar.gz: ed354b7f472d84e17c996d2a97c61da81f41bc92
 SHA512:
-  metadata.gz: db36959ac2578e4f9559aece670ab1a8fcc58d33d87bceb24dd9ea6871260d0af88ad570907198e01a4d733e146e884d5fca62ffec2223b61d1b2bd6aba8d399
-  data.tar.gz: de95b997afd0c83d6e1b344e5e00f9bd0e2a6ce57c7d81bbde0bc5a8ac6f4efbe804087c2565c89ec879145c5e06e00ced67d491e77cfe2515c9900817063676
+  metadata.gz: fe2d52575496d9f73201deff62c664611c664148a2bde2f01adc1d63074c35ff6dda1103d19171dcb1f114fc1eb563d4235abc7e2439a5d8a6cf0ab88d761a8a
+  data.tar.gz: a7c46d882287552df02f7f3f3baf25c9182ac16c47905bef51520e41895d1baebc81f10ea33798d93c51df85593f16c6829fa7169a71df41c12940f81351986c

data/lib/faraday/http_cache.rb

@@ -54,20 +54,26 @@ module Faraday
     EVENT_NAME = 'http_cache.faraday'
 
     CACHE_STATUSES = [
-      # The request was not cacheable:
+      # The request was not cacheable.
       :unacceptable,
 
-      # The response was cached and can still be used:
+      # The response was cached and can still be used.
       :fresh,
 
-      # The response was cached and the server has validated it with a 304 response:
+      # The response was cached and the server has validated it with a 304 response.
       :valid,
 
-      # The response was cached but the server could not validate it.
+      # The response was cache but was revalidated by the sserver.
       :invalid,
 
-      # No response was found in the cache:
-      :miss
+      # No response was found in the cache.
+      :miss,
+
+      # The response can't be cached.
+      :uncacheable,
+
+      # The request decided to ignore the cache.
+      :bypass
     ]
 
     # Public: Initializes a new HttpCache middleware.
@@ -243,6 +249,8 @@ module Faraday
           updated_payload[:response_headers].update(updated_response_headers)
           requested_env.update(updated_payload)
           response = Response.new(updated_payload)
+        else
+          trace :invalid
         end
         store(response)
       end
@@ -259,7 +267,7 @@ module Faraday
     end
 
     # Internal: Stores the response into the storage.
-    # If the response isn't cacheable, a trace action 'invalid' will be
+    # If the response isn't cacheable, a trace action 'uncacheable' will be
     # recorded for logging purposes.
     #
     # response - a 'Faraday::HttpCache::Response' instance to be stored.
@@ -270,7 +278,7 @@ module Faraday
         trace :store
         @storage.write(@request, response)
       else
-        trace :invalid
+        trace :uncacheable
       end
     end
 

data/spec/http_cache_spec.rb

@@ -28,7 +28,7 @@ describe Faraday::HttpCache do
     client.post('post').body
   end
 
-  it 'does not cache responses with invalid status code' do
+  it 'does not cache responses with , status code' do
     client.get('broken')
     expect(client.get('broken').body).to eq('2')
   end
@@ -89,8 +89,8 @@ describe Faraday::HttpCache do
       client.patch('counter')
     end
 
-    it 'logs that a response with a bad status code is invalid' do
-      expect(logger).to receive(:debug) { |&block| expect(block.call).to eq('HTTP Cache: [GET /broken] miss, invalid') }
+    it 'logs that a response with a bad status code is uncacheable' do
+      expect(logger).to receive(:debug) { |&block| expect(block.call).to eq('HTTP Cache: [GET /broken] miss, uncacheable') }
       client.get('broken')
     end
 
@@ -115,8 +115,8 @@ describe Faraday::HttpCache do
       expect(client.get('private').body).to eq('2')
     end
 
-    it 'logs that a private response is invalid' do
-      expect(logger).to receive(:debug) { |&block| expect(block.call).to eq('HTTP Cache: [GET /private] miss, invalid') }
+    it 'logs that a private response is uncacheable' do
+      expect(logger).to receive(:debug) { |&block| expect(block.call).to eq('HTTP Cache: [GET /private] miss, uncacheable') }
       client.get('private')
     end
   end
@@ -140,8 +140,8 @@ describe Faraday::HttpCache do
     expect(client.get('dontstore').body).to eq('2')
   end
 
-  it 'logs that a response with a no-store directive is invalid' do
-    expect(logger).to receive(:debug) { |&block| expect(block.call).to eq('HTTP Cache: [GET /dontstore] miss, invalid') }
+  it 'logs that a response with a no-store directive is uncacheable' do
+    expect(logger).to receive(:debug) { |&block| expect(block.call).to eq('HTTP Cache: [GET /dontstore] miss, uncacheable') }
     client.get('dontstore')
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faraday-http-cache
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.2
 platform: ruby
 authors:
 - Lucas Mazza
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-14 00:00:00.000000000 Z
+date: 2015-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday