faraday-http-cache 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f34a3a6ee332a8ce2480f41e1071020237c0ae1e
-  data.tar.gz: e1fc2519d29fc6656e156ffa4d9bf722e8b17297
+  metadata.gz: d851a7d541055e460f971cf80a0e06ac22e532e5
+  data.tar.gz: 519218770fbff5e98c7fbb9ba6561b6f8af3a75e
 SHA512:
-  metadata.gz: aa4045303477608539cc6f844daf4ebade16ac4e3e4ba7ecc5c11a4f9f096c4895893f773708607826dc1428b50814cf5e6e1298330e36f6e5c4f3cc8d5a817c
-  data.tar.gz: f56ed4f205684f471a39fd471b107e3fb417ffcdb945af2c67ad5d018958bbc93873076e0eeab0b97ac6f4984243aba5d27bf73246480c0a1e675e4009bfbc8c
+  metadata.gz: b13880d63d13760de6e4759b1315311412ca445f706b80e9dcb4a4fc7a23bdb22f976f5fbd77e6782ed62b0fa2e5c9e48c0806cbf4e5e137ab038ad0ea2739d2
+  data.tar.gz: 8945bb6f2bf29e4f9e6578eb40c4fcaa2d1c0502ad1c22963ae0bfab6c7f848d0fdac4df1f9010225c67e9461d23bedecfeaf4f61782fab28c6bfc3063ac7866

data/lib/faraday/http_cache/storage.rb

@@ -110,7 +110,7 @@ module Faraday
       #
       # Returns true or false.
       def response_matches?(request, cached_request, cached_response)
-        request.method.to_s == cached_request[:method] &&
+        request.method.to_s == cached_request[:method].to_s &&
           vary_matches?(cached_response, request, cached_request)
       end
 

data/spec/storage_spec.rb

@@ -70,14 +70,30 @@ describe Faraday::HttpCache::Storage do
   end
 
   describe 'reading responses' do
-    it 'returns nil if the response is not cached' do
-      expect(subject.read(request)).to be_nil
+    let(:storage) { Faraday::HttpCache::Storage.new(store: cache, serializer: serializer) }
+
+    shared_examples 'A storage with serialization' do
+      it 'returns nil if the response is not cached' do
+        expect(subject.read(request)).to be_nil
+      end
+
+      it 'decodes a stored response' do
+        subject.write(request, response)
+
+        expect(subject.read(request)).to be_a(Faraday::HttpCache::Response)
+      end
     end
 
-    it 'decodes a stored response' do
-      subject.write(request, response)
+    context 'with the JSON serializer' do
+      let(:serializer) { JSON }
+
+      it_behaves_like 'A storage with serialization'
+    end
 
-      expect(subject.read(request)).to be_a(Faraday::HttpCache::Response)
+    context 'with the Marshal serializer' do
+      let(:serializer) { Marshal }
+
+      it_behaves_like 'A storage with serialization'
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faraday-http-cache
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Lucas Mazza
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-27 00:00:00.000000000 Z
+date: 2015-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday