faraday-honeycomb 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 528655cf7e365e6f896409616b92a37d88dc8dcc
-  data.tar.gz: 750102a966db633f9318b112f9cddcbf2520824e
+SHA256:
+  metadata.gz: a75e1c7076952aa2d4583729d7952714996ca1e78ce2db4744a3ca947d897776
+  data.tar.gz: aaa17e9dcd7d330528c9240f876c9f5772073c40a0d7d315e380c82fa05077f0
 SHA512:
-  metadata.gz: d483d76fe1fc6087d1acb12f4bd6d51c1e5f75099466633868605f38d42d69cfb2cb67bf203dbfbcfbd831f4a293071b409ea256dfd62036598543676bfbe244
-  data.tar.gz: d5beb0e6701bbe26ec07e0518849b35174bbf408c3faf6944d520f3cf269859eabe7debe4f284b65147fb262ff97542db47c8c97a3e3d95328f1e90c6f90801b
+  metadata.gz: 460b2e4d398de2debd98d4cae9e1c27b56f6fcc8b901270f8dbc58d3b4fc04ea587db44a0b213c933910268b5dd411f8ee11a660895680c42fbb6e0829ce1ceb
+  data.tar.gz: d416b7d6d336469ae782190547625bb4c88edc3397508fe4ed16df081670363d5b01a601e84add233e84f3231fa47b600f30bacc8290fa223ff4db57f831bdb6

data/lib/faraday/honeycomb/middleware.rb

@@ -10,43 +10,61 @@ module Faraday
 
     class Middleware
       def initialize(app, options = {})
-        @honeycomb = options[:client] || Libhoney::Client.new(options.merge(user_agent_addition: USER_AGENT_SUFFIX))
+        honeycomb = options[:client] || Libhoney::Client.new(options.merge(user_agent_addition: USER_AGENT_SUFFIX))
+        @builder = honeycomb.builder.
+          add(
+            'type' => 'http_client',
+            'meta.package' => 'faraday',
+            'meta.package_version' => Faraday::VERSION,
+          )
         @app = app
       end
 
       def call(env)
-        event = @honeycomb.event
+        event = @builder.event
 
-        event.add_field :url, env.url.to_s
-
-        event.add_field :protocol, env.url.scheme
-        event.add_field :host, env.url.host
-        event.add_field :path, env.url.path
+        add_request_fields(event, env)
 
         start = Time.now
         response = adding_span_metadata_if_available(event, env) do
           @app.call(env)
         end
 
-        event.add_field :status, response.status
+        add_response_fields(event, response)
 
         response
       rescue Exception => e
         if event
-          event.add_field :exception_class, e.class
-          event.add_field :exception_message, e.message
+          event.add_field 'request.error', e.class.name
+          event.add_field 'request.error_detail', e.message
         end
         raise
       ensure
         if start && event
           finish = Time.now
           duration = finish - start
-          event.add_field :durationMs, duration * 1000
+          event.add_field 'duration_ms', duration * 1000
           event.send
         end
       end
 
       private
+      def add_request_fields(event, env)
+        loud_method = env.method.upcase.to_s
+
+        event.add(
+          'name' => "#{loud_method} #{env.url.host}#{env.url.path}",
+          'request.method' => loud_method,
+          'request.protocol' => env.url.scheme,
+          'request.host' => env.url.host,
+          'request.path' => env.url.path,
+        )
+      end
+
+      def add_response_fields(event, response)
+        event.add_field 'response.status_code', response.status
+      end
+
       def adding_span_metadata_if_available(event, env)
         return yield unless defined?(::Honeycomb.trace_id)
 

data/lib/faraday/honeycomb/version.rb

@@ -1,7 +1,7 @@
 module Faraday
   module Honeycomb
     GEM_NAME = 'faraday-honeycomb'
-    VERSION = '0.0.2'
+    VERSION = '0.0.3'
 
     MIN_FARADAY_VERSION = '0.8'
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faraday-honeycomb
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Sam Stokes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-07 00:00:00.000000000 Z
+date: 2018-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: libhoney
@@ -94,7 +94,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: "    TO DO *is* a description\n"
+description: |2
+      TO DO *is* a description
 email:
 - sam@honeycomb.io
 executables: []
@@ -126,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Instrument your Faraday HTTP requests with Honeycomb