faraday-highly_available_retries 0.1.0.pre.1 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0d99996c87cd7bfc2792430d4a7be1dc810889e2d59c1460da5c56bf18a32990
-  data.tar.gz: 4eae695335d5848847bc4e9a34295575dd9ca306c5380b79c77cba059bdc643a
+  metadata.gz: 60c7beae6c72a2b4ce0b66aa27a7532b4bb3065c56e77c5f3d310c2b334fdde0
+  data.tar.gz: 362bcc689ffce4a331bdaa73afecaa3a58b7ebd2dbe6f0dfb420c822e35d6759
 SHA512:
-  metadata.gz: 6262767b39d59b4a7a4e1b1ecf31a8160ca6b0c3bda88d74e6ec49379ee8508d6e7e7235e581ba9c72c6429074a786def5c4369a80f9566e268c8b05789aa020
-  data.tar.gz: b2a1fc4a67ea0c9616194183e164a458dac26e93d186d2ee15f22f076820641404080c4d539cebd815fee2daae907baa5b410c7b6a9f51700fbda984a2a6c4d9
+  metadata.gz: 6aec8d1ad550fe272628d75c828f1f47df09b010ad24ed57ed9feca125aae14f089d2e0ccf9723911d396c1d85db1ae5198a6c7e9d73156e2df8025b71db201f
+  data.tar.gz: 501360d550dca579dc6e961ab7bc208a2ba7c436386d5dcb1e423e965e92ca62980ce388d2473802fa843f970c2001409b32cedc6b8b50a762bf632ba3e798ad

data/CHANGELOG.md

@@ -4,6 +4,10 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 **Note:** this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.1.0] - Unreleased
+## [0.1.1] - 2023-08-16
+### Fixed
+- Fixed a bug where the `hosts` list was not be re-resolved on each new request made
+
+## [0.1.0] - 2023-08-13
 
 *   Initial release.

data/README.md

@@ -11,9 +11,22 @@ This list of IP addresses is then shuffled, and if a request fails to connect to
 And so on and so forth, until the retries are exhausted. If all of the IPs fail, then we cycle back to the first one and try again.
 
 The reason this is impactful and should be used in conjunction with the retry middleware is that the retry middleware will
-leave DNS resolution to the OS, which has the potential of caching results and not try resolving to a different IP address.
-This means that if a DNS entry resolves to three IPs, `[A, B, C]`, the retry middleware may try all three retries against
-`A`, where as this middleware guarantees that it will try `A`, `B`, and `C`.
+leave DNS resolution to the OS, which has the potential of two pitfalls:
+
+1. Caching results and not try resolving to a different IP address.
+2. Leaving resolution to a roll of the dice allowing the same IP to be tried multiple times.
+
+The issue with the first pitfall is rather obvious, but the second is a bit more subtle. If you have a DNS entry that resolves
+to 2 IP addresses `[A, B]` and 1 attempt, the OS resolution will result in one of the following list of attempts:
+
+1. `[A, A]`
+2. `[A, B]`
+3. `[B. B]`
+4. `[B, A]`
+
+This gives you a 50% chance of hitting the same IP twice, and a 50% chance of hitting the other IP twice, meaning the retry
+has no effect. By using this gem, you can ensure that the list of IPs is resolved ahead of time and cycled through to ensure
+a different IP is tried on each attempt.
 
 ## Installation
 

data/lib/faraday/highly_available_retries/middleware.rb

@@ -73,7 +73,7 @@ module Faraday
         host_list = if env[FAILOVER_ORIGINAL_HOST_ENV_KEY]
                       [[env[FAILOVER_ORIGINAL_HOST_ENV_KEY], env[FAILOVER_ORIGINAL_PORT_ENV_KEY]]] + @options.hosts(refresh: true)
                     else
-                      @options.hosts
+                      @options.hosts(refresh: true)
                     end
 
         host_list.map { |host, port| Endpoint.from_host_and_port(host, port) }.flatten

data/lib/faraday/highly_available_retries/version.rb

@@ -2,6 +2,6 @@
 
 module Faraday
   module HighlyAvailableRetries
-    VERSION = '0.1.0.pre.1'
+    VERSION = '0.1.1'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: faraday-highly_available_retries
 version: !ruby/object:Gem::Version
-  version: 0.1.0.pre.1
+  version: 0.1.1
 platform: ruby
 authors:
 - Invoca Development
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-02 00:00:00.000000000 Z
+date: 2023-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -49,8 +49,8 @@ licenses:
 metadata:
   allowed_push_host: https://rubygems.org
   bug_tracker_uri: https://github.com/invoca/faraday-highly_available_retries/issues
-  changelog_uri: https://github.com/invoca/faraday-highly_available_retries/blob/v0.1.0.pre.1/CHANGELOG.md
-  documentation_uri: http://www.rubydoc.info/gems/faraday-highly_available_retries/0.1.0.pre.1
+  changelog_uri: https://github.com/invoca/faraday-highly_available_retries/blob/v0.1.1/CHANGELOG.md
+  documentation_uri: http://www.rubydoc.info/gems/faraday-highly_available_retries/0.1.1
   homepage_uri: https://github.com/invoca/faraday-highly_available_retries
   source_code_uri: https://github.com/invoca/faraday-highly_available_retries
   wiki_uri: https://github.com/invoca/faraday-highly_available_retries/wiki
@@ -68,9 +68,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.4.17
 signing_key: