faraday-gzip 3.0.1 → 3.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a6ceb06f7b18d8d70a15a0a8ceda7cf7a2956df6653066f8ae0c84c0f1c832a
-  data.tar.gz: 9cde727357feea0a7efe5fe80a73c95942eb5fbcd0b21fa7a20c54d92acb91e8
+  metadata.gz: 801efea11d6b5a0e1f2d82c802cb6e0eea73bf542f7b9a793ff2288cefcc6c7f
+  data.tar.gz: d6d5f77de67e0223cdbf225cdb52e121d548a7202bd91bc4acfd50b9b0ef7e25
 SHA512:
-  metadata.gz: 5ee966bedad1ea9379de2f5f8c971326488366d831df22e78c7f29557a41189befce5bf0be373482de72b441a94e3d435db7812c980f69258cdb8ca207decd08
-  data.tar.gz: '08f511d78ee79f136d2ba4d5770585ec4a146296e8d6b2c72bdf4efbba5e450fb8a84988872da4b7278c3bcd9b183b7c513e6e7880000052d33bed5bfd6dceac'
+  metadata.gz: 715ab8b38d3050eacbbe21ac8f7444390e31d4807bd9908c6671ced6511c36b849ab11ec806140f2730d131b39dd8b90f7e08d03f69c4b2851a0df366020a78a
+  data.tar.gz: dd479efd565f0b80e371ee7f5b1883614c52f7d55a78b8e5df92a80cb5a5d940e1f8049bc0dddff5d97a56e6935b554d106fa223700f35536d3dfc3b876effa4

data/CHANGELOG.md

@@ -1,8 +1,12 @@
 # Changelog
 
-## 3.0.1 (01-Nov-2024)
+## 3.0.3 (25-Feb-2025)
 
-* Minor fix in gemspec
+* Minor code fixes, make some methods more solid
+
+## 3.0.1 / 3.0.2 (01-Nov-2024)
+
+* Minor fixes in gemspec
 
 ## 3.0.0 (29-Oct-2024)
 

data/lib/faraday/gzip/middleware.rb

@@ -67,7 +67,11 @@ module Faraday
       def uncompress_gzip(body)
         io = StringIO.new(body)
         gzip_reader = Zlib::GzipReader.new(io, encoding: 'ASCII-8BIT')
-        gzip_reader.read
+        begin
+          gzip_reader.read
+        ensure
+          gzip_reader.close
+        end
       end
 
       # Process deflate
@@ -103,7 +107,7 @@ module Faraday
 
       # Method providing the processors
       def processors
-        {
+        @processors ||= {
           'gzip' => ->(body) { uncompress_gzip(body) },
           'deflate' => ->(body) { inflate(body) },
           'br' => ->(body) { brotli_inflate(body) }

data/lib/faraday/gzip/version.rb

@@ -2,6 +2,6 @@
 
 module Faraday
   module Gzip
-    VERSION = '3.0.1'
+    VERSION = '3.0.3'
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: faraday-gzip
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.0.3
 platform: ruby
 authors:
 - Ilya Krukowski
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-01 00:00:00.000000000 Z
+date: 2025-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -114,20 +113,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.32'
-- !ruby/object:Gem::Dependency
-  name: rubocop-packaging
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -172,20 +157,15 @@ files:
 - lib/faraday/gzip.rb
 - lib/faraday/gzip/middleware.rb
 - lib/faraday/gzip/version.rb
-- spec/faraday/gzip/middleware_spec.rb
-- spec/faraday/gzip/version_spec.rb
-- spec/spec_helper.rb
 homepage: https://github.com/bodrovis/faraday-gzip
 licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/bodrovis/faraday-gzip/issues
   changelog_uri: https://github.com/bodrovis/faraday-gzip/blob/master/CHANGELOG.md
-  documentation_uri: http://www.rubydoc.info/gems/faraday-gzip/3.0.1
-  homepage_uri: https://github.com/bodrovis/faraday-gzip
+  documentation_uri: http://www.rubydoc.info/gems/faraday-gzip/3.0.3
   source_code_uri: https://github.com/bodrovis/faraday-gzip
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -200,8 +180,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 3.6.5
 specification_version: 4
 summary: Automatically sets compression headers and decompresses the response
 test_files: []

data/spec/faraday/gzip/middleware_spec.rb

@@ -1,179 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Faraday::Gzip::Middleware do
-  require 'brotli' if Faraday::Gzip::Middleware::BROTLI_SUPPORTED
-
-  subject(:middleware) do
-    described_class.new(->(env) { Faraday::Response.new(env) })
-  end
-
-  let(:headers) { {} }
-
-  def process(body, content_type = nil, options = {})
-    env = {
-      body: body, request: options,
-      request_headers: Faraday::Utils::Headers.new,
-      response_headers: Faraday::Utils::Headers.new(headers)
-    }
-    env[:response_headers]['content-type'] = content_type if content_type
-    yield(env) if block_given?
-    middleware.call(env)
-  end
-
-  context 'when request' do
-    it 'sets the Accept-Encoding request header' do
-      env = process('').env
-      encodings = Faraday::Gzip::Middleware::BROTLI_SUPPORTED ? 'gzip,deflate,br' : 'gzip,deflate'
-      expect(env[:request_headers][:accept_encoding]).to eq(encodings)
-    end
-
-    it 'doesnt overwrite existing Accept-Encoding request header' do
-      env = process('') do |e|
-        e[:request_headers][:accept_encoding] = 'zopfli'
-      end.env
-      expect(env[:request_headers][:accept_encoding]).to eq('zopfli')
-    end
-  end
-
-  context 'when response' do
-    let(:uncompressed_body) do
-      '<html><head><title>Rspec</title></head><body>Hello, spec!</body></html>'
-    end
-    let(:empty_body) { '' }
-    let(:gzipped_body) do
-      io = StringIO.new
-      gz = Zlib::GzipWriter.new(io)
-      gz.write(uncompressed_body)
-      gz.close
-      res = io.string
-      res.force_encoding('BINARY')
-      res
-    end
-    let(:deflated_body) do
-      Zlib::Deflate.deflate(uncompressed_body)
-    end
-    let(:raw_deflated_body) do
-      z = Zlib::Deflate.new(Zlib::DEFAULT_COMPRESSION, -Zlib::MAX_WBITS)
-      compressed_body = z.deflate(uncompressed_body, Zlib::FINISH)
-      z.close
-      compressed_body
-    end
-
-    if Faraday::Gzip::Middleware::BROTLI_SUPPORTED
-      let(:brotlied_body) do
-        Brotli.deflate(uncompressed_body)
-      end
-    end
-
-    shared_examples 'compressed response' do
-      it 'uncompresses the body' do
-        expect(process(body).body).to eq(uncompressed_body)
-      end
-
-      it 'sets the Content-Length' do
-        expect(process(body).headers['Content-Length']).to eq(uncompressed_body.length)
-      end
-
-      it 'removes the Content-Encoding' do
-        expect(process(body).headers['Content-Encoding']).to be_nil
-      end
-    end
-
-    context 'when gzipped response' do
-      let(:body) { gzipped_body }
-      let(:headers) { { 'Content-Encoding' => 'gzip', 'Content-Length' => body.length } }
-
-      it_behaves_like 'compressed response'
-    end
-
-    context 'when deflated response' do
-      let(:body) { deflated_body }
-      let(:headers) { { 'Content-Encoding' => 'deflate', 'Content-Length' => body.length } }
-
-      it_behaves_like 'compressed response'
-    end
-
-    context 'when raw deflated response' do
-      let(:body) { raw_deflated_body }
-      let(:headers) { { 'Content-Encoding' => 'deflate', 'Content-Length' => body.length } }
-
-      it_behaves_like 'compressed response'
-    end
-
-    if Faraday::Gzip::Middleware::BROTLI_SUPPORTED
-      context 'when brotlied response' do
-        let(:body) { brotlied_body }
-        let(:headers) { { 'Content-Encoding' => 'br', 'Content-Length' => body.length } }
-
-        it_behaves_like 'compressed response'
-      end
-    end
-
-    context 'when empty response' do
-      let(:body) { empty_body }
-      let(:headers) { { 'Content-Encoding' => 'gzip', 'Content-Length' => body.length } }
-
-      it 'sets the Content-Length' do
-        expect(process(body).headers['Content-Length']).to eq(empty_body.length)
-      end
-
-      it 'removes the Content-Encoding' do
-        expect(process(body).headers['Content-Encoding']).to be_nil
-      end
-    end
-
-    context 'when nil response' do
-      let(:body) { nil }
-      let(:headers) { { 'Content-Encoding' => 'gzip', 'Content-Length' => 0 } }
-
-      it 'sets the Content-Length' do
-        expect(process(body).headers['Content-Length']).to eq(0)
-      end
-
-      it 'removes the Content-Encoding' do
-        expect(process(body).headers['Content-Encoding']).to be_nil
-      end
-    end
-
-    context 'when identity response' do
-      let(:body) { uncompressed_body }
-
-      it 'does not modify the body' do
-        expect(process(body).body).to eq(uncompressed_body)
-      end
-    end
-
-    context 'when unsupported encoding response' do
-      let(:body) { 'unsupported' }
-      let(:headers) { { 'Content-Encoding' => 'unsupported' } }
-
-      it 'does not modify the body' do
-        expect(process(body).body).to eq(body)
-      end
-
-      it 'preserves the Content-Encoding header' do
-        expect(process(body).headers['Content-Encoding']).to eq('unsupported')
-      end
-    end
-
-    context 'when no Content-Encoding header' do
-      let(:body) { uncompressed_body }
-      let(:headers) { {} }
-
-      it 'does not modify the body' do
-        expect(process(body).body).to eq(uncompressed_body)
-      end
-
-      it 'does not add a Content-Encoding header' do
-        expect(process(body).headers['Content-Encoding']).to be_nil
-      end
-    end
-
-    context 'when Content-Length is a string' do
-      let(:body) { gzipped_body }
-      let(:headers) { { 'Content-Encoding' => 'gzip', 'Content-Length' => body.length.to_s } }
-
-      it_behaves_like 'compressed response'
-    end
-  end
-end

data/spec/faraday/gzip/version_spec.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe 'Faraday::Gzip::VERSION' do
-  subject { Object.const_get(self.class.description) }
-
-  it { is_expected.to match(/^\d+\.\d+\.\d+(\.\w+(\.\d+)?)?$/) }
-end

data/spec/spec_helper.rb

@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-
-require 'faraday'
-require 'simplecov'
-
-SimpleCov.start do
-  add_filter 'spec/'
-  add_filter '.github/'
-end
-
-require_relative '../lib/faraday/gzip'
-
-RSpec.configure do |config|
-  # Enable flags like --only-failures and --next-failure
-  config.example_status_persistence_file_path = '.rspec_status'
-
-  # Disable RSpec exposing methods globally on `Module` and `main`
-  config.disable_monkey_patching!
-
-  config.expect_with :rspec do |c|
-    c.syntax = :expect
-  end
-
-  config.order = :random
-end