faraday-digestauth 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 !binary "U0hBMQ==":
-  metadata.gz: 5e80cb294f034a9b9e14cb46d063ba8b1e9d466e
-  data.tar.gz: e622418ada1c6d1858d8d26263d35396a803efed
+  metadata.gz: 1c01446f0b7a664c1686708031360d4de062e0a4
+  data.tar.gz: 3c7447336b7b528bb1f9fe0ae111cccca2e9127f
 SHA512:
-  metadata.gz: a057d93c5969e4f9b29af8084712c2c5e2c6c83ec5eddc589ff14318ca890b6d40467c0ba3185a9ec98bd2e71ebc8b856c8b7c247da027c05b317765cddcb475
-  data.tar.gz: 225060eae656de664177c984f392240f0fcdfc369583c24907ad925c33e0b1bebd2d4f2e0d27399e5d5b13f881484f146c13dac2c068cc902d5ce36150b622f5
+  metadata.gz: a579073989264f24fdebe0f9ef56572af56fa667c8bc998c65e284ba1979acb6afb4140b157aa5936699e161e8e2d95dc632c938fb220609bd3bc8c3a089df83
+  data.tar.gz: a8721c84ad509ec0e97143565b1586d5ff049836e4077d3b60de699cb55708f702ab7fa36235bbb7120ac6a7156f708f1d6ad7825c8b0c5beaf1b68a07ccc157

data/.rspec

@@ -0,0 +1,3 @@
+--colour
+--format documentation
+

data/.rubocop.yml

@@ -0,0 +1,72 @@
+AllCops:
+  Exclude:
+    - vendor/**/*
+    - bin/**/*
+
+LineLength:
+  Enabled: false
+
+MethodLength:
+  Enabled: false
+
+ClassLength:
+  Enabled: false
+
+Documentation:
+  # don't require classes to be documented
+  Enabled: false
+
+CollectionMethods:
+  # don't prefer map to collect, recuce to inject
+  Enabled: false
+
+Encoding:
+  # no need to always specify encoding
+  Enabled: false
+
+StringLiterals:
+  # use single or double-quoted strings, as you please
+  Enabled: false
+
+Void:
+  # == operator used in void context in specs
+  Enabled: false
+
+SignalException:
+  # prefer raise to fail
+  EnforcedStyle: only_raise
+
+RaiseArgs:
+  # don't care for what kind of raise
+  Enabled: false
+
+PerlBackrefs:
+  # TODO: regular expression matching with $1, $2, etc.
+  Enabled: false
+
+BlockNesting:
+  # TODO: fix too much nesting
+  Max: 4
+
+Lambda:
+  # TODO: replace all lambda with -> or Proc
+  Enabled: false
+
+Blocks:
+  # allow multi-line blocks like expect { }
+  Enabled: false
+
+WordArray:
+  # %w vs. [ '', ... ]
+  Enabled: false
+
+CyclomaticComplexity:
+  Enabled: false
+
+DoubleNegation:
+  Enabled: false
+
+PredicateName:
+  Enabled: false
+
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,16 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2014-09-26 16:00:47 -0400 using RuboCop version 0.26.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: Exclude.
+Style/FileName:
+  Enabled: false
+
+# Offense count: 3
+# Configuration parameters: MaxSlashes.
+Style/RegexpLiteral:
+  Enabled: false

data/.travis.yml

@@ -3,22 +3,18 @@ env:
   global:
     - "JRUBY_OPTS=-Xcext.enabled=true"
 rvm:
-  - 2.1.0
+  - 2.1.2
   - 2.0.0
   - 1.9.3
-  - 1.9.2
-  - 1.8.7
-  - jruby-18mode
   - jruby-19mode
-  - rbx
+  - rbx-2.2.10
   - ruby-head
   - jruby-head
   - ree
 matrix:
   allow_failures:
-    - rvm: 1.8.7
     - rvm: ree
+    - rvm: ruby-head
     - rvm: jruby-18mode
-    - rvm: jruby-19mode
     - rvm: jruby-head
   fast_finish: true

data/README.md

@@ -6,12 +6,6 @@
 [![Coverage Status](https://coveralls.io/repos/bhaberer/faraday-digestauth/badge.png?branch=master)](https://coveralls.io/r/bhaberer/faraday-digestauth?branch=m    aster)
 [![Code Climate](https://codeclimate.com/github/bhaberer/faraday-digestauth.png)](https://codeclimate.com/github/bhaberer/faraday-digestauth)
 
-This gem started as a direct copy of a gist belonging to @kapkaev
-
-It is located at https://gist.github.com/kapkaev/5088751
-
-I merely gemmed it up so that I could use it in multiple places.
-
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -47,3 +41,11 @@ end
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+## History
+
+This gem was extracted from [Hyperclient](https://github.com/codegram/hyperclient) by [@oriolgual](https://github.com/oriolgual).
+
+## License
+
+MIT License, see [LICENSE](LICENSE.txt) for details.

data/Rakefile

@@ -1,7 +1,11 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new
 
-task :default => :spec
-task :test => :spec
+task test: :spec
+
+require 'rubocop/rake_task'
+RuboCop::RakeTask.new
+
+task default: [:rubocop, :spec]

data/faraday-digestauth.gemspec

@@ -6,14 +6,14 @@ require 'faraday/digestauth/version'
 Gem::Specification.new do |spec|
   spec.name          = 'faraday-digestauth'
   spec.version       = Faraday::DigestAuth::VERSION
-  spec.authors       = ['Brian Haberer', 'Ildar Kapkaev']
-  spec.email         = ['bhaberer@gmail.com', 'kirs.box@gmail.com']
-  spec.description   = %q{Faraday extension to enable digest auth}
-  spec.summary       = %q{Digest Auth for Faraday}
+  spec.authors       = ['Brian Haberer', 'Oriol Gual']
+  spec.email         = ['bhaberer@gmail.com', 'oriol.gual@gmail.com']
+  spec.description   = 'Faraday extension to enable digest auth'
+  spec.summary       = 'Digest Auth for Faraday'
   spec.homepage      = 'https://github.com/bhaberer/faraday-digestauth'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
@@ -24,4 +24,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10'
   spec.add_development_dependency 'rspec', '~> 3'
   spec.add_development_dependency 'coveralls', '~> 0.1'
+  spec.add_development_dependency 'rubocop', '~> 0.26.1'
+  spec.add_development_dependency 'webmock', '~> 1'
 end

data/lib/faraday/digestauth.rb

@@ -7,9 +7,9 @@ require 'faraday/request/digestauth'
 
 # Register the middleware as a Request middleware with the name :digest
 if Faraday.respond_to?(:register_middleware)                 # Faraday 0.8
-  Faraday.register_middleware :request, :digest => Faraday::Request::DigestAuth
+  Faraday.register_middleware :request, digest: Faraday::Request::DigestAuth
 elsif Faraday::Request.respond_to?(:register_middleware)     # Faraday 0.9
-  Faraday::Request.register_middleware :digest => Faraday::Request::DigestAuth
+  Faraday::Request.register_middleware digest: Faraday::Request::DigestAuth
 elsif Faraday::Request.respond_to?(:register_lookup_modules) # Faraday 0.7
-  Faraday::Request.register_lookup_modules :digest => :DigestAuth
+  Faraday::Request.register_lookup_modules digest: :DigestAuth
 end

data/lib/faraday/digestauth/version.rb

@@ -2,6 +2,6 @@
 module Faraday
   # Versioning Info
   module DigestAuth
-    VERSION = '0.2.0'
+    VERSION = '0.2.1'
   end
 end

data/lib/faraday/request/digestauth.rb

@@ -26,9 +26,13 @@ module Faraday
       # app      - The Faraday app.
       # user     - A String with the user to authentication the connection.
       # password - A String with the password to authentication the connection.
-      def initialize(app, user, password)
+      # opts     - A hash with options
+      #            - keep_body_on_handshake: if set to truthy, will also send
+      #              the original request body
+      def initialize(app, user, password, opts = {})
         super(app)
         @user, @password = user, password
+        @opts = opts
       end
 
       # Public: Sends a first request with an empty body to get the
@@ -55,7 +59,7 @@ module Faraday
       # Returns a Faraday::Response.
       def handshake(env)
         env_without_body = env.dup
-        env_without_body.delete(:body)
+        env_without_body.delete(:body) unless @opts[:keep_body_on_handshake]
         @app.call(env_without_body)
       end
 

data/spec/faraday-digestauth_spec.rb

@@ -1,13 +1,38 @@
 require 'spec_helper'
 
 describe Faraday::Request::DigestAuth do
+  let(:connection) do
+    Faraday.new('http://api.example.org/') do |builder|
+      builder.request :digest, 'USER', 'PASS'
+      builder.adapter :net_http
+    end
+  end
+
+  describe 'when the server does not return a 401' do
+    it 'does nothing' do
+      stub_request(:get, 'http://api.example.org/productions/1')
+        .to_return(status: 500, body: 'Foo body')
+
+      response = connection.get('/productions/1')
+      expect(response.body).to eq 'Foo body'
+    end
+  end
+
+  describe 'when the server returns a 401' do
+    let(:first_call_headers) { 'Digest realm="MyApp", algorithm=MD5' }
+    let(:second_call_headers) { 'Digest username="USER", realm="MyApp", uri="/", algorithm="MD5"' }
+    it 'authenticates using digest' do
+      stub_request(:get, 'http://api.example.org/productions/1')
+        .with(body: nil)
+        .to_return(status: 401, headers: { 'www-authenticate' => first_call_headers })
 
-  # This doesn't do anything yet.
-  it 'should allow users to build faraday objects with digest creds' do
-      @conn = Faraday.new(:url => 'http://localhost/') do |f|
-                f.request(:digest, :username, :password)
-                f.adapter  Faraday.default_adapter
-              end
+      stub_request(:get, 'http://api.example.org/productions/1')
+        .with(body: "{\"foo\":1}",
+              headers: { 'Authorization' => %r{second_call_headers} })
+        .to_return(body: '{"resource": "This is the resource"}',
+                   headers: { content_type: 'application/json' })
 
+      connection.get('/productions/1')
+    end
   end
 end

data/spec/spec_helper.rb

@@ -8,3 +8,4 @@ SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
 SimpleCov.start
 
 require 'faraday/digestauth'
+require 'webmock/rspec'

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: faraday-digestauth
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Brian Haberer
-- Ildar Kapkaev
+- Oriol Gual
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-04 00:00:00.000000000 Z
+date: 2015-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -95,15 +95,46 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.26.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.26.1
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1'
 description: Faraday extension to enable digest auth
 email:
 - bhaberer@gmail.com
-- kirs.box@gmail.com
+- oriol.gual@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
+- .rubocop.yml
+- .rubocop_todo.yml
 - .travis.yml
 - Gemfile
 - LICENSE.txt
@@ -136,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.4
 signing_key: 
 specification_version: 4
 summary: Digest Auth for Faraday