faraday-detailed_logger 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 39391a10ebf6f5c1e3afd4a16142b4a7a5cf44de
-  data.tar.gz: 7c339da08c5eba109844ec73cc5fe555b7a32f06
+  metadata.gz: 9de23200c017205fc17035dbc8ab4cd8e373c7df
+  data.tar.gz: 9bc2d6b56c9755f8968423a04ffe7e32b1ceb1fd
 SHA512:
-  metadata.gz: 5c4eb19555cb5d2062e6574f06c20c2104351ea4416912012296e323cc2c6c2b6f5a3342c6771cf350b7ddd5a997cc30a00e29a3d66298ff92e9afabb42834c9
-  data.tar.gz: 04c930843a10137ddccf41c45530519c25eebbd7e38e04e18f19ff207cb1686b449461a23df23ba01855a822502920f693c43ea925cf7c6d8c3babf35579794c
+  metadata.gz: c19accdf9dd31ce178bfc1e426f2ce7bbf733a407a0b2671c3667d2b6e6c5a9f1a14496fbd0909eaac3d5d076934a4e1baed906ca31e61d3b74b9e64b6db8f59
+  data.tar.gz: 8f64e8042ce7a1b171e81ffa6f6d582fcf31586b87a89589eb46a76f17008b38641f88a133d89f7df324b81053aa27f87b0a925c09b49de9ffe715f2dbe20c6a

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -0,0 +1,247 @@
+AllCops:
+  Exclude:
+    - "vendor/**/*"
+    - "db/schema.rb"
+  UseCache: false
+Style/BracesAroundHashParameters:
+  EnforcedStyle: braces
+Style/CollectionMethods:
+  Description: Preferred collection methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
+  Enabled: true
+  PreferredMethods:
+    collect: map
+    collect!: map!
+    find: detect
+    find_all: select
+    reduce: inject
+Style/DotPosition:
+  Description: Checks the position of the dot in multi-line method calls.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
+  Enabled: true
+  EnforcedStyle: trailing
+  SupportedStyles:
+  - leading
+  - trailing
+Style/FileName:
+  Description: Use snake_case for source file names.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-files
+  Enabled: false
+  Exclude: []
+Style/GuardClause:
+  Description: Check for conditionals that can be replaced with guard clauses
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals
+  Enabled: false
+  MinBodyLength: 1
+Style/IfUnlessModifier:
+  Description: Favor modifier if/unless usage when you have a single-line body.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier
+  Enabled: false
+  MaxLineLength: 80
+Style/IndentHash:
+  EnforcedStyle: consistent
+Style/OptionHash:
+  Description: Don't use option hashes when you can use keyword arguments.
+  Enabled: false
+Style/PercentLiteralDelimiters:
+  Description: Use `%`-literal delimiters consistently
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#percent-literal-braces
+  Enabled: false
+  PreferredDelimiters:
+    "%": "()"
+    "%i": "()"
+    "%q": "()"
+    "%Q": "()"
+    "%r": "{}"
+    "%s": "()"
+    "%w": "()"
+    "%W": "()"
+    "%x": "()"
+Style/PredicateName:
+  Description: Check the names of predicate methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
+  Enabled: true
+  NamePrefix:
+  - is_
+  - has_
+  - have_
+  NamePrefixBlacklist:
+  - is_
+  Exclude:
+  - spec/**/*
+Style/RaiseArgs:
+  Description: Checks the arguments passed to raise/fail.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#exception-class-messages
+  Enabled: false
+  EnforcedStyle: exploded
+  SupportedStyles:
+  - compact
+  - exploded
+Style/SignalException:
+  Description: Checks for proper usage of fail and raise.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#fail-method
+  Enabled: false
+  EnforcedStyle: semantic
+  SupportedStyles:
+  - only_raise
+  - only_fail
+  - semantic
+Style/SingleLineBlockParams:
+  Description: Enforces the names of some block params.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#reduce-blocks
+  Enabled: false
+  Methods:
+  - reduce:
+    - a
+    - e
+  - inject:
+    - a
+    - e
+Style/SingleLineMethods:
+  Description: Avoid single-line methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-single-line-methods
+  Enabled: false
+  AllowIfMethodIsEmpty: true
+Style/StringLiterals:
+  Description: Checks if uses of quotes match the configured preference.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
+  Enabled: true
+  EnforcedStyle: double_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
+Style/StringLiteralsInInterpolation:
+  Description: Checks if uses of quotes inside expressions in interpolated strings
+    match the configured preference.
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
+Style/TrailingCommaInArguments:
+  Description: 'Checks for trailing comma in argument lists.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  Enabled: false
+  EnforcedStyleForMultiline: no_comma
+  SupportedStyles:
+  - comma
+  - consistent_comma
+  - no_comma
+Style/TrailingCommaInLiteral:
+  Description: 'Checks for trailing comma in array and hash literals.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  Enabled: false
+  EnforcedStyleForMultiline: no_comma
+  SupportedStyles:
+  - comma
+  - consistent_comma
+  - no_comma
+Metrics/AbcSize:
+  Description: A calculated magnitude based on number of assignments, branches, and
+    conditions.
+  Enabled: false
+  Max: 15
+Metrics/ClassLength:
+  Description: Avoid classes longer than 100 lines of code.
+  Enabled: false
+  CountComments: false
+  Max: 100
+Metrics/ModuleLength:
+  CountComments: false
+  Max: 100
+  Description: Avoid modules longer than 100 lines of code.
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Description: A complexity metric that is strongly correlated to the number of test
+    cases needed to validate a method.
+  Enabled: false
+  Max: 6
+Metrics/MethodLength:
+  Description: Avoid methods longer than 10 lines of code.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#short-methods
+  Enabled: false
+  CountComments: false
+  Max: 10
+Metrics/ParameterLists:
+  Description: Avoid parameter lists longer than three or four parameters.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#too-many-params
+  Enabled: false
+  Max: 5
+  CountKeywordArgs: true
+Metrics/PerceivedComplexity:
+  Description: A complexity metric geared towards measuring complexity for a human
+    reader.
+  Enabled: false
+  Max: 7
+Lint/AssignmentInCondition:
+  Description: Don't use assignment in conditions.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#safe-assignment-in-condition
+  Enabled: false
+  AllowSafeAssignment: true
+Style/InlineComment:
+  Description: Avoid inline comments.
+  Enabled: false
+Style/AccessorMethodName:
+  Description: Check the naming of accessor methods for get_/set_.
+  Enabled: false
+Style/Alias:
+  Description: Use alias_method instead of alias.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#alias-method
+  Enabled: false
+Style/Documentation:
+  Description: Document classes and non-namespace modules.
+  Enabled: false
+Style/DoubleNegation:
+  Description: Checks for uses of double negation (!!).
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-bang-bang
+  Enabled: false
+Style/EachWithObject:
+  Description: Prefer `each_with_object` over `inject` or `reduce`.
+  Enabled: false
+Style/EmptyLiteral:
+  Description: Prefer literals to Array.new/Hash.new/String.new.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#literal-array-hash
+  Enabled: false
+Style/ModuleFunction:
+  Description: Checks for usage of `extend self` in modules.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#module-function
+  Enabled: false
+Style/OneLineConditional:
+  Description: Favor the ternary operator(?:) over if/then/else/end constructs.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#ternary-operator
+  Enabled: false
+Style/PerlBackrefs:
+  Description: Avoid Perl-style regex back references.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-perl-regexp-last-matchers
+  Enabled: false
+Style/Send:
+  Description: Prefer `Object#__send__` or `Object#public_send` to `send`, as `send`
+    may overlap with existing methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#prefer-public-send
+  Enabled: false
+Style/SpecialGlobalVars:
+  Description: Avoid Perl-style global variables.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-cryptic-perlisms
+  Enabled: false
+Style/VariableInterpolation:
+  Description: Don't interpolate global, instance and class variables directly in
+    strings.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#curlies-interpolate
+  Enabled: false
+Style/WhenThen:
+  Description: Use when x then ... for one-line cases.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#one-line-cases
+  Enabled: false
+Lint/EachWithObjectArgument:
+  Description: Check for immutable argument given to each_with_object.
+  Enabled: true
+Lint/HandleExceptions:
+  Description: Don't suppress exception.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions
+  Enabled: false
+Lint/LiteralInCondition:
+  Description: Checks of literals used in conditions.
+  Enabled: false
+Lint/LiteralInInterpolation:
+  Description: Checks for literals used in interpolation.
+  Enabled: false

data/CHANGELOG.md

@@ -10,6 +10,10 @@
 
 * No significant changes.
 
+## [2.1.0][] / 2016-10-12
+
+* Catch StandardError exceptions to log and re-raise them.
+
 ## [2.0.0][] / 2016-07-08
 
 * Remove Logger `progname` support/configuration. Varying the progname appears
@@ -33,4 +37,5 @@
 [1.0.0]: https://github.com/envylabs/faraday-detailed_logger/tree/v1.0.0
 [1.1.0]: https://github.com/envylabs/faraday-detailed_logger/compare/v1.0.0...v1.1.0
 [2.0.0]: https://github.com/envylabs/faraday-detailed_logger/compare/v1.1.0...v2.0.0
-[HEAD]: https://github.com/envylabs/faraday-detailed_logger/compare/v2.0.0...master
+[2.1.0]: https://github.com/envylabs/faraday-detailed_logger/compare/v2.0.0...v2.1.0
+[HEAD]: https://github.com/envylabs/faraday-detailed_logger/compare/v2.1.0...master

data/Gemfile

@@ -1,4 +1,2 @@
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in faraday-detailed_logger.gemspec
+source "https://rubygems.org"
 gemspec

data/Rakefile

@@ -3,4 +3,4 @@ require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task({ default: :spec })

data/faraday-detailed_logger.gemspec

@@ -1,22 +1,28 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'faraday/detailed_logger/version'
+require "faraday/detailed_logger/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "faraday-detailed_logger"
-  spec.version       = Faraday::DetailedLogger::VERSION
-  spec.authors       = ["Envy Labs"]
-  spec.email         = [""]
+  spec.name = "faraday-detailed_logger"
+  spec.version = Faraday::DetailedLogger::VERSION
+  spec.authors = ["Envy Labs"]
+  spec.email = [""]
 
-  spec.summary       = %q{A detailed request and response logger for Faraday.}
-  spec.description   = %q{A Faraday middleware for logging request and response activity including method, URI, headers, and body at varying log levels.}
-  spec.homepage      = "https://github.com/envylabs/faraday-detailed_logger"
-  spec.license       = "MIT"
+  spec.summary = "A detailed request and response logger for Faraday."
+  spec.description = %(
+    A Faraday middleware for logging request and response activity including
+    method, URI, headers, and body at varying log levels.
+  )
+  spec.homepage = "https://github.com/envylabs/faraday-detailed_logger"
+  spec.license = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.files = `git ls-files -z`.split("\x0").reject { |f|
+    f.match(%r{^(test|spec|features)/})
+  }
+
+  spec.bindir = "exe"
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_runtime_dependency "faraday"

data/lib/faraday/detailed_logger/middleware.rb

@@ -14,13 +14,11 @@ module Faraday
     # greater level, this is not a concern.
     #
     class Middleware < Faraday::Response::Middleware
-
       def self.default_logger
         require "logger"
-        ::Logger.new(STDOUT)
+        ::Logger.new($stdout)
       end
 
-
       # Public: Initialize a new Logger middleware.
       #
       # app - A Faraday-compatible middleware stack or application.
@@ -46,9 +44,12 @@ module Faraday
       def call(env)
         logger.tagged(*tags) do
           logger.info { "#{env[:method].upcase} #{env[:url]}" }
-          logger.debug { curl_output(env[:request_headers], env[:body]).inspect }
+          logger.debug { curl_request_output(env) }
         end
         super
+      rescue
+        logger.error { "#{$!.class.name} - #{$!.message} (#{$!.backtrace.first})" }
+        raise
       end
 
       # Internal: Used by Faraday as a callback hook to process a network
@@ -63,19 +64,25 @@ module Faraday
 
         logger.tagged(*tags) do
           log_response_status(status) { "HTTP #{status}" }
-          logger.debug { curl_output(env[:response_headers], env[:body]).inspect }
+          logger.debug { curl_response_output(env) }
         end
       end
 
-
       private
 
-
       attr_reader :logger
       attr_reader :tags
 
+      def curl_request_output(env)
+        curl_output(env[:request_headers], env[:body]).inspect
+      end
+
+      def curl_response_output(env)
+        curl_output(env[:response_headers], env[:body]).inspect
+      end
+
       def curl_output(headers, body)
-        string = headers.collect { |k,v| "#{k}: #{v}" }.join("\n")
+        string = headers.map { |k, v| "#{k}: #{v}" }.join("\n")
         string + "\n\n#{body}"
       end
 
@@ -91,4 +98,6 @@ module Faraday
   end
 end
 
-Faraday::Response.register_middleware(:detailed_logger => Faraday::DetailedLogger::Middleware)
+Faraday::Response.register_middleware({
+  detailed_logger: Faraday::DetailedLogger::Middleware
+})

data/lib/faraday/detailed_logger/tagged_logging.rb

@@ -1,4 +1,4 @@
-require 'logger'
+require "logger"
 
 module Faraday
   module DetailedLogger
@@ -10,7 +10,9 @@ module Faraday
       extend Forwardable
 
       module Formatter
-        BLANK = lambda { |value| value.respond_to?(:empty?) ? !!value.empty? : !value }
+        BLANK = lambda do |value|
+          value.respond_to?(:empty?) ? !!value.empty? : !value
+        end
 
         def call(severity, timestamp, progname, msg)
           super(severity, timestamp, progname, "#{tags_text}#{msg}")
@@ -38,20 +40,20 @@ module Faraday
         end
 
         def current_tags
-          @thread_key ||= "faraday_detailed_logger_tagged_logging_tags:#{object_id}".freeze
+          @thread_key ||= "faraday_detailed_logger_tags:#{object_id}".freeze
           Thread.current[@thread_key] ||= []
         end
 
         private
-          def tags_text
-            tags = current_tags
-            if tags.any?
-              tags.collect { |tag| "[#{tag}] " }.join
-            end
+
+        def tags_text
+          tags = current_tags
+          if tags.any?
+            tags.map { |tag| "[#{tag}] " }.join
           end
+        end
       end
 
-
       def self.new(logger)
         unless logger.respond_to?(:tagged)
           logger.formatter ||= ::Logger::Formatter.new

data/lib/faraday/detailed_logger/version.rb

@@ -1,5 +1,5 @@
 module Faraday
   module DetailedLogger
-    VERSION = "2.0.0"
+    VERSION = "2.1.0".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faraday-detailed_logger
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Envy Labs
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-08 00:00:00.000000000 Z
+date: 2016-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -94,8 +94,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-description: A Faraday middleware for logging request and response activity including
-  method, URI, headers, and body at varying log levels.
+description: "\n    A Faraday middleware for logging request and response activity
+  including\n    method, URI, headers, and body at varying log levels.\n  "
 email:
 - ''
 executables: []
@@ -103,7 +103,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hound.yml"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md
@@ -146,4 +148,3 @@ signing_key:
 specification_version: 4
 summary: A detailed request and response logger for Faraday.
 test_files: []
-has_rdoc: