faraday-cookie_jar 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23be36b8be03b487d50d756a69c6f3e6996a1e2f
-  data.tar.gz: 80be5d729297d81d752dce3c0ff65c11e6d04911
+  metadata.gz: a8195f07090b241910a6e10b5507219a4e1b0bb0
+  data.tar.gz: cfdbddb3fd497aa3e1afc96b9d0987e0817d2459
 SHA512:
-  metadata.gz: eedf7cd419797c390d238fab7a48b198a37855653d17af0283a56f020f92587f3a31b3ebc93ab4f3769979a2b1e308d17e3c7cd88c170e9b24d7f4ea426f8e6e
-  data.tar.gz: 05c368592c7eea598722a17fb9b3cfb88d4d11f7c38d91c4c7c48d022fb06eb43e7a244ea0b51a5b1731bc419e99cfc95dd502fd92245c509bb9f6c619b5a748
+  metadata.gz: b97438bab250cb4ce8a6f3d03f0df750adfa3bd5b82ced61bf50dd52d995967c875e9eec207d50826833d4f5a6c218e86b8b72b0d159acb819f0ee2c24c66bf4
+  data.tar.gz: 93c1ee9c3fa64a9491a442028ee2ce1f12921722419613b43bd4481b61920bdab81e19087f591e67afea1ed74c5a80ab5a3f823f8d3c4584aa3b2ef378d6a140

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.0.6  Tue Jan 21 16:34:35 PST 2014
+
+- Support Faraday 0.9 registry API (cameron-martin)
+- Support specifying CookieJar in configuration (cameron-martin)
+
 ## 0.0.5  Mon Jan 20 21:53:13 PST 2014
 
 - Lock faraday dependency to < 0.9.0 for now

data/faraday-cookie_jar.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "faraday", ">= 0.7.4", "< 0.9.0"
+  spec.add_dependency "faraday", ">= 0.7.4"
   spec.add_dependency "http-cookie", "~> 1.0.0"
 
   spec.add_development_dependency "bundler", "~> 1.3"

data/lib/faraday/cookie_jar.rb

@@ -5,7 +5,7 @@ module Faraday
   class CookieJar < Faraday::Middleware
     def initialize(app, options = {})
       super(app)
-      @jar = HTTP::CookieJar.new
+      @jar = options[:jar] || HTTP::CookieJar.new
     end
 
     def call(env)
@@ -32,4 +32,6 @@ end
 
 if Faraday.respond_to? :register_middleware
   Faraday.register_middleware :cookie_jar => lambda { Faraday::CookieJar }
+elsif Faraday::Middleware.respond_to? :register_middleware
+  Faraday::Middleware.register_middleware :cookie_jar => Faraday::CookieJar
 end

data/lib/faraday/cookie_jar/version.rb

@@ -1,5 +1,5 @@
 module Faraday
   module CookieJarVersion
-    VERSION = "0.0.5"
+    VERSION = "0.0.6"
   end
 end

data/spec/faraday-cookie_jar/cookie_jar_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 
 describe Faraday::CookieJar do
   let(:conn) { Faraday.new(:url => 'http://faraday.example.com') }
+  let(:cookie_jar) { HTTP::CookieJar.new }
 
   before do
     conn.use :cookie_jar
@@ -10,19 +11,32 @@ describe Faraday::CookieJar do
 
   it 'get default cookie' do
     conn.get('/default')
-    conn.get('/dump').body.should == 'foo=bar'
+    expect(conn.get('/dump').body).to eq('foo=bar')
   end
 
   it 'does not send cookies to wrong path' do
     conn.get('/path')
-    conn.get('/dump').body.should_not == 'foo=bar'
+    expect(conn.get('/dump').body).to_not eq('foo=bar')
   end
 
   it 'expires cookie' do
     conn.get('/expires')
-    conn.get('/dump').body.should == 'foo=bar'
+    expect(conn.get('/dump').body).to eq('foo=bar')
     sleep 2
-    conn.get('/dump').body.should_not == 'foo=bar'
+    expect(conn.get('/dump').body).to_not eq('foo=bar')
+  end
+
+  it 'fills an injected cookie jar' do
+
+    conn_with_jar = Faraday.new(:url => 'http://faraday.example.com') do |conn|
+      conn.use :cookie_jar, jar: cookie_jar
+      conn.adapter :net_http # for sham_rock
+    end
+
+    conn_with_jar.get('/default')
+
+    expect(cookie_jar.empty?).to be_false
+
   end
 
   it 'multiple cookies' do
@@ -33,7 +47,7 @@ describe Faraday::CookieJar do
       request.headers.merge!({:Cookie => 'language=english'})
     end
 
-    response.body.should == 'foo=bar;language=english'
+    expect(response.body).to eq('foo=bar;language=english')
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faraday-cookie_jar
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Tatsuhiko Miyagawa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-21 00:00:00.000000000 Z
+date: 2014-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -17,9 +17,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.7.4
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -27,9 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.7.4
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: http-cookie
   requirement: !ruby/object:Gem::Requirement