familia 2.0.0.pre21 → 2.0.0.pre23

data/try/integration/data_types/datatype_pipelines_try.rb

@@ -81,10 +81,12 @@ result = @user.scores.pipelined { |pipe| }
 #=> [true, true]
 
 ## Multiple DataType operations in single pipeline
+# Note: Raw Redis commands bypass Familia's JSON serialization.
+# Use serialize_value for values that will be looked up via Familia methods.
 result = @user.scores.pipelined do |pipe|
-  pipe.zadd(@user.scores.dbkey, 500, 'multi')
-  pipe.hset(@user.profile.dbkey, 'multi', 'pipeline')
-  pipe.sadd(@user.tags.dbkey, 'multi_tag')
+  pipe.zadd(@user.scores.dbkey, 500, @user.scores.serialize_value('multi'))
+  pipe.hset(@user.profile.dbkey, 'multi', @user.profile.serialize_value('pipeline'))
+  pipe.sadd(@user.tags.dbkey, @user.tags.serialize_value('multi_tag'))
 end
 [
   result.is_a?(MultiResult),

data/try/integration/data_types/datatype_transactions_try.rb

@@ -152,6 +152,8 @@ conn_class
 #=> "Redis::MultiConnection"
 
 ## Transaction with direct_access works correctly
+# Note: direct_access bypasses serialize_value, so raw 'true' string
+# gets parsed as JSON boolean true on retrieval (Issue #190 behavior)
 result = @user.profile.transaction do |trans_conn|
   trans_conn.hset(@user.profile.dbkey, 'status', 'active')
 
@@ -162,7 +164,7 @@ result = @user.profile.transaction do |trans_conn|
   end
 end
 [@user.profile['status'], @user.profile['verified']]
-#=> ["active", "true"]
+#=> ["active", true]
 
 ## Transaction atomicity - all commands succeed or none
 test_zset = Familia::SortedSet.new('atomic:test')
@@ -182,11 +184,13 @@ end
 #=> ["initial"]
 
 ## Nested transactions with parent-owned DataTypes work
+# Note: Raw Redis commands bypass Familia's JSON serialization.
+# Use serialize_value or check raw members for consistency.
 outer_result = @user.scores.transaction do |outer_conn|
-  outer_conn.zadd(@user.scores.dbkey, 999, 'outer_member')
+  outer_conn.zadd(@user.scores.dbkey, 999, @user.scores.serialize_value('outer_member'))
 
   inner_result = @user.tags.transaction do |inner_conn|
-    inner_conn.sadd(@user.tags.dbkey, 'nested_tag')
+    inner_conn.sadd(@user.tags.dbkey, @user.tags.serialize_value('nested_tag'))
   end
 
   inner_result.is_a?(MultiResult)
@@ -231,12 +235,14 @@ TransactionTestUser.logical_database
 #=> 2
 
 ## Multiple DataType types in single transaction
+# Note: Raw Redis commands bypass Familia's JSON serialization.
+# Use serialize_value for values that will be looked up via Familia methods.
 result = @user.scores.transaction do |conn|
   # Can operate on different DataTypes using same connection
-  conn.zadd(@user.scores.dbkey, 777, 'multi_test')
-  conn.hset(@user.profile.dbkey, 'multi', 'yes')
-  conn.sadd(@user.tags.dbkey, 'multi_tag')
-  conn.rpush(@user.activity.dbkey, 'multi_action')
+  conn.zadd(@user.scores.dbkey, 777, @user.scores.serialize_value('multi_test'))
+  conn.hset(@user.profile.dbkey, 'multi', @user.profile.serialize_value('yes'))
+  conn.sadd(@user.tags.dbkey, @user.tags.serialize_value('multi_tag'))
+  conn.rpush(@user.activity.dbkey, @user.activity.serialize_value('multi_action'))
 end
 [
   result.is_a?(MultiResult),

data/try/integration/models/customer_try.rb

@@ -73,7 +73,8 @@ Customer.find_by_id(ident).planid
 #=> true
 
 ## Customer can be added to class-level sorted set
-Customer.instances.add(@customer.identifier)
+# Note: Add the object directly so identifier extraction is consistent
+Customer.instances.add(@customer)
 Customer.instances.member?(@customer)
 #=> true
 
@@ -97,11 +98,10 @@ multi_result = @customer.destroy!
 cust = Customer.find_by_id('test@example.com')
 exists = Customer.exists?('test@example.com')
 [multi_result.results, cust.nil?, exists]
-#=> [[1, 0, 1, 1, 1, 1, 1], true, false]
+#=> [[1, 0, 1, 1, 1, 1, 1, true], true, false]
 
 ## Customer.destroy! can be called on an already destroyed object
 @customer.destroy!
-#=:> MultiResult
 #==> result.successful?
 #=*> result.results
 

data/try/unit/data_types/boolean_try.rb

@@ -3,6 +3,7 @@
 # frozen_string_literal: true
 
 # try/data_types/boolean_try.rb
+# Issue #190: Updated to reflect JSON serialization with type preservation
 
 require_relative '../../support/helpers/test_helpers'
 
@@ -10,37 +11,49 @@ Familia.debug = false
 
 @hashkey = Familia::HashKey.new 'key'
 
-## Boolean values are returned as strings, on assignment as string
+## String 'true' is stored and returned as string
 @hashkey['test'] = 'true'
 #=> "true"
 
-## Boolean values are returned as strings
+## String values are returned as strings
 @hashkey['test']
 #=> "true"
 
-## Trying to store a boolean value to a hash key raises an exception
-begin
-  @hashkey['test'] = true
-rescue Familia::NotDistinguishableError => e
-  e.message
-end
-#=> "Cannot represent true<TrueClass> as a string"
+## Boolean true is now stored with type preservation (Issue #190)
+@hashkey['bool_true'] = true
+#=> true
 
-## Boolean values are returned as strings
-@hashkey['test']
-#=> "true"
+## Boolean true is returned as TrueClass
+@hashkey['bool_true']
+#=> true
 
-## Trying to store a nil value to a hash key raises an exception
-begin
-  @hashkey['test'] = nil
-rescue Familia::NotDistinguishableError => e
-  e.message
-end
-#=> "Cannot represent <NilClass> as a string"
+## Boolean true has correct class
+@hashkey['bool_true'].class
+#=> TrueClass
 
-## The exceptions prevented the hash from being updated
-@hashkey['test']
-#=> "true"
+## Boolean false is stored with type preservation
+@hashkey['bool_false'] = false
+#=> false
+
+## Boolean false is returned as FalseClass
+@hashkey['bool_false']
+#=> false
+
+## Boolean false has correct class
+@hashkey['bool_false'].class
+#=> FalseClass
+
+## nil is stored with type preservation
+@hashkey['nil_value'] = nil
+#=> nil
+
+## nil is returned as nil
+@hashkey['nil_value']
+#=> nil
+
+## nil has correct class
+@hashkey['nil_value'].class
+#=> NilClass
 
 ## Clear the hash key
 @hashkey.delete!

data/try/unit/data_types/hash_try.rb

@@ -50,8 +50,8 @@ require_relative '../../support/helpers/test_helpers'
 @a.props.decrement 'counter', 60
 #=> 40
 
-## Familia::HashKey#values_at
+## Familia::HashKey#values_at (counter is integer from HINCRBY, others are strings)
 @a.props.values_at 'fieldA', 'counter', 'fieldC'
-#=> ['1', '40', '3']
+#=> ['1', 40, '3']
 
 @a.props.delete!

data/try/unit/data_types/serialization_try.rb

@@ -0,0 +1,386 @@
+# try/unit/data_types/serialization_try.rb
+#
+# frozen_string_literal: true
+
+# Test coverage for DataType serialization/deserialization behavior
+# Issue #190: Unify DataType and Horreum serialization for type preservation
+
+require_relative '../../support/helpers/test_helpers'
+
+Familia.debug = false
+
+# Create test instances
+@bone = Bone.new('serialize_test_token')
+
+# ========================================
+# DataType Serialization Behavior (Issue #190)
+# Now uses JSON serialization for type preservation
+# ========================================
+
+## HashKey stores string values correctly
+@bone.props['string_field'] = 'hello'
+@bone.props['string_field']
+#=> 'hello'
+
+## HashKey stores integer with type preservation
+@bone.props['int_field'] = 42
+@bone.props['int_field']
+#=> 42
+
+## HashKey stores float with type preservation
+@bone.props['float_field'] = 3.14
+@bone.props['float_field']
+#=> 3.14
+
+## HashKey stores symbol as string (symbols serialize to strings in JSON)
+@bone.props['symbol_field'] = :active
+@bone.props['symbol_field']
+#=> 'active'
+
+## HashKey stores boolean true with type preservation
+@bone.props['bool_true'] = true
+@bone.props['bool_true']
+#=> true
+
+## HashKey stores boolean true as TrueClass
+@bone.props['bool_true'].class
+#=> TrueClass
+
+## HashKey stores boolean false with type preservation
+@bone.props['bool_false'] = false
+@bone.props['bool_false']
+#=> false
+
+## HashKey stores boolean false as FalseClass
+@bone.props['bool_false'].class
+#=> FalseClass
+
+## HashKey stores nil with type preservation
+@bone.props['nil_field'] = nil
+@bone.props['nil_field']
+#=> nil
+
+## HashKey stores hash with type preservation
+@bone.props['hash_field'] = { 'key' => 'value' }
+@bone.props['hash_field']
+#=> {'key'=>'value'}
+
+## HashKey stores array with type preservation
+@bone.props['array_field'] = [1, 2, 3]
+@bone.props['array_field']
+#=> [1, 2, 3]
+
+# ========================================
+# List Serialization Behavior
+# ========================================
+
+## List stores string values correctly
+@bone.owners.delete!
+@bone.owners.push('owner1')
+@bone.owners.first
+#=> 'owner1'
+
+## List stores integer with type preservation
+@bone.owners.delete!
+@bone.owners.push(123)
+@bone.owners.first
+#=> 123
+
+## List stores boolean with type preservation
+@bone.owners.delete!
+@bone.owners.push(true)
+@bone.owners.first
+#=> true
+
+## List stores nil with type preservation
+@bone.owners.delete!
+@bone.owners.push(nil)
+@bone.owners.first
+#=> nil
+
+# ========================================
+# Set Serialization Behavior
+# ========================================
+
+## Set stores string values correctly
+@bone.tags.delete!
+@bone.tags.add('tag1')
+@bone.tags.members.include?('tag1')
+#=> true
+
+## Set stores integer with type preservation
+@bone.tags.delete!
+@bone.tags.add(42)
+@bone.tags.members.include?(42)
+#=> true
+
+## Set stores boolean with type preservation
+@bone.tags.delete!
+@bone.tags.add(true)
+@bone.tags.members.include?(true)
+#=> true
+
+# ========================================
+# SortedSet Serialization Behavior
+# ========================================
+
+## SortedSet stores string values correctly
+@bone.metrics.delete!
+@bone.metrics.add('metric1', 1.0)
+@bone.metrics.members.include?('metric1')
+#=> true
+
+## SortedSet stores integer member with type preservation
+@bone.metrics.delete!
+@bone.metrics.add(999, 1.0)
+@bone.metrics.members.include?(999)
+#=> true
+
+## SortedSet stores boolean member with type preservation
+@bone.metrics.delete!
+@bone.metrics.add(true, 1.0)
+@bone.metrics.members.include?(true)
+#=> true
+
+# ========================================
+# Horreum Field Serialization (for comparison)
+# Uses JSON encoding - type preserved
+# ========================================
+
+## Horreum field stores string with JSON encoding
+@customer = Customer.new
+@customer.custid = 'serialization_test'
+@customer.role = 'admin'
+@customer.save
+loaded = Customer.find_by_id('serialization_test')
+loaded.role
+#=> 'admin'
+
+## Horreum field stores boolean true (JSON encoded)
+@customer.verified = true
+@customer.save
+@loaded_customer = Customer.find_by_id('serialization_test')
+@loaded_customer.verified
+#=> true
+
+## Horreum verified field is actually boolean, not string
+@loaded_customer.verified.class
+#=> TrueClass
+
+## Horreum field stores boolean false (JSON encoded)
+@customer.reset_requested = false
+@customer.save
+@loaded_customer2 = Customer.find_by_id('serialization_test')
+@loaded_customer2.reset_requested
+#=> false
+
+## Horreum reset_requested field is actually boolean, not string
+@loaded_customer2.reset_requested.class
+#=> FalseClass
+
+# ========================================
+# Type Round-Trip Comparison (Unified Behavior)
+# ========================================
+
+## Integer round-trip in HashKey now preserves type (Issue #190)
+@bone.props['roundtrip_int'] = 100
+retrieved = @bone.props['roundtrip_int']
+retrieved.class
+#=> Integer
+
+## Boolean round-trip in HashKey preserves type
+@bone.props['roundtrip_bool'] = true
+@bone.props['roundtrip_bool'].class
+#=> TrueClass
+
+## DataType and Horreum now use same JSON serialization
+@session = Session.new
+@session.sessid = 'roundtrip_test'
+# Both DataType and Horreum fields now preserve types consistently
+
+# ========================================
+# Horreum serialize_value Comprehensive Tests
+# (Issue #190: Document behavior for unification)
+# ========================================
+
+## Horreum serialize_value: string gets JSON encoded with quotes
+@customer.serialize_value('hello')
+#=> '"hello"'
+
+## Horreum serialize_value: empty string gets JSON encoded
+@customer.serialize_value('')
+#=> '""'
+
+## Horreum serialize_value: integer becomes JSON number (no quotes)
+@customer.serialize_value(42)
+#=> '42'
+
+## Horreum serialize_value: zero becomes JSON number
+@customer.serialize_value(0)
+#=> '0'
+
+## Horreum serialize_value: negative integer
+@customer.serialize_value(-99)
+#=> '-99'
+
+## Horreum serialize_value: float becomes JSON number
+@customer.serialize_value(3.14159)
+#=> '3.14159'
+
+## Horreum serialize_value: boolean true becomes JSON true
+@customer.serialize_value(true)
+#=> 'true'
+
+## Horreum serialize_value: boolean false becomes JSON false
+@customer.serialize_value(false)
+#=> 'false'
+
+## Horreum serialize_value: nil becomes JSON null
+@customer.serialize_value(nil)
+#=> 'null'
+
+## Horreum serialize_value: symbol becomes JSON string
+@customer.serialize_value(:active)
+#=> '"active"'
+
+## Horreum serialize_value: hash becomes JSON object
+@customer.serialize_value({ name: 'test', count: 5 })
+#=> '{"name":"test","count":5}'
+
+## Horreum serialize_value: array becomes JSON array
+@customer.serialize_value([1, 'two', true, nil])
+#=> '[1,"two",true,null]'
+
+## Horreum serialize_value: nested structures work
+@customer.serialize_value({ users: [{ id: 1 }, { id: 2 }] })
+#=> '{"users":[{"id":1},{"id":2}]}'
+
+# ========================================
+# Horreum deserialize_value Comprehensive Tests
+# ========================================
+
+## Horreum deserialize_value: JSON string becomes Ruby string
+@customer.deserialize_value('"hello"')
+#=> 'hello'
+
+## Horreum deserialize_value: JSON number becomes Ruby integer
+@customer.deserialize_value('42')
+#=> 42
+
+## Horreum deserialize_value: JSON number is actually Integer class
+@customer.deserialize_value('42').class
+#=> Integer
+
+## Horreum deserialize_value: JSON float becomes Ruby float
+@customer.deserialize_value('3.14159')
+#=> 3.14159
+
+## Horreum deserialize_value: JSON float is actually Float class
+@customer.deserialize_value('3.14159').class
+#=> Float
+
+## Horreum deserialize_value: JSON true becomes Ruby true
+@customer.deserialize_value('true')
+#=> true
+
+## Horreum deserialize_value: JSON true is TrueClass
+@customer.deserialize_value('true').class
+#=> TrueClass
+
+## Horreum deserialize_value: JSON false becomes Ruby false
+@customer.deserialize_value('false')
+#=> false
+
+## Horreum deserialize_value: JSON false is FalseClass
+@customer.deserialize_value('false').class
+#=> FalseClass
+
+## Horreum deserialize_value: JSON null becomes Ruby nil
+@customer.deserialize_value('null')
+#=> nil
+
+## Horreum deserialize_value: JSON object becomes Ruby hash
+@customer.deserialize_value('{"name":"test","count":5}')
+#=> {"name"=>"test", "count"=>5}
+
+## Horreum deserialize_value: JSON array becomes Ruby array
+@customer.deserialize_value('[1,"two",true,null]')
+#=> [1, "two", true, nil]
+
+## Horreum deserialize_value: nil input returns nil
+@customer.deserialize_value(nil)
+#=> nil
+
+## Horreum deserialize_value: empty string returns nil
+@customer.deserialize_value('')
+#=> nil
+
+## Horreum deserialize_value: plain unquoted string (legacy data) returns as-is
+# This handles data stored before JSON encoding was used
+@customer.deserialize_value('plain string without quotes')
+#=> 'plain string without quotes'
+
+# ========================================
+# Familia Object Serialization (shared behavior)
+# ========================================
+
+## Horreum serialize_value: string value gets JSON encoded
+# When storing a value from another Familia object's field
+@ref_customer = Customer.new('reference_test@example.com')
+@ref_customer.custid = 'reference_test@example.com'
+# Note: Horreum.serialize_value uses JsonSerializer.dump, which JSON-encodes
+# all values, including strings. This is different from DataType#serialize_value,
+# which has special handling for Familia objects.
+@customer.serialize_value(@ref_customer.custid)
+#=> '"reference_test@example.com"'
+
+# ========================================
+# Round-trip Type Preservation Tests
+# ========================================
+
+## Round-trip: integer preserves type through Horreum serialization
+serialized = @customer.serialize_value(42)
+@customer.deserialize_value(serialized)
+#=> 42
+
+## Round-trip: integer class preserved
+serialized = @customer.serialize_value(42)
+@customer.deserialize_value(serialized).class
+#=> Integer
+
+## Round-trip: boolean true preserves type
+serialized = @customer.serialize_value(true)
+@customer.deserialize_value(serialized)
+#=> true
+
+## Round-trip: boolean true class preserved
+serialized = @customer.serialize_value(true)
+@customer.deserialize_value(serialized).class
+#=> TrueClass
+
+## Round-trip: boolean false preserves type
+serialized = @customer.serialize_value(false)
+@customer.deserialize_value(serialized)
+#=> false
+
+## Round-trip: nil preserves type
+serialized = @customer.serialize_value(nil)
+@customer.deserialize_value(serialized)
+#=> nil
+
+## Round-trip: hash preserves structure
+serialized = @customer.serialize_value({ active: true, count: 10 })
+@customer.deserialize_value(serialized)
+#=> {"active"=>true, "count"=>10}
+
+## Round-trip: array preserves structure and types
+serialized = @customer.serialize_value([1, 'two', true, nil, 3.5])
+@customer.deserialize_value(serialized)
+#=> [1, "two", true, nil, 3.5]
+
+# Cleanup
+@bone.props.delete!
+@bone.owners.delete!
+@bone.tags.delete!
+@bone.metrics.delete!
+@customer.destroy! rescue nil

data/try/unit/horreum/destroy_related_fields_cleanup_try.rb

@@ -259,8 +259,9 @@ destroy_result = model.destroy!
 
 # Should result in success and also complete in a reasonable amount of
 # time (under 100ms for this test). I acknowledge this is flaky.
+# Note: 42 results = 40 related field DELs + 1 main object DEL + 1 instances ZREM
 [destroy_result.class, destroy_result.successful?, destroy_result.results.size]
-#=> [MultiResult, true, 41]
+#=> [MultiResult, true, 42]
 #=%> 100
 
 ## Verify transaction_fallback_integration_try.rb bug is fixed

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: familia
 version: !ruby/object:Gem::Version
-  version: 2.0.0.pre21
+  version: 2.0.0.pre23
 platform: ruby
 authors:
 - Delano Mandelbaum
@@ -168,12 +168,6 @@ files:
 - bin/irb
 - bin/try
 - bin/tryouts
-- changelog.d/20251105_flexible_external_identifier_format.rst
-- changelog.d/20251107_112554_delano_179_participation_asymmetry.rst
-- changelog.d/20251107_213121_delano_fix_thread_safety_races_011CUumCP492Twxm4NLt2FvL.rst
-- changelog.d/20251107_fix_participates_in_symbol_resolution.rst
-- changelog.d/20251107_optimized_redis_exists_checks.rst
-- changelog.d/20251108_frozen_string_literal_pragma.rst
 - changelog.d/README.md
 - changelog.d/scriv.ini
 - docs/1106-participates_in-bidirectional-solution.md
@@ -224,6 +218,7 @@ files:
 - examples/safe_dump.rb
 - examples/sampling_demo.rb
 - examples/single_connection_transaction_confusions.rb
+- examples/through_relationships.rb
 - familia.gemspec
 - lib/familia.rb
 - lib/familia/base.rb
@@ -281,6 +276,7 @@ files:
 - lib/familia/features/relationships/participation/participant_methods.rb
 - lib/familia/features/relationships/participation/rebuild_strategies.md
 - lib/familia/features/relationships/participation/target_methods.rb
+- lib/familia/features/relationships/participation/through_model_operations.rb
 - lib/familia/features/relationships/participation_membership.rb
 - lib/familia/features/relationships/participation_relationship.rb
 - lib/familia/features/relationships/score_encoding.rb
@@ -328,6 +324,8 @@ files:
 - try/edge_cases/reserved_keywords_try.rb
 - try/edge_cases/string_coercion_try.rb
 - try/edge_cases/ttl_side_effects_try.rb
+- try/features/count_any_edge_cases_try.rb
+- try/features/count_any_methods_try.rb
 - try/features/encrypted_fields/aad_protection_try.rb
 - try/features/encrypted_fields/concealed_string_core_try.rb
 - try/features/encrypted_fields/context_isolation_try.rb
@@ -365,12 +363,14 @@ files:
 - try/features/relationships/indexing_commands_verification_try.rb
 - try/features/relationships/indexing_rebuild_try.rb
 - try/features/relationships/indexing_try.rb
-- try/features/relationships/participation_bidirectional_try.rb
 - try/features/relationships/participation_commands_verification_spec.rb
 - try/features/relationships/participation_commands_verification_try.rb
+- try/features/relationships/participation_method_prefix_try.rb
 - try/features/relationships/participation_performance_improvements_try.rb
 - try/features/relationships/participation_reverse_index_try.rb
+- try/features/relationships/participation_reverse_methods_try.rb
 - try/features/relationships/participation_target_class_resolution_try.rb
+- try/features/relationships/participation_through_try.rb
 - try/features/relationships/participation_unresolved_target_try.rb
 - try/features/relationships/relationships_api_changes_try.rb
 - try/features/relationships/relationships_edge_cases_try.rb
@@ -505,6 +505,7 @@ files:
 - try/unit/data_types/hash_try.rb
 - try/unit/data_types/list_try.rb
 - try/unit/data_types/lock_try.rb
+- try/unit/data_types/serialization_try.rb
 - try/unit/data_types/sorted_set_try.rb
 - try/unit/data_types/sorted_set_zadd_options_try.rb
 - try/unit/data_types/string_try.rb