familia 2.0.0.pre16 → 2.0.0.pre18

data/try/features/feature_dependencies_try.rb

@@ -1,6 +1,6 @@
 # try/features/feature_dependencies_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../support/helpers/test_helpers'
 
 Familia.debug = false
 

data/try/features/feature_improvements_try.rb

@@ -1,6 +1,6 @@
 # try/features/feature_improvements_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../support/helpers/test_helpers'
 
 # Test hierarchical feature registration
 class ::TestClass

data/try/features/field_groups_try.rb

@@ -0,0 +1,244 @@
+# frozen_string_literal: true
+
+# try/features/field_groups_try.rb
+
+require_relative '../../lib/familia'
+
+# Define test classes in setup section
+class BasicUser < Familia::Horreum
+  field_group :personal_info do
+    field :name
+    field :email
+  end
+end
+
+class MultiGroupUser < Familia::Horreum
+  field_group :personal do
+    field :name
+    field :email
+  end
+
+  field_group :metadata do
+    field :created_at
+    field :updated_at
+  end
+end
+
+class EmptyGroupModel < Familia::Horreum
+  field_group :placeholder
+end
+
+class TransientModel < Familia::Horreum
+  feature :transient_fields
+  transient_field :api_key
+  transient_field :session_token
+end
+
+class EncryptedModel < Familia::Horreum
+  feature :encrypted_fields
+  encrypted_field :password
+  encrypted_field :credit_card
+end
+
+class MixedGroupsModel < Familia::Horreum
+  feature :transient_fields
+  transient_field :temp_data
+
+  field_group :custom do
+    field :custom_field
+  end
+
+  feature :encrypted_fields
+  encrypted_field :secret_key
+end
+
+class FieldsOutsideGroups < Familia::Horreum
+  field :standalone_field
+
+  field_group :grouped do
+    field :grouped_field
+  end
+end
+
+class NoSuchGroup < Familia::Horreum
+  field_group :existing do
+    field :name
+  end
+end
+
+class ParentModel < Familia::Horreum
+  field_group :base_fields do
+    field :id
+  end
+end
+
+class ChildModel < ParentModel
+  field_group :child_fields do
+    field :name
+  end
+end
+
+# Create instances for testing
+@user = MultiGroupUser.new(name: 'Alice', email: 'alice@example.com', created_at: Time.now.to_i)
+@user2 = BasicUser.new(name: 'Bob', email: 'bob@example.com')
+
+## Manual field groups - basic access via hash
+BasicUser.instance_variable_get(:@field_groups)[:personal_info]
+#=> [:name, :email]
+
+## Multiple groups - access personal group via hash
+MultiGroupUser.instance_variable_get(:@field_groups)[:personal]
+#=> [:name, :email]
+
+## Multiple groups - access metadata group via hash
+MultiGroupUser.instance_variable_get(:@field_groups)[:metadata]
+#=> [:created_at, :updated_at]
+
+## Multiple groups - list all field groups (returns hash)
+MultiGroupUser.field_groups.keys.sort
+#=> [:metadata, :personal]
+
+## Field groups - fields defined inside groups are tracked
+user = MultiGroupUser.new(name: 'Alice', email: 'alice@example.com', created_at: Time.now.to_i)
+
+## Grouped fields - access name field
+@user.name
+#=> 'Alice'
+
+## Grouped fields - access email field
+@user.email
+#=> 'alice@example.com'
+
+## Empty group - access via hash
+EmptyGroupModel.instance_variable_get(:@field_groups)[:placeholder]
+#=> []
+
+## Empty group - list field groups (returns hash)
+EmptyGroupModel.field_groups
+#=> {placeholder: []}
+
+## Empty group - list field group keys
+EmptyGroupModel.field_groups.keys
+#=> [:placeholder]
+
+## Transient feature - access via backward compatible method
+TransientModel.transient_fields
+#=> [:api_key, :session_token]
+
+## Transient feature - access via field_groups hash
+TransientModel.instance_variable_get(:@field_groups)[:transient_fields]
+#=> [:api_key, :session_token]
+
+## Transient feature - field_groups returns hash with content
+TransientModel.field_groups
+#=> {transient_fields: [:api_key, :session_token]}
+
+## Transient feature - list field group keys
+TransientModel.field_groups.keys
+#=> [:transient_fields]
+
+## Encrypted feature - access via backward compatible method
+EncryptedModel.encrypted_fields
+#=> [:password, :credit_card]
+
+## Encrypted feature - access via field_groups hash
+EncryptedModel.instance_variable_get(:@field_groups)[:encrypted_fields]
+#=> [:password, :credit_card]
+
+## Encrypted feature - field_groups returns hash with content
+EncryptedModel.field_groups
+#=> {encrypted_fields: [:password, :credit_card]}
+
+## Encrypted feature - list field group keys
+EncryptedModel.field_groups.keys
+#=> [:encrypted_fields]
+
+## Mixed groups - list all field group keys
+MixedGroupsModel.field_groups.keys.sort
+#=> [:custom, :encrypted_fields, :transient_fields]
+
+## Mixed groups - access custom group via hash
+MixedGroupsModel.instance_variable_get(:@field_groups)[:custom]
+#=> [:custom_field]
+
+## Mixed groups - access transient_fields via backward compatible method
+MixedGroupsModel.transient_fields
+#=> [:temp_data]
+
+## Mixed groups - access encrypted_fields via backward compatible method
+MixedGroupsModel.encrypted_fields
+#=> [:secret_key]
+
+## Error: nested field groups
+class NestedGroupsModel < Familia::Horreum
+  field_group :outer do
+    field_group :inner do
+      field :bad
+    end
+  end
+end
+#=!> Familia::Problem
+
+## Exception during field_group block resets @current_field_group
+class ErrorDuringGroup < Familia::Horreum
+  begin
+    field_group :broken do
+      field :first_field
+      raise StandardError, "Simulated error"
+      field :unreachable_field
+    end
+  rescue StandardError
+    # Swallow the error for testing
+  end
+
+  # Field defined after the error should not be in :broken group
+  field :after_error
+end
+
+ErrorDuringGroup
+#=> ErrorDuringGroup
+
+## Exception handling - broken group has only first_field
+ErrorDuringGroup.instance_variable_get(:@field_groups)[:broken]
+#=> [:first_field]
+
+## Exception handling - after_error field is not in broken group
+ErrorDuringGroup.instance_variable_get(:@field_groups)[:broken].include?(:after_error)
+#=> false
+
+## Exception handling - after_error is in fields list
+ErrorDuringGroup.fields.include?(:after_error)
+#=> true
+
+## Exception handling - current_field_group was reset to nil
+ErrorDuringGroup.instance_variable_get(:@current_field_group)
+#=> nil
+
+
+## Fields outside - access grouped field group via hash
+FieldsOutsideGroups.instance_variable_get(:@field_groups)[:grouped]
+#=> [:grouped_field]
+
+## Fields outside - all fields include both grouped and standalone
+FieldsOutsideGroups.fields
+#=> [:standalone_field, :grouped_field]
+
+## Accessing non-existent field group returns nil
+NoSuchGroup.instance_variable_get(:@field_groups)[:nonexistent]
+#=> nil
+
+## Inheritance - parent class has its own field groups
+ParentModel.field_groups
+#=> {base_fields: [:id]}
+
+## Inheritance - child class has its own field groups
+ChildModel.field_groups
+#=> {child_fields: [:name]}
+
+## Normal field access - get name value
+@user2.name
+#=> 'Bob'
+
+## Normal field access - get email value
+@user2.email
+#=> 'bob@example.com'

data/try/features/object_identifier/object_identifier_integration_try.rb

@@ -1,6 +1,6 @@
 # try/features/object_identifier/object_identifier_integration_try.rb
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 

data/try/features/object_identifier/object_identifier_try.rb

@@ -1,6 +1,6 @@
 # try/features/object_identifier/object_identifier_try.rb
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 

data/try/features/quantization/quantization_try.rb

@@ -1,6 +1,6 @@
 # try/features/quantization_try.rb
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 

data/try/features/real_feature_integration_try.rb

@@ -1,6 +1,6 @@
 # try/features/real_feature_integration_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../support/helpers/test_helpers'
 
 Familia.debug = false
 
@@ -12,15 +12,17 @@ class ExpirationIntegrationTest < Familia::Horreum
   feature :expiration
 end
 
-# Safe dump feature integration with field categories
+# Safe dump feature integration with field types
 class SafeDumpCategoryTest < Familia::Horreum
+  feature :encrypted_fields
+  feature :transient_fields
+  feature :safe_dump
+
   identifier_field :id
   field :id
-  field :public_name, category: :persistent
-  field :email, category: :encrypted
-  field :tryouts_cache_data, category: :transient
-
-  feature :safe_dump
+  field :public_name
+  encrypted_field :email
+  transient_field :tryouts_cache_data
 
   # Use new SafeDump DSL
   safe_dump_field :id
@@ -30,14 +32,15 @@ end
 
 # Combined features work together
 class CombinedFeaturesTest < Familia::Horreum
-  identifier_field :id
-  field :id
-  field :name, category: :persistent
-  field :temp_data, category: :transient
-
+  feature :transient_fields
   feature :expiration
   feature :safe_dump
 
+  identifier_field :id
+  field :id
+  field :name
+  transient_field :temp_data
+
   # Use new SafeDump DSL
   safe_dump_field :id
   safe_dump_field :name
@@ -123,11 +126,11 @@ CombinedFeaturesTest.features_enabled.include?(:safe_dump)
 
 ## Test that feature() method returns current features when called with no args
 CombinedFeaturesTest.feature
-#=> [:expiration, :safe_dump]
+#=> [:transient_fields, :expiration, :safe_dump]
 
 ## Test that features_enabled() method returns the same results as feature() method
 CombinedFeaturesTest.feature
-#=> [:expiration, :safe_dump]
+#=> [:transient_fields, :expiration, :safe_dump]
 
 ## Features list is accessible
 QueryFeaturesTest.feature

data/try/features/relationships/indexing_commands_verification_try.rb

@@ -4,7 +4,7 @@
 # This test ensures the indexing system uses proper DataType methods instead of direct Redis calls
 #
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 # Enable database command logging for command verification tests
 Familia.enable_database_logging = true
@@ -44,8 +44,11 @@ end
 
 # Test data
 @user = TestIndexedUser.new(user_id: 'test_user_123', email: 'test@example.com', department: 'engineering')
+@user.save
 @company = TestIndexedCompany.new(company_id: 'test_company_456', name: 'Test Corp')
+@company.save
 @employee = TestIndexedEmployee.new(emp_id: 'test_emp_789', email: 'emp@example.com', department: 'sales')
+@employee.save
 
 ## Class-level indexing creates proper DataType field
 TestIndexedUser.respond_to?(:email_index)
@@ -91,6 +94,7 @@ end
 #=> false
 
 ## Instance-level indexing works with parent context
+@employee.save
 @employee.add_to_test_indexed_company_dept_index(@company)
 sample = @company.sample_from_department('sales')
 sample.first&.emp_id == @employee.emp_id
@@ -103,15 +107,16 @@ dept_index.class.name
 
 ## Multiple employees in same department
 @employee2 = TestIndexedEmployee.new(emp_id: 'test_emp_999', email: 'emp2@example.com', department: 'sales')
+@employee2.save
 @employee2.add_to_test_indexed_company_dept_index(@company)
 employees_in_sales = @company.find_all_by_department('sales')
-employees_in_sales.map(&:emp_id).sort
+employees_in_sales&.map(&:emp_id).sort
 #=> ["test_emp_789", "test_emp_999"]
 
 ## Removing from instance-level index works
 @employee.remove_from_test_indexed_company_dept_index(@company)
 remaining_employees = @company.find_all_by_department('sales')
-remaining_employees.map(&:emp_id)
+remaining_employees&.map(&:emp_id)
 #=> ["test_emp_999"]
 
 ## Index update methods work correctly

data/try/features/relationships/indexing_try.rb

@@ -4,7 +4,7 @@
 # Tests both multi_index (parent-context) and unique_index (class-level) indexing
 #
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 # Test classes for indexing functionality
 class ::TestUser < Familia::Horreum
@@ -55,13 +55,18 @@ end
 
 # Setup
 @user1 = TestUser.new(user_id: 'user_001', email: 'alice@example.com', username: 'alice', department: 'engineering', role: 'developer')
+@user1.save
 @user2 = TestUser.new(user_id: 'user_002', email: 'bob@example.com', username: 'bob', department: 'marketing', role: 'manager')
+@user2.save
 @user3 = TestUser.new(user_id: 'user_003', email: 'charlie@example.com', username: 'charlie', department: 'engineering', role: 'lead')
+@user3.save
 
 @company_id = "comp_#{rand(10000000)}"
 @company = TestCompany.create(company_id: @company_id, name: 'Acme Corp')
 @emp1 = TestEmployee.new(emp_id: 'emp_001', email: 'alice@acme.com', department: 'engineering', manager_id: 'mgr_001', badge_number: 'BADGE001')
+@emp1.save
 @emp2 = TestEmployee.new(emp_id: 'emp_002', email: 'bob@acme.com', department: 'sales', manager_id: 'mgr_002', badge_number: 'BADGE002')
+@emp2.save
 
 
 ## Context-scoped methods require context parameter
@@ -152,6 +157,11 @@ found_users.map(&:user_id).sort
 TestUser.find_all_by_email([]).length
 #=> 0
 
+## Single value (non-array) is accepted by find_all_by method
+found_users = TestUser.find_all_by_email('bob@example.com')
+found_users.map(&:user_id)
+#=> ["user_002"]
+
 ## Update index entry with old value removal
 old_email = @user1.email
 @user1.email = 'alice.new@example.com'
@@ -236,6 +246,11 @@ found_emps = @company.find_all_by_badge_number(badges)
 found_emps.map(&:emp_id).sort
 #=> ["emp_001", "emp_002"]
 
+## Single value (non-array) accepted for instance-scoped find_all_by
+found_emps = @company.find_all_by_badge_number('BADGE002')
+found_emps.map(&:emp_id)
+#=> ["emp_002"]
+
 ## Update badge index entry
 old_badge = @emp1.badge_number
 @emp1.badge_number = 'BADGE001_NEW'

data/try/features/relationships/participation_commands_verification_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe 'participation_commands_verification_try' do
     Timecop.freeze(Time.parse("2024-01-15 10:30:00"))
     puts Time.now  # Always returns 2024-01-15 10:30:00
     puts Date.today  # Always returns 2024-01-15
-    require_relative '../../../lib/middleware/database_middleware'
+    require_relative '../../../lib/middleware/database_logger'
     require_relative '../../../lib/familia'
     Familia.enable_database_logging = true
     Familia.enable_database_counter = true

data/try/features/relationships/participation_commands_verification_try.rb

@@ -17,7 +17,7 @@ puts Date.today  # Always returns 2024-01-15
 
 
 # Load middleware first
-require_relative '../../../lib/middleware/database_middleware'
+require_relative '../../../lib/middleware/database_logger'
 
 # Load Familia
 require_relative '../../../lib/familia'
@@ -83,7 +83,7 @@ instantiation_commands.empty?
 database_commands = DatabaseLogger.capture_commands do
   @customer.save
 end
-database_commands.map { |cmd| cmd[:command] } if database_commands
+database_commands.map { |cmd| cmd.command } if database_commands
 ##=> [["hmset", "reverse_index_customer:ri_cust_123:object", "customer_id", "ri_cust_123", "name", "Reverse Index Test Customer"], ["zadd", "reverse_index_customer:instances", "1705343400.0", "ri_cust_123"]]
 
 
@@ -91,14 +91,14 @@ database_commands.map { |cmd| cmd[:command] } if database_commands
 database_commands = DatabaseLogger.capture_commands do
   @domain1.save
 end
-database_commands[0][:command] if database_commands && database_commands[0]
+database_commands[0].command if database_commands && database_commands[0]
 ##=>  ["hmset", "reverse_index_domain:ri_dom_1:object", "domain_id", "ri_dom_1", "display_domain", "example1.com", "created_at", "1705343400.0"]
 
 ## Domain2 save functionality
 database_commands = DatabaseLogger.capture_commands do
   @domain2.save
 end
-database_commands[0][:command]if database_commands && database_commands[0]
+database_commands[0].command if database_commands && database_commands[0]
 ##=> ["hmset", "reverse_index_domain:ri_dom_2:object", "domain_id", "ri_dom_2", "display_domain", "example2.com", "created_at", "1705343401.0"]
 
 

data/try/features/relationships/participation_performance_improvements_try.rb

@@ -3,7 +3,7 @@
 # Tests for performance improvements in participation functionality
 # Verifies reverse index functionality and robust type comparison
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 # Test classes for performance improvements
 class PerfTestCustomer < Familia::Horreum

data/try/features/relationships/participation_reverse_index_try.rb

@@ -3,7 +3,7 @@
 # Tests for participation reverse index functionality
 # Verifies performance improvements and correct behavior
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 # Test classes for reverse index functionality
 class ReverseIndexCustomer < Familia::Horreum

data/try/features/relationships/relationships_api_changes_try.rb

@@ -4,7 +4,7 @@
 # Testing new class_participates_in and unique_index methods
 # Testing breaking changes and argument validation
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 # Test classes for new API
 class ::ApiTestUser < Familia::Horreum

data/try/features/relationships/relationships_edge_cases_try.rb

@@ -1,6 +1,6 @@
 # Simplified edge case testing for Relationships v2 - focusing on core functionality
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 # Test classes for edge case testing
 class EdgeTestCustomer < Familia::Horreum
@@ -41,14 +41,14 @@ end
 @domain1 = EdgeTestDomain.new(
   domain_id: 'edge_dom_1',
   display_domain: 'edge1.example.com',
-  created_at: Time.new(2025, 6, 15, 12, 0, 0),
+  created_at: Time.new(2025, 6, 15, 12, 0, 0).to_i,  # Convert Time to Integer for JSON serialization
   score_value: 10
 )
 
 @domain2 = EdgeTestDomain.new(
   domain_id: 'edge_dom_2',
   display_domain: 'edge2.example.com',
-  created_at: Time.new(2025, 7, 20, 15, 30, 0),
+  created_at: Time.new(2025, 7, 20, 15, 30, 0).to_i,  # Convert Time to Integer for JSON serialization
   score_value: 25
 )
 

data/try/features/relationships/relationships_performance_minimal_try.rb

@@ -1,6 +1,6 @@
 # Minimal performance testing focusing on core Familia functionality
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 require 'benchmark'
 
 # Simple test classes without relationships feature

data/try/features/relationships/relationships_performance_simple_try.rb

@@ -2,7 +2,7 @@
 #
 # Simplified performance testing for the Relationships feature
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 require 'benchmark'
 
 # Test classes for performance testing

data/try/features/relationships/relationships_performance_try.rb

@@ -2,7 +2,7 @@
 #
 # Performance and integration testing for the Relationships feature
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 require 'benchmark'
 
 # Test classes for performance testing

data/try/features/relationships/relationships_performance_working_try.rb

@@ -2,7 +2,7 @@
 #
 # Working performance test focusing on basic functionality
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 require 'benchmark'
 
 # Simple test class using only basic Familia features

data/try/features/relationships/relationships_try.rb

@@ -3,7 +3,7 @@
 # Simplified Familia v2 relationship functionality tests - focusing on core working features
 #
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 # Test classes for Familia v2 relationship functionality
 class TestCustomer < Familia::Horreum

data/try/features/safe_dump/safe_dump_advanced_try.rb

@@ -2,7 +2,7 @@
 
 # These tryouts test the safe dumping functionality.
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 ## By default Familia::Base has no safe_dump_fields method
 Familia::Base.respond_to?(:safe_dump_fields)

data/try/features/safe_dump/safe_dump_try.rb

@@ -1,6 +1,6 @@
 # try/features/safe_dump_try.rb
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 

data/try/features/transient_fields/redacted_string_try.rb

@@ -1,6 +1,6 @@
 # try/features/transient_fields/redacted_string_try.rb
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 
 # Create sample sensitive values for testing

data/try/features/transient_fields/refresh_reset_try.rb

@@ -1,13 +1,15 @@
 # try/features/transient_fields/refresh_reset_try.rb
 # Test that refresh! properly resets transient fields to nil
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 
 Familia.dbclient.flushdb
 
 class SecretService < Familia::Horreum
+  feature :transient_fields
+
   identifier_field :name
 
   field :name

data/try/features/transient_fields/single_use_redacted_string_try.rb

@@ -1,6 +1,6 @@
 # try/features/transient_fields/single_use_redacted_string_try.rb
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 @otp_code = "123456"
 @auth_token = "temp-auth-token-xyz"

data/try/features/transient_fields/transient_fields_core_try.rb

@@ -1,6 +1,6 @@
 # try/features/transient_fields_core_try.rb
 
-require_relative '../../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 class SecretService < Familia::Horreum
   feature :transient_fields