familia 2.0.0.pre16 → 2.0.0.pre17

data/try/features/field_groups_try.rb

@@ -0,0 +1,244 @@
+# frozen_string_literal: true
+
+# try/features/field_groups_try.rb
+
+require_relative '../../lib/familia'
+
+# Define test classes in setup section
+class BasicUser < Familia::Horreum
+  field_group :personal_info do
+    field :name
+    field :email
+  end
+end
+
+class MultiGroupUser < Familia::Horreum
+  field_group :personal do
+    field :name
+    field :email
+  end
+
+  field_group :metadata do
+    field :created_at
+    field :updated_at
+  end
+end
+
+class EmptyGroupModel < Familia::Horreum
+  field_group :placeholder
+end
+
+class TransientModel < Familia::Horreum
+  feature :transient_fields
+  transient_field :api_key
+  transient_field :session_token
+end
+
+class EncryptedModel < Familia::Horreum
+  feature :encrypted_fields
+  encrypted_field :password
+  encrypted_field :credit_card
+end
+
+class MixedGroupsModel < Familia::Horreum
+  feature :transient_fields
+  transient_field :temp_data
+
+  field_group :custom do
+    field :custom_field
+  end
+
+  feature :encrypted_fields
+  encrypted_field :secret_key
+end
+
+class FieldsOutsideGroups < Familia::Horreum
+  field :standalone_field
+
+  field_group :grouped do
+    field :grouped_field
+  end
+end
+
+class NoSuchGroup < Familia::Horreum
+  field_group :existing do
+    field :name
+  end
+end
+
+class ParentModel < Familia::Horreum
+  field_group :base_fields do
+    field :id
+  end
+end
+
+class ChildModel < ParentModel
+  field_group :child_fields do
+    field :name
+  end
+end
+
+# Create instances for testing
+@user = MultiGroupUser.new(name: 'Alice', email: 'alice@example.com', created_at: Time.now.to_i)
+@user2 = BasicUser.new(name: 'Bob', email: 'bob@example.com')
+
+## Manual field groups - basic access via hash
+BasicUser.instance_variable_get(:@field_groups)[:personal_info]
+#=> [:name, :email]
+
+## Multiple groups - access personal group via hash
+MultiGroupUser.instance_variable_get(:@field_groups)[:personal]
+#=> [:name, :email]
+
+## Multiple groups - access metadata group via hash
+MultiGroupUser.instance_variable_get(:@field_groups)[:metadata]
+#=> [:created_at, :updated_at]
+
+## Multiple groups - list all field groups (returns hash)
+MultiGroupUser.field_groups.keys.sort
+#=> [:metadata, :personal]
+
+## Field groups - fields defined inside groups are tracked
+user = MultiGroupUser.new(name: 'Alice', email: 'alice@example.com', created_at: Time.now.to_i)
+
+## Grouped fields - access name field
+@user.name
+#=> 'Alice'
+
+## Grouped fields - access email field
+@user.email
+#=> 'alice@example.com'
+
+## Empty group - access via hash
+EmptyGroupModel.instance_variable_get(:@field_groups)[:placeholder]
+#=> []
+
+## Empty group - list field groups (returns hash)
+EmptyGroupModel.field_groups
+#=> {placeholder: []}
+
+## Empty group - list field group keys
+EmptyGroupModel.field_groups.keys
+#=> [:placeholder]
+
+## Transient feature - access via backward compatible method
+TransientModel.transient_fields
+#=> [:api_key, :session_token]
+
+## Transient feature - access via field_groups hash
+TransientModel.instance_variable_get(:@field_groups)[:transient_fields]
+#=> [:api_key, :session_token]
+
+## Transient feature - field_groups returns hash with content
+TransientModel.field_groups
+#=> {transient_fields: [:api_key, :session_token]}
+
+## Transient feature - list field group keys
+TransientModel.field_groups.keys
+#=> [:transient_fields]
+
+## Encrypted feature - access via backward compatible method
+EncryptedModel.encrypted_fields
+#=> [:password, :credit_card]
+
+## Encrypted feature - access via field_groups hash
+EncryptedModel.instance_variable_get(:@field_groups)[:encrypted_fields]
+#=> [:password, :credit_card]
+
+## Encrypted feature - field_groups returns hash with content
+EncryptedModel.field_groups
+#=> {encrypted_fields: [:password, :credit_card]}
+
+## Encrypted feature - list field group keys
+EncryptedModel.field_groups.keys
+#=> [:encrypted_fields]
+
+## Mixed groups - list all field group keys
+MixedGroupsModel.field_groups.keys.sort
+#=> [:custom, :encrypted_fields, :transient_fields]
+
+## Mixed groups - access custom group via hash
+MixedGroupsModel.instance_variable_get(:@field_groups)[:custom]
+#=> [:custom_field]
+
+## Mixed groups - access transient_fields via backward compatible method
+MixedGroupsModel.transient_fields
+#=> [:temp_data]
+
+## Mixed groups - access encrypted_fields via backward compatible method
+MixedGroupsModel.encrypted_fields
+#=> [:secret_key]
+
+## Error: nested field groups
+class NestedGroupsModel < Familia::Horreum
+  field_group :outer do
+    field_group :inner do
+      field :bad
+    end
+  end
+end
+#=!> Familia::Problem
+
+## Exception during field_group block resets @current_field_group
+class ErrorDuringGroup < Familia::Horreum
+  begin
+    field_group :broken do
+      field :first_field
+      raise StandardError, "Simulated error"
+      field :unreachable_field
+    end
+  rescue StandardError
+    # Swallow the error for testing
+  end
+
+  # Field defined after the error should not be in :broken group
+  field :after_error
+end
+
+ErrorDuringGroup
+#=> ErrorDuringGroup
+
+## Exception handling - broken group has only first_field
+ErrorDuringGroup.instance_variable_get(:@field_groups)[:broken]
+#=> [:first_field]
+
+## Exception handling - after_error field is not in broken group
+ErrorDuringGroup.instance_variable_get(:@field_groups)[:broken].include?(:after_error)
+#=> false
+
+## Exception handling - after_error is in fields list
+ErrorDuringGroup.fields.include?(:after_error)
+#=> true
+
+## Exception handling - current_field_group was reset to nil
+ErrorDuringGroup.instance_variable_get(:@current_field_group)
+#=> nil
+
+
+## Fields outside - access grouped field group via hash
+FieldsOutsideGroups.instance_variable_get(:@field_groups)[:grouped]
+#=> [:grouped_field]
+
+## Fields outside - all fields include both grouped and standalone
+FieldsOutsideGroups.fields
+#=> [:standalone_field, :grouped_field]
+
+## Accessing non-existent field group returns nil
+NoSuchGroup.instance_variable_get(:@field_groups)[:nonexistent]
+#=> nil
+
+## Inheritance - parent class has its own field groups
+ParentModel.field_groups
+#=> {base_fields: [:id]}
+
+## Inheritance - child class has its own field groups
+ChildModel.field_groups
+#=> {child_fields: [:name]}
+
+## Normal field access - get name value
+@user2.name
+#=> 'Bob'
+
+## Normal field access - get email value
+@user2.email
+#=> 'bob@example.com'

data/try/features/relationships/indexing_try.rb

@@ -152,6 +152,11 @@ found_users.map(&:user_id).sort
 TestUser.find_all_by_email([]).length
 #=> 0
 
+## Single value (non-array) is accepted by find_all_by method
+found_users = TestUser.find_all_by_email('bob@example.com')
+found_users.map(&:user_id)
+#=> ["user_002"]
+
 ## Update index entry with old value removal
 old_email = @user1.email
 @user1.email = 'alice.new@example.com'
@@ -236,6 +241,11 @@ found_emps = @company.find_all_by_badge_number(badges)
 found_emps.map(&:emp_id).sort
 #=> ["emp_001", "emp_002"]
 
+## Single value (non-array) accepted for instance-scoped find_all_by
+found_emps = @company.find_all_by_badge_number('BADGE002')
+found_emps.map(&:emp_id)
+#=> ["emp_002"]
+
 ## Update badge index entry
 old_badge = @emp1.badge_number
 @emp1.badge_number = 'BADGE001_NEW'

data/try/features/transient_fields/refresh_reset_try.rb

@@ -8,6 +8,8 @@ Familia.debug = false
 Familia.dbclient.flushdb
 
 class SecretService < Familia::Horreum
+  feature :transient_fields
+
   identifier_field :name
 
   field :name

data/try/helpers/test_helpers.rb

@@ -10,6 +10,7 @@ require_relative '../../lib/familia'
 
 Familia.enable_database_logging = true
 Familia.enable_database_counter = true
+Familia.uri = 'redis://127.0.0.1:2525'
 
 class Bone < Familia::Horreum
   using Familia::Refinements::TimeLiterals
@@ -44,12 +45,10 @@ class Customer < Familia::Horreum
 
   using Familia::Refinements::TimeLiterals
 
-  logical_database 15 # Use something other than the default DB
+  logical_database 3 # Use something other than the default DB
   default_expiration 5.years
 
   feature :safe_dump
-  # feature :expiration
-  # feature :api_version
 
   # Use new SafeDump DSL instead of @safe_dump_fields
   safe_dump_field :custid
@@ -108,7 +107,7 @@ end
 class Session < Familia::Horreum
   using Familia::Refinements::TimeLiterals
 
-  logical_database 14 # don't use Onetime's default DB
+  logical_database 2 # a non-default database
   default_expiration 180.minutes
 
   identifier_field :sessid

data/try/horreum/auto_indexing_on_save_try.rb

@@ -0,0 +1,212 @@
+# try/horreum/auto_indexing_on_save_try.rb
+
+#
+# Auto-indexing on save functionality tests
+# Tests automatic index population when Familia::Horreum objects are saved
+#
+
+require_relative '../helpers/test_helpers'
+
+# Test classes for auto-indexing functionality
+class ::AutoIndexUser < Familia::Horreum
+  feature :relationships
+
+  identifier_field :user_id
+  field :user_id
+  field :email
+  field :username
+  field :department
+
+  # Class-level unique indexes (should auto-populate on save)
+  unique_index :email, :email_index
+  unique_index :username, :username_index
+end
+
+class ::AutoIndexCompany < Familia::Horreum
+  feature :relationships
+
+  identifier_field :company_id
+  field :company_id
+  field :name
+end
+
+class ::AutoIndexEmployee < Familia::Horreum
+  feature :relationships
+
+  identifier_field :emp_id
+  field :emp_id
+  field :badge_number
+  field :department
+
+  # Instance-scoped indexes (should NOT auto-populate - require parent context)
+  unique_index :badge_number, :badge_index, within: AutoIndexCompany
+  multi_index :department, :dept_index, within: AutoIndexCompany
+end
+
+# Setup
+@user_id = "user_#{rand(1000000)}"
+@user = AutoIndexUser.new(user_id: @user_id, email: 'test@example.com', username: 'testuser', department: 'engineering')
+
+@company_id = "comp_#{rand(1000000)}"
+@company = AutoIndexCompany.new(company_id: @company_id, name: 'Test Corp')
+
+@emp_id = "emp_#{rand(1000000)}"
+@employee = AutoIndexEmployee.new(emp_id: @emp_id, badge_number: 'BADGE123', department: 'sales')
+
+# =============================================
+# 1. Class-Level Unique Index Auto-Population
+# =============================================
+
+## Unique index is empty before save
+AutoIndexUser.email_index.has_key?('test@example.com')
+#=> false
+
+## Save automatically populates unique index
+@user.save
+AutoIndexUser.email_index.has_key?('test@example.com')
+#=> true
+
+## Auto-populated index maps to correct identifier
+AutoIndexUser.email_index.get('test@example.com')
+#=> @user_id
+
+## Finder method works after auto-indexing
+found = AutoIndexUser.find_by_email('test@example.com')
+found&.user_id
+#=> @user_id
+
+## Multiple unique indexes auto-populate on same save
+AutoIndexUser.username_index.get('testuser')
+#=> @user_id
+
+## Subsequent saves maintain index (idempotent)
+@user.save
+AutoIndexUser.email_index.get('test@example.com')
+#=> @user_id
+
+## Changing indexed field and saving adds new entry (old entry remains unless manually removed)
+# Note: Auto-indexing is idempotent addition only - updates require manual update_in_class_* calls
+@user.email = 'newemail@example.com'
+@user.save
+# New email is indexed, but old email remains (expected behavior - use update_in_class_* for proper updates)
+[AutoIndexUser.email_index.has_key?('test@example.com'), AutoIndexUser.email_index.get('newemail@example.com') == @user_id]
+#=> [true, true]
+
+# =============================================
+# 2. Instance-Scoped Indexes (Manual Only)
+# =============================================
+
+## Instance-scoped indexes do NOT auto-populate on save
+@employee.save
+@company.badge_index.has_key?('BADGE123')
+#=> false
+
+## Instance-scoped indexes remain manual (require parent context)
+@employee.add_to_auto_index_company_badge_index(@company)
+@company.badge_index.has_key?('BADGE123')
+#=> true
+
+# =============================================
+# 3. Edge Cases and Error Handling
+# =============================================
+
+## Nil field values handled gracefully
+@user_nil_id = "user_nil_#{rand(1000000)}"
+@user_nil = AutoIndexUser.new(user_id: @user_nil_id, email: nil, username: nil, department: nil)
+@user_nil.save
+AutoIndexUser.email_index.has_key?('')
+#=> false
+
+## Empty string field values handled gracefully
+@user_empty_id = "user_empty_#{rand(1000000)}"
+@user_empty = AutoIndexUser.new(user_id: @user_empty_id, email: '', username: '', department: '')
+@user_empty.save
+# Empty strings are indexed (they're valid string values, just empty)
+AutoIndexUser.email_index.has_key?('')
+#=> true
+
+## Auto-indexing works with create method
+@user2_id = "user_#{rand(1000000)}"
+@user2 = AutoIndexUser.create(user_id: @user2_id, email: 'create@example.com', username: 'createuser', department: 'marketing')
+AutoIndexUser.find_by_email('create@example.com')&.user_id
+#=> @user2_id
+
+## Auto-indexing idempotent with multiple saves
+@user2.save
+@user2.save
+@user2.save
+AutoIndexUser.email_index.get('create@example.com')
+#=> @user2_id
+
+## Field update followed by save adds new entry (use update_in_class_* for proper updates)
+old_email = @user2.email
+@user2.email = 'updated@example.com'
+@user2.save
+# Both old and new emails are indexed (auto-indexing doesn't remove old values)
+# For proper updates that remove old values, use: @user2.update_in_class_email_index(old_email)
+[AutoIndexUser.email_index.has_key?(old_email), AutoIndexUser.email_index.get('updated@example.com') == @user2_id]
+#=> [true, true]
+
+# =============================================
+# 4. Integration with Other Features
+# =============================================
+
+## Auto-indexing works with transient fields
+class ::AutoIndexWithTransient < Familia::Horreum
+  feature :transient_fields
+  feature :relationships
+
+  identifier_field :id
+  field :id
+  field :email
+  transient_field :temp_value
+
+  unique_index :email, :email_index
+end
+
+@transient_id = "trans_#{rand(1000000)}"
+@transient_obj = AutoIndexWithTransient.new(id: @transient_id, email: 'transient@example.com', temp_value: 'ignored')
+@transient_obj.save
+AutoIndexWithTransient.find_by_email('transient@example.com')&.id
+#=> @transient_id
+
+## Auto-indexing works regardless of other features
+# Just verify that the feature system doesn't interfere
+@transient_obj.class.respond_to?(:indexing_relationships)
+#=> true
+
+# =============================================
+# 5. Performance and Behavior Verification
+# =============================================
+
+## Auto-indexing has negligible overhead (no existence checks)
+# This test verifies the design: we use idempotent commands (HSET, SADD)
+# rather than checking if the index exists before updating
+@user4_id = "user_#{rand(1000000)}"
+@user4 = AutoIndexUser.new(user_id: @user4_id, email: 'perf@example.com', username: 'perfuser', department: 'ops')
+
+# Save multiple times - all should succeed with same result
+@user4.save
+@user4.save
+@user4.save
+
+AutoIndexUser.email_index.get('perf@example.com')
+#=> @user4_id
+
+## Auto-indexing only processes class-level indexes
+# Verify no errors when instance-scoped indexes present
+@employee2_id = "emp_#{rand(1000000)}"
+@employee2 = AutoIndexEmployee.new(emp_id: @employee2_id, badge_number: 'BADGE456', department: 'engineering')
+@employee2.save  # Should not error, just skip instance-scoped indexes
+@employee2.emp_id
+#=> @employee2_id
+
+# Teardown - clean up test objects
+[@user, @user2, @user4, @user_nil, @user_empty, @company, @employee, @employee2, @transient_obj].each do |obj|
+  obj.destroy! if obj.respond_to?(:destroy!) && obj.respond_to?(:exists?) && obj.exists?
+end
+
+# Clean up class-level indexes
+[AutoIndexUser.email_index, AutoIndexUser.username_index].each do |index|
+  index.delete! if index.respond_to?(:delete!) && index.respond_to?(:exists?) && index.exists?
+end

data/try/horreum/commands_try.rb

@@ -1,3 +1,5 @@
+# try/horreum/commands_try.rb
+
 # Test Horreum Valkey/Redis commands
 
 require_relative '../helpers/test_helpers'

data/try/horreum/defensive_initialization_try.rb

@@ -0,0 +1,86 @@
+# try/horreum/defensive_initialization_try.rb
+
+require_relative '../helpers/test_helpers'
+
+# Test defensive initialization behavior
+class User < Familia::Horreum
+  field :email
+  list :sessions
+  zset :metrics
+
+  def initialize(email = nil)
+    # This is the common mistake - overriding initialize without calling super
+    @email = email
+    # Missing: super() or initialize_relatives
+  end
+end
+
+class SafeUser < Familia::Horreum
+  field :email
+  list :sessions
+  zset :metrics
+
+  def init
+    # This is the correct way - using the init hook
+    # Fields are already set by initialize, no need to override
+  end
+end
+
+# Setup instances for testing
+@user = User.new("test@example.com")
+@safe_user = SafeUser.new
+@safe_user.email = "safe@example.com"
+
+## Test that accessing relationships after bad initialize triggers lazy initialization
+@user.email
+#=> "test@example.com"
+
+## Test that sessions works with lazy initialization
+@user.sessions.class
+#=> Familia::ListKey
+
+## Test that metrics also works with lazy initialization
+@user.metrics.class
+#=> Familia::SortedSet
+
+## Test that safe user works normally
+@safe_user.email
+#=> "safe@example.com"
+
+## Test that safe user sessions work
+@safe_user.sessions.class
+#=> Familia::ListKey
+
+## Test that relatives_initialized flag prevents double initialization
+@user.singleton_class.instance_variable_get(:@relatives_initialized)
+#=> true
+
+## Test that manual initialize_relatives call is no-op
+@user.initialize_relatives
+@user.sessions.class
+#=> Familia::ListKey
+
+## Test that the original problem is now fixed - bad override still works
+class BadUser < Familia::Horreum
+  field :email
+  list :sessions
+
+  def initialize(email)
+    # Bad: overriding initialize without calling super
+    @email = email
+    # Missing: super() or initialize_relatives
+  end
+end
+
+@bad_user = BadUser.new("bad@example.com")
+@bad_user.email
+#=> "bad@example.com"
+
+## Test that relationships work despite bad initialize (lazy initialization kicks in)
+@bad_user.sessions.class
+#=> Familia::ListKey
+
+## Test that the bad user can actually use the relationships
+@bad_user.sessions.add("session_123")
+@bad_user.sessions.size > 0
+#=> true

data/try/horreum/destroy_related_fields_cleanup_try.rb

@@ -1,3 +1,5 @@
+# try/horreum/destroy_related_fields_cleanup_try.rb
+
 # Horreum destroy! Related Fields Cleanup Tryouts
 #
 # Tests that when a Horreum instance is destroyed, all its related fields

data/try/horreum/settings_try.rb

@@ -1,3 +1,5 @@
+# try/horreum/settings_try.rb
+
 # Test Horreum settings
 
 require_relative '../helpers/test_helpers'

data/try/memory/memory_docker_ruby_dump.sh

@@ -59,7 +59,7 @@ docker exec $CONTAINER_ID bash -c '
 #   $
 #   $ docker run --rm -d -p 3000:3000 \
 #     -e SECRET=$SECRET \
-#     -e REDIS_URL=redis://host.docker.internal:6379/0 \
+#     -e REDIS_URL=redis://host.docker.internal:2525/0 \
 #     ghcr.io/onetimesecret/devtimesecret-lite:latest
 #
 #     abcd1234

data/try/models/customer_try.rb

@@ -103,15 +103,15 @@ exists = Customer.exists?('test@example.com')
 
 ## Customer.logical_database returns the correct database number
 Customer.logical_database
-#=> 15
+#=> 3
 
 ## Customer.logical_database returns the correct database number
 @customer.logical_database
-#=> 15
+#=> 3
 
 ## @customer.dbclient.connection returns the correct database URI
 @customer.dbclient.connection
-#=> {:host=>"127.0.0.1", :port=>6379, :db=>15, :id=>"redis://127.0.0.1:6379/15", :location=>"127.0.0.1:6379"}
+#=> {:host=>"127.0.0.1", :port=>2525, :db=>3, :id=>"redis://127.0.0.1:2525/3", :location=>"127.0.0.1:2525"}
 
 ## @customer.dbclient.uri returns the correct database URI
 @customer.secrets_created.logical_database
@@ -119,7 +119,7 @@ Customer.logical_database
 
 ## @customer.dbclient.uri returns the correct database URI
 @customer.secrets_created.dbclient.connection
-#=> {:host=>"127.0.0.1", :port=>6379, :db=>15, :id=>"redis://127.0.0.1:6379/15", :location=>"127.0.0.1:6379"}
+#=> {:host=>"127.0.0.1", :port=>2525, :db=>3, :id=>"redis://127.0.0.1:2525/3", :location=>"127.0.0.1:2525"}
 
 ## Customer.url is nil by default
 Customer.uri
@@ -131,7 +131,7 @@ Customer.instances.logical_database
 
 ## Customer.logical_database returns the correct database number
 Customer.instances.uri.to_s
-#=> 'redis://127.0.0.1/15'
+#=> 'redis://127.0.0.1/3'
 
 # Teardown
 Customer.instances.delete!

data/try/valkey.conf

@@ -0,0 +1,26 @@
+# try/test-valkey.conf
+
+# Familia - Tryouts Valkey Config
+# 2025-10-01
+#
+# Usage:
+#
+#   $ valkey-server try/valkey.conf
+#
+
+dir ./data
+
+enable-debug-command yes
+
+#requirepass CHANGEME
+
+bind 127.0.0.1
+port 2525
+databases 10
+
+timeout 4
+daemonize no
+loglevel notice
+
+# Disable RDB persistence for tests DB
+save ""