familia 2.0.0.pre15 → 2.0.0.pre17

data/try/features/relationships/relationships_try.rb

@@ -25,14 +25,11 @@ class TestDomain < Familia::Horreum
   field :created_at
   field :permission_level
 
-  # Basic tracking with simplified score
-  tracked_in TestCustomer, :domains, score: :created_at
-  class_tracked_in :all_domains, score: :created_at
+  # Basic participation with simplified score
+  participates_in TestCustomer, :domains, score: :created_at
+  class_participates_in :all_domains, score: :created_at
 
   # Note: Indexing features removed for stability
-
-  # Basic membership
-  member_of TestCustomer, :domains
 end
 
 class TestTag < Familia::Horreum
@@ -42,8 +39,8 @@ class TestTag < Familia::Horreum
   field :name
   field :created_at
 
-  # Global tracking
-  class_tracked_in :all_tags, score: :created_at
+  # Global participation
+  class_participates_in :all_tags, score: :created_at
 end
 
 # Setup
@@ -51,10 +48,10 @@ end
 @domain = TestDomain.new(
   domain_id: 'dom_789',
   display_domain: 'example.com',
-  created_at: Time.now.to_i,
+  created_at: Familia.now.to_i,
   permission_level: :write
 )
-@tag = TestTag.new(name: 'important', created_at: Time.now.to_i)
+@tag = TestTag.new(name: 'important', created_at: Familia.now.to_i)
 
 # =============================================
 # 1. V2 Feature Integration Tests
@@ -72,10 +69,6 @@ TestDomain.included_modules.map(&:name).include?('Familia::Features::Relationshi
 @domain.respond_to?(:permission_encode)
 #=> true
 
-## Redis operations functionality is available
-@domain.respond_to?(:atomic_operation)
-#=> true
-
 ## Identifier method works (wraps identifier_field)
 TestDomain.identifier_field
 #=> :domain_id
@@ -89,7 +82,7 @@ TestDomain.identifier_field
 # =============================================
 
 ## Permission encoding creates proper score
-@score = @domain.permission_encode(Time.now, :write)
+@score = @domain.permission_encode(Familia.now, :write)
 @score.to_s.match?(/\d+\.\d+/)
 #=> true
 
@@ -99,16 +92,16 @@ decoded[:permission_list].include?(:write)
 #=> true
 
 ## Score encoding preserves timestamp ordering
-@early_score = @domain.encode_score(Time.now - 3600, 100)  # 1 hour ago
-@late_score = @domain.encode_score(Time.now, 100)
+@early_score = @domain.encode_score(Familia.now - 3600, 100)  # 1 hour ago
+@late_score = @domain.encode_score(Familia.now, 100)
 @late_score > @early_score
 #=> true
 
 # =============================================
-# 3. Tracking Relationships (tracked_in)
+# 3. Participation Relationships (participates_in)
 # =============================================
 
-## Save operation manages tracking relationships
+## Save operation manages participation relationships
 @customer.save
 @domain.save
 
@@ -129,24 +122,24 @@ decoded[:permission_list].include?(:write)
 #=> true
 
 ## Domain can check membership in customer domains (collision-free naming)
-@domain.respond_to?(:in_testcustomer_domains?)
+@domain.respond_to?(:in_test_customer_domains?)
 #=> true
 
 ## Domain can add itself to customer domains (collision-free naming)
-@domain.respond_to?(:add_to_testcustomer_domains)
+@domain.respond_to?(:add_to_test_customer_domains)
 #=> true
 
 ## Domain can remove itself from customer domains (collision-free naming)
-@domain.respond_to?(:remove_from_testcustomer_domains)
+@domain.respond_to?(:remove_from_test_customer_domains)
 #=> true
 
 ## Add domain to customer collection
-@domain.add_to_testcustomer_domains(@customer)
-@domain.in_testcustomer_domains?(@customer)
+@domain.add_to_test_customer_domains(@customer)
+@domain.in_test_customer_domains?(@customer)
 #=> true
 
 ## Score is properly encoded
-score = @domain.score_in_testcustomer_domains(@customer)
+score = @domain.score_in_test_customer_domains(@customer)
 score.is_a?(Float) && score > 0
 #=> true
 
@@ -154,8 +147,8 @@ score.is_a?(Float) && score > 0
 # 4. Basic Functionality Verification
 # =============================================
 
-## Domain tracking methods work correctly
-@domain.respond_to?(:score_in_testcustomer_domains)
+## Domain participation methods work correctly
+@domain.respond_to?(:score_in_test_customer_domains)
 #=> true
 
 ## Score calculation methods are available
@@ -163,23 +156,23 @@ score.is_a?(Float) && score > 0
 #=> true
 
 # =============================================
-# 5. Basic Membership Relationships (member_of)
+# 5. Bidirectional Participation Methods
 # =============================================
 
-## Member_of generates collision-free methods with collection names
-@domain.respond_to?(:add_to_testcustomer_domains)
+## participates_in generates collision-free bidirectional methods with collection names
+@domain.respond_to?(:add_to_test_customer_domains)
 #=> true
 
-## Basic membership operations work
-@domain.remove_from_testcustomer_domains(@customer)
-@domain.in_testcustomer_domains?(@customer)
+## Basic bidirectional participation operations work
+@domain.remove_from_test_customer_domains(@customer)
+@domain.in_test_customer_domains?(@customer)
 #=> false
 
 # =============================================
 # 6. Basic Global Tag Tracking Test
 # =============================================
 
-## Tag can be tracked globally
+## Tag can be participating globally
 @tag.save
 @tag.respond_to?(:add_to_class_all_tags)
 #=> true
@@ -213,10 +206,6 @@ temp_key = @domain.create_temp_key("test_operation", 60)
 temp_key.start_with?("temp:")
 #=> true
 
-## Batch operations are available
-@domain.respond_to?(:batch_zadd)
-#=> true
-
 ## Score range queries work
 @domain.respond_to?(:score_range)
 #=> true

data/try/features/safe_dump/safe_dump_advanced_try.rb

@@ -17,8 +17,8 @@ Customer.safe_dump_fields
 @cust.custid = 'test@example.com'
 @cust.role = 'user'
 @cust.verified = true
-@cust.created = Time.now.to_i
-@cust.updated = Time.now.to_i
+@cust.created = Familia.now.to_i
+@cust.updated = Familia.now.to_i
 @safe_dump = @cust.safe_dump
 @safe_dump.keys.sort
 #=> [:active, :created, :custid, :role, :secrets_created, :updated, :verified]

data/try/features/transient_fields/refresh_reset_try.rb

@@ -8,6 +8,8 @@ Familia.debug = false
 Familia.dbclient.flushdb
 
 class SecretService < Familia::Horreum
+  feature :transient_fields
+
   identifier_field :name
 
   field :name
@@ -94,7 +96,7 @@ SecretService.fields.sort
 @service.endpoint_url
 #=> "https://api.example.com"
 
-## Set transient fields again after refresh
+## UnsortedSet transient fields again after refresh
 @service.api_key = 'new-api-key-after-refresh'
 @service.password = 'new-password-after-refresh'
 @service.token = 'new-token-after-refresh'

data/try/features/transient_fields/simple_refresh_test.rb

@@ -14,7 +14,7 @@ class Customer
   transient_field :temp_data
 end
 
-# Set some values
+# UnsortedSet some values
 service.name = 'Test Customer'
 service.temp_data = 'secret-info'
 

data/try/helpers/test_cleanup.rb

@@ -0,0 +1,86 @@
+# Test cleanup helper for managing anonymous classes and test isolation
+#
+# This module provides utilities to create and cleanup test classes that
+# inherit from Familia classes. Without proper cleanup, anonymous classes
+# pollute the Familia.members registry causing test failures.
+
+module TestCleanup
+  @test_classes = []
+
+  class << self
+    attr_reader :test_classes
+
+    # Create a test class that inherits from the given base class.
+    # The created class is automatically tracked for cleanup.
+    #
+    # @param base_class [Class] The class to inherit from (e.g., Familia::Horreum)
+    # @param block [Proc] Block to define the class body
+    # @return [Class] The created test class
+    def create_test_class(base_class, &block)
+      test_class = Class.new(base_class, &block)
+      track_test_class(test_class)
+      test_class
+    end
+
+    # Track a test class for cleanup. Use this when you create test classes
+    # directly with Class.new instead of using create_test_class.
+    #
+    # @param klass [Class] The test class to track
+    # @return [Class] The tracked class
+    def track_test_class(klass)
+      @test_classes << klass unless @test_classes.include?(klass)
+      klass
+    end
+
+    # Remove all tracked test classes from Familia.members and clear
+    # the tracking array. This should be called in test teardown.
+    #
+    # @return [Array<Class>] The classes that were removed
+    def cleanup_test_classes
+      removed_classes = []
+
+      @test_classes.each do |test_class|
+        if Familia.members.include?(test_class)
+          Familia.unload_member(test_class)
+          removed_classes << test_class
+        end
+      end
+
+      @test_classes.clear
+      removed_classes
+    end
+
+    # Clean up all anonymous classes from Familia.members.
+    # This is a more aggressive cleanup that removes any class with nil name.
+    #
+    # @return [Array<Class>] The anonymous classes that were removed
+    def cleanup_anonymous_classes
+      Familia.clear_anonymous_members
+    end
+
+    # Perform complete test cleanup - both tracked and anonymous classes
+    #
+    # @return [Hash] Summary of cleanup performed
+    def complete_cleanup
+      tracked_removed = cleanup_test_classes
+      anonymous_removed = cleanup_anonymous_classes
+
+      {
+        tracked_classes_removed: tracked_removed.size,
+        anonymous_classes_removed: anonymous_removed.size,
+        total_removed: tracked_removed.size + anonymous_removed.size
+      }
+    end
+  end
+end
+
+# Automatically perform cleanup if we're in test mode
+# This ensures cleanup happens even if tests don't explicitly call it
+at_exit do
+  if Familia.test_mode? && TestCleanup.test_classes.any?
+    cleanup_result = TestCleanup.complete_cleanup
+    if cleanup_result[:total_removed] > 0
+      puts "[TestCleanup] Cleaned up #{cleanup_result[:total_removed]} test classes on exit"
+    end
+  end
+end

data/try/helpers/test_helpers.rb

@@ -10,6 +10,7 @@ require_relative '../../lib/familia'
 
 Familia.enable_database_logging = true
 Familia.enable_database_counter = true
+Familia.uri = 'redis://127.0.0.1:2525'
 
 class Bone < Familia::Horreum
   using Familia::Refinements::TimeLiterals
@@ -44,12 +45,10 @@ class Customer < Familia::Horreum
 
   using Familia::Refinements::TimeLiterals
 
-  logical_database 15 # Use something other than the default DB
+  logical_database 3 # Use something other than the default DB
   default_expiration 5.years
 
   feature :safe_dump
-  # feature :expiration
-  # feature :api_version
 
   # Use new SafeDump DSL instead of @safe_dump_fields
   safe_dump_field :custid
@@ -65,7 +64,7 @@ class Customer < Familia::Horreum
   # We use a callable here since `:active?` is not a valid method symbol.
   safe_dump_field :active, ->(cust) { cust.active? }
 
-  class_sorted_set :values, key: 'onetime:customer'
+  class_sorted_set :values, key: 'familia:customer'
   class_hashkey :domains
 
   hashkey :stripe_customer
@@ -91,9 +90,9 @@ class Customer < Familia::Horreum
   field :reset_requested #=> Boolean
 
   hashkey :password_reset #=> Familia::HashKey
-  list :sessions #=> Familia::List
+  list :sessions #=> Familia::ListKey
 
-  class_list :customers, suffix: []
+  class_list :all_customers, suffix: [] # no suffix
   class_string :message
 
   class_zset :instances, class: self, reference: true
@@ -108,7 +107,7 @@ end
 class Session < Familia::Horreum
   using Familia::Refinements::TimeLiterals
 
-  logical_database 14 # don't use Onetime's default DB
+  logical_database 2 # a non-default database
   default_expiration 180.minutes
 
   identifier_field :sessid

data/try/horreum/auto_indexing_on_save_try.rb

@@ -0,0 +1,212 @@
+# try/horreum/auto_indexing_on_save_try.rb
+
+#
+# Auto-indexing on save functionality tests
+# Tests automatic index population when Familia::Horreum objects are saved
+#
+
+require_relative '../helpers/test_helpers'
+
+# Test classes for auto-indexing functionality
+class ::AutoIndexUser < Familia::Horreum
+  feature :relationships
+
+  identifier_field :user_id
+  field :user_id
+  field :email
+  field :username
+  field :department
+
+  # Class-level unique indexes (should auto-populate on save)
+  unique_index :email, :email_index
+  unique_index :username, :username_index
+end
+
+class ::AutoIndexCompany < Familia::Horreum
+  feature :relationships
+
+  identifier_field :company_id
+  field :company_id
+  field :name
+end
+
+class ::AutoIndexEmployee < Familia::Horreum
+  feature :relationships
+
+  identifier_field :emp_id
+  field :emp_id
+  field :badge_number
+  field :department
+
+  # Instance-scoped indexes (should NOT auto-populate - require parent context)
+  unique_index :badge_number, :badge_index, within: AutoIndexCompany
+  multi_index :department, :dept_index, within: AutoIndexCompany
+end
+
+# Setup
+@user_id = "user_#{rand(1000000)}"
+@user = AutoIndexUser.new(user_id: @user_id, email: 'test@example.com', username: 'testuser', department: 'engineering')
+
+@company_id = "comp_#{rand(1000000)}"
+@company = AutoIndexCompany.new(company_id: @company_id, name: 'Test Corp')
+
+@emp_id = "emp_#{rand(1000000)}"
+@employee = AutoIndexEmployee.new(emp_id: @emp_id, badge_number: 'BADGE123', department: 'sales')
+
+# =============================================
+# 1. Class-Level Unique Index Auto-Population
+# =============================================
+
+## Unique index is empty before save
+AutoIndexUser.email_index.has_key?('test@example.com')
+#=> false
+
+## Save automatically populates unique index
+@user.save
+AutoIndexUser.email_index.has_key?('test@example.com')
+#=> true
+
+## Auto-populated index maps to correct identifier
+AutoIndexUser.email_index.get('test@example.com')
+#=> @user_id
+
+## Finder method works after auto-indexing
+found = AutoIndexUser.find_by_email('test@example.com')
+found&.user_id
+#=> @user_id
+
+## Multiple unique indexes auto-populate on same save
+AutoIndexUser.username_index.get('testuser')
+#=> @user_id
+
+## Subsequent saves maintain index (idempotent)
+@user.save
+AutoIndexUser.email_index.get('test@example.com')
+#=> @user_id
+
+## Changing indexed field and saving adds new entry (old entry remains unless manually removed)
+# Note: Auto-indexing is idempotent addition only - updates require manual update_in_class_* calls
+@user.email = 'newemail@example.com'
+@user.save
+# New email is indexed, but old email remains (expected behavior - use update_in_class_* for proper updates)
+[AutoIndexUser.email_index.has_key?('test@example.com'), AutoIndexUser.email_index.get('newemail@example.com') == @user_id]
+#=> [true, true]
+
+# =============================================
+# 2. Instance-Scoped Indexes (Manual Only)
+# =============================================
+
+## Instance-scoped indexes do NOT auto-populate on save
+@employee.save
+@company.badge_index.has_key?('BADGE123')
+#=> false
+
+## Instance-scoped indexes remain manual (require parent context)
+@employee.add_to_auto_index_company_badge_index(@company)
+@company.badge_index.has_key?('BADGE123')
+#=> true
+
+# =============================================
+# 3. Edge Cases and Error Handling
+# =============================================
+
+## Nil field values handled gracefully
+@user_nil_id = "user_nil_#{rand(1000000)}"
+@user_nil = AutoIndexUser.new(user_id: @user_nil_id, email: nil, username: nil, department: nil)
+@user_nil.save
+AutoIndexUser.email_index.has_key?('')
+#=> false
+
+## Empty string field values handled gracefully
+@user_empty_id = "user_empty_#{rand(1000000)}"
+@user_empty = AutoIndexUser.new(user_id: @user_empty_id, email: '', username: '', department: '')
+@user_empty.save
+# Empty strings are indexed (they're valid string values, just empty)
+AutoIndexUser.email_index.has_key?('')
+#=> true
+
+## Auto-indexing works with create method
+@user2_id = "user_#{rand(1000000)}"
+@user2 = AutoIndexUser.create(user_id: @user2_id, email: 'create@example.com', username: 'createuser', department: 'marketing')
+AutoIndexUser.find_by_email('create@example.com')&.user_id
+#=> @user2_id
+
+## Auto-indexing idempotent with multiple saves
+@user2.save
+@user2.save
+@user2.save
+AutoIndexUser.email_index.get('create@example.com')
+#=> @user2_id
+
+## Field update followed by save adds new entry (use update_in_class_* for proper updates)
+old_email = @user2.email
+@user2.email = 'updated@example.com'
+@user2.save
+# Both old and new emails are indexed (auto-indexing doesn't remove old values)
+# For proper updates that remove old values, use: @user2.update_in_class_email_index(old_email)
+[AutoIndexUser.email_index.has_key?(old_email), AutoIndexUser.email_index.get('updated@example.com') == @user2_id]
+#=> [true, true]
+
+# =============================================
+# 4. Integration with Other Features
+# =============================================
+
+## Auto-indexing works with transient fields
+class ::AutoIndexWithTransient < Familia::Horreum
+  feature :transient_fields
+  feature :relationships
+
+  identifier_field :id
+  field :id
+  field :email
+  transient_field :temp_value
+
+  unique_index :email, :email_index
+end
+
+@transient_id = "trans_#{rand(1000000)}"
+@transient_obj = AutoIndexWithTransient.new(id: @transient_id, email: 'transient@example.com', temp_value: 'ignored')
+@transient_obj.save
+AutoIndexWithTransient.find_by_email('transient@example.com')&.id
+#=> @transient_id
+
+## Auto-indexing works regardless of other features
+# Just verify that the feature system doesn't interfere
+@transient_obj.class.respond_to?(:indexing_relationships)
+#=> true
+
+# =============================================
+# 5. Performance and Behavior Verification
+# =============================================
+
+## Auto-indexing has negligible overhead (no existence checks)
+# This test verifies the design: we use idempotent commands (HSET, SADD)
+# rather than checking if the index exists before updating
+@user4_id = "user_#{rand(1000000)}"
+@user4 = AutoIndexUser.new(user_id: @user4_id, email: 'perf@example.com', username: 'perfuser', department: 'ops')
+
+# Save multiple times - all should succeed with same result
+@user4.save
+@user4.save
+@user4.save
+
+AutoIndexUser.email_index.get('perf@example.com')
+#=> @user4_id
+
+## Auto-indexing only processes class-level indexes
+# Verify no errors when instance-scoped indexes present
+@employee2_id = "emp_#{rand(1000000)}"
+@employee2 = AutoIndexEmployee.new(emp_id: @employee2_id, badge_number: 'BADGE456', department: 'engineering')
+@employee2.save  # Should not error, just skip instance-scoped indexes
+@employee2.emp_id
+#=> @employee2_id
+
+# Teardown - clean up test objects
+[@user, @user2, @user4, @user_nil, @user_empty, @company, @employee, @employee2, @transient_obj].each do |obj|
+  obj.destroy! if obj.respond_to?(:destroy!) && obj.respond_to?(:exists?) && obj.exists?
+end
+
+# Clean up class-level indexes
+[AutoIndexUser.email_index, AutoIndexUser.username_index].each do |index|
+  index.delete! if index.respond_to?(:delete!) && index.respond_to?(:exists?) && index.exists?
+end

data/try/horreum/base_try.rb

@@ -52,7 +52,7 @@ Familia.debug = false
 #=> true
 
 ## Horreum object fields have a fast attribute method (1 of 2)
-Familia.trace :LOAD, @customer.dbclient, @customer.uri, caller if Familia.debug?
+Familia.trace :LOAD, nil, @customer.uri if Familia.debug?
 @customer.name! 'Jane Doe'
 #=> true
 
@@ -69,7 +69,8 @@ Familia.trace :LOAD, @customer.dbclient, @customer.uri, caller if Familia.debug?
 
 ## Horreum objects can be destroyed
 @customer.destroy!
-#=> true
+#=:> MultiResult
+#==> result.successful?
 
 ## All horrerum objects have a key field
 @customer.identifier

data/try/horreum/commands_try.rb

@@ -1,4 +1,6 @@
-# Test Horreum Redis commands
+# try/horreum/commands_try.rb
+
+# Test Horreum Valkey/Redis commands
 
 require_relative '../helpers/test_helpers'
 

data/try/horreum/defensive_initialization_try.rb

@@ -0,0 +1,86 @@
+# try/horreum/defensive_initialization_try.rb
+
+require_relative '../helpers/test_helpers'
+
+# Test defensive initialization behavior
+class User < Familia::Horreum
+  field :email
+  list :sessions
+  zset :metrics
+
+  def initialize(email = nil)
+    # This is the common mistake - overriding initialize without calling super
+    @email = email
+    # Missing: super() or initialize_relatives
+  end
+end
+
+class SafeUser < Familia::Horreum
+  field :email
+  list :sessions
+  zset :metrics
+
+  def init
+    # This is the correct way - using the init hook
+    # Fields are already set by initialize, no need to override
+  end
+end
+
+# Setup instances for testing
+@user = User.new("test@example.com")
+@safe_user = SafeUser.new
+@safe_user.email = "safe@example.com"
+
+## Test that accessing relationships after bad initialize triggers lazy initialization
+@user.email
+#=> "test@example.com"
+
+## Test that sessions works with lazy initialization
+@user.sessions.class
+#=> Familia::ListKey
+
+## Test that metrics also works with lazy initialization
+@user.metrics.class
+#=> Familia::SortedSet
+
+## Test that safe user works normally
+@safe_user.email
+#=> "safe@example.com"
+
+## Test that safe user sessions work
+@safe_user.sessions.class
+#=> Familia::ListKey
+
+## Test that relatives_initialized flag prevents double initialization
+@user.singleton_class.instance_variable_get(:@relatives_initialized)
+#=> true
+
+## Test that manual initialize_relatives call is no-op
+@user.initialize_relatives
+@user.sessions.class
+#=> Familia::ListKey
+
+## Test that the original problem is now fixed - bad override still works
+class BadUser < Familia::Horreum
+  field :email
+  list :sessions
+
+  def initialize(email)
+    # Bad: overriding initialize without calling super
+    @email = email
+    # Missing: super() or initialize_relatives
+  end
+end
+
+@bad_user = BadUser.new("bad@example.com")
+@bad_user.email
+#=> "bad@example.com"
+
+## Test that relationships work despite bad initialize (lazy initialization kicks in)
+@bad_user.sessions.class
+#=> Familia::ListKey
+
+## Test that the bad user can actually use the relationships
+@bad_user.sessions.add("session_123")
+@bad_user.sessions.size > 0
+#=> true