familia 1.2.1 → 2.0.0.pre2

data/try/{25_redis_type_hash_try.rb → datatypes/hash_try.rb}

@@ -1,7 +1,9 @@
-require_relative '../lib/familia'
-require_relative './test_helpers'
+# try/datatypes/hash_try.rb
 
-@a = Bone.new 'atoken', 'akey'
+require_relative '../../lib/familia'
+require_relative '../helpers/test_helpers'
+
+@a = Bone.new 'atoken'
 
 ## Familia::HashKey#has_key? knows when there's no key
 @a.props.has_key? 'fieldA'

data/try/{23_redis_type_list_try.rb → datatypes/list_try.rb}

@@ -1,8 +1,10 @@
+# try/datatypes/list_try.rb
 
-require_relative '../lib/familia'
-require_relative './test_helpers'
 
-@a = Bone.new 'atoken', 'akey'
+require_relative '../../lib/familia'
+require_relative '../helpers/test_helpers'
+
+@a = Bone.new 'atoken'
 
 ## Familia::List#push
 ret = @a.owners.push :value1

data/try/{22_redis_type_set_try.rb → datatypes/set_try.rb}

@@ -1,8 +1,10 @@
+# try/datatypes/set_try.rb
 
-require_relative '../lib/familia'
-require_relative './test_helpers'
 
-@a = Bone.new 'atoken', 'akey'
+require_relative '../../lib/familia'
+require_relative '../helpers/test_helpers'
+
+@a = Bone.new 'atoken'
 
 ## Familia::Set#add
 ret = @a.tags.add :a

data/try/{21_redis_type_zset_try.rb → datatypes/sorted_set_try.rb}

@@ -1,11 +1,13 @@
-require_relative '../lib/familia'
-require_relative './test_helpers'
+# try/datatypes/sorted_set_try.rb
 
-# Familia.debug = true
+require_relative '../../lib/familia'
+require_relative '../helpers/test_helpers'
 
-@a = Bone.new 'atoken', 'akey'
+
+@a = Bone.new 'atoken'
 
 ## Familia::SortedSet#add
+@a = Bone.new 'atoken'
 @a.metrics.add 2, :metric2
 @a.metrics.add 4, :metric4
 @a.metrics.add 0, :metric0

data/try/{24_redis_type_string_try.rb → datatypes/string_try.rb}

@@ -1,13 +1,13 @@
-require_relative '../lib/familia'
-require_relative './test_helpers'
+# try/datatypes/string_try.rb
 
-#Familia.apiversion = 'v1'
+require_relative '../../lib/familia'
+require_relative '../helpers/test_helpers'
 
-@a = Bone.new 'atoken2', 'akey'
+@a = Bone.new(token: 'atoken2')
 
-## Bone#rediskey
-@a.rediskey
-#=> 'bone:atoken2:akey:object'
+## Bone#dbkey
+@a.dbkey
+#=> 'bone:atoken2:object'
 
 ## Familia::String#value should give default value
 @a.value.value
@@ -27,7 +27,7 @@ require_relative './test_helpers'
 
 ## Familia::String.new
 @ret = Familia::String.new 'arbitrary:key'
-@ret.rediskey
+@ret.dbkey
 #=> 'arbitrary:key'
 
 ## instance set

data/try/edge_cases/empty_identifiers_try.rb

@@ -0,0 +1,48 @@
+require_relative '../helpers/test_helpers'
+
+# Test empty identifier edge cases
+group "Empty Identifier Edge Cases"
+
+setup do
+  @user_class = Class.new(Familia::Horreum) do
+    identifier :email
+    field :name
+  end
+end
+
+try "empty string identifier causes stack overflow" do
+  user = @user_class.new(email: "", name: "Test")
+
+  begin
+    user.exists?  # This should cause infinite loop
+    false
+  rescue SystemStackError
+    true  # Expected stack overflow
+  rescue => e
+    false # Unexpected error
+  end
+end
+
+try "nil identifier causes stack overflow" do
+  user = @user_class.new(email: nil, name: "Test")
+
+  begin
+    user.exists?
+    false
+  rescue SystemStackError, Familia::NoIdentifier
+    true  # Expected error
+  end
+end
+
+try "validation workaround prevents stack overflow" do
+  user = @user_class.new(email: "", name: "Test")
+
+  # Workaround: validate before operations
+  if user.identifier.to_s.empty?
+    raise ArgumentError, "Empty identifier"
+  end
+
+  false  # Should not reach here
+rescue ArgumentError => e
+  e.message.include?("Empty identifier")
+end

data/try/{92_symbolize_try.rb → edge_cases/hash_symbolization_try.rb}

@@ -1,20 +1,24 @@
-require_relative '../lib/familia'
-require_relative './test_helpers'
+# try/edge_cases/hash_symbolization_try.rb
+
+# NOTE: These testcases are disabled b/c there's a shared context
+# bug in Tryouts 3.1 that prevents the setup instance vars from
+# being available to the testcases.
+
+require_relative '../../lib/familia'
+require_relative '../helpers/test_helpers'
 
 Familia.debug = false
 
 # Test the updated deserialize_value method
 class SymbolizeTest < Familia::Horreum
-  identifier :id
+  identifier_field :id
   field :id
   field :config
 end
 
+@test_hash = { "name" => "John", "age" => 30, "nested" => { "theme" => "dark" } }
 @test_obj = SymbolizeTest.new
 @test_obj.id = "symbolize_test_1"
-
-## Test with a hash containing string keys
-@test_hash = { "name" => "John", "age" => 30, "nested" => { "theme" => "dark" } }
 @test_obj.config = @test_hash
 @test_obj.save
 
@@ -85,6 +89,7 @@ end
 @test_obj.deserialize_value('just a string')
 #=> "just a string"
 
+## A stringified number is still a stringified number
 @test_obj.deserialize_value('42')
 #=> "42"
 
@@ -92,5 +97,5 @@ end
 @test_obj.deserialize_value('invalid json')
 #=> "invalid json"
 
-## Clean up
+# Clean up
 @test_obj.destroy!

data/try/edge_cases/json_serialization_try.rb

@@ -0,0 +1,85 @@
+# try/edge_cases/json_serialization_try.rb
+
+require_relative '../../lib/familia'
+require_relative '../helpers/test_helpers'
+
+Familia.debug = false
+
+# Define a simple model with fields that should handle JSON data
+class JsonTest < Familia::Horreum
+  identifier_field :id
+  field :id
+  field :config      # This should be able to store Hash objects
+  field :tags        # This should be able to store Array objects
+  field :simple      # This should store simple strings as-is
+end
+
+
+## Test 1: Store a Hash - should serialize to JSON automatically
+test_obj = JsonTest.new
+test_obj.config = { theme: "dark", notifications: true, settings: { volume: 80 } }
+test_obj.config
+#=:> Hash
+
+## Test 2: Store an Array - should serialize to JSON automatically
+test_obj = JsonTest.new
+test_obj.tags = ["ruby", "valkey", "json", "familia"]
+test_obj.tags
+#=:> Array
+
+## Test 3: Store a simple string - should remain as string
+test_obj = JsonTest.new
+test_obj.simple = "just a string"
+test_obj.simple
+#=:> String
+
+## Save the object - this should call serialize_value and use to_json
+test_obj = JsonTest.new 'a_unque_id'
+test_obj.save
+#=> true
+
+## Verify what's actually stored in Database (raw)
+test_obj = JsonTest.new
+test_obj.id = "json_test_1"
+test_obj.config = { theme: "dark", notifications: true, settings: { volume: 80 } }
+test_obj.simple = "just a string"
+test_obj.tags = ["ruby", "valkey", "json", "familia"]
+test_obj.save
+test_obj.hgetall
+#=> {"id"=>"json_test_1", "config"=>"{\"theme\":\"dark\",\"notifications\":true,\"settings\":{\"volume\":80}}", "tags"=>"[\"ruby\",\"valkey\",\"json\",\"familia\"]", "simple"=>"just a string"}
+
+## Test 4: Hash should be deserialized back to Hash
+test_obj = JsonTest.new 'any_id_will_do'
+puts "Config after refresh:"
+puts test_obj.config
+puts "Config class: "
+[test_obj.config.class, test_obj.config]
+##=> [Hash, {:theme=>"dark", :notifications=>true, :settings=>{:volume=>80}}]
+
+## Test 5: Array should be deserialized back to Array
+test_obj = JsonTest.new 'any_id_will_do'
+puts "Tags after refresh:"
+puts test_obj.tags.inspect
+puts "Tags class: #{test_obj.tags.class}"
+test_obj.tags.inspect
+test_obj.tags
+##=> ["ruby", "valkey", "json", "familia"]
+
+## Test 6: Simple string should remain a string (this works correctly)
+test_obj = JsonTest.new 'any_id_will_do'
+puts "Simple after refresh:"
+puts test_obj.simple.inspect
+puts "Simple class: #{test_obj.simple.class}"
+[test_obj.simple.class, test_obj.simple]
+##=> [String, "just a string"]
+
+# Demonstrate the asymmetry:
+test_obj = JsonTest.new 'any_id_will_do'
+puts "\n=== ASYMMETRY DEMONSTRATION ==="
+puts "Before save: config is #{test_obj.config.class}"
+test_obj.config = { example: "data" }
+puts "After assignment: config is #{test_obj.config.class}"
+test_obj.save
+puts "After save: config is still #{test_obj.config.class}"
+test_obj.refresh!
+puts "After refresh: config is now #{test_obj.config.class}!"

data/try/edge_cases/race_conditions_try.rb

@@ -0,0 +1,60 @@
+require_relative '../helpers/test_helpers'
+
+# Test connection race conditions
+group "Race Conditions Edge Cases"
+
+setup do
+  @user_class = Class.new(Familia::Horreum) do
+    identifier :email
+    field :counter
+  end
+end
+
+try "concurrent connection access causes race condition" do
+  user = @user_class.new(email: "test@example.com", counter: 0)
+  user.save
+
+  threads = []
+  results = []
+
+  # Simulate high concurrency
+  10.times do
+    threads << Thread.new do
+      begin
+        user.incr(:counter)
+        results << "success"
+      rescue => e
+        results << "error: #{e.class.name}"
+      end
+    end
+  end
+
+  threads.each(&:join)
+
+  # May show race condition issues
+  errors = results.count { |r| r.start_with?("error") }
+  errors > 0  # Expects some race condition errors
+ensure
+  user&.delete!
+end
+
+try "connection pool stress test" do
+  users = []
+
+  # Create multiple users concurrently
+  threads = []
+  20.times do |i|
+    threads << Thread.new do
+      user = @user_class.new(email: "user#{i}@example.com")
+      user.save
+      users << user
+    end
+  end
+
+  threads.each(&:join)
+
+  # Check for connection issues
+  users.length > 0  # Some should succeed despite race conditions
+ensure
+  users.each(&:delete!) rescue nil
+end

data/try/edge_cases/reserved_keywords_try.rb

@@ -0,0 +1,59 @@
+require_relative '../helpers/test_helpers'
+
+# Test reserved keyword handling
+group "Reserved Keywords Edge Cases"
+
+setup do
+  @user_class = Class.new(Familia::Horreum) do
+    identifier :email
+    # These should fail with reserved keywords
+    begin
+      field :ttl      # Reserved for expiration
+      field :db       # Reserved for database
+      field :redis    # Reserved for connection
+    rescue => e
+      # Expected to fail
+    end
+
+    # Workarounds
+    field :secret_ttl
+    field :user_db
+    field :redis_config
+  end
+end
+
+try "cannot use ttl as field name" do
+  begin
+    Class.new(Familia::Horreum) do
+      field :ttl
+    end
+    false  # Should not reach here
+  rescue => e
+    true   # Expected error
+  end
+end
+
+try "workaround with prefixed names works" do
+  user = @user_class.new(email: "test@example.com")
+  user.secret_ttl = 3600
+  user.user_db = 5
+  user.redis_config = {host: "localhost"}
+  user.save
+
+  user.secret_ttl == 3600 &&
+    user.user_db == 5 &&
+    user.redis_config.is_a?(Hash)
+ensure
+  user&.delete!
+end
+
+try "reserved methods still work normally" do
+  user = @user_class.new(email: "test@example.com")
+  user.save
+
+  user.respond_to?(:ttl) &&
+    user.respond_to?(:db) &&
+    user.respond_to?(:redis)
+ensure
+  user&.delete!
+end

data/try/{93_string_coercion_try.rb → edge_cases/string_coercion_try.rb}

@@ -1,35 +1,63 @@
-# try/93_string_coercion_try.rb
+# try/edge_cases/string_coercion_try.rb
 
-require_relative '../lib/familia'
-require_relative './test_helpers'
+require_relative '../helpers/test_helpers'
 
 Familia.debug = false
 
+@customer_id = 'customer-string-coercion-test'
+
 # Error handling: object without proper identifier setup
 class ::BadIdentifierTest < Familia::Horreum
   # No identifier method defined - should cause issues
 end
 
+# Case statement works with string matching
+def classify_id(obj)
+  case obj.to_s
+  when /customer/
+    'customer_type'
+  when /session/
+    'session_type'
+  else
+    'unknown_type'
+  end
+end
+
+# Polymorphic method accepting both strings and Familia objects
+def process_identifier(id_or_object)
+  # Can handle both string IDs and Familia objects uniformly
+  processed_id = id_or_object.to_s
+  "processed:#{processed_id}"
+end
+
+def lookup_by_id(id_string)
+  id_string.to_s.upcase
+end
+
+## Instantiaite a troubled model class
 @bad_obj = ::BadIdentifierTest.new
+#=:> BadIdentifierTest
 
 # Test polymorphic string usage for Familia objects
-@customer_id = 'customer-string-coercion-test'
 @customer = Customer.new(@customer_id)
 @customer.name = 'John Doe'
 @customer.planid = 'premium'
 @customer.save
+#=> true
 
-@session_id = 'session-string-coercion-test'
-@session = Session.new(@session_id)
+## Session save
+@session = Session.new
 @session.custid = @customer_id
 @session.useragent = 'Test Browser'
 @session.save
+#=> true
 
-## Complex identifier test with array-based identifier
+## Bone with simple identifier
 @bone = Bone.new
 @bone.token = 'test_token'
 @bone.name = 'test_name'
-
+@bone.identifier
+#=> 'test_token'
 
 ## Basic to_s functionality returns identifier
 @customer.to_s
@@ -43,14 +71,20 @@ end
 @customer.to_s == @customer.identifier
 #=> true
 
+## Session identifier can be set and is not overidden even after saved
+@session_id = 'session-string-coercion-test'
+session = Session.new(@session_id)
+session.identifier
+session
+#==> _.to_s == @session_id
+#==> _.identifier == @session_id
+#==> _.save
+#==> _.identifier == @session_id
+#==> _.to_s == @session_id
+
 ## Session to_s works with generated identifier
 @session.to_s
-#=> @session_id
-
-## Method accepting string parameter works with Familia object
-def lookup_by_id(id_string)
-  id_string.to_s.upcase
-end
+#=<> @session_id
 
 lookup_by_id(@customer)
 #=> @customer_id.upcase
@@ -64,7 +98,7 @@ lookup_by_id(@customer)
 ## Array operations work with mixed types
 @mixed_array = [@customer_id, @customer, @session]
 @mixed_array.map(&:to_s)
-#=> [@customer_id, @customer_id, @session_id]
+#=> [@customer_id, @customer_id, _[2]]
 
 ## String comparison works
 @customer.to_s == @customer_id
@@ -72,75 +106,42 @@ lookup_by_id(@customer)
 
 ## Join operations work seamlessly
 [@customer, 'separator', @session].join(':')
-#=> "#{@customer_id}:separator:#{@session_id}"
-
-## Case statement works with string matching
-def classify_id(obj)
-  case obj.to_s
-  when /customer/
-    'customer_type'
-  when /session/
-    'session_type'
-  else
-    'unknown_type'
-  end
-end
+#=~> /\A#{@customer_id}:separator:[0-9a-z]+\z/
 
+## Classify a customer
 classify_id(@customer)
 #=> 'customer_type'
 
-classify_id(@session)
-#=> 'session_type'
-
-## Polymorphic method accepting both strings and Familia objects
-def process_identifier(id_or_object)
-  # Can handle both string IDs and Familia objects uniformly
-  processed_id = id_or_object.to_s
-  "processed:#{processed_id}"
-end
-
+## Polymorphic method accepting both strings and Familia objects (string)
 process_identifier(@customer_id)
 #=> "processed:#{@customer_id}"
 
+## Polymorphic method accepting both strings and Familia objects (familia)
 process_identifier(@customer)
 #=> "processed:#{@customer_id}"
 
-## Redis storage using object as string key
+## Database storage using object as string key
 @metadata = Familia::HashKey.new 'metadata'
 @metadata[@customer] = 'customer_metadata'
 @metadata[@customer.to_s] # Same key access
 #=> 'customer_metadata'
 
-## Cleanup after test
+## Cleanup after test, 1
 @metadata.delete!
 #=> true
 
+## Cleanup after test, 2
 @customer.delete!
 #=> true
 
+## Cleanup after test, 3
 @session.delete!
 #=> true
 
 ## to_s handles identifier errors gracefully
-@bad_obj.to_s.include?('BadIdentifierTest')
-#=> true
-
-## Array-based identifier works with to_s
-@bone.to_s
-#=> 'test_token:test_name'
-
-## String operations on complex identifier
-@bone.to_s.split(':')
-#=> ['test_token', 'test_name']
-
-## Cleanup a key that does not exist
-@bone.delete!
-#=> false
-
-## Cleanup a key that exists
-@bone.save
-@bone.delete!
-#=> true
+badboi = BadIdentifierTest.new
+badboi.to_s #.include?('BadIdentifierTest')
+#=~> /BadIdentifierTest:0x[0-9a-f]+/
 
 ## Performance consideration: to_s caching behavior
 @customer2 = Customer.new('performance-test')

data/try/edge_cases/ttl_side_effects_try.rb

@@ -0,0 +1,51 @@
+require_relative '../helpers/test_helpers'
+
+# Test TTL side effects
+group "TTL Side Effects Edge Cases"
+
+setup do
+  @session_class = Class.new(Familia::Horreum) do
+    identifier :session_id
+    field :name
+    field :data
+    feature :expiration
+    ttl 300  # 5 minutes
+  end
+end
+
+try "field update unintentionally resets TTL" do
+  session = @session_class.new(session_id: "test123", name: "Session")
+  session.save
+
+  # Set shorter TTL
+  session.expire(60)
+  original_ttl = session.realttl
+
+  # Update field - this may reset TTL unexpectedly
+  session.name = "Updated Session"
+  session.save
+
+  new_ttl = session.realttl
+
+  # TTL should remain short but may have been reset
+  new_ttl > original_ttl  # Indicates TTL side effect
+ensure
+  session&.delete!
+end
+
+try "batch update preserves TTL with flag" do
+  session = @session_class.new(session_id: "test124")
+  session.save
+  session.expire(60)
+
+  original_ttl = session.realttl
+
+  # Use update_expiration: false to preserve TTL
+  session.batch_update({name: "Batch Updated"}, update_expiration: false)
+
+  new_ttl = session.realttl
+
+  (original_ttl - new_ttl).abs < 5  # TTL preserved within tolerance
+ensure
+  session&.delete!
+end