falcon 0.55.2 → 0.55.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e901867477864a82832904cbaa1662105e6dce12190e057d457a666fa3dfe42
-  data.tar.gz: 523e181a6685bfe398bc5630076ab8e76642bf47181d4e20c62192813f121712
+  metadata.gz: 518acbb2388840608c7abc42e802372d5b8cf547d0928a0164afc5bdd3aa7590
+  data.tar.gz: 9d37e38f1c95e19fa11a34c7ccebab765820401a48bea7e97b6a9ecf7e0c36d5
 SHA512:
-  metadata.gz: 0eb64a874478507caeafefb4c83b108cfa7b00326cf69ce7581ab534e9466048dea1572b66044f06ee19b21998fafad32cf5de3ea050f6ae0f32b1743424ef2e
-  data.tar.gz: 3f041a4ebdf07b1063373a27e7151b4f8380f4f440b34a773f27b0b6761d64f721209c5a7d2366f1210e1be1d3042d1e8bed117a77a7ce81d9335274636fe656
+  metadata.gz: 05ae47c057c66f6a89e84d2f46a2a4db66109716a1035af63bfd0e2db4272d51a1e6702bf7f915a32b1f9479c991ca7de622d7ed96ac1ddfa7c6e234a866299b
+  data.tar.gz: 4ceeb8958477cff0ffc308ea911e7844bebb6343cf464a20e35e749098a104cf2f807f92d56fb891eeb4f2135cbec638b1518b7b7362ee926658250f19d09898

data/lib/falcon/body/request_finished.rb

@@ -11,10 +11,13 @@ module Falcon
 		# Wraps a response body and decrements a metric after the body is closed.
 		#
 		# Runs close on the underlying body first (which invokes rack.response_finished),
-		# then decrements the metric. Use this so requests_active stays elevated until
-		# the request is fully finished (including response_finished callbacks).
+		# then decrements the metric, even if closing raises. Use this so requests_active
+		# stays elevated until the request is fully finished (including response_finished
+		# callbacks), without leaking if close reports an error.
 		class RequestFinished < Protocol::HTTP::Body::Wrapper
-			# Wrap a response body with a metric. If the body is nil or empty, decrements immediately.
+			# Wrap a response body with a metric.
+			#
+			# Expects the caller to have incremented `requests_active` beforehand. If the body is not wrapped (nil or empty message/body, or an error while assigning the wrapper), the `ensure` block decrements once. When wrapped, the metric is decremented in {#close}.
 			#
 			# @parameter message [Protocol::HTTP::Response] The response whose body to wrap.
 			# @parameter metric [Async::Utilization::Metric] The metric to decrement when the body is closed.
@@ -29,6 +32,8 @@ module Falcon
 				message
 			end
 			
+			# Initialize the wrapper.
+			#
 			# @parameter body [Protocol::HTTP::Body::Readable] The body to wrap.
 			# @parameter metric [Async::Utilization::Metric] The metric to decrement on close.
 			def initialize(body, metric)
@@ -52,7 +57,7 @@ module Falcon
 			# @parameter error [Exception, nil] Optional error that caused the close.
 			def close(error = nil)
 				super
-				
+			ensure
 				@metric&.decrement
 				@metric = nil
 			end

data/lib/falcon/server.rb

@@ -69,10 +69,22 @@ module Falcon
 		# Body::RequestFinished wrapper runs the decrement after the body closes,
 		# so response_finished callbacks are counted as active.
 		def call(...)
+			decrement = false
+			
 			@requests_total_metric.increment
 			@requests_active_metric.increment
+			decrement = true
+			
+			# Roll back `requests_active` unless the full `super` + wrap path completes. Covers
+			# `super` raising before `wrap` runs, errors inside `wrap`, and other abnormal exits.
+			response = Body::RequestFinished.wrap(super, @requests_active_metric)
+			decrement = false
 			
-			return Body::RequestFinished.wrap(super, @requests_active_metric)
+			return response
+		ensure
+			if decrement
+				@requests_active_metric.decrement
+			end
 		end
 		
 		# Generates a human-readable string representing the current statistics.

data/lib/falcon/version.rb

@@ -5,5 +5,5 @@
 
 # @namespace
 module Falcon
-	VERSION = "0.55.2"
+	VERSION = "0.55.4"
 end

data/readme.md

@@ -47,9 +47,17 @@ Please see the [project documentation](https://socketry.github.io/falcon/) for m
 
 Please see the [project releases](https://socketry.github.io/falcon/releases/index) for all releases.
 
+### v0.55.4
+
+  - Ensure `requests_active` is decremented if closing the response body raises.
+
+### v0.55.3
+
+  - Decrement `requests_active` in `Falcon::Server#call` when `super` or `Falcon::Body::RequestFinished.wrap` raises, so utilization metrics are not leaked on error paths.
+
 ### v0.55.2
 
-  - Remove unnecessary require for `async/service/supervisor/supervised`."
+  - Remove unnecessary require for `async/service/supervisor/supervised`.
 
 ### v0.55.1
 
@@ -87,15 +95,6 @@ Please see the [project releases](https://socketry.github.io/falcon/releases/ind
   - Introduce <code class="language-ruby">Falcon::Environment::Server\#make\_server</code> which gives you full control over the server creation process.
   - [Introduce `Async::Container::Supervisor`.](https://socketry.github.io/falcon/releases/index#introduce-async::container::supervisor.)
 
-### v0.50.0
-
-  - Add <code class="language-ruby">Falcon::Environment::Server\#endpoint\_options</code> to allow configuration of the endpoint options more easily.
-
-### v0.49.0
-
-  - [Falcon Server Container Health Checks](https://socketry.github.io/falcon/releases/index#falcon-server-container-health-checks)
-  - [Falcon Server Process Title](https://socketry.github.io/falcon/releases/index#falcon-server-process-title)
-
 ## Contributing
 
 We welcome contributions to this project.

data/releases.md

@@ -1,8 +1,16 @@
 # Releases
 
+## v0.55.4
+
+  - Ensure `requests_active` is decremented if closing the response body raises.
+
+## v0.55.3
+
+  - Decrement `requests_active` in `Falcon::Server#call` when `super` or `Falcon::Body::RequestFinished.wrap` raises, so utilization metrics are not leaked on error paths.
+
 ## v0.55.2
 
-  - Remove unnecessary require for `async/service/supervisor/supervised`."
+  - Remove unnecessary require for `async/service/supervisor/supervised`.
 
 ## v0.55.1
 

data.tar.gz.sig

@@ -1 +1,5 @@
-q,4��_�:�=�"��ߙ����t!&sל�c\�q�bN�gL�>>S�}!!�Db�Y�,w����kC����U���������+'�'��[x٥�L���!�+�L��f��&`Go���XZ����^p�G`��
+����ҳƇJ�si
+5��6={К+�bV�_G8l�q��|��\E�����a�
+�G�t�	\�t����W�rn��Q�S�p����w������]ͤe�g����Ŗ��l�X��
+E���nb[����Zd�|%�ަ�+�s���X6�$�ku�:��`	���E�slnq��!�XQOmNL���k(��m3�aQA����ݳ��J�T�@�QT�,�LJ�}{��vç���һS��t�J
��hEd��=�\����ɳN�|��X�_{�<��u�}�����.�T�OC7�̕]���9�νrR�Ѹ/)8�=�����kt��D��_�w�$&�әhv�r_�
+e�

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: falcon
 version: !ruby/object:Gem::Version
-  version: 0.55.2
+  version: 0.55.4
 platform: ruby
 authors:
 - Samuel Williams
@@ -312,7 +312,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 4.0.10
 specification_version: 4
 summary: A fast, asynchronous, rack-compatible web server.
 test_files: []