fakturan_nu 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b13585e5fc6be9909753083863eda66758b826d7
-  data.tar.gz: 9b8a8ce02f6e623bd01f3f7f1ca0bc4b5105d6be
+  metadata.gz: 6ed6955e3027b00dace28b8064a0ba10a0432442
+  data.tar.gz: 979f391de0873200d18198ba11b4a4190d689a21
 SHA512:
-  metadata.gz: 91aa5a0c02ec650d3de08b278223fe165b146ab7f21cde3149e592c39ce3c616c90869b41329fbb2198df6136d2ccb5cb9e654d43c5834b14e2b5e01428f5f4c
-  data.tar.gz: 9b2cf0b37560c8b21466f15781c52e0a7401b1469ed312c00a804ad50fdf7b0f179374162a735cee434ffea090e87366c9c129410716b2129a5aa4e3c576a561
+  metadata.gz: 8ee731a75e0e05e1bfe543aec9cccaeed9364f7cac99360a249ce47c634b86b82105d3a6d9baed73f39304a4a24b13c658ffdee767380bea1ab10b7867fe4017
+  data.tar.gz: b584bfaee349fd14d4bdc37202fef9a0f2c762622f08a1d49de293b29aba91f242dbde5d8fc10d628b91533856c0e92e606efc372da95e2af0dcc775b584e0b4

data/fakturan_nu.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name        = 'fakturan_nu'
-  s.version     = '1.1.1'
+  s.version     = '1.1.2'
   s.date        = '2015-04-14'
   s.summary     = 'A ruby client for the Fakturan.nu - API'
   s.description = 'A ruby client for the Fakturan.nu - API. Fakturan.nu is a webbapp for billing.'

data/lib/fakturan_nu/base.rb

@@ -44,8 +44,10 @@ module Fakturan
             self.add_to_errors(field_name.to_sym, [{error: :invalid}])
             field_errors.each do |new_error_hash_with_index| # new_error_hash_OR_error_type ("blank") on presence of has_many
               new_error_hash_with_index.each do |index, inner_errors_hash|
-                error_attribute = inner_errors_hash.keys.first.split('.').last.to_sym
-                self.send(ass_name)[index.to_i].add_to_errors(error_attribute, inner_errors_hash.values.last)
+                inner_errors_hash.each do |inner_field_name, inner_field_errors|
+                  error_attribute = inner_field_name.split('.').last.to_sym
+                  self.send(ass_name)[index.to_i].add_to_errors(error_attribute, inner_field_errors)
+                end
               end
             end
           else # It's a belongs_to or has_one

data/test/exceptions_test.rb

@@ -70,29 +70,33 @@ module Fakturan
       assert_equal 400, error.status
     end
 
+    def test_multiple_validation_errors_on_has_many
+      stub_api_request(:post, '/trees').to_return(body: {errors: {apples: [{"0" => {"apples.colour" => [{error: :too_short, count:4}], "apples.shape" => [{error: :taken, value: "square"}]}}]}}.to_json, status: 422)
+      tree = Fakturan::Tree.new({"apples"=>[{"colour"=>"", "shape"=>"square"}]})
+      assert_equal false, tree.save
+      assert_equal ({:colour=>[{:error=>:too_short, :count=>4}], :shape=>[{:error=>:taken, :value=>"square"}]}), tree.apples.first.errors.details
+    end
+
     def test_validation_errors_on_associations_when_created_through_params
       stub_api_request(:post, '/trees').to_return(body: {errors: {apples: [{"0" => {"apples.colour" => [{error: :blank}]}}], "crown.fluffyness" => [{error: :invalid}]}}.to_json, status: 422)
-
-      a = Fakturan::Tree.new({"apples"=>[{"name"=>"zdsdfsdf", "email"=>"", "password"=>"", "firstname"=>"zdsdfsdf", "lastname"=>"zdsdfsdf", "colour"=>""}], "crown"=>{"fluffyness"=>""}})
-
-      assert_equal false, a.save
-      assert_equal (["Apples is invalid", "Crown fluffyness is invalid"]), a.errors.to_a
-      assert_equal (["Fluffyness is invalid"]), a.crown.errors.to_a
+      tree = Fakturan::Tree.new({"apples"=>[{"something"=>""}], "crown"=>{"fluffyness"=>""}})
+      assert_equal false, tree.save
+      assert_equal ({:colour=>[{:error=>:blank}]}), tree.apples.first.errors.details
+      assert_equal (["Apples is invalid", "Crown fluffyness is invalid"]), tree.errors.to_a
+      assert_equal (["Fluffyness is invalid"]), tree.crown.errors.to_a
     end
 
     def test_validation_errors_on_blank_associated_objects
       stub_api_request(:post, '/trees').to_return(body: {errors: {apples: [{error: :blank}], crown: [{error: :blank}]}}.to_json, status: 422)
-      a = Fakturan::Tree.new()
-      assert_equal false, a.save
-      assert_equal (["Apples can't be blank", "Crown can't be blank"]), a.errors.to_a
-      assert_equal ({:apples=>[{:error=>:blank}], :crown=>[{:error=>:blank}]}), a.errors.details
+      tree = Fakturan::Tree.new()
+      assert_equal false, tree.save
+      assert_equal (["Apples can't be blank", "Crown can't be blank"]), tree.errors.to_a
+      assert_equal ({:apples=>[{:error=>:blank}], :crown=>[{:error=>:blank}]}), tree.errors.details
     end
 
     def test_save_fails_when_has_many_validation_fails
       stub_api_request(:post, '/invoices').to_return(body: {errors: {rows: [{"0" => {"rows.product_code" => [{error: :too_long, count:30}]}}] }}.to_json, status: 422)
-
       invoice = Fakturan::Invoice.new(client: { company: "Acme inc" }, rows: [{product_code: '1234567890123456789012345678901'}])
-
       assert_equal false, invoice.save
       assert_equal ({:product_code=>[{:error=>:too_long, :count=>30}]}), invoice.rows[0].errors.details
       assert_equal "Rows is invalid", invoice.errors.to_a.first
@@ -100,10 +104,8 @@ module Fakturan
 
     def test_validation_errors_on_associations
       stub_api_request(:post, '/invoices').to_return(body: {errors: {date: [{error: :blank},{error: :invalid}], rows: [{"0" => {"rows.product_code" => [{error: :too_long, count:30}]}}, {"2" => {"rows.product_code" => [{error: :too_long, count:30}]}}], "client.company" => [{ error: :blank}]}}.to_json, status: 422)
-
       invoice = Fakturan::Invoice.new(client: {}, rows: [{product_code: '1234567890123456789012345678901'}, {product_code: '1'}, {product_code: '1234567890123456789012345678901'}])
       invoice.save
-
       assert_equal "Client company can't be blank", invoice.errors.to_a.last
       assert_equal ({date: [{error: :blank}, {error: :invalid}], :rows=>[{:error=>:invalid}]}), invoice.errors.details
       assert_equal ({:product_code=>[{:error=>:too_long, :count=>30}]}), invoice.rows[0].errors.details

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fakturan_nu
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Jonathan Bourque Olivegren