faker 3.4.2 → 3.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf806bbcecec3b286e05fe7c79f0b4274708a3a7f55add0b3488a3ba8bf574f6
-  data.tar.gz: 688f47f7f92a4b58281ef2e3beb0df72e134e916929d7aa1ff4e6db07af9151d
+  metadata.gz: dc659ae3f4a2f8e2d7f7fc3a22903c5a1e81138110b8ddeced3b6969ad92e22d
+  data.tar.gz: a0370b7a158c4fe7a40b3a32500e45997cb0fa5b753e507f65cbbebe66523c2a
 SHA512:
-  metadata.gz: 4cd84609a1b8b0d846f5185cd544141e22d8296a2bcbe4a613daabcdadde8afa1039a9087dafbf7b7ccba7668ff5c506b1ca25cbebd3520455760a16dea45cd6
-  data.tar.gz: ab939601c6ceeb1f051d708687a61e2a89c3e9da77881159866a73cb5039c9292101cb48d3b19c36607b1cbf25192e8895e7e49b0dde1e88c0e07c0e24e75f01
+  metadata.gz: fa3feb382544da65be21255d723278ef89ba1c470a572267b61c5adb9c4e5b171668356bd30f339be12a735d605722118ad0e6d302b3c3774e987cd76bdc3763
+  data.tar.gz: 031cadfc32e4f3faaf68d971a18cda06caa01a610da3449a4fe3d5fe9c0523979b4426b9fbb699a6a6f2511958223875d783e7b792aebb390a4d871bbbbae59d

data/CHANGELOG.md

@@ -1,5 +1,119 @@
 # Changelog
 
+## [v3.5.2](https://github.com/faker-ruby/faker/tree/v3.5.2) (2025-07-01)
+
+Happy Canada Day! 🍁
+
+This version adds and improves some locales and fixes some bugs.
+
+Thanks to all contributors!
+
+### Improvements & Bug fixes
+* Correct `Faker::Address.city` and `Faker::Address.street_address` for `:fr` locale by @brupla6126 in https://github.com/faker-ruby/faker/pull/3018
+* fix condominium_fiscal_code generator length from 9 to 11 characters by @FiloSpaTeam in https://github.com/faker-ruby/faker/pull/3037
+* Add Cell Phone, Default Time Zone and State Abbreviation translation for en-PAK locale by @wonderer007 in https://github.com/faker-ruby/faker/pull/3024
+* Fix usage docs header indentation by @jaredsmithse in https://github.com/faker-ruby/faker/pull/3049
+* Fix nl phone format by @klaaspieter in https://github.com/faker-ruby/faker/pull/3050
+* Fix typo in `ja/book` locale by @thdaraujo in https://github.com/faker-ruby/faker/pull/3062
+* fix a typo by @jethrodaniel in https://github.com/faker-ruby/faker/pull/3060
+* Fix typo in `restaurant.yml` by @daniel-nerdgeschoss in https://github.com/faker-ruby/faker/pull/3067
+* Fix city address with number in `locales/fr/address.yml` by @brupla6126 in https://github.com/faker-ruby/faker/pull/3071
+* Fix unclosed quote in `locales/en/cosmere.yml` by @bensheldon in https://github.com/faker-ruby/faker/pull/3075
+* Remove inappropriate word from ja lorem by @se4weed in https://github.com/faker-ruby/faker/pull/3095
+* Add mountains to de-CH locale by @codez in https://github.com/faker-ruby/faker/pull/3066
+* Bump i18n from 1.14.6 to 1.14.7 by @dependabot in https://github.com/faker-ruby/faker/pull/3042
+
+### Chore
+* ci: run against Ruby 3.4 by @thdaraujo in https://github.com/faker-ruby/faker/pull/3079
+* Fix Broken CI by @wonderer007 in https://github.com/faker-ruby/faker/pull/3073
+
+### Update local dependencies
+* Bump rubocop from 1.67.0 to 1.68.0 by @dependabot in https://github.com/faker-ruby/faker/pull/3020
+* Bump rubocop from 1.68.0 to 1.69.2 by @dependabot in https://github.com/faker-ruby/faker/pull/3035
+* Bump rubocop version + offenses fixes by @stefannibrasil in https://github.com/faker-ruby/faker/pull/3053
+* deps: update dev dependencies by @thdaraujo in https://github.com/faker-ruby/faker/pull/3078
+* Bump rubocop-minitest and fix rubocop's offense by @stefannibrasil in https://github.com/faker-ruby/faker/pull/3052
+* Bump rubocop-minitest from 0.38.0 to 0.38.1 by @dependabot in https://github.com/faker-ruby/faker/pull/3088
+* Bump rubocop-rake from 0.6.0 to 0.7.1 by @dependabot in https://github.com/faker-ruby/faker/pull/3059
+* deps: bump `rubocop-minitest` from `0.37.1` to `0.38.0`. by @thdaraujo in https://github.com/faker-ruby/faker/pull/3080
+* Bump minitest from 5.25.1 to 5.25.4 by @dependabot in https://github.com/faker-ruby/faker/pull/3031
+* Bump test-unit from 3.6.2 to 3.6.7 by @dependabot in https://github.com/faker-ruby/faker/pull/3038
+* Bump benchmark from 0.3.0 to 0.4.0 by @dependabot in https://github.com/faker-ruby/faker/pull/3021
+* Bump benchmark from 0.4.0 to 0.4.1 by @dependabot in https://github.com/faker-ruby/faker/pull/3087
+* Bump pry from 0.14.2 to 0.15.2 by @dependabot in https://github.com/faker-ruby/faker/pull/3039
+* Bump rake from 13.2.1 to 13.3.0 by @dependabot in https://github.com/faker-ruby/faker/pull/3086
+* Bump test-unit from 3.6.8 to 3.6.9 by @dependabot in https://github.com/faker-ruby/faker/pull/3096
+
+### New Contributors
+* @brupla6126 made their first contribution in https://github.com/faker-ruby/faker/pull/3018
+* @jaredsmithse made their first contribution in https://github.com/faker-ruby/faker/pull/3049
+* @klaaspieter made their first contribution in https://github.com/faker-ruby/faker/pull/3050
+* @jethrodaniel made their first contribution in https://github.com/faker-ruby/faker/pull/3060
+* @daniel-nerdgeschoss made their first contribution in https://github.com/faker-ruby/faker/pull/3067
+* @bensheldon made their first contribution in https://github.com/faker-ruby/faker/pull/3075
+* @se4weed made their first contribution in https://github.com/faker-ruby/faker/pull/3095
+
+**Full Changelog**: https://github.com/faker-ruby/faker/compare/v3.5.1...v3.5.2
+
+---------------------------------
+
+## [v3.5.1](https://github.com/faker-ruby/faker/tree/v3.5.1) (2024-10-18)
+
+Happy October! 🎃
+
+This version **drops support for Ruby < 3.0**. We only support one EOL Ruby version at a time. Please upgrade to Ruby 3.0 to update to this and future versions of faker-ruby.
+
+Besides that, this version removes deprecated generators, fixes some bugs, and adds a Security Policy.
+
+Thanks to all contributors!
+
+### Breaking Changes
+* Drop support for Ruby 2.7 by @tatheerf02 in https://github.com/faker-ruby/faker/pull/3006
+* Removes deprecated generators by @stefannibrasil in https://github.com/faker-ruby/faker/pull/3014
+
+The following deprecated generators are being removed. Please use the new generators:
+
+
+| Deprecated                                          | New |
+| -------- | ------- |
+| Faker::TvShows::TheFreshPrinceOfBelAir.celebrity    | Faker::TvShows::TheFreshPrinceOfBelAir.actor        |
+| Faker::TvShows::Buffy.celebrity                     | Faker::TvShows::Buffy.actor                         |
+| Faker::TvShows::DrWho.villian                       | Faker::TvShows::DrWho.villain                       |
+| Faker::Games::HeroesOfTheStorm.class                | Faker::Games::HeroesOfTheStorm.class_name           |
+| Faker::JapaneseMedia::FmaBrotherhood                | Faker::JapaneseMedia::FullmetalAlchemistBrotherhood |
+| Faker::Show                                         | Faker::Theater                                      |
+| Faker::Australia                                    | Faker::Locations::Australia                         |
+| Faker::IDNumber                                     | Faker::IdNumber                                     |
+
+### Improvements & Bug fixes
+* Fix typos by @tagliala in https://github.com/faker-ruby/faker/pull/2982
+* Fix benchmark:all_methods task by excluding Faker::Deprecator module from benchmark target by @amatsuda in https://github.com/faker-ruby/faker/pull/2988
+* Add Brazilian Portuguese translations for `Faker::Subscription` by @murichristopher in https://github.com/faker-ruby/faker/pull/2960
+* Deprecator improvements by @stefannibrasil in https://github.com/faker-ruby/faker/pull/2997
+* Faker::Alphanumeric.alphanumeric determinism fix by @admtnnr in https://github.com/faker-ruby/faker/pull/2996
+* Remove CodeClimate badges by @tagliala in https://github.com/faker-ruby/faker/pull/3003
+* Update Company.logo example url by @dirschn in https://github.com/faker-ruby/faker/pull/3007
+* fix(music.band): removes leading whitespace by @JeremasPosta in https://github.com/faker-ruby/faker/pull/3015
+* Create SECURITY.md by @stefannibrasil in https://github.com/faker-ruby/faker/pull/3016
+
+### Update local dependencies
+* Bump i18n from 1.14.5 to 1.14.6 by @dependabot in https://github.com/faker-ruby/faker/pull/3005
+* Bump minitest from 5.24.1 to 5.25.0 by @dependabot in https://github.com/faker-ruby/faker/pull/2991
+* Bump rubocop-minitest from 0.35.1 to 0.36.0 by @dependabot in https://github.com/faker-ruby/faker/pull/2999
+* Bump yard from 0.9.36 to 0.9.37 by @dependabot in https://github.com/faker-ruby/faker/pull/3000
+* Bump rubocop from 1.65.1 to 1.66.1 by @dependabot in https://github.com/faker-ruby/faker/pull/3001
+
+### New Contributors
+* @murichristopher made their first contribution in https://github.com/faker-ruby/faker/pull/2960
+* @admtnnr made their first contribution in https://github.com/faker-ruby/faker/pull/2996
+* @dirschn made their first contribution in https://github.com/faker-ruby/faker/pull/3007
+* @tatheerf02 made their first contribution in https://github.com/faker-ruby/faker/pull/3006
+* @JeremasPosta made their first contribution in https://github.com/faker-ruby/faker/pull/3015
+
+**Full Changelog**: https://github.com/faker-ruby/faker/compare/v3.4.2...v3.5.1
+
+--------------------------------------
+
 ## [v3.4.2](https://github.com/faker-ruby/faker/tree/v3.4.2) (2024-07-16)
 
 Happy July with a new faker-ruby release.
@@ -36,7 +150,7 @@ Breaking change was introduced in "Add test range param to NHS numbers" by @nean
 * Bump rubocop from 1.64.1 to 1.65.0 by @dependabot in https://github.com/faker-ruby/faker/pull/2979
 * Bump rubocop-minitest from 0.35.0 to 0.35.1 by @dependabot in https://github.com/faker-ruby/faker/pull/2980
 
-## New Contributors
+### New Contributors
 * @twk-mn made their first contribution in https://github.com/faker-ruby/faker/pull/2961
 * @neanias made their first contribution in https://github.com/faker-ruby/faker/pull/2947
 * @garrettgregor made their first contribution in https://github.com/faker-ruby/faker/pull/2963
@@ -79,7 +193,7 @@ Breaking change was introduced in "Add test range param to NHS numbers" by @nean
 * Bump minitest from 5.22.3 to 5.23.1 by @dependabot in https://github.com/faker-ruby/faker/pull/2957
 * Bump rubocop from 1.63.4 to 1.64.0 by @dependabot in https://github.com/faker-ruby/faker/pull/2958
 
-## New Contributors
+### New Contributors
 
 * @connie-feng made their first contribution in https://github.com/faker-ruby/faker/pull/2930
 * @andrelaszlo made their first contribution in https://github.com/faker-ruby/faker/pull/2927
@@ -234,7 +348,7 @@ This version:
 * Bump rubocop from 1.57.1 to 1.57.2 by @dependabot in https://github.com/faker-ruby/faker/pull/2844
 * Bump timecop from 0.9.6 to 0.9.8 by @dependabot in https://github.com/faker-ruby/faker/pull/2811
 
-## New Contributors
+### New Contributors
 * @BelaBartok39 made their first contribution in https://github.com/faker-ruby/faker/pull/2812
 * @fernandomenolli made their first contribution in https://github.com/faker-ruby/faker/pull/2816
 * @hoshy made their first contribution in https://github.com/faker-ruby/faker/pull/2818
@@ -298,7 +412,7 @@ Other changes included in this version:
 * Update rubocop-minitest requirement from = 0.30.0 to = 0.31.0 by @dependabot in https://github.com/faker-ruby/faker/pull/2759
 * Bump minitest from 5.18.1 to 5.19.0 by @dependabot in https://github.com/faker-ruby/faker/pull/2804
 
-## New Contributors
+### New Contributors
 * @old-dead-account made their first contribution in https://github.com/faker-ruby/faker/pull/2742
 * @IvanReyesO7 made their first contribution in https://github.com/faker-ruby/faker/pull/2744
 * @DeepakRaj228 made their first contribution in https://github.com/faker-ruby/faker/pull/2741
@@ -365,7 +479,7 @@ Other changes included in this version:
 * Add Faker::Company.department generator by @acuppy in https://github.com/faker-ruby/faker/pull/2737
 * Update Pull Request template and guides by @stefannibrasil in https://github.com/faker-ruby/faker/pull/2749
 
-## New Contributors
+### New Contributors
 * @lexisvar made their first contribution in https://github.com/faker-ruby/faker/pull/2699
 * @danieldiekmeier made their first contribution in https://github.com/faker-ruby/faker/pull/2700
 * @AaronRustad made their first contribution in https://github.com/faker-ruby/faker/pull/2706
@@ -2549,7 +2663,7 @@ Fix lib/faker/version.rb
 - Fixed typo in dutch translation [\#679](https://github.com/stympy/faker/pull/679) ([nschmoller](https://github.com/nschmoller))
 - Add pokemon [\#677](https://github.com/stympy/faker/pull/677) ([bakunyo](https://github.com/bakunyo))
 - Food [\#672](https://github.com/stympy/faker/pull/672) ([martymclaugh](https://github.com/martymclaugh))
-- Added charcaters and houses data for game of thrones in en.yml [\#670](https://github.com/stympy/faker/pull/670) ([vamsipavanmahesh](https://github.com/vamsipavanmahesh))
+- Added characters and houses data for game of thrones in en.yml [\#670](https://github.com/stympy/faker/pull/670) ([vamsipavanmahesh](https://github.com/vamsipavanmahesh))
 - add Faker::Commerce.promotion\_code [\#669](https://github.com/stympy/faker/pull/669) ([jGRUBBS](https://github.com/jGRUBBS))
 - Eliminate and prevent leading and trailing white space [\#665](https://github.com/stympy/faker/pull/665) ([retroGiant89](https://github.com/retroGiant89))
 - Fix for memory overflow error Issue: \#478 [\#664](https://github.com/stympy/faker/pull/664) ([anuj-verma](https://github.com/anuj-verma))

data/README.md

@@ -4,8 +4,6 @@
 [![Tests](https://github.com/faker-ruby/faker/workflows/Tests/badge.svg)](https://github.com/faker-ruby/faker/actions?query=workflow%3ATests)
 [![Gem Version](https://badge.fury.io/rb/faker.svg)](https://badge.fury.io/rb/faker)
 [![Inline docs](https://inch-ci.org/github/faker-ruby/faker.svg?branch=main)](https://inch-ci.org/github/faker-ruby/faker)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/ef54c7f9df86e965d64b/test_coverage)](https://codeclimate.com/github/stympy/faker/test_coverage)
-[![Maintainability](https://api.codeclimate.com/v1/badges/ef54c7f9df86e965d64b/maintainability)](https://codeclimate.com/github/stympy/faker/maintainability)
 
 Faker is a port of [Perl's Data::Faker library](https://metacpan.org/pod/Data::Faker).
 It's a library for generating fake data such as names, addresses, and phone numbers.
@@ -40,7 +38,7 @@ and it was the original impetus for the creation of this gem.
     - [Notes](#notes)
   - [Getting Started](#getting-started)
   - [Usage](#usage)
-      - [A note about the Generators versions](#a-note-about-the-generators-versions)
+    - [A note about the Generators versions](#a-note-about-the-generators-versions)
     - [Ensuring unique values](#ensuring-unique-values)
     - [Deterministic Random](#deterministic-random)
     - [Customization](#customization)
@@ -91,7 +89,7 @@ Faker::ProgrammingLanguage.name #=> "Ruby"
 
 For a complete list of the generators, see [Generators](#generators).
 
-#### A note about the Generators versions
+### A note about the Generators versions
 
 If you get a `uninitialized constant Faker::[some_class]` error, your version of
 the gem is behind main.

data/lib/faker/default/alphanumeric.rb

@@ -60,7 +60,7 @@ module Faker
         randoms = Array.new(random_count) { sample(ALPHANUMS) }
 
         combined = alphas + numbers + randoms
-        combined.shuffle.join
+        shuffle!(combined).join
       end
     end
   end

data/lib/faker/default/code.rb

@@ -168,6 +168,7 @@ module Faker
 
       # Reporting body identifier
       RBI = %w[01 10 30 33 35 44 45 49 50 51 52 53 54 86 91 98 99].freeze
+      private_constant :RBI
 
       def generate_imei
         str = Array.new(15, 0)
@@ -269,7 +270,10 @@ module Faker
       end
 
       EAN_CHECK_DIGIT8 = [3, 1, 3, 1, 3, 1, 3].freeze
+      private_constant :EAN_CHECK_DIGIT8
+
       EAN_CHECK_DIGIT13 = [1, 3, 1, 3, 1, 3, 1, 3, 1, 3, 1, 3].freeze
+      private_constant :EAN_CHECK_DIGIT13
 
       def rut_verificator_digit(rut)
         total = rut.to_s.rjust(8, '0').chars.zip(%w[3 2 7 6 5 4 3 2]).collect { |a, b| a.to_i * b.to_i }.inject(:+)

data/lib/faker/default/company.rb

@@ -494,7 +494,7 @@ module Faker
           # Construct taxpayer number
           gen.group(name: :taxpayer_number) do |g_|
             g_.letter(length: 3, ranges: ['A'..'Z'])
-            g_.letter(length: 1, ranges: [%w[A B C F G H L J P T K]].to_a)
+            g_.letter(length: 1, ranges: [%w[A B C F G H L J P T K]])
             g_.letter(length: 1, ranges: ['A'..'Z'])
             g_.int(length: 4, ranges: [0..9999])
             g_.letter(length: 1, ranges: ['A'..'Z'])

data/lib/faker/default/driving_licence.rb

@@ -104,7 +104,7 @@ module Faker
           end
           g.computed do
             gender_marker = gender == :female ? 50 : 0
-            format('%02d', (dob.month + gender_marker))
+            format('%02d', dob.month + gender_marker)
           end
           g.computed do
             format('%02d', dob.day)

data/lib/faker/default/finance.rb

@@ -97,11 +97,11 @@ module Faker
       ##
       # Returns a random condominium fiscal code.
       #
-      # @param country [String] Two capital letter country code to use for the vat number.
+      # @param country [String] Two capital letter country code to use for the condominium fiscal code number.
       # @return [String]
       #
       # @example
-      #   Faker::Finance.condominium_fiscal_code #=> "012345678"
+      #   Faker::Finance.condominium_fiscal_code #=> "01234567890"
       #
       # @faker.version next
       def condominium_fiscal_code(country: 'IT')

data/lib/faker/default/id_number.rb

@@ -12,7 +12,7 @@ module Faker
     ].freeze
     ZA_RACE_DIGIT = '8'
     ZA_CITIZENSHIP_DIGITS = %w[0 1].freeze
-    BRAZILIAN_ID_FORMAT = /(\d{1,2})(\d{3})(\d{3})([\dX])/.freeze
+    BRAZILIAN_ID_FORMAT = /(\d{1,2})(\d{3})(\d{3})([\dX])/
     BRAZILIAN_ID_FROM = 10_000_000
     BRAZILIAN_ID_TO = 99_999_999
 
@@ -421,7 +421,4 @@ module Faker
       end
     end
   end
-
-  include Faker::Deprecator
-  deprecate_generator('IDNumber', IdNumber)
 end

data/lib/faker/default/internet.rb

@@ -267,7 +267,7 @@ module Faker
       #   Faker::Internet.mac_address(prefix: 'aa:44')  #=> "aa:44:30:88:6e:95"
       def mac_address(prefix: '')
         prefix_digits = prefix.split(':').map { |d| d.to_i(16) }
-        address_digits = Array.new((6 - prefix_digits.size)) { rand(256) }
+        address_digits = Array.new(6 - prefix_digits.size) { rand(256) }
         (prefix_digits + address_digits).map { |d| format('%02x', d) }.join(':')
       end
 

data/lib/faker/default/invoice.rb

@@ -13,8 +13,8 @@ module Faker
       # @return [Integer]
       #
       # @example
-      #   Faker::Finance.amount_between #=> 0
-      #   Faker::Finance.amount_between(0, 10) #=> 4.33
+      #   Faker::Invoice.amount_between #=> 0
+      #   Faker::Invoice.amount_between(from: 0, to: 10) #=> 4.33
       #
       # @faker.version 1.9.0
       def amount_between(from: 0, to: 0)
@@ -22,7 +22,7 @@ module Faker
       end
 
       ##
-      # Produces a random valid reference accoring to the International bank slip reference https://en.wikipedia.org/wiki/Creditor_Reference
+      # Produces a random valid reference according to the International bank slip reference https://en.wikipedia.org/wiki/Creditor_Reference
       #
       # @param ref [String] Specifies reference base.
       # @return [String]

data/lib/faker/default/json.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Json < Base
     require 'json'
@@ -104,17 +106,20 @@ module Faker
       end
 
       def add_hash(key_array, hash, width, options)
-        string_to_eval = 'hash'
+        string_to_eval = 'hash'.dup
+
         key_array.length.times do |index|
           string_to_eval << "['#{key_array[index]}']"
         end
         string_to_eval << " = #{build_shallow_hash(width, options)}"
         eval(string_to_eval)
+
         hash
       end
 
       def build_keys_from_array(key_array)
-        key_string = ''
+        key_string = ''.dup
+
         key_array.each do |value|
           key_string << "['#{value}']"
         end

data/lib/faker/default/national_health_service.rb

@@ -20,8 +20,7 @@ module Faker
         # If the check digit is equivalent to 10, the number is invalid.
         # See https://en.wikipedia.org/wiki/NHS_number
         base_number -= 1 if check_digit(number: base_number) == 10
-        "#{base_number}#{check_digit(number: base_number)}".to_s
-                                                           .chars
+        "#{base_number}#{check_digit(number: base_number)}".chars
                                                            .insert(3, ' ')
                                                            .insert(7, ' ')
                                                            .join

data/lib/faker/default/placeholdit.rb

@@ -45,7 +45,7 @@ module Faker
       private
 
       def generate_color
-        format('%06x', (rand * 0xffffff))
+        format('%06x', rand * 0xffffff)
       end
     end
   end

data/lib/faker/default/theater.rb

@@ -46,7 +46,4 @@ module Faker
       end
     end
   end
-
-  include Faker::Deprecator
-  deprecate_generator('Show', Theater)
 end

data/lib/faker/games/heroes_of_the_storm.rb

@@ -17,17 +17,6 @@ module Faker
           fetch('heroes_of_the_storm.battlegrounds')
         end
 
-        ##
-        # This method is deprecated. The implementation will be removed in a near future release.
-        # Use `HeroesOfTheStorm.class_name` instead.
-        #
-        # @deprecated Use {#class_name} instead.
-        def class
-          warn '`HeroesOfTheStorm.class` is deprecated. Use `HeroesOfTheStorm.class_name` instead.'
-
-          super
-        end
-
         ##
         # Produces a class name from Heroes of the Storm.
         #

data/lib/faker/japanese_media/fullmetal_alchemist_brotherhood.rb

@@ -44,8 +44,5 @@ module Faker
         end
       end
     end
-
-    include Faker::Deprecator
-    deprecate_generator('FmaBrotherhood', FullmetalAlchemistBrotherhood)
   end
 end

data/lib/faker/locations/australia.rb

@@ -46,7 +46,4 @@ module Faker
       end
     end
   end
-
-  include Deprecator
-  deprecate_generator('Australia', Locations::Australia)
 end

data/lib/faker/movies/star_wars.rb

@@ -204,7 +204,7 @@ module Faker
         # @example
         #   Faker::Movies::StarWars.droids
         #
-        # @faker.versionn 1.6.2
+        # @faker.version 1.6.2
         def droids
           fetch_all('star_wars.droids')
         end

data/lib/faker/tv_shows/buffy.rb

@@ -45,19 +45,6 @@ module Faker
           fetch('buffy.actors')
         end
 
-        ##
-        # Produces a actor from Buffy the Vampire Slayer.
-        #
-        # @return [String]
-        #
-        # @example
-        #   Faker::TvShows::Buffy.celebrity #=> "John Ritter"
-        #
-        # @deprecated Use the `actor` method instead.
-        #
-        # @faker.version 1.9.2
-        alias celebrity actor
-
         ##
         # Produces a big bad from Buffy the Vampire Slayer.
         #

data/lib/faker/tv_shows/dr_who.rb

@@ -84,19 +84,6 @@ module Faker
           fetch('dr_who.villains')
         end
 
-        ##
-        # Produces a villain from Doctor Who.
-        #
-        # @return [String]
-        #
-        # @example
-        #   Faker::TvShows::DrWho.villian #=> "The Master"
-        #
-        # @deprecated Use the correctly-spelled `villain` method instead.
-        #
-        # @faker.version 1.8.0
-        alias villian villain
-
         ##
         # Produces a species from Doctor Who.
         #

data/lib/faker/tv_shows/the_fresh_prince_of_bel_air.rb

@@ -32,19 +32,6 @@ module Faker
           fetch('the_fresh_prince_of_bel_air.actors')
         end
 
-        ##
-        # Produces a actor from The Fresh Prince of Bel-Air.
-        #
-        # @return [String]
-        #
-        # @example
-        #   Faker::TvShows::TheFreshPrinceOfBelAir.celebrity #=> "Quincy Jones"
-        #
-        # @deprecated Use the `actor` method instead.
-        #
-        # @faker.version 1.8.3
-        alias celebrity actor
-
         ##
         # Produces a quote from The Fresh Prince of Bel-Air.
         #

data/lib/faker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Faker # :nodoc:
-  VERSION = '3.4.2'
+  VERSION = '3.5.2'
 end

data/lib/faker.rb

@@ -5,7 +5,7 @@ mydir = __dir__
 require 'psych'
 require 'i18n'
 
-Dir.glob(File.join(mydir, 'helpers', '*.rb')).sort.each { |file| require file }
+Dir.glob(File.join(mydir, 'helpers', '*.rb')).each { |file| require file }
 
 I18n.load_path += Dir[File.join(mydir, 'locales', '**/*.yml')]
 
@@ -107,7 +107,7 @@ module Faker
       # with an array of values and selecting one of them.
       def fetch(key)
         fetched = sample(translate("faker.#{key}"))
-        if fetched&.match(%r{^/}) && fetched&.match(%r{/$}) # A regex
+        if fetched&.match(%r{^/}) && fetched.match(%r{/$}) # A regex
           regexify(fetched)
         else
           fetched
@@ -249,6 +249,10 @@ module Faker
         list.shuffle(random: Faker::Config.random)
       end
 
+      def shuffle!(list)
+        list.shuffle!(random: Faker::Config.random)
+      end
+
       def rand(max = nil)
         if max.nil?
           Faker::Config.random.rand
@@ -271,4 +275,4 @@ module Faker
 end
 
 # require faker objects
-Dir.glob(File.join(mydir, 'faker', '/**/*.rb')).sort.each { |file| require file }
+Dir.glob(File.join(mydir, 'faker', '/**/*.rb')).each { |file| require file }

data/lib/helpers/deprecator.rb

@@ -1,17 +1,70 @@
 # frozen_string_literal: true
 
 # Based on Rails ActiveSupport Deprecator
-# https://github.com/rails/rails/blob/6f0d1ad14b92b9f5906e44740fce8b4f1c7075dc/activesupport/lib/active_support/deprecation/constant_accessor.rb
+# https://github.com/rails/rails/blob/main/activesupport/lib/active_support/deprecation/constant_accessor.rb
 
 # rubocop:disable Style/ClassVars
 module Faker
+  # Provides a way to rename generators, including their namespaces, with a deprecation cycle in which
+  # both the old and new names work, but using the old one prints a deprecation message.
+  #
+  # Deprecator provides a deprecate_generator method to be used when
+  # renaming a generator. For example, let's say we want to change the following Generator's
+  # name to <tt>Faker::NewGenerator</tt>:
+  #
+  #   module Faker
+  #     class Generator
+  #       def self.generate
+  #         "be kind"
+  #       end
+  #     end
+  #   end
+  #
+  # To rename it, you need to do the update the name and declare the deprecation by
+  # including the <tt>Deprecator</tt> module and using the deprecate_generator method:
+  #
+  #   module Faker
+  #     class NewGenerator
+  #       def self.generate
+  #         "be kind"
+  #       end
+  #     end
+  #
+  #     include Deprecator
+  #     deprecate_generator('DeprecatedGenerator', NewGenerator)
+  #   end
+  #
+  # The first argument is a constant name (no colons) as a string. It is the name of
+  # the constant you want to deprecate.
+  #
+  # The second argument is the constant path of the replacement (no colons) as a constant.
+  #
+  # For this to work, a +const_missing+ hook is installed. When users
+  # reference the deprecated constant, the callback prints the
+  # message and constantizes the replacement.
+  #
+  # With that in place, references to <tt>Faker::Deprecator</tt> still work, they
+  # evaluate to <tt>Faker::NewGenerator</tt> now, and trigger a deprecation warning:
+  #
+  #   Faker::Generator.generate
+  #   # DEPRECATION WARNING: Faker::Generator is deprecated. Use Faker::NewGenerator instead
+  #   # "be kind"
+  #
+  # For testing the deprecations, we provide <tt>assert_deprecated</tt>
+  # and <tt>assert_not_deprecated</tt> matchers.
+  #
+  # There's also a <tt>Faker::Deprecator.skip_warning</tt> helper to silence
+  # the deprecation messages in the *test* output. Use it for generators that have lots of tests
+  # to avoid too many noise when running the tests.
   module Deprecator
     def self.included(base)
       extension = Module.new do
         def const_missing(missing_const_name)
           if class_variable_defined?(:@@_deprecated_constants) && (replacement = class_variable_get(:@@_deprecated_constants)[missing_const_name.to_s])
             unless Faker::Deprecator.skip_warning?
-              $stdout.puts("DEPRECATION WARNING: #{name}::#{replacement[:old_generator]} is deprecated. Use #{replacement[:new_constant]} instead.")
+              deprecated_message = "#{name}::#{replacement[:old_generator]} is deprecated."
+              replacement_message = "Use #{replacement[:new_constant]} instead."
+              $stdout.puts("DEPRECATION WARNING: #{deprecated_message} #{replacement_message}")
             end
 
             return replacement[:new_constant]
@@ -22,13 +75,25 @@ module Faker
 
         def deprecate_generator(old_generator_name, new_generator_constant)
           class_variable_set(:@@_deprecated_constants, {}) unless class_variable_defined?(:@@_deprecated_constants)
-          class_variable_get(:@@_deprecated_constants)[old_generator_name] = { new_constant: new_generator_constant, old_generator: old_generator_name }
+          class_variable_get(:@@_deprecated_constants)[old_generator_name] = {
+            new_constant: new_generator_constant,
+            old_generator: old_generator_name
+          }
         end
       end
 
       base.singleton_class.prepend extension
     end
 
+    # Silence deprecation warnings within the block.
+    #
+    #   Faker::Generator.generate
+    #   # => DEPRECATION WARNING: Faker::Generator is deprecated. Use Faker::NewGenerator instead.
+    #
+    #   Faker::Deprecator.skip_warning do
+    #     Faker::Generator.generate
+    #   end
+    #   # => nil
     def self.skip_warning
       original = Faker::Deprecator.skip
       Faker::Deprecator.skip = true
@@ -38,7 +103,7 @@ module Faker
     end
 
     def self.skip_warning?
-      skip == true
+      @skip == true
     end
 
     def self.skip