faker 3.2.3 → 3.3.0

data/lib/faker/default/south_africa.rb

@@ -13,7 +13,7 @@ module Faker
       #
       # @faker.version 1.9.2
       def id_number
-        Faker::IDNumber.south_african_id_number
+        Faker::IdNumber.south_african_id_number
       end
 
       ##
@@ -26,7 +26,7 @@ module Faker
       #
       # @faker.version 1.9.2
       def valid_id_number
-        Faker::IDNumber.valid_south_african_id_number
+        Faker::IdNumber.valid_south_african_id_number
       end
 
       ##
@@ -39,7 +39,7 @@ module Faker
       #
       # @faker.version 1.9.2
       def invalid_id_number
-        Faker::IDNumber.invalid_south_african_id_number
+        Faker::IdNumber.invalid_south_african_id_number
       end
 
       ##

data/lib/faker/japanese_media/fullmetal_alchemist_brotherhood.rb

@@ -2,47 +2,50 @@
 
 module Faker
   class JapaneseMedia
-    class FmaBrotherhood < Base
+    class FullmetalAlchemistBrotherhood < Base
       class << self
         ##
-        # Produces a character from FmaBrotherhood.
+        # Produces a character from FullmetalAlchemistBrotherhood.
         #
         # @return [String]
         #
         # @example
-        #   Faker::JapaneseMedia::FmaBrotherhood.character #=> "Edward Elric"
+        #   Faker::JapaneseMedia::FullmetalAlchemistBrotherhood.character #=> "Edward Elric"
         #
         # @faker.version next
         def character
-          fetch('fma_brotherhood.characters')
+          fetch('fullmetal_alchemist_brotherhood.characters')
         end
 
         ##
-        # Produces a cities from FmaBrotherhood.
+        # Produces a cities from FullmetalAlchemistBrotherhood.
         #
         # @return [String]
         #
         # @example
-        #   Faker::JapaneseMedia::FmaBrotherhood.city #=> "Central City"
+        #   Faker::JapaneseMedia::FullmetalAlchemistBrotherhood.city #=> "Central City"
         #
         # @faker.version next
         def city
-          fetch('fma_brotherhood.cities')
+          fetch('fullmetal_alchemist_brotherhood.cities')
         end
 
         ##
-        # Produces a country from FmaBrotherhood.
+        # Produces a country from FullmetalAlchemistBrotherhood.
         #
         # @return [String]
         #
         # @example
-        #   Faker::JapaneseMedia::FmaBrotherhood.country #=> "Xing"
+        #   Faker::JapaneseMedia::FullmetalAlchemistBrotherhood.country #=> "Xing"
         #
         # @faker.version next
         def country
-          fetch('fma_brotherhood.countries')
+          fetch('fullmetal_alchemist_brotherhood.countries')
         end
       end
     end
+
+    include Faker::Deprecator
+    deprecate_generator('FmaBrotherhood', FullmetalAlchemistBrotherhood)
   end
 end

data/lib/faker/locations/australia.rb

@@ -1,47 +1,52 @@
 # frozen_string_literal: true
 
 module Faker
-  class Australia < Base
-    class << self
-      ##
-      # Produces a location in Australia
-      #
-      # @return [String]
-      #
-      # @example
-      #   Faker::Australia.location
-      #    #=> "Sydney"
-      #
-      # @faker.version next
-      def location
-        fetch('australia.locations')
-      end
+  extend Deprecator
 
-      # Produces an Australian animal
-      #
-      # @return [String]
-      #
-      # @example
-      #   Faker::Australia.animal
-      #    #=> "Dingo"
-      #
-      # @faker.version next
-      def animal
-        fetch('australia.animals')
-      end
+  class Locations
+    class Australia < Base
+      class << self
+        ##
+        # Produces a location in Australia
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Locations::Australia.location
+        #    #=> "Sydney"
+        #
+        # @faker.version next
+        def location
+          fetch('locations.australia.locations')
+        end
+
+        # Produces an Australian animal
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Locations::Australia.animal
+        #    #=> "Dingo"
+        #
+        # @faker.version next
+        def animal
+          fetch('locations.australia.animals')
+        end
 
-      # Produces an Australian State or Territory
-      #
-      # @return [String]
-      #
-      # @example
-      #   Faker::Australia.state
-      #    #=> "New South Wales"
-      #
-      # @faker.version next
-      def state
-        fetch('australia.states')
+        # Produces an Australian State or Territory
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Locations::Australia.state
+        #    #=> "New South Wales"
+        #
+        # @faker.version next
+        def state
+          fetch('locations.australia.states')
+        end
       end
     end
   end
+  deprecate_generator('Australia', Locations::Australia)
 end

data/lib/faker/movies/{room.rb → the_room.rb}

@@ -14,7 +14,7 @@ module Faker
         #
         # @faker.version next
         def actor
-          fetch('room.actors')
+          fetch('the_room.actors')
         end
 
         ##
@@ -27,7 +27,7 @@ module Faker
         #
         # @faker.version next
         def character
-          fetch('room.characters')
+          fetch('the_room.characters')
         end
 
         ##
@@ -40,7 +40,7 @@ module Faker
         #
         # @faker.version next
         def location
-          fetch('room.locations')
+          fetch('the_room.locations')
         end
 
         ##
@@ -55,7 +55,7 @@ module Faker
         #
         # @faker.version next
         def quote
-          fetch('room.quotes')
+          fetch('the_room.quotes')
         end
       end
     end

data/lib/faker/music/smashing_pumpkins.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+require_relative 'music'
+
+module Faker
+  class Music
+    class SmashingPumpkins < Base
+      class << self
+        ##
+        # Produces the name of a member of the Smashing Pumpkins (current and former)
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Music::SmashingPumpkins.musician #=> "Billy Corgan"
+        #
+        # @faker.version next
+        def musician
+          fetch('smashing_pumpkins.musicians')
+        end
+
+        ##
+        # Produces the name of an album by the Smashing Pumpkins.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Music::SmashingPumpkins.album #=> "Siamese Dream"
+        #
+        # @faker.version next
+        def album
+          fetch('smashing_pumpkins.albums')
+        end
+
+        ##
+        # Produces a random Smashing Pumpkins song lyric.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Music::SmashingPumpkins.lyric #=> "Despite all my rage, I am still just a rat in a cage"
+        #   Faker::Music::SmashingPumpkins.lyric #=> "Breathin' underwater, and livin' under glass"
+        #
+        # @faker.version next
+        def lyric
+          fetch('smashing_pumpkins.lyric')
+        end
+
+        ##
+        # Produces the name of a song by the Smashing Pumpkins.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Music::SmashingPumpkins.song #=> "Stand Inside My Love"
+        #
+        # @faker.version next
+        def song
+          fetch('smashing_pumpkins.songs')
+        end
+      end
+    end
+  end
+end

data/lib/faker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Faker # :nodoc:
-  VERSION = '3.2.3'
+  VERSION = '3.3.0'
 end

data/lib/helpers/deprecator.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+# Based on Rails ActiveSupport Deprecator
+# https://github.com/rails/rails/blob/6f0d1ad14b92b9f5906e44740fce8b4f1c7075dc/activesupport/lib/active_support/deprecation/constant_accessor.rb
+
+# rubocop:disable Style/ClassVars
+module Faker
+  module Deprecator
+    def self.included(base)
+      extension = Module.new do
+        def const_missing(missing_const_name)
+          if class_variable_defined?(:@@_deprecated_constants) && (replacement = class_variable_get(:@@_deprecated_constants)[missing_const_name.to_s])
+            $stdout.puts("DEPRECATION WARNING: #{name}::#{replacement[:old_generator]} is deprecated. Use #{replacement[:new_constant]} instead.")
+            return replacement[:new_constant]
+          end
+
+          super
+        end
+
+        def deprecate_generator(old_generator_name, new_generator_constant)
+          class_variable_set(:@@_deprecated_constants, {}) unless class_variable_defined?(:@@_deprecated_constants)
+          class_variable_get(:@@_deprecated_constants)[old_generator_name] = { new_constant: new_generator_constant, old_generator: old_generator_name }
+        end
+      end
+
+      base.singleton_class.prepend extension
+    end
+  end
+end
+# rubocop:enable Style/ClassVars

data/lib/locales/bg.yml

@@ -17,7 +17,6 @@ bg:
       default_country: [България]
       default_country_code: ["BG"]
     internet:
-      free_email: [abv.bg, mail.bg, dir.bg, gmail.com, yahoo.com, hotmail.com]
       domain_suffix: [com, bg, info, бг, net, org]
 
     name: