faker 2.2.0 → 2.5.0

data/lib/faker/default/types.rb

@@ -8,9 +8,8 @@ module Faker
 
     class << self
       def rb_string(legacy_words = NOT_GIVEN, words: 1)
-        if legacy_words != NOT_GIVEN
-          warn_with_uplevel 'Passing `words` with the 1st argument of `Types.rb_string` is deprecated. Use keyword argument like `Types.rb_string(words: ...)` instead.', uplevel: 1
-          words = legacy_words
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :words if legacy_words != NOT_GIVEN
         end
 
         resolved_num = resolve(words)
@@ -26,26 +25,18 @@ module Faker
       end
 
       def rb_integer(legacy_from = NOT_GIVEN, legacy_to = NOT_GIVEN, from: 0, to: 100)
-        if legacy_from != NOT_GIVEN
-          warn_with_uplevel 'Passing `from` with the 1st argument of `Types.rb_integer` is deprecated. Use keyword argument like `Types.rb_integer(from: ...)` instead.', uplevel: 1
-          from = legacy_from
-        end
-        if legacy_to != NOT_GIVEN
-          warn_with_uplevel 'Passing `to` with the 2nd argument of `Types.rb_integer` is deprecated. Use keyword argument like `Types.rb_integer(to: ...)` instead.', uplevel: 1
-          to = legacy_to
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :from if legacy_from != NOT_GIVEN
+          keywords << :to if legacy_to != NOT_GIVEN
         end
 
         rand(from..to).to_i
       end
 
       def rb_hash(legacy_number = NOT_GIVEN, legacy_type = NOT_GIVEN, number: 1, type: random_type)
-        if legacy_number != NOT_GIVEN
-          warn_with_uplevel 'Passing `number` with the 1st argument of `Types.rb_hash` is deprecated. Use keyword argument like `Types.rb_hash(number: ...)` instead.', uplevel: 1
-          number = legacy_number
-        end
-        if legacy_type != NOT_GIVEN
-          warn_with_uplevel 'Passing `type` with the 2nd argument of `Types.rb_hash` is deprecated. Use keyword argument like `Types.rb_hash(type: ...)` instead.', uplevel: 1
-          type = legacy_type
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :number if legacy_number != NOT_GIVEN
+          keywords << :type if legacy_type != NOT_GIVEN
         end
 
         {}.tap do |hsh|
@@ -56,18 +47,16 @@ module Faker
       end
 
       def complex_rb_hash(legacy_number = NOT_GIVEN, number: 1)
-        if legacy_number != NOT_GIVEN
-          warn_with_uplevel 'Passing `number` with the 1st argument of `Types.complex_rb_hash` is deprecated. Use keyword argument like `Types.complex_rb_hash(number: ...)` instead.', uplevel: 1
-          number = legacy_number
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :number if legacy_number != NOT_GIVEN
         end
 
         rb_hash(number: number, type: random_complex_type)
       end
 
       def rb_array(legacy_len = NOT_GIVEN, len: 1)
-        if legacy_len != NOT_GIVEN
-          warn_with_uplevel 'Passing `len` with the 1st argument of `Types.rb_array` is deprecated. Use keyword argument like `Types.rb_array(len: ...)` instead.', uplevel: 1
-          len = legacy_len
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :len if legacy_len != NOT_GIVEN
         end
 
         [].tap do |ar|

data/lib/faker/default/vehicle.rb

@@ -9,7 +9,7 @@ module Faker
     VIN_LETTERS = 'ABCDEFGHJKLMNPRSTUVWXYZ'
     VIN_MAP = '0123456789X'
     VIN_WEIGHTS = '8765432X098765432'
-    VIN_REGEX = /^[A-Z0-9]{3}[A-Z0-9]{5}[A-Z0-9]{1}[A-Z0-9]{1}[A-Z0-0]{1}[A-Z0-9]{1}\d{5}$/
+    VIN_REGEX = /^[A-Z0-9]{3}[A-Z0-9]{5}[A-Z0-9]{1}[A-Z0-9]{1}[A-Z0-0]{1}[A-Z0-9]{1}\d{5}$/.freeze
     SG_CHECKSUM_WEIGHTS = [3, 14, 2, 12, 2, 11, 1].freeze
     SG_CHECKSUM_CHARS = 'AYUSPLJGDBZXTRMKHEC'
 
@@ -27,9 +27,8 @@ module Faker
       end
 
       def model(legacy_make_of_model = NOT_GIVEN, make_of_model: '')
-        if legacy_make_of_model != NOT_GIVEN
-          warn_with_uplevel 'Passing `make_of_model` with the 1st argument of `Vehicle.model` is deprecated. Use keyword argument like `Vehicle.model(make_of_model: ...)` instead.', uplevel: 1
-          make_of_model = legacy_make_of_model
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :make_of_model if legacy_make_of_model != NOT_GIVEN
         end
 
         return fetch("vehicle.models_by_make.#{make}") if make_of_model.empty?
@@ -91,13 +90,9 @@ module Faker
       end
 
       def mileage(legacy_min = NOT_GIVEN, legacy_max = NOT_GIVEN, min: MILEAGE_MIN, max: MILEAGE_MAX)
-        if legacy_min != NOT_GIVEN
-          warn_with_uplevel 'Passing `min` with the 1st argument of `Vehicle.mileage` is deprecated. Use keyword argument like `Vehicle.mileage(min: ...)` instead.', uplevel: 1
-          min = legacy_min
-        end
-        if legacy_max != NOT_GIVEN
-          warn_with_uplevel 'Passing `max` with the 2nd argument of `Vehicle.mileage` is deprecated. Use keyword argument like `Vehicle.mileage(max: ...)` instead.', uplevel: 1
-          max = legacy_max
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :min if legacy_min != NOT_GIVEN
+          keywords << :max if legacy_max != NOT_GIVEN
         end
 
         rand_in_range(min, max)
@@ -106,9 +101,8 @@ module Faker
       alias kilometrage mileage
 
       def license_plate(legacy_state_abreviation = NOT_GIVEN, state_abreviation: '')
-        if legacy_state_abreviation != NOT_GIVEN
-          warn_with_uplevel 'Passing `state_abreviation` with the 1st argument of `Vehicle.license_plate` is deprecated. Use keyword argument like `Vehicle.license_plate(state_abreviation: ...)` instead.', uplevel: 1
-          state_abreviation = legacy_state_abreviation
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :state_abreviation if legacy_state_abreviation != NOT_GIVEN
         end
 
         return regexify(bothify(fetch('vehicle.license_plate'))) if state_abreviation.empty?

data/lib/faker/default/world_cup.rb

@@ -16,22 +16,17 @@ module Faker
       end
 
       def group(legacy_group = NOT_GIVEN, group: 'group_A')
-        if legacy_group != NOT_GIVEN
-          warn_with_uplevel 'Passing `group` with the 1st argument of `WorldCup.group` is deprecated. Use keyword argument like `WorldCup.group(group: ...)` instead.', uplevel: 1
-          group = legacy_group
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :group if legacy_group != NOT_GIVEN
         end
 
         fetch("world_cup.groups.#{group}")
       end
 
       def roster(legacy_country = NOT_GIVEN, legacy_type = NOT_GIVEN, country: 'Egypt', type: 'coach')
-        if legacy_country != NOT_GIVEN
-          warn_with_uplevel 'Passing `country` with the 1st argument of `WorldCup.roster` is deprecated. Use keyword argument like `WorldCup.roster(country: ...)` instead.', uplevel: 1
-          country = legacy_country
-        end
-        if legacy_type != NOT_GIVEN
-          warn_with_uplevel 'Passing `type` with the 2nd argument of `WorldCup.roster` is deprecated. Use keyword argument like `WorldCup.roster(type: ...)` instead.', uplevel: 1
-          type = legacy_type
+        warn_for_deprecated_arguments do |keywords|
+          keywords << :country if legacy_country != NOT_GIVEN
+          keywords << :type if legacy_type != NOT_GIVEN
         end
 
         fetch("world_cup.rosters.#{country}.#{type}")

data/lib/faker/games/dota.rb

@@ -4,26 +4,72 @@ module Faker
   class Games
     class Dota < Base
       class << self
+        ##
+        # Produces the name of a hero from Dota.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::Dota.hero #=> "Abaddon"
+        #
+        # @faker.version 1.9.0
         def hero
           fetch('games.dota.hero')
         end
 
+        ##
+        # Produces the name of an item from Dota.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::Dota.item #=> "Armlet of Mordiggian"
+        #
+        # @faker.version 1.9.0
         def item
           fetch('games.dota.item')
         end
 
+        ##
+        # Produces the name of a professional Dota team.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::Dota.team #=> "Evil Geniuses"
+        #
+        # @faker.version 1.9.0
         def team
           fetch('games.dota.team')
         end
 
+        ##
+        # Produces the name of a professional Dota player.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::Dota.player #=> "Dendi"
+        #
+        # @faker.version 1.9.0
         def player
           fetch('games.dota.player')
         end
 
+        ##
+        # Produces the name of a hero from Dota.
+        #
+        # @param hero [String] The name of a Dota hero.
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::Dota.quote #=> "You have called death upon yourself."
+        #   Faker::Games::Dota.quote(hero: 'alchemist') #=> "Better living through alchemy!"
+        #
+        # @faker.version 1.9.0
         def quote(legacy_hero = NOT_GIVEN, hero: 'abaddon')
-          if legacy_hero != NOT_GIVEN
-            warn_with_uplevel 'Passing `hero` with the 1st argument of `Dota.quote` is deprecated. Use keyword argument like `Dota.quote(hero: ...)` instead.', uplevel: 1
-            hero = legacy_hero
+          warn_for_deprecated_arguments do |keywords|
+            keywords << :hero if legacy_hero != NOT_GIVEN
           end
 
           fetch("games.dota.#{hero}.quote")

data/lib/faker/games/elder_scrolls.rb

@@ -4,34 +4,106 @@ module Faker
   class Games
     class ElderScrolls < Base
       class << self
+        ##
+        # Produces the name of a race from the Elder Scrolls universe.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::ElderScrolls.race #=> "Argonian"
+        #
+        # @faker.version 1.9.2
         def race
           fetch('games.elder_scrolls.race')
         end
 
+        ##
+        # Produces the name of a city from the Elder Scrolls universe.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::ElderScrolls.city #=> "Whiterun"
+        #
+        # @faker.version 1.9.2
         def city
           fetch('games.elder_scrolls.city')
         end
 
+        ##
+        # Produces the name of a creature from the Elder Scrolls universe.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::ElderScrolls.creature #=> "Frost Troll"
+        #
+        # @faker.version 1.9.2
         def creature
           fetch('games.elder_scrolls.creature')
         end
 
+        ##
+        # Produces the name of a region from the Elder Scrolls universe.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::ElderScrolls.region #=> "Cyrodiil"
+        #
+        # @faker.version 1.9.2
         def region
           fetch('games.elder_scrolls.region')
         end
 
+        ##
+        # Produces the name of a dragon from the Elder Scrolls universe.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::ElderScrolls.dragon #=> "Blood Dragon"
+        #
+        # @faker.version 1.9.2
         def dragon
           fetch('games.elder_scrolls.dragon')
         end
 
+        ##
+        # Produces a randomly generated name from the Elder Scrolls universe.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::ElderScrolls.name #=> "Balgruuf The Old"
+        #
+        # @faker.version 1.9.2
         def name
           "#{fetch('games.elder_scrolls.first_name')} #{fetch('games.elder_scrolls.last_name')}"
         end
 
+        ##
+        # Produces a first name from the Elder Scrolls universe.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::ElderScrolls.first_name #=> "Balgruuf"
+        #
+        # @faker.version 1.9.2
         def first_name
           fetch('games.elder_scrolls.first_name')
         end
 
+        ##
+        # Produces a last name from the Elder Scrolls universe.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::ElderScrolls.last_name #=> "The Old"
+        #
+        # @faker.version 1.9.2
         def last_name
           fetch('games.elder_scrolls.last_name')
         end

data/lib/faker/games/fallout.rb

@@ -4,18 +4,55 @@ module Faker
   class Games
     class Fallout < Base
       class << self
+        ##
+        # Produces the name of a character from the Fallout games.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::Fallout.character #=> "Liberty Prime"
+        #
+        # @faker.version 1.9.2
         def character
           fetch('games.fallout.characters')
         end
 
+        ##
+        # Produces the name of a faction from the Fallout games.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::Fallout.faction #=> "Brotherhood of Steel"
+        #
+        # @faker.version 1.9.2
         def faction
           fetch('games.fallout.factions')
         end
 
+        ##
+        # Produces the name of a location from the Fallout games.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::Fallout.location #=> "New Vegas"
+        #
+        # @faker.version 1.9.2
         def location
           fetch('games.fallout.locations')
         end
 
+        ##
+        # Produces a quote from the Fallout games.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::Fallout.quote
+        #     #=> "Democracy is non-negotiable"
+        #
+        # @faker.version 1.9.2
         def quote
           fetch('games.fallout.quotes')
         end

data/lib/faker/games/game.rb

@@ -5,14 +5,41 @@ module Faker
     flexible :game
 
     class << self
+      ##
+      # Produces the name of a video game.
+      #
+      # @return [String]
+      #
+      # @example
+      #   Faker::Game.title #=> "Half-Life 2"
+      #
+      # @faker.version 1.9.4
       def title
         fetch('game.title')
       end
 
+      ##
+      # Produces the name of a video game genre.
+      #
+      # @return [String]
+      #
+      # @example
+      #   Faker::Game.genre #=> "Real-time strategy"
+      #
+      # @faker.version 1.9.4
       def genre
         fetch('game.genre')
       end
 
+      ##
+      # Produces the name of a video game console or platform.
+      #
+      # @return [String]
+      #
+      # @example
+      #   Faker::Game.platform #=> "Nintendo Switch"
+      #
+      # @faker.version 1.9.4
       def platform
         fetch('game.platform')
       end

data/lib/faker/games/half_life.rb

@@ -4,14 +4,41 @@ module Faker
   class Games
     class HalfLife < Base
       class << self
+        ##
+        # Produces the name of a character from the Half-Life games.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::HalfLife.character #=> "Gordon Freeman"
+        #
+        # @faker.version 1.9.2
         def character
           fetch('games.half_life.character')
         end
 
+        ##
+        # Produces the name of an enemy from the Half-Life games.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::HalfLife.enemy #=> "Headcrab"
+        #
+        # @faker.version 1.9.2
         def enemy
           fetch('games.half_life.enemy')
         end
 
+        ##
+        # Produces the name of a location from the Half-Life games.
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Games::HalfLife.location #=> "Black Mesa Research Facility"
+        #
+        # @faker.version 1.9.2
         def location
           fetch('games.half_life.location')
         end