fakefs 0.17.0 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2615742cb54b7cea91ad40e51e1b1baf037ea9295eff338b0432fc20f1ea9483
-  data.tar.gz: e9e136d1eb2d10a18b0470ed45c8058b88656af040d45136f78a53fb21bf42c0
+  metadata.gz: 9479bf3a7bc17238053ebfe0489449a54eaf93975c253873caa817cb608a6e12
+  data.tar.gz: e0071c3db4a4b16278a995b0f1ecce76a6781ce23847ef67194a0edb2f2999e2
 SHA512:
-  metadata.gz: 790f25734bd4b9bf2c4b82750421bbe40114a591efa327b909b61e0ef341360f5bdbde7c5d99c06a3931f46d655710f1fc7c302a24b67590cb849e506e750450
-  data.tar.gz: 73578d236fa95d8307311c87c9fba693c101295bdc915b2bc6adda0c074e9ea5eb782121af5cc3c3446cf8292d57a6ed8dd5c6979a4cdee9be2fb11053c4b65c
+  metadata.gz: 03be56fc4d1a9f05d410e75f2292cb498c0522f9a40508a28763ec757a5b6bf011be8c1462b52292987ea5f594ed54f04f64e1a4baefac2768c4db318ae5f389
+  data.tar.gz: 7fdd408a1814b6629271d4de1c9610c77836e9d1d8a3dfec8c7c4667bfa4d5fd02e5ed5b85aa111de3e5d5a84808c97b8ced730d2c4cbbad995cb87b703b3014

data/lib/fakefs/file.rb

@@ -60,10 +60,12 @@ module FakeFS
     end
 
     def self.readable?(path)
+      return false unless exist? path
       File.lstat(path).readable?
     end
 
     def self.writable?(path)
+      return false unless exist? path
       File.lstat(path).writable?
     end
 
@@ -281,8 +283,15 @@ module FakeFS
       RealFile.split(path)
     end
 
-    def self.chmod(mode_int, filename)
-      FileSystem.find(filename).mode = 0o100000 + mode_int
+    def self.chmod(mode, filename)
+      # chmod's mode can either be passed in in absolute mode, or symbolic mode
+      # for reference: https://ruby-doc.org/stdlib-2.2.2/libdoc/fileutils/rdoc/FileUtils.html#method-c-chmod
+      # if the mode is passed in symbolic mode we must convert it to absolute mode
+      is_absolute_mode = mode.is_a? Numeric
+      unless is_absolute_mode
+        mode = convert_symbolic_chmod_to_absolute mode
+      end
+      FileSystem.find(filename).mode = 0o100000 + mode
     end
 
     # Not exactly right, returns true if the file is chmod +x for owner. In the
@@ -567,8 +576,15 @@ module FakeFS
       self.class.mtime(@path)
     end
 
-    def chmod(mode_int)
-      @file.mode = 0o100000 + mode_int
+    def chmod(mode)
+      # chmod's mode can either be passed in in absolute mode, or symbolic mode
+      # for reference: https://ruby-doc.org/stdlib-2.2.2/libdoc/fileutils/rdoc/FileUtils.html#method-c-chmod
+      # if the mode is passed in symbolic mode we must convert it to absolute mode
+      is_absolute_mode = mode.is_a? Numeric
+      unless is_absolute_mode
+        mode = convert_symbolic_chmod_to_absolute mode
+      end
+      @file.mode = 0o100000 + mode
     end
 
     def chown(owner_int, group_int)
@@ -672,6 +688,78 @@ module FakeFS
       read_buf
     end
 
+    def self.convert_symbolic_chmod_to_absolute(mode)
+      # mode always must be of form <GROUP1>=<FLAGS>,<GROUP2>=<FLAGS,...
+      # e.g.: u=wr,go=x
+      chmod_pairs = mode.split(',')
+
+      # - duplicating groups is OK ( e.g.: 'ugouuoouu' is valid and is interpretted as 'ugo' )
+      # - duplicating modes is OK ( e.g.: 'wwwwwwwww' is interpreted as 'w' )
+      # - omitting the right hand side is interpretted as removing all permission
+      # ( e.g.: 'ugo=' is really 'chmod 000' )
+      # - omitting the left hand side is interpretted as all groups ( e.g.: '=rwx' is really 'ugo=rwx' )
+      # - if we list a group more than once, we only apply the rightmost permissions
+      # ( e.g.: 'ug=rx,g=x' is really 'u=r,g=x' )
+      # - we cannot list any flags that are not 'rwx' ( e.g.: converting 'ug=rwx' to 'ug=7' is invalid )
+      # or else an error is raised
+      #   - in the example above, the following error is raised: 'invalid `perm' symbol in file mode: 7 (ArgumentError)'
+      # - we cannot put in any groups that are not 'ugo' ( e.g.: listing groups as 'uzg=x' is invalid )
+      # or else an error is raised
+      #   - in the example above, the following error is raised: 'invalid `who' symbol in file mode: z (ArgumentError)'
+      valid_groups_to_numeric_vals = { 'u' => 0o100, 'g' => 0o10, 'o' => 0o1 }
+      current_groups_to_vals = { 0o100 => 0o0, 0o10 => 0o0, 0o1 => 0o0 }
+      valid_modes_to_numeric_vals = { 'r' => 0o4, 'w' => 0o2, 'x' => 0o1 }
+      chmod_pairs.each do |pair|
+        groups = pair.rpartition('=').first
+        modes = pair.rpartition('=').last
+
+        # if we give no modes, then we are removing all permission
+        chmod_perm_num = 0o0
+        if modes != ''
+          # make sure there are no invalid flags in the modes
+          # and that we discard duplicates as chmod does
+          given_modes = modes.split('')
+          given_modes = given_modes.uniq
+          given_modes.each do |specific_mode|
+            # ensure that the mode is valid
+            unless valid_modes_to_numeric_vals.key? specific_mode
+              raise ArgumentError, "Invalid `perm' symbol in file mode: #{specific_mode}"
+            end
+
+            chmod_addend = valid_modes_to_numeric_vals[specific_mode]
+            chmod_perm_num += chmod_addend
+          end
+        end
+
+        # if we give no groups, then we are giving all groups
+        if groups == ''
+          current_groups_to_vals[0o100] = chmod_perm_num
+          current_groups_to_vals[0o10] = chmod_perm_num
+          current_groups_to_vals[0o1] = chmod_perm_num
+        else
+          # make sure there are no invalid flags in the groups
+          # and that we discard duplicates as chmod does
+          given_groups = groups.split('')
+          given_groups = given_groups.uniq
+          given_groups.each do |specific_group|
+            # ensure that the group is valid
+            unless valid_groups_to_numeric_vals.key? specific_group
+              raise ArgumentError, "Invalid `who' symbol in file mode: #{specific_group}"
+            end
+
+            # take the current chmod amt from earlier and assosciate that as the current chmod factor for the group
+            group_num = valid_groups_to_numeric_vals[specific_group]
+            current_groups_to_vals[group_num] = chmod_perm_num
+          end
+        end
+      end
+
+      # return an octal chmod value for the value
+      0o100 * current_groups_to_vals[0o100] + 0o10 * current_groups_to_vals[0o10] + current_groups_to_vals[0o1]
+    end
+
+    private_class_method :convert_symbolic_chmod_to_absolute
+
     private
 
     def check_modes!

data/lib/fakefs/version.rb

@@ -1,7 +1,7 @@
 module FakeFS
   # Version module
   module Version
-    VERSION = '0.17.0'.freeze
+    VERSION = '0.18.0'.freeze
 
     def self.to_s
       VERSION

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fakefs
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.0
 platform: ruby
 authors:
 - Chris Wanstrath
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-16 00:00:00.000000000 Z
+date: 2018-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bump