fake_ftp 0.0.4 → 0.0.5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    fake_ftp (0.0.4)
+    fake_ftp (0.0.5)
 
 GEM
   remote: http://rubygems.org/

data/README.markdown

@@ -63,6 +63,7 @@ To test active upload:
 
     server.stop
 
+Note that many FTP clients default to active, unless specified otherwise.
 
 References
 ----------
@@ -75,6 +76,7 @@ Contributors
 
 * Eric Saxby
 * Colin Shield
+* liehann (https://github.com/liehann)
 
 License
 -------
@@ -99,4 +101,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
+THE SOFTWARE.

data/lib/fake_ftp/file.rb

@@ -2,11 +2,22 @@ module FakeFtp
   class File
     attr_accessor :bytes, :name
     attr_writer :type
+    attr_accessor :data
+    attr_reader :created
 
-    def initialize(name = nil, bytes = nil, type = nil)
-      self.name = name
-      self.bytes = bytes
-      self.type = type
+    def initialize(name = nil, data = nil, type = nil)
+      @created = Time.now
+      @name = name
+      @data = data
+      data_is_bytes = (data.nil? || Integer === data)
+      @bytes = data_is_bytes ? data : data.length
+      @data = data_is_bytes ? nil : data
+      @type = type
+    end
+
+    def data=(data)
+      @data = data
+      @bytes = @data.nil? ? nil : data.length
     end
 
     def passive?

data/lib/fake_ftp/server.rb

@@ -7,7 +7,7 @@ module FakeFtp
     attr_accessor :port, :passive_port
     attr_reader :mode
 
-    CMDS = %w[acct cwd cdup pass pasv port pwd quit stor type user]
+    CMDS = %w[acct cwd cdup list nlst pass pasv port pwd quit stor retr type user]
     LNBK = "\r\n"
 
     def initialize(control_port = 21, data_port = nil, options = {})
@@ -29,6 +29,10 @@ module FakeFtp
       @files.detect { |file| file.name == name }
     end
 
+    def add_file(filename, data)
+      @files << FakeFtp::File.new(::File.basename(filename.to_s), data, @mode)
+    end
+
     def start
       @started = true
       @server = ::TCPServer.new('127.0.0.1', port)
@@ -134,18 +138,13 @@ module FakeFtp
     end
 
     def _stor(filename)
-      if @mode == :passive
-        respond_with('125 Do it!')
-        data_client = @data_server.accept
-      else
-        respond_with('425 Ain\'t no data port!') && return if @active_connection.nil?
-        respond_with('125 Do it!')
+      respond_with('425 Ain\'t no data port!') && return if active? && @active_connection.nil?
 
-        data_client = @active_connection
-      end
+      respond_with('125 Do it!')
+      data_client = active? ? @active_connection : @data_server.accept
 
       data = data_client.recv(1024)
-      file = FakeFtp::File.new(::File.basename(filename.to_s), data.length, @mode)
+      file = FakeFtp::File.new(::File.basename(filename.to_s), data, @mode)
       @files << file
 
       data_client.close
@@ -153,6 +152,52 @@ module FakeFtp
       '226 Did it!'
     end
 
+    def _retr(filename)
+      respond_with('501 No filename given') if filename.empty?
+
+      file = file(::File.basename(filename.to_s))
+      return respond_with('550 File not found') if file.nil?
+
+      respond_with('425 Ain\'t no data port!') && return if active? && @active_connection.nil?
+
+      respond_with('150 File status ok, about to open data connection')
+      data_client = active? ? @active_connection : @data_server.accept
+
+      data_client.write(file.data)
+
+      data_client.close
+      @active_connection = nil
+      '226 File transferred'
+    end
+
+    def _list(args)
+      respond_with('425 Ain\'t no data port!') && return if active? && @active_connection.nil?
+
+      respond_with('150 Listing status ok, about to open data connection')
+      data_client = active? ? @active_connection : @data_server.accept
+
+      data_client.write(@files.map do |f|
+        "-rw-r--r--\t1\towner\tgroup\t#{f.bytes}\t#{f.created.strftime('%b %d %H:%M')}\t#{f.name}"
+      end.join("\n"))
+      data_client.close
+      @active_connection = nil
+
+      '226 List information transferred'
+    end
+
+    def _nlst(args)
+      respond_with('425 Ain\'t no data port!') && return if active? && @active_connection.nil?
+
+      respond_with('150 Listing status ok, about to open data connection')
+      data_client = active? ? @active_connection : @data_server.accept
+
+      data_client.write(files.join("\n"))
+      data_client.close
+      @active_connection = nil
+
+      '226 List information transferred'
+    end
+
     def _type(type = 'A')
       case type.to_s
         when 'A'
@@ -167,5 +212,9 @@ module FakeFtp
     def _user(name = '')
       (name.to_s == 'anonymous') ? '230 logged in' : '331 send your password'
     end
+
+    def active?
+      @mode == :active
+    end
   end
-end
+end

data/lib/fake_ftp/version.rb

@@ -1,3 +1,3 @@
 module FakeFtp
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/models/fake_ftp/file_spec.rb

@@ -15,6 +15,12 @@ describe FakeFtp::File do
       @file.bytes = 87
       @file.bytes.should == 87
     end
+
+    it "has a data attribute" do
+      @file.data = 'some data'
+      @file.data.should == 'some data'
+      @file.bytes.should == 'some data'.length
+    end
   end
 
   context 'setup' do

data/spec/models/fake_ftp/server_spec.rb

@@ -311,6 +311,55 @@ describe FakeFtp::Server do
             @server.files.should include('some_file')
             @server.file('some_file').bytes.should == 10
           end
+
+          it "does not accept RETR without a filename" do
+              @client.puts "RETR"
+              @client.gets.should == "501 No filename given\r\n"
+          end
+
+          it "does not serve files that do not exist" do
+              @client.puts "RETR some_file"
+              @client.gets.should == "550 File not found\r\n"
+          end
+
+          it "accepts RETR with a filename" do
+            @server.add_file('some_file', '1234567890')
+            @client.puts "RETR some_file"
+            @client.gets.should == "150 File status ok, about to open data connection\r\n"
+            @data_client = TCPSocket.open('127.0.0.1', 21213)
+            data = @data_client.read(1024)
+            @data_client.close
+            data.should == '1234567890'
+            @client.gets.should == "226 File transferred\r\n"
+          end
+
+          it "accepts a LIST command" do
+            @server.add_file('some_file', '1234567890')
+            @server.add_file('another_file', '1234567890')
+            @client.puts "LIST"
+            @client.gets.should == "150 Listing status ok, about to open data connection\r\n"
+            @data_client = TCPSocket.open('127.0.0.1', 21213)
+            data = @data_client.read(2048)
+            @data_client.close
+            data.should == [
+              "-rw-r--r--\t1\towner\tgroup\t10\t#{@server.file('some_file').created.strftime('%b %d %H:%M')}\tsome_file",
+              "-rw-r--r--\t1\towner\tgroup\t10\t#{@server.file('another_file').created.strftime('%b %d %H:%M')}\tanother_file",
+            ].join("\n")
+            @client.gets.should == "226 List information transferred\r\n"
+          end
+
+          it "accepts an NLST command" do
+            @server.add_file('some_file', '1234567890')
+            @server.add_file('another_file', '1234567890')
+            @client.puts "NLST"
+            @client.gets.should == "150 Listing status ok, about to open data connection\r\n"
+            @data_client = TCPSocket.open('127.0.0.1', 21213)
+            data = @data_client.read(1024)
+            @data_client.close
+            data.should == "some_file\nanother_file"
+            @client.gets.should == "226 List information transferred\r\n"
+          end
+
         end
 
         context 'active' do
@@ -347,6 +396,40 @@ describe FakeFtp::Server do
             @server.files.should include('some_other_file')
             @server.file('some_other_file').bytes.should == 5
           end
+
+          it "accepts RETR with a filename" do
+            @client.puts "PORT 127,0,0,1,82,224"
+            @client.gets.should == "200 Okay\r\n"
+
+            @server.add_file('some_file', '1234567890')
+            @client.puts "RETR some_file"
+            @client.gets.should == "150 File status ok, about to open data connection\r\n"
+
+            @data_connection.join
+            data = @server_client.read(1024)
+            @server_client.close
+
+            data.should == '1234567890'
+            @client.gets.should == "226 File transferred\r\n"
+          end
+
+          it "accepts an NLST command" do
+            @client.puts "PORT 127,0,0,1,82,224"
+            @client.gets.should == "200 Okay\r\n"
+
+            @server.add_file('some_file', '1234567890')
+            @server.add_file('another_file', '1234567890')
+            @client.puts "NLST"
+            @client.gets.should == "150 Listing status ok, about to open data connection\r\n"
+
+            @data_connection.join
+            data = @server_client.read(1024)
+            @server_client.close
+
+            data.should == "some_file\nanother_file"
+            @client.gets.should == "226 List information transferred\r\n"
+          end
+
         end
       end
     end
@@ -415,4 +498,4 @@ describe FakeFtp::Server do
       end
     end
   end
-end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: fake_ftp
 version: !ruby/object:Gem::Version 
-  hash: 23
-  prerelease: false
+  hash: 21
+  prerelease: 
   segments: 
   - 0
   - 0
-  - 4
-  version: 0.0.4
+  - 5
+  version: 0.0.5
 platform: ruby
 authors: 
 - Colin Shield
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-06 00:00:00 -08:00
+date: 2011-05-12 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: fake_ftp
-rubygems_version: 1.3.7
+rubygems_version: 1.5.3
 signing_key: 
 specification_version: 3
 summary: Creates a fake FTP server for use in testing