fake_dynamo 0.0.4 → 0.0.5

data/lib/fake_dynamo/attribute.rb

@@ -14,6 +14,16 @@ module FakeDynamo
           numeric(n)
         end
       end
+
+      if ['S', 'SS'].include? @type
+        Array(value).each do |v|
+          raise ValidationException, 'An AttributeValue may not contain an empty string' if v == ''
+        end
+      end
+
+      if name == ''
+        raise ValidationException, 'Empty attribute name'
+      end
     end
 
     def numeric(n)

data/lib/fake_dynamo/filter.rb

@@ -3,6 +3,7 @@ module FakeDynamo
     include Validation
 
     def comparison_filter(value_list, size, target_attribute, fail_on_type_mismatch, supported_types, comparator)
+      return false if target_attribute.nil?
 
       validate_size(value_list, size)
 
@@ -66,6 +67,8 @@ module FakeDynamo
     end
 
     def contains_filter(value_list, target_attribute, fail_on_type_mismatch)
+      return false if target_attribute.nil?
+
       validate_size(value_list, 1)
       value_attribute = Attribute.from_hash(target_attribute.name, value_list.first)
       validate_supported_types(value_attribute, ['N', 'S'])
@@ -78,6 +81,8 @@ module FakeDynamo
     end
 
     def not_contains_filter(value_list, target_attribute, fail_on_type_mismatch)
+      return false if target_attribute.nil?
+
       validate_size(value_list, 1)
       value_attribute = Attribute.from_hash(target_attribute.name, value_list.first)
       validate_supported_types(value_attribute, ['N', 'S'])
@@ -92,6 +97,8 @@ module FakeDynamo
     INF = 1.0/0.0
 
     def in_filter(value_list, target_attribute, fail_on_type_mismatch)
+      return false if target_attribute.nil?
+
       validate_size(value_list, (1..INF))
 
       value_attribute_list = value_list.map do |value|

data/lib/fake_dynamo/version.rb

@@ -1,3 +1,3 @@
 module FakeDynamo
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/fake_dynamo/table_spec.rb

@@ -128,6 +128,37 @@ module FakeDynamo
         end.to raise_error(ValidationException, /mismatch/i)
       end
 
+      it 'should fail if the attribute value contains empty string' do
+        expect do
+          subject.put_item({ 'TableName' => 'Table1',
+                             'Item' => {
+                               'AttributeName1' => { 'S' => "test" },
+                               'AttributeName2' => { 'N' => '11' },
+                               'x' => { 'S' => '' }
+                             }})
+        end.to raise_error(ValidationException, /empty/i)
+
+        expect do
+          subject.put_item({ 'TableName' => 'Table1',
+                             'Item' => {
+                               'AttributeName1' => { 'S' => "test" },
+                               'AttributeName2' => { 'N' => '11' },
+                               'x' => { 'SS' => ['x', ''] }
+                             }})
+        end.to raise_error(ValidationException, /empty/i)
+      end
+
+      it 'should fail on empty key value' do
+        expect do
+          subject.put_item({ 'TableName' => 'Table1',
+                             'Item' => {
+                               'AttributeName1' => { 'S' => "test" },
+                               'AttributeName2' => { 'N' => '11' },
+                               '' => { 'SS' => ['x'] }
+                             }})
+        end.to raise_error(ValidationException, /empty/i)
+      end
+
       it 'should putitem in the table' do
         subject.put_item(item)
         subject.items.size.should == 1

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fake_dynamo
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-20 00:00:00.000000000 Z
+date: 2012-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &70102532152560 !ruby/object:Gem::Requirement
+  requirement: &70299635734020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70102532152560
+  version_requirements: *70299635734020
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70102532151680 !ruby/object:Gem::Requirement
+  requirement: &70299635733520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70102532151680
+  version_requirements: *70299635733520
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &70102532146440 !ruby/object:Gem::Requirement
+  requirement: &70299635733020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70102532146440
+  version_requirements: *70299635733020
 description: 
 email:
 - ananthakumaran@gmail.com