fake_braintree 0.2.1 → 0.3

data/spec/fake_braintree/transparent_redirect_spec.rb

@@ -1,56 +1,103 @@
 require 'spec_helper'
 
 describe FakeBraintree::SinatraApp do
-  context "Braintree::TransparentRedirect.url" do
-    it "returns a URL that will redirect with a token for the specified request" do
-      redirect_url = "http://example.com/redirect_path"
+  context 'Braintree::TransparentRedirect.url' do
+    it 'returns a URL that will redirect with a token for the specified request' do
+      redirect_url = 'http://example.com/redirect_path'
 
-      response = post_transparent_redirect(:redirect_url => redirect_url, :customer => build_customer_hash)
+      response = post_transparent_redirect(:create_customer_data, :redirect_url => redirect_url, :customer => build_customer_hash)
 
-      response.code.should == "303"
-      response["Location"].should =~ %r{http://example\.com/redirect_path}
+      response.code.should == '303'
+      response['Location'].should =~ %r{http://example\.com/redirect_path}
       params = parse_redirect(response)
-      params[:http_status].should == "200"
+      params[:http_status].should == '200'
       params[:id].should_not be_nil
       params[:kind].should_not be_nil
     end
 
-    it "rejects submissions without transparent redirect data" do
+    it "preserves redirect_url query parameters" do
+      redirect_url = 'http://example.com/redirect_path?preserve=me'
+
+      response = post_transparent_redirect(
+        :create_customer_data,
+        :redirect_url => redirect_url,
+        :customer => build_customer_hash
+      )
+
+      params = parse_redirect(response)
+      params[:preserve].should == 'me'
+    end
+
+    it 'rejects submissions without transparent redirect data' do
       response = post_transparent_redirect_without_data
-      response.code.should == "422"
+      response.code.should == '422'
     end
   end
 
-  context "Braintree::TransparentRedirect.confirm" do
-    it "confirms and runs the specified request" do
-      number = "4111111111111111"
-      customer_hash = build_customer_hash(:credit_card => { :number => number })
-      response = post_transparent_redirect(:customer => customer_hash)
-      query = parse_query(response)
+  context 'Braintree::TransparentRedirect.confirm' do
+    describe 'Creating customers' do
+      it 'confirms and runs the specified request' do
+        number = '4111111111111111'
+        customer_hash = build_customer_hash(:credit_card => { :number => number })
+        response = post_transparent_redirect(:create_customer_data, :customer => customer_hash)
+        query = parse_query(response)
 
-      result = Braintree::TransparentRedirect.confirm(query)
+        result = Braintree::TransparentRedirect.confirm(query)
 
-      result.should be_success
+        result.should be_success
 
-      customer = Braintree::Customer.find(result.customer.id)
-      customer.credit_cards.first.last_4.should == "1111"
+        customer = Braintree::Customer.find(result.customer.id)
+        customer.credit_cards.first.last_4.should == '1111'
+      end
+    end
+
+    describe 'Creating credit cards' do
+      it 'confirms and runs the specified request' do
+        customer = create_customer.customer
+        number = '4111111111111337'
+        credit_card_hash = build_credit_card_hash({ :number => number, :customer_id => customer.id})
+        response = post_transparent_redirect(:create_credit_card_data, :credit_card => credit_card_hash)
+        query = parse_query(response)
+
+        result = Braintree::TransparentRedirect.confirm(query)
+
+        result.should be_success
+
+        customer = Braintree::Customer.find(customer.id)
+        customer.credit_cards.first.last_4.should == '1111'
+      end
     end
   end
 
   def build_customer_hash(options = {})
     {
       :credit_card => {
-        :number => "4111111111111111",
-        :expiration_date => "4/2015",
-        :cardholder_name => "Susie Spender"
+        :number => '4111111111111111',
+        :expiration_date => '4/2015',
+        :cardholder_name => 'Susie Spender'
       }.update(options[:credit_card] || {})
     }
   end
 
-  def post_transparent_redirect(data)
+  def build_credit_card_hash(options = {})
+    {
+        :number => '4111111111111111',
+        :expiration_date => '4/2015',
+        :cardholder_name => 'Susie Spender',
+        :cvv => '123',
+        :billing_address => {
+          :street_address => '123 Sesame Street',
+          :locality => 'San Francisco',
+          :region => 'CA',
+          :postal_code => '94110'
+        }
+    }.update(options || {})
+  end
+
+  def post_transparent_redirect(type, data)
     params = data.dup
-    redirect_url = params.delete(:redirect_url) || "http://example.com/redirect_path"
-    params[:tr_data] = Braintree::TransparentRedirect.create_customer_data(:redirect_url => redirect_url)
+    redirect_url = params.delete(:redirect_url) || 'http://example.com/redirect_path'
+    params[:tr_data] = Braintree::TransparentRedirect.send(type, {:redirect_url => redirect_url}.merge(params))
     post_transparent_redirect_params(params)
   end
 
@@ -71,6 +118,6 @@ describe FakeBraintree::SinatraApp do
   end
 
   def parse_query(response)
-    URI.parse(response["Location"]).query
+    URI.parse(response['Location']).query
   end
 end

data/spec/fake_braintree_spec.rb

@@ -1,13 +1,13 @@
 require 'spec_helper'
 
-describe FakeBraintree, ".decline_all_cards!" do
+describe FakeBraintree, '.decline_all_cards!' do
   before { FakeBraintree.decline_all_cards! }
 
-  it "declines all cards" do
+  it 'declines all cards' do
     create_sale.should_not be_success
   end
 
-  it "stops declining cards after clear! is called" do
+  it 'stops declining cards after clear! is called' do
     FakeBraintree.clear!
     create_sale.should be_success
   end
@@ -17,8 +17,8 @@ describe FakeBraintree, ".decline_all_cards!" do
   end
 end
 
-describe FakeBraintree, ".log_file_path" do
-  it "is tmp/log" do
+describe FakeBraintree, '.log_file_path' do
+  it 'is tmp/log' do
     FakeBraintree.log_file_path.should == 'tmp/log'
   end
 end
@@ -26,36 +26,36 @@ end
 describe Braintree::Configuration do
   subject { Braintree::Configuration }
 
-  it "is running in the development environment" do
+  it 'is running in the development environment' do
     subject.environment.should == :development
   end
 
-  it "has some fake API credentials" do
-    subject.merchant_id.should == "xxx"
-    subject.public_key.should == "xxx"
-    subject.private_key.should == "xxx"
+  it 'has some fake API credentials' do
+    subject.merchant_id.should == 'xxx'
+    subject.public_key.should == 'xxx'
+    subject.private_key.should == 'xxx'
   end
 end
 
 describe FakeBraintree do
-  it "creates a log file" do
+  it 'creates a log file' do
     File.exist?(FakeBraintree.log_file_path).should == true
   end
 
-  it "logs to the correct path" do
+  it 'logs to the correct path' do
     Braintree::Configuration.logger.info('Logger test')
     File.readlines(FakeBraintree.log_file_path).last.should == "Logger test\n"
   end
 end
 
-describe FakeBraintree, ".clear_log!" do
-  it "clears the log file" do
+describe FakeBraintree, '.clear_log!' do
+  it 'clears the log file' do
     write_to_log
     subject.clear_log!
-    File.read(FakeBraintree.log_file_path).should == ""
+    File.read(FakeBraintree.log_file_path).should == ''
   end
 
-  it "is called by clear!" do
+  it 'is called by clear!' do
     FakeBraintree.expects(:clear_log!)
     FakeBraintree.clear!
   end
@@ -65,8 +65,8 @@ describe FakeBraintree, ".clear_log!" do
   end
 end
 
-describe FakeBraintree, "VALID_CREDIT_CARDS" do
-  it "includes only credit cards that are valid in the Braintree sandbox" do
+describe FakeBraintree, 'VALID_CREDIT_CARDS' do
+  it 'includes only credit cards that are valid in the Braintree sandbox' do
     FakeBraintree::VALID_CREDIT_CARDS.sort.should == valid_credit_cards.sort
   end
 
@@ -82,46 +82,46 @@ describe FakeBraintree, "VALID_CREDIT_CARDS" do
   end
 end
 
-describe FakeBraintree, ".failure_response" do
-  it "can be called with no arguments" do
+describe FakeBraintree, '.failure_response' do
+  it 'can be called with no arguments' do
     expect { FakeBraintree.failure_response }.not_to raise_error
   end
 end
 
-describe FakeBraintree, ".generate_transaction" do
-  it "allows setting the subscription id" do
+describe FakeBraintree, '.generate_transaction' do
+  it 'allows setting the subscription id' do
     transaction = FakeBraintree.generate_transaction(:subscription_id => 'foobar')
     transaction['subscription_id'].should == 'foobar'
   end
 
-  it "allows setting created_at" do
+  it 'allows setting created_at' do
     time = Time.now
     transaction = FakeBraintree.generate_transaction(:created_at => time)
     transaction['created_at'].should == time
   end
 
-  it "sets created_at to Time.now by default" do
+  it 'sets created_at to Time.now by default' do
     Timecop.freeze do
       transaction = FakeBraintree.generate_transaction
       transaction['created_at'].should == Time.now
     end
   end
 
-  it "has the correct amount" do
-    transaction = FakeBraintree.generate_transaction(:amount => "20.00")
-    transaction['amount'].should == "20.00"
+  it 'has the correct amount' do
+    transaction = FakeBraintree.generate_transaction(:amount => '20.00')
+    transaction['amount'].should == '20.00'
   end
 
-  it "allows no arguments" do
+  it 'allows no arguments' do
     expect { FakeBraintree.generate_transaction }.not_to raise_error
   end
 
-  context "status_history" do
-    it "returns a hash with a status_history key" do
+  context 'status_history' do
+    it 'returns a hash with a status_history key' do
       FakeBraintree.generate_transaction(:amount => '20').should have_key('status_history')
     end
 
-    it "has a timestamp of Time.now" do
+    it 'has a timestamp of Time.now' do
       Timecop.freeze do
         transaction = FakeBraintree.generate_transaction(:status => Braintree::Transaction::Status::Failed,
                                                          :subscription_id => 'my_subscription_id')
@@ -129,12 +129,12 @@ describe FakeBraintree, ".generate_transaction" do
       end
     end
 
-    it "has the desired amount" do
+    it 'has the desired amount' do
       transaction = FakeBraintree.generate_transaction(:amount => '20.00')
       transaction['status_history'].first['amount'].should == '20.00'
     end
 
-    it "has the desired status" do
+    it 'has the desired status' do
       status = Braintree::Transaction::Status::Failed
       transaction = FakeBraintree.generate_transaction(:status => status)
       transaction['status_history'].first['status'].should == status

data/spec/spec_helper.rb

@@ -11,7 +11,7 @@ Spork.prefork do
     File.new('tmp/braintree_log', 'w').close
   end
 
-  Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].each {|f| require f}
+  Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each {|f| require f}
 
   clear_braintree_log
 

data/spec/support/braintree_helpers.rb

@@ -1,7 +1,7 @@
 module BraintreeHelpers
   def create_braintree_customer(cc_number, expiration_date)
     Braintree::Customer.create(
-      :email => "me@example.com",
+      :email => 'me@example.com',
       :credit_card => {
         :number => cc_number,
         :expiration_date => expiration_date

data/spec/support/matchers/clear_hash_when_cleared.rb

@@ -1,11 +1,11 @@
 RSpec::Matchers.define :clear_hash_when_cleared do |property|
   match do |object|
-    object.send(property.to_sym)["key"] = "value"
+    object.send(property.to_sym)['key'] = 'value'
     object.clear!
     object.send(property.to_sym).should be_empty
   end
 
-  failure_message do
+  failure_message_for_should do
     "Expected #{object} to clear #{property} hash after clear!, but it did not."
   end
 end

data/spec/support/matchers/have_accessor_for.rb

@@ -4,7 +4,7 @@ RSpec::Matchers.define :have_hash_accessor_for do |property|
     object.send(property.to_sym)['key'].should == 'value'
   end
 
-  failure_message do
+  failure_message_for_should do
     "Expected #{object} to have accessor for #{property}, but it did not."
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fake_braintree
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: '0.3'
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-26 00:00:00.000000000 Z
+date: 2013-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -114,7 +114,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.12.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -122,7 +122,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.12.0
 - !ruby/object:Gem::Dependency
   name: bourne
   requirement: !ruby/object:Gem::Requirement
@@ -214,10 +214,10 @@ files:
 - .gitignore
 - .travis.yml
 - CONTRIBUTING.md
-- Changelog.md
 - GOALS
 - Gemfile
 - LICENSE
+- NEWS.md
 - README.md
 - Rakefile
 - fake_braintree.gemspec
@@ -259,7 +259,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3718552739890395570
+      hash: 2263458799663259679
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -268,7 +268,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3718552739890395570
+      hash: 2263458799663259679
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24

data/Changelog.md

@@ -1,41 +0,0 @@
-# 0.2.0
-* Generated transactions (from FakeBraintree.generate_transaction) now include
-  the amount.
-* Braintree::Customer.update will reject updates that contain credit cards that
-  have been marked as a failure in the registry.
-
-# 0.1.1
-* Braintree::CreditCard.update now works
-
-# 0.1.0
-* FakeBraintree.{customers, transactions, failures, subscriptions, redirects}
-  are now accessed via FakeBraintree.registry. For example,
-  FakeBraintree.customers is now FakeBraintree.registry.customers
-* FakeBraintree.credit_card_from_token is now FakeBraintree.registry.credit_card_from_token
-* The server code (it intercepts calls to Braintree) now lives in FakeBraintree::Server
-* Braintree::Customer.create will use the provided customer ID instead of
-  overwriting it (#15).
-* Braintree::Subscription.cancel now works
-
-# 0.0.6
-* Flesh out the README
-* Add support for transparent redirect
-* Add basic support for adding add-ons
-* Add basic support for adding discounts
-* Add support for Braintree::Customer.update
-* Add support for Braintree::Customer.delete
-* Add support for Braintree::Subscription.delete
-* Lots of internal refactorings
-
-# 0.0.5
-* Add support for Braintree::Customer.find
-
-# 0.0.4
-* Allow for very basic card verification
-
-# 0.0.3
-* Ensure FakeBraintree.log_file_path directory exists
-* The FakeBraintree.log_file_path attribute can now be read (it could only be set before)
-* Clear log when FakeBraintree.clear! is called
-* Correctly handle nonexistent subscriptions when using
-  Braintree::Subscription.find