fake_braintree 0.0.3 → 0.0.4

data/Changelog.md

@@ -0,0 +1,9 @@
+# 0.0.4
+* Allow for very basic card verification
+
+# 0.0.3
+* Ensure FakeBraintree.log_file_path directory exists
+* The FakeBraintree.log_file_path attribute can now be read (it could only be set before)
+* Clear log when FakeBraintree.clear! is called
+* Correctly handle nonexistent subscriptions when using
+  Braintree::Subscription.find

data/README.md

@@ -3,4 +3,26 @@
 Currently in alpha. Needs complete test coverage, then more functionality can
 be added.
 
-Call FakeBraintree.activate! to make it go.
+## Quick start
+Call `FakeBraintree.activate!` to make it go. `FakeBraintree.clear!` will clear
+all data, which you probably want to do before each test.
+
+Example, in spec\_helper.rb:
+
+    FakeBraintree.activate!
+
+    RSpec.configure do |c|
+      c.before do
+        FakeBraintree.clear!
+      end
+    end
+
+## Verifying credit cards
+
+To verify every credit card you try to use, call
+`FakeBraintree.verify\_all\_cards!`. This will stay "on" until you set
+`FakeBraintree.verify_all_cards = false`.  Calling FakeBraintree.clear! _will
+not_ change it. It does very basic verification: it only matches the credit card
+number against these:
+http://www.braintreepayments.com/docs/ruby/reference/sandbox and rejects them if
+they aren't one of the listed numbers.

data/lib/fake_braintree.rb

@@ -3,6 +3,7 @@ require 'braintree'
 require 'sham_rack'
 
 require 'fake_braintree/sinatra_app'
+require 'fake_braintree/valid_credit_cards'
 require 'fake_braintree/version'
 
 module FakeBraintree
@@ -13,7 +14,8 @@ module FakeBraintree
     @transaction   = {}
 
     @decline_all_cards = false
-    attr_accessor :customers, :subscriptions, :failures, :transaction, :decline_all_cards
+    @verify_all_cards  = false
+    attr_accessor :customers, :subscriptions, :failures, :transaction, :decline_all_cards, :verify_all_cards
   end
 
   def self.activate!
@@ -48,7 +50,7 @@ module FakeBraintree
   end
 
   def self.failure_response(card_number)
-    failure = self.failures[card_number]
+    failure = self.failures[card_number] || {}
     failure["errors"] ||= { "errors" => [] }
 
     { "message"      => failure["message"],
@@ -78,6 +80,10 @@ module FakeBraintree
     self.decline_all_cards
   end
 
+  def self.verify_all_cards!
+    self.verify_all_cards = true
+  end
+
   def self.credit_card_from_token(token)
     self.customers.values.detect do |customer|
       next unless customer.key?("credit_cards")

data/lib/fake_braintree/sinatra_app.rb

@@ -22,6 +22,18 @@ module FakeBraintree
       def md5(content)
         Digest::MD5.hexdigest(content)
       end
+
+      def verify_credit_card?(customer_hash)
+        return true if FakeBraintree.verify_all_cards
+
+        customer_hash["credit_card"].key?("options") &&
+          customer_hash["credit_card"]["options"].is_a?(Hash) &&
+          customer_hash["credit_card"]["options"]["verify_card"] == true
+      end
+
+      def has_invalid_credit_card?(customer_hash)
+        ! FakeBraintree::VALID_CREDIT_CARDS.include?(customer_hash["credit_card"]["number"])
+      end
     end
 
     # Braintree::Customer.create
@@ -30,23 +42,27 @@ module FakeBraintree
       if FakeBraintree.failure?(customer["credit_card"]["number"])
         gzipped_response(422, FakeBraintree.failure_response(customer["credit_card"]["number"]).to_xml(:root => 'api_error_response'))
       else
-        customer["id"] ||= md5("#{params[:merchant_id]}#{Time.now.to_f}")
-        customer["merchant-id"] = params[:merchant_id]
-        if customer["credit_card"] && customer["credit_card"].is_a?(Hash)
-          customer["credit_card"].delete("__content__")
-          if !customer["credit_card"].empty?
-            customer["credit_card"]["last_4"]           = customer["credit_card"].delete("number")[-4..-1]
-            customer["credit_card"]["token"]            = md5("#{customer['merchant_id']}#{customer['id']}#{Time.now.to_f}")
-            expiration_date = customer["credit_card"].delete("expiration_date")
-            customer["credit_card"]["expiration_month"] = expiration_date.split('/')[0]
-            customer["credit_card"]["expiration_year"]  = expiration_date.split('/')[1]
-
-            credit_card = customer.delete("credit_card")
-            customer["credit_cards"] = [credit_card]
+        if verify_credit_card?(customer) && has_invalid_credit_card?(customer)
+          gzipped_response(422, FakeBraintree.failure_response(customer["credit_card"]["number"]).to_xml(:root => 'api_error_response'))
+        else
+          customer["id"] ||= md5("#{params[:merchant_id]}#{Time.now.to_f}")
+          customer["merchant-id"] = params[:merchant_id]
+          if customer["credit_card"] && customer["credit_card"].is_a?(Hash)
+            customer["credit_card"].delete("__content__")
+            if !customer["credit_card"].empty?
+              customer["credit_card"]["last_4"]           = customer["credit_card"].delete("number")[-4..-1]
+              customer["credit_card"]["token"]            = md5("#{customer['merchant_id']}#{customer['id']}#{Time.now.to_f}")
+              expiration_date = customer["credit_card"].delete("expiration_date")
+              customer["credit_card"]["expiration_month"] = expiration_date.split('/')[0]
+              customer["credit_card"]["expiration_year"]  = expiration_date.split('/')[1]
+
+              credit_card = customer.delete("credit_card")
+              customer["credit_cards"] = [credit_card]
+            end
           end
+          FakeBraintree.customers[customer["id"]] = customer
+          gzipped_response(201, customer.to_xml(:root => 'customer'))
         end
-        FakeBraintree.customers[customer["id"]] = customer
-        gzipped_response(201, customer.to_xml(:root => 'customer'))
       end
     end
 

data/lib/fake_braintree/valid_credit_cards.rb

@@ -0,0 +1,9 @@
+module FakeBraintree
+  VALID_CREDIT_CARDS = %w(4111111111111111 4005519200000004
+                          4009348888881881 4012000033330026
+                          4012000077777777 4012888888881881
+                          4217651111111119 4500600000000061
+                          5555555555554444 378282246310005
+                          371449635398431 6011111111111117
+                          3530111333300000)
+end

data/lib/fake_braintree/version.rb

@@ -1,3 +1,3 @@
 module FakeBraintree
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/fake_braintree/sinatra_app_spec.rb

@@ -65,7 +65,7 @@ module FakeBraintree
     let(:expiration_date)      { "04/2016" }
     let(:payment_method_token) { braintree_credit_card_token(cc_number, expiration_date) }
     let(:subscription_result)  { Braintree::Subscription.create(:payment_method_token => payment_method_token,
-                                                                :plan_id => plan_id) }
+                                                                :plan_id => 'my-plan-id') }
 
     it "can find a created subscription" do
       Braintree::Subscription.find(subscription_result.subscription.id).should be
@@ -75,4 +75,52 @@ module FakeBraintree
       expect { Braintree::Subscription.find('abc123') }.to raise_error(Braintree::NotFoundError, /abc123/)
     end
   end
+
+  describe SinatraApp, "Braintree::Customer.create" do
+    let(:cc_number)       { %w(4111 1111 1111 1111).join }
+    let(:expiration_date) { "04/2016" }
+    after { FakeBraintree.verify_all_cards = false }
+
+    it "successfully creates a customer" do
+      result = Braintree::Customer.create(
+        :credit_card => {
+          :number          => cc_number,
+          :expiration_date => expiration_date
+        })
+
+      result.should be_success
+    end
+
+    it "verifies the card number when passed :verify_card => true" do
+      Braintree::Customer.create(
+        :credit_card => {
+          :number          => cc_number,
+          :expiration_date => expiration_date,
+          :options         => { :verify_card => true }
+        }).should be_success
+
+      Braintree::Customer.create(
+        :credit_card => {
+          :number          => '123456',
+          :expiration_date => expiration_date,
+          :options         => { :verify_card => true }
+        }).should_not be_success
+    end
+
+    it "verifies the card number when FakeBraintree.verify_all_cards == true" do
+      FakeBraintree.verify_all_cards!
+
+      Braintree::Customer.create(
+        :credit_card => {
+          :number          => cc_number,
+          :expiration_date => expiration_date
+        }).should be_success
+
+      Braintree::Customer.create(
+        :credit_card => {
+          :number          => '123456',
+          :expiration_date => expiration_date
+        }).should_not be_success
+    end
+  end
 end

data/spec/fake_braintree_spec.rb

@@ -84,3 +84,20 @@ describe FakeBraintree, ".clear_log!" do
     FakeBraintree.clear!
   end
 end
+
+describe FakeBraintree, "VALID_CREDIT_CARDS" do
+  let(:valid_credit_cards) do
+    %w(4111111111111111 4005519200000004
+       4009348888881881 4012000033330026
+       4012000077777777 4012888888881881
+       4217651111111119 4500600000000061
+       5555555555554444 378282246310005
+       371449635398431 6011111111111117
+       3530111333300000
+      )
+  end
+
+  it "includes only credit cards that are valid in production" do
+    FakeBraintree::VALID_CREDIT_CARDS.sort.should == valid_credit_cards.sort
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fake_braintree
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2011-10-24 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sham_rack
-  requirement: &70234757701580 !ruby/object:Gem::Requirement
+  requirement: &70166836515360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70234757701580
+  version_requirements: *70166836515360
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70234757700380 !ruby/object:Gem::Requirement
+  requirement: &70166836511340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70234757700380
+  version_requirements: *70166836511340
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &70234757699160 !ruby/object:Gem::Requirement
+  requirement: &70166836500660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70234757699160
+  version_requirements: *70166836500660
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &70234757698720 !ruby/object:Gem::Requirement
+  requirement: &70166836498100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70234757698720
+  version_requirements: *70166836498100
 - !ruby/object:Gem::Dependency
   name: braintree
-  requirement: &70234757698120 !ruby/object:Gem::Requirement
+  requirement: &70166836491540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: '2.5'
   type: :runtime
   prerelease: false
-  version_requirements: *70234757698120
+  version_requirements: *70166836491540
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70234757697400 !ruby/object:Gem::Requirement
+  requirement: &70166836489720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +76,10 @@ dependencies:
         version: 2.6.0
   type: :development
   prerelease: false
-  version_requirements: *70234757697400
+  version_requirements: *70166836489720
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70234757696880 !ruby/object:Gem::Requirement
+  requirement: &70166836488220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,7 +87,7 @@ dependencies:
         version: 0.9.12
   type: :development
   prerelease: false
-  version_requirements: *70234757696880
+  version_requirements: *70166836488220
 description: A fake Braintree that you can run integration tests against
 email:
 - gabe@thoughtbot.com
@@ -97,12 +97,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- Changelog.md
 - Gemfile
 - README.md
 - Rakefile
 - fake_braintree.gemspec
 - lib/fake_braintree.rb
 - lib/fake_braintree/sinatra_app.rb
+- lib/fake_braintree/valid_credit_cards.rb
 - lib/fake_braintree/version.rb
 - spec/fake_braintree/sinatra_app_spec.rb
 - spec/fake_braintree_spec.rb