facturacr 0.1.4 → 1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aea851ecee75d42e2a0b8f958ead2ac23d0a4cb1
-  data.tar.gz: 1484b00510fe834c3c29eab1cb5115504cd2512b
+  metadata.gz: db381bbaa82171a178d543ba768b109dda40ce9b
+  data.tar.gz: 3dd2171473e12c9f578c9d21d12d18fe600d587d
 SHA512:
-  metadata.gz: e1c76bad034b6de2b6530f4c1bbf0304dff3b70491deceaad4734cb580f5845bfd9ad3e4a4150154caca4f1eefe071eabf42bd6701a0139716d8a73fb3a150d9
-  data.tar.gz: 20219ed607264ac15ecc9c65fcf66e00c477b3a379a73736b9b04213287673b78e0073c494ae5a032bad37697cce717a91f0271f3e9214b0f5d6d9679149fc49
+  metadata.gz: 86db7abd0fc67508f335f56de8d561a7fdbc7bc55147821a2bb07c919f3d2f7e0d5159d6edcf2e971c9914677f11d4d58e1c6b50e533a6b669d028ea220252db
+  data.tar.gz: f16d24d241f22cc0e70d4672d46528dffbbe1b6e7fb85d21add0754635658c2d39341de002aff4192a0128ce9130db47c4ca0376d01c3e689431387a83bedf93

data/README.md

@@ -5,7 +5,7 @@ Esta librería implementa los procesos de facturación electrónica del Minister
 Actualmente cuenta con las siguientes características:
 
 - Generación de XML
-- Firmado de XML (utilizando JAVA)
+- Firmado de XML (XADES-EPES en ruby y java)
 - Comunicación con el API del ministerio de hacienda
 - Línea de comando para realizar los procesos
 
@@ -71,13 +71,20 @@ FE.configure do |config|
 end
 ```
 
-Para firmar documentos. (Debe tener java instalado)
+Para firmar documentos, existen dos métodos:
+-Con java, se invoca un JAR con 4 argumentos. Este método es muy lento debido a que el proceso principal ejecuta el jar en otro proceso. Fue la primera implementación mientras se desarrollaba la implementación nativa en Ruby.
 ```ruby
-
 	signer = FE::JavaSigner.new FE.configuration.key_path, FE.configuration.key_password, "/path/to/unsigned.xml", "/path/to/signed.xml"
 	signer.sign
 ```
-
+-La implementación nativa en ruby:
+```ruby
+  xml_provider = FE::DataProvider.new :string, "<?xml version="1.0"?><FacturaElectronica> ... </FacturaElectornica>"
+  key_provider = FE::DataProvider.new :file, FE.configuration.key_path
+  signer = FE::Signer.new xml_provider: xml_provider, key_provider: key_provider, pin: FE.configuration.key_password, output_path: "/path/to/signed.xml"
+  signer.sign
+```
+Esta implementación permite además evitar la lectura y escritura de archivos en el disco duro, lo que permite realizar el firmado de manera mucho más rápida.
 
 Para enviar documentos al API
 ```ruby
@@ -169,12 +176,6 @@ Para enviar documentos
 
 	$ facturacr send_document /path/to/signed.xml		
 
-## To Do
-
-- Mejorar y extender la generación de XML
-- Implemntar un mapeo más sencillo para generación de XML
-- Implementar Aceptación y Rechazo
-- Finalizar el firmador en ruby
 
 ## Development
 

data/facturacr.gemspec

@@ -19,13 +19,13 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.10"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "minitest"
-  spec.add_development_dependency "minitest-colorize"
+  spec.add_development_dependency "minitest", '~> 5.11'
+  spec.add_development_dependency "minitest-colorize", '~> 0.0'
   
-  spec.add_dependency 'rest-client'
-  spec.add_dependency 'nokogiri'
-  spec.add_dependency 'colorize'
-  spec.add_dependency 'thor'
-  spec.add_dependency 'activemodel'
-  spec.add_dependency 'awesome_print'
+  spec.add_dependency 'rest-client', '~> 2.0'
+  spec.add_dependency 'nokogiri', '~> 1.8'
+  spec.add_dependency 'colorize', '~> 0.8'
+  spec.add_dependency 'thor', '~> 0.20'
+  spec.add_dependency 'activemodel', '>= 3.2'
+  spec.add_dependency 'awesome_print', '~> 1.8'
 end

data/lib/facturacr.rb

@@ -11,6 +11,7 @@ require 'facturacr/xml_document'
 require 'facturacr/api'
 require 'facturacr/builder'
 require 'facturacr/version'
+require 'facturacr/data_provider'
 require 'facturacr/signer/signer'
 require 'facturacr/reception_message'
 

data/lib/facturacr/api.rb

@@ -7,7 +7,7 @@ require 'json'
 module FE
   class Api
     
-    attr_accessor :authentication_endpoint, :document_endpoint, :username, :password, :client_id, :errors
+    attr_accessor :authentication_endpoint, :document_endpoint, :username, :password, :client_id, :errors, :check_location
     
     def initialize(configuration = nil)
       @authentication_endpoint = (configuration || FE.configuration).authentication_endpoint
@@ -32,7 +32,11 @@ module FE
     def send_document(payload)
       authenticate    
       response = RestClient.post "#{@document_endpoint}/recepcion", payload.to_json, {:Authorization=> "bearer #{@token}", content_type: :json}
-      return true if response.code.eql?(200) || response.code.eql?(202)
+      if response.code.eql?(200) || response.code.eql?(202)
+        @check_location = response.headers[:location]
+        puts "CheckLocation: #{@check_location}"
+        return true 
+      end
     rescue => e
       @errors[:request] = {message: e.message, response: e.response}
       return false      

data/lib/facturacr/builder.rb

@@ -92,7 +92,12 @@ module FE
       taxes = []
       if txs.is_a?(Array) && txs.first.is_a?(Hash)
         txs.each do |t|
-          taxes << FE::Document::Tax.new(code: "01", rate: 13, total: 13)
+          exo = t.delete(:exoneration)
+          if exo && exo.is_a?(Hash)
+            t[:exoneration] = FE::Document::Exoneration.new(exo)
+          end
+          
+          taxes << FE::Document::Tax.new(t)
         end
       else
         taxes = txs
@@ -258,5 +263,6 @@ module FE
       FE::Document::Reference.new args
     end
     
+    
   end
 end

data/lib/facturacr/cli.rb

@@ -3,29 +3,7 @@ require 'awesome_print'
 require 'facturacr'
 require 'facturacr/cli/generate'
 require 'fileutils'
-=begin
-require 'facturacr/document'
-require 'facturacr/document/fax'
-require 'facturacr/document/identification_document'
-require 'facturacr/document/issuer'
-require 'facturacr/document/receiver'
-require 'facturacr/document/location'
-require 'facturacr/document/phone_type'
-require 'facturacr/document/phone'
-require 'facturacr/document/item'
-require 'facturacr/document/tax'
-require 'facturacr/document/summary'
-require 'facturacr/document/regulation'
-require 'facturacr/document/reference'
 
-require 'facturacr/invoice'
-require 'facturacr/credit_note'
-require 'facturacr/signer/signer'
-require 'facturacr/api'
-require 'facturacr/signed_document'
-require 'facturacr/builder'
-require 'facturacr/xml_document'
-=end
 module FE
   
   module Utils
@@ -56,28 +34,37 @@ module FE
     desc "sign XML_IN XML_OUT", "signs the xml document and stores the signed document in the output path"
     method_option :config_file, aliases: '-c', desc: "default configuration file", default: "tmp/config.yml"
     def sign(xml_in, xml_out)
+      start = Time.now
       FE::Utils.configure(options[:config_file])
-      signer = FE::JavaSigner.new FE.configuration.key_path, FE.configuration.key_password, xml_in, xml_out
+      
+      key_provider = FE::DataProvider.new(:file, FE.configuration.key_path)
+      document_provider = FE::DataProvider.new(:file, xml_in)
+      signer_args = {xml_provider: document_provider, key_provider: key_provider, pin: FE.configuration.key_password, output_path: xml_out }
+      signer = FE::Signer.new signer_args
       signer.sign
+      puts "Signature: #{Time.now - start} sec.".blue
     end
     
     desc "send_document SIGNED_XML", "sends the SIGNED_XML file to the API"
     method_option :config_file, aliases: '-c', desc: "default configuration file", default: "tmp/config.yml"
     def send_document(path)
       FE::Utils.configure(options[:config_file])
-      xml_document = FE::XmlDocument.new(path)
+      xml_document = FE::XmlDocument.new(DataProvider.new :file, path)
       document = xml_document.document
-      if document.is_a?(FE::ReceptionMessage)
-        document.receiver_id_type = "02"
-      end
       signed_document = FE::SignedDocument.new(document,path)
       api = FE::Api.new
-      if api.send_document(signed_document.payload)
+      payload = signed_document.payload
+      if api.send_document(payload)
         puts "Document Sent".green
         puts "KEY: #{document.key}"
         puts "Wait 5 seconds before check..."
         sleep 5
-        invoke :check, [document.key], :config_file=>options[:config_file]
+        if document.is_a?(FE::ReceptionMessage)
+          check_key = api.check_location.split("/").last
+        else
+          check_key = document.key
+        end
+        invoke :check, [check_key], :config_file=>options[:config_file]
       else
         puts "ERROR".red
         ap api.errors

data/lib/facturacr/cli/generate.rb

@@ -11,6 +11,7 @@ module FE
       method_option :data_path, default: "tmp/data.yml"
       method_option :output_path, desc: "path to save the output"     
       def invoice
+        start = Time.now
         data = YAML.load_file(options[:data_path]).with_indifferent_access
         builder = FE::Builder.new
         
@@ -27,6 +28,8 @@ module FE
         write(invoice, output_path)
         print_details(invoice)
         sign(output_path, options) if options[:sign]
+        end_at = Time.now
+        puts "Total Time: #{end_at - start} sec."
         send_document("#{output_path}.signed.xml") if options[:sign] && options[:send]
         
       end
@@ -140,7 +143,7 @@ module FE
       method_option :document_situation, desc: "the situation of the document", default: "1"
       method_option :config_file, aliases: '-c', desc: "default configuration file", default: "tmp/config.yml"
       def reception_message
-        doc = XmlDocument.new(options[:xml_in]) 
+        doc = XmlDocument.new(DataProvider.new(:file, options[:xml_in]))
         
         builder = FE::Builder.new
       
@@ -150,17 +153,17 @@ module FE
           key: doc.document.key, 
           date: doc.document.date, 
           number: options[:number],
-          issuer_id_number: doc.document.receiver.identification_document.id_number,
-          issuer_id_type: doc.document.receiver.identification_document.document_type,
-          receiver_id_number: doc.document.issuer.identification_document.id_number,
-          receiver_id_type: doc.document.issuer.identification_document.document_type,
+          issuer_id_number: doc.document.issuer.identification_document.id_number,
+          issuer_id_type: doc.document.issuer.identification_document.document_type,
+          receiver_id_number: doc.document.receiver.identification_document.id_number,
+          receiver_id_type: doc.document.receiver.identification_document.document_type,
           message: options[:action],
           tax: doc.document.summary.tax_total,
           total: doc.document.summary.net_total,
           document_situation: options[:document_situation]
         })
         
-        message.security_code = (SecureRandom.random_number * (10**8)).round.to_s
+        message.security_code = 8.times.map{ rand(0..9) }.join
         if options[:output_path]
           output_path = options[:output_path]
         else

data/lib/facturacr/data_provider.rb

@@ -0,0 +1,21 @@
+module FE
+  
+  class DataProvider
+    SOURCES = [:string, :file]
+    
+    attr_accessor :contents
+    
+    def initialize(source, data)
+      source = source.to_s.to_sym
+      raise ArgumentError, "source (#{source}) is not valid" if !SOURCES.include?(source)
+      raise ArgumentError, "#{data} does not exist" if soruce.eql?(:file) && !File.exists?(data)
+      
+      if source.eql?(:string)
+        @contents = data
+      elsif source.eql?(:file)
+        @contents = File.read(data)
+      end
+    end   
+  end
+  
+end

data/lib/facturacr/document.rb

@@ -147,6 +147,7 @@ module FE
           numeroIdentificacion: @receiver.identification_document.id_number
         }
       end
+      
       payload
     end
     

data/lib/facturacr/document/exoneration.rb

@@ -12,7 +12,7 @@ module FE
         "05" => "Zonas Francas",
         "99" => "Otros"
       }
-      attr_accessor :document_type, :document_number, :institution, :date, :total_tax, :percentage
+      attr_accessor :document_type, :document_number, :institution, :date, :total_tax, :percentage, :net_total
       
       validates :document_type, presence: true, inclusion: DOCUMENT_TYPES.keys
       validates :document_number, presence: true
@@ -25,9 +25,11 @@ module FE
         @document_type = args[:document_type]
         @document_number = args[:document_number]
         @institution = args[:institution]
-        @date = args[:date].xmlschema
+        @date = args[:date]
         @total_tax = args[:total_tax]
-        @percentage = args[:percentage]
+        if args[:net_total].present?
+          @percentage = ((@total_tax / args[:net_total].to_f)*100).to_i
+        end
       end
       
       def build_xml(node)
@@ -35,10 +37,10 @@ module FE
         node = Nokogiri::XML::Builder.new if node.nil?
         
         node.Exoneracion do |xml|
-          xml.TipoDocument @document_type
+          xml.TipoDocumento @document_type
           xml.NumeroDocumento @document_number
           xml.NombreInstitucion @institution
-          xml.FechaEmision @date
+          xml.FechaEmision @date.xmlschema
           xml.MontoImpuesto @total_tax
           xml.PorcentajeCompra @percentage
         end

data/lib/facturacr/document/item.rb

@@ -4,7 +4,7 @@ module FE
       include ActiveModel::Validations
       
       attr_accessor :line_number, :code, :quantity, :unit, :description, :unit_price, :total,
-                    :discount, :discount_reason, :subtotal, :taxes, :exoneration, :net_total
+                    :discount, :discount_reason, :subtotal, :taxes, :net_total
                     
       validates :line_number, presence: true
       validates :quantity, presence: true, numericality: {greater_than: 0}
@@ -49,7 +49,7 @@ module FE
           x.Detalle @description
           x.PrecioUnitario @unit_price
           x.MontoTotal @total
-          x.Discount @discount if @discount.present?
+          x.MontoDescuento @discount if @discount.present?
           x.NaturalezaDescuento @discount_reason if @discount_reason.present?
           x.SubTotal @subtotal
           @taxes.each do |tax|

data/lib/facturacr/document/tax.rb

@@ -19,13 +19,14 @@ module FE
         "11"=>"Impuesto Selectivo de Consumo Compras Autorizadas",
         "99"=>"Otros"
       }
-      attr_accessor :code, :rate, :total
+      attr_accessor :code, :rate, :total, :exoneration
       
       validates :code, presence: true, inclusion: TAX_CODES.keys
       def initialize(args={})
         @code = args[:code]
         @rate = args[:rate]
         @total = args[:total]
+        @exoneration = args[:exoneration]
       end
       
       def build_xml(node)
@@ -36,6 +37,9 @@ module FE
           xml.Codigo @code
           xml.Tarifa @rate
           xml.Monto @total
+          if @exoneration.present?
+            @exoneration.build_xml(xml)
+          end
         end
       end
       

data/lib/facturacr/reception_message.rb

@@ -9,7 +9,7 @@ module FE
       "2" => "Aceptacion Parcial",
       "3" => "Rechazado"
     }
-    attr_accessor :key, :date, :issuer_id_number, :receiver_id_number, :message, :details, :tax, :total, :number, :receiver_id_type, :security_code, :document_situation
+    attr_accessor :key, :date, :issuer_id_number, :receiver_id_number, :message, :details, :tax, :total, :number, :receiver_id_type, :security_code, :document_situation, :issuer_id_type
     
     validates :date, presence: true
     validates :issuer_id_number, presence: true, length: {is: 12}
@@ -19,10 +19,13 @@ module FE
     validates :total, presence: true, numericality: true
     validates :number, presence: true
     validates :security_code, presence: true, length: {is: 8}
+    validates :issuer_id_type, presence: true
+    validates :receiver_id_type, presence: true
     
     def initialize(args = {})
       @key = args[:key]
       @date = args[:date]
+      @issuer_id_type = args[:issuer_id_type]
       @issuer_id_number = args[:issuer_id_number]
       @receiver_id_type = args[:receiver_id_type]
       @receiver_id_number = args[:receiver_id_number]
@@ -40,22 +43,6 @@ module FE
       }
     end
     
-    def key
-      raise "Documento inválido: #{errors.messages}" unless valid?  
-      country = "506"
-      day = "%02d" % @date.day
-      month = "%02d" % @date.month
-      year = "%02d" % (@date.year - 2000)
-      id_number = @receiver_id_number.rjust(12,"0")
-
-      situation = @document_situation
-      security_code = @security_code
-
-      result = "#{country}#{day}#{month}#{year}#{id_number}#{sequence}#{situation}#{security_code}"
-      raise "The key is invalid: #{result}" unless result.length.eql?(50)
-      
-      result
-    end
     
     def headquarters
       @headquarters ||= "001"
@@ -84,15 +71,15 @@ module FE
       builder  = Nokogiri::XML::Builder.new
       
       builder.MensajeReceptor(@namespaces) do |xml|
-        xml.Clave key
+        xml.Clave @key
         xml.NumeroCedulaEmisor @issuer_id_number
         xml.FechaEmisionDoc @date.xmlschema
         xml.Mensaje @message
         xml.DetalleMensaje @details if @details
-        xml.MontoTotalImpuesto @tax if @tax
+        xml.MontoTotalImpuesto @tax.to_f
         xml.TotalFactura @total
         xml.NumeroCedulaReceptor @receiver_id_number
-        xml.NumConsecutivoReceptor sequence
+        xml.NumeroConsecutivoReceptor sequence
       end
       
       builder
@@ -103,16 +90,32 @@ module FE
     end
     
     def api_payload
+      
       payload = {}
-      payload[:clave] = key
+      payload[:clave] = @key
       payload[:fecha] = @date.xmlschema
       payload[:emisor] = {
-        tipoIdentificacion: @receiver_id_type,
+        tipoIdentificacion: infer_id_type(@issuer_id_number),
+        numeroIdentificacion: @issuer_id_number
+      }
+      payload[:receptor] = {
+        tipoIdentificacion: infer_id_type(@receiver_id_number),
         numeroIdentificacion: @receiver_id_number
       }
+      payload[:consecutivoReceptor] = sequence
       payload
     end
     
+    def infer_id_type(id_number)
+      if id_number.to_i.to_s.size == 9
+        "01"
+      elsif id_number.to_i.to_s.size == 10
+        "02"
+      elsif id_number.to_i.to_S.size == 11
+        "03"
+      end
+    end
     
   end
+  
 end