factory_strategist 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0ce7f02ee00b07efad3acb9b46edec6e555e6a271cb8cf380f4a7da0d447780
-  data.tar.gz: 3fefcdb5cdad957f34c19c5cb4cb36106bc3df444e373478dbc697be37277780
+  metadata.gz: 1b696ae5076bfcd930027df307103f00ec6c7267d660c0eba3bca872f94f3e5c
+  data.tar.gz: c7c51ce9ec33f16d774fd9a4453d4a47faadd03a60a2ca6b83a6166f6d2b7d66
 SHA512:
-  metadata.gz: 603fa59303b82d120b1afe8d2de49e4c5e5f10e063bef151570351ec1e11396ed82da2b52dcdae881b0722d4c9e5d9a409c4b8bdca4bbefc67aa9773ffd90532
-  data.tar.gz: 6e4d85f95b0d63eddb6d5eb6a730d439a807ffb726eabad15d4c3dbd31e2c6d6f2ddb51383ba9b43efccfee1eeb9f6b007debb471f65877688775a1444de9cdb
+  metadata.gz: 374037f3c92595ce7ff909951f9a2533aed5eb3b9d8cd3d096a8ad56f638b50c5f137b3de1c00455f7c540fee678c6408746059f51eb7d196956a5c2a87627cd
+  data.tar.gz: 3b5ee739ffb8f8d14db07fba26ac735da669f016d7209b5925ec600bc41d9364940996d199e7534a83bbd236ead5dd5c27dc475cfdc4a88aa784016dc255cec4

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [Unreleased]
 
+## [0.4.0] - 2021-10-20
+
+### Changed
+
+- Rewrite `create` to `build` or `build_stubbed` and create new example block
+
 ## [0.3.0] - 2021-10-03
 
 - Rewrite main codes to make them simple(no specs!)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    factory_strategist (0.3.0)
+    factory_strategist (0.4.0)
       factory_bot
       rspec
 

data/README.md

@@ -21,16 +21,6 @@ Or install it yourself as:
 
     $ gem install factory_strategist
 
-At last, include module at in spec/rails_heper of your rails app:
-
-```ruby
-require 'factory_strategist'
-
-RSpec.configure do |config|
-  config.include FactoryStrategist
-end
-```
-
 ## Usage
 
 As for usability, it is like a kind of linter.

data/lib/factory_strategist/configure.rb

@@ -2,6 +2,9 @@
 
 require "rspec"
 require "factory_bot"
+require_relative "./proc_parser"
+
+using ProcParser
 module FactoryStrategist
   # Settings to see which method is best
   module Configure
@@ -18,21 +21,29 @@ private
 def detect_optimal_strategy_at(example)
   return unless run_successfully?(example) # when spec fails with create, no-op
 
-  return put_best_strategy_at(example, :build_stubbed) if run_successfully_with?(:build_stubbed, example)
+  return put_best_strategy_at(example, :build_stubbed) if run_successfully_with?("build_stubbed", example)
 
-  put_best_strategy_at(example, :build) if run_successfully_with?(:build, example)
+  put_best_strategy_at(example, :build) if run_successfully_with?("build", example)
 end
 
 def run_successfully?(example)
-  example.run
-  !example.exception
+  example.call
+  true
+rescue StandardError
+  false
 end
 
 def put_best_strategy_at(example, method)
   p "#{example.location} create can be replaced to #{method}"
 end
 
-def run_successfully_with?(method, example)
-  FactoryBot::Syntax::Methods.alias_method :create, method
-  run_successfully?(example)
+def run_successfully_with?(method_name, example)
+  ex = example_replaced_from_create_to(method_name, example)
+  run_successfully?(ex)
+end
+
+def example_replaced_from_create_to(method_name, example)
+  block_body = example.example.metadata[:block].body
+  new_body = "Proc.new{ #{block_body.gsub("create", method_name.to_s)} }"
+  eval(new_body) # rubocop:disable Security/Eval
 end

data/lib/factory_strategist/proc_parser.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+# module to get parsed proc as string
+# the codes in this file are based on https://secret-garden.hatenablog.com/entry/2019/09/08/145037 by @osyo-manga
+module ProcParser
+  ELEMENTS = %i[
+    magic
+    major_version
+    minor_version
+    format_type
+    misc
+    label
+    path
+    absolute_path
+    first_lineno
+    type
+    locals
+    args
+    catch_table
+    bytecode
+  ].freeze
+
+  refine RubyVM::InstructionSequence do
+    def to_h
+      ELEMENTS.zip(to_a).to_h
+    end
+  end
+
+  using self
+
+  refine Proc do
+    def body # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      path, (start_lnum, start_col, end_lnum, end_col) = code_location
+
+      raise "Unsupported file" if path.nil?
+
+      File.readlines(path).then do |lines|
+        start_line = lines[start_lnum - 1]
+        end_line = lines[end_lnum - 1]
+        if start_lnum == end_lnum
+          start_line[(start_col + 1)...(end_col - 1)]
+        elsif end_lnum - start_lnum == 1
+          start_line[(start_col + 1)...] + end_line[...(end_col - 1)]
+        else
+          lines[start_lnum...(end_lnum - 1)].join
+        end
+      end
+    end
+
+    def code_location
+      RubyVM::InstructionSequence.of(self).to_h
+                                 .then { |iseq| [iseq[:absolute_path], iseq.dig(:misc, :code_location)] }
+    end
+  end
+end

data/lib/factory_strategist/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FactoryStrategist
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_strategist
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Keiko Kaneko
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-10-03 00:00:00.000000000 Z
+date: 2021-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: factory_bot
@@ -89,6 +89,7 @@ files:
 - factory_strategist.gemspec
 - lib/factory_strategist.rb
 - lib/factory_strategist/configure.rb
+- lib/factory_strategist/proc_parser.rb
 - lib/factory_strategist/version.rb
 homepage: https://github.com/neko314/factory_strategist
 licenses: