factory_strategist 0.1.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72156c528e7c26354b741bcd6e9774a9115b55098fb66b4cbcab6df0395b3235
-  data.tar.gz: e76bb500a3e4ee0828a1347f6282262ffe39a38e8ffe40e9b42596c38116736c
+  metadata.gz: d95eb767d76d8721c3b79c5bc8540d6c1bfc1e605d8a89605892005538fb68a9
+  data.tar.gz: 40d5e549acf43c3479576ba3f9c4845428699d94c33bdbbfda4a14fdbb1b2ca7
 SHA512:
-  metadata.gz: 50e11e52cfbf2337ffba95aa6287ac0c32067a77476802ec0ec6cbe98035b443acb6fbcbfb311a658100ea71392bd19c65cdbdcf8693b6e6b196f7612bf4ac04
-  data.tar.gz: 6d7ba24c1bc541e824d66f588a73ef295ea46506b433ff3363f06d5c7d239cbd382a189386d3729f7ca13e7b4d0675c4f29fb206dc914a682713788676f8d452
+  metadata.gz: db525a1cc9609c04e6dd60b8e5279d607b9737f5f34110650eabb0c3c57c8c2f447026f3bed650cdbf135be128a9740ad4ba26796008d6415addf0afa60a08d5
+  data.tar.gz: cf947466ada2d3f73bccdd0c3adb6ec07a6729be057425e2a972cb4fe63c354300b66e1f9fbdff159d31ca1c80ce6c039f254cdb85adcb0146736575acf146ee

data/CHANGELOG.md

@@ -1,5 +1,25 @@
 ## [Unreleased]
 
-## [0.1.0] - 2021-08-22
+## [0.5.0] - 2021-10-22
 
-- Initial release
+### Changed
+
+- `build` now takes precedence over `build_stubbed`
+
+## [0.4.0] - 2021-10-20
+
+### Changed
+
+- Rewrite `create` to `build` or `build_stubbed` and create new example block
+
+## [0.3.0] - 2021-10-03
+
+- Rewrite main codes to make them simple(no specs!)
+
+## [0.2.0] - 2021-09-26
+
+- Add environment variable: `FATORYSTRATEGIST` to apply configuration this gem expands
+
+## [0.1.0] - 2021-09-24
+
+- Verify if called `FactoryBot.create` is replacable to `FactoryBot.build_stubbed` by alias

data/Gemfile.lock

@@ -1,24 +1,13 @@
 PATH
   remote: .
   specs:
-    factory_strategist (0.1.0)
+    factory_strategist (0.5.0)
+      factory_bot
+      rspec
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (6.1.4.1)
-      actionview (= 6.1.4.1)
-      activesupport (= 6.1.4.1)
-      rack (~> 2.0, >= 2.0.9)
-      rack-test (>= 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actionview (6.1.4.1)
-      activesupport (= 6.1.4.1)
-      builder (~> 3.1)
-      erubi (~> 1.4)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.1, >= 1.2.0)
     activesupport (6.1.4.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
@@ -26,42 +15,16 @@ GEM
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
     ast (2.4.2)
-    builder (3.2.4)
     concurrent-ruby (1.1.9)
-    crass (1.0.6)
     diff-lcs (1.4.4)
-    erubi (1.10.0)
     factory_bot (6.2.0)
       activesupport (>= 5.0.0)
     i18n (1.8.10)
       concurrent-ruby (~> 1.0)
-    loofah (2.12.0)
-      crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
-    method_source (1.0.0)
     minitest (5.14.4)
-    nokogiri (1.12.4-x86_64-darwin)
-      racc (~> 1.4)
-    nokogiri (1.12.4-x86_64-linux)
-      racc (~> 1.4)
     parallel (1.20.1)
     parser (3.0.2.0)
       ast (~> 2.4.1)
-    racc (1.5.2)
-    rack (2.2.3)
-    rack-test (1.1.0)
-      rack (>= 1.0, < 3)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
-      nokogiri (>= 1.6)
-    rails-html-sanitizer (1.4.2)
-      loofah (~> 2.3)
-    railties (6.1.4.1)
-      actionpack (= 6.1.4.1)
-      activesupport (= 6.1.4.1)
-      method_source
-      rake (>= 0.13)
-      thor (~> 1.0)
     rainbow (3.0.0)
     rake (13.0.6)
     regexp_parser (2.1.1)
@@ -78,14 +41,6 @@ GEM
     rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-rails (5.0.2)
-      actionpack (>= 5.2)
-      activesupport (>= 5.2)
-      railties (>= 5.2)
-      rspec-core (~> 3.10)
-      rspec-expectations (~> 3.10)
-      rspec-mocks (~> 3.10)
-      rspec-support (~> 3.10)
     rspec-support (3.10.2)
     rubocop (1.20.0)
       parallel (~> 1.10)
@@ -104,25 +59,23 @@ GEM
       rubocop (~> 1.0)
       rubocop-ast (>= 1.1.0)
     ruby-progressbar (1.11.0)
-    thor (1.1.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.0.0)
-    zeitwerk (2.4.2)
+    zeitwerk (2.5.1)
 
 PLATFORMS
+  x86_64-darwin-19
   x86_64-darwin-20
   x86_64-linux
 
 DEPENDENCIES
-  factory_bot
   factory_strategist!
   rake (~> 13.0)
   rspec (~> 3.0)
-  rspec-rails
   rubocop (~> 1.7)
   rubocop-rake
   rubocop-rspec
 
 BUNDLED WITH
-   2.2.26
+   2.2.28

data/README.md

@@ -21,16 +21,6 @@ Or install it yourself as:
 
     $ gem install factory_strategist
 
-At last, include module at in spec/rails_heper of your rails app:
-
-```ruby
-require 'factory_strategist'
-
-RSpec.configure do |config|
-  config.include FactoryStrategist
-end
-```
-
 ## Usage
 
 As for usability, it is like a kind of linter.
@@ -58,7 +48,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/factory_strategist. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/[USERNAME]/factory_strategist/blob/main/CODE_OF_CONDUCT.md).
+Bug reports and pull requests are welcome on GitHub at https://github.com/neko314/factory_strategist. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/neko314/factory_strategist/blob/main/CODE_OF_CONDUCT.md).
 
 ## License
 
@@ -66,4 +56,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the FactoryStrategist project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/factory_strategist/blob/main/CODE_OF_CONDUCT.md).
+Everyone interacting in the FactoryStrategist project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/neko314/factory_strategist/blob/main/CODE_OF_CONDUCT.md).

data/factory_strategist.gemspec

@@ -32,8 +32,8 @@ Gem::Specification.new do |spec|
 
   # Uncomment to register a new dependency of your gem
   # spec.add_dependency "example-gem", "~> 1.0"
-  spec.add_development_dependency "factory_bot"
-  spec.add_development_dependency "rspec-rails"
+  spec.add_dependency "factory_bot"
+  spec.add_dependency "rspec"
   spec.add_development_dependency "rubocop-rake"
   spec.add_development_dependency "rubocop-rspec"
 

data/lib/factory_strategist/configure.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require "rspec"
+require "factory_bot"
+require_relative "./proc_parser"
+
+using ProcParser
+module FactoryStrategist
+  # Settings to see which method is best
+  module Configure
+    RSpec.configure do |config|
+      config.around(:example) do |ex|
+        detect_optimal_strategy_at(ex)
+      end
+    end
+  end
+end
+
+private
+
+def detect_optimal_strategy_at(example)
+  return unless run_successfully?(example) # when spec fails with create, no-op
+
+  return put_best_strategy_at(example, :build) if run_successfully_with?("build", example)
+
+  put_best_strategy_at(example, :build_stubbed) if run_successfully_with?("build_stubbed", example)
+end
+
+def run_successfully?(example)
+  example.call
+  true
+rescue StandardError
+  false
+end
+
+def put_best_strategy_at(example, method)
+  p "#{example.location} create can be replaced to #{method}"
+end
+
+def run_successfully_with?(method_name, example)
+  ex = example_replaced_from_create_to(method_name, example)
+  run_successfully?(ex)
+end
+
+def example_replaced_from_create_to(method_name, example)
+  block_body = example.example.metadata[:block].body
+  new_body = "Proc.new{ #{block_body.gsub("create", method_name.to_s)} }"
+  eval(new_body) # rubocop:disable Security/Eval
+end

data/lib/factory_strategist/proc_parser.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+# module to get parsed proc as string
+# the codes in this file are based on https://secret-garden.hatenablog.com/entry/2019/09/08/145037 by @osyo-manga
+module ProcParser
+  ELEMENTS = %i[
+    magic
+    major_version
+    minor_version
+    format_type
+    misc
+    label
+    path
+    absolute_path
+    first_lineno
+    type
+    locals
+    args
+    catch_table
+    bytecode
+  ].freeze
+
+  refine RubyVM::InstructionSequence do
+    def to_h
+      ELEMENTS.zip(to_a).to_h
+    end
+  end
+
+  using self
+
+  refine Proc do
+    def body # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      path, (start_lnum, start_col, end_lnum, end_col) = code_location
+
+      raise "Unsupported file" if path.nil?
+
+      File.readlines(path).then do |lines|
+        start_line = lines[start_lnum - 1]
+        end_line = lines[end_lnum - 1]
+        if start_lnum == end_lnum
+          start_line[(start_col + 1)...(end_col - 1)]
+        elsif end_lnum - start_lnum == 1
+          start_line[(start_col + 1)...] + end_line[...(end_col - 1)]
+        else
+          lines[start_lnum...(end_lnum - 1)].join
+        end
+      end
+    end
+
+    def code_location
+      RubyVM::InstructionSequence.of(self).to_h
+                                 .then { |iseq| [iseq[:absolute_path], iseq.dig(:misc, :code_location)] }
+    end
+  end
+end

data/lib/factory_strategist/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FactoryStrategist
-  VERSION = "0.1.0"
+  VERSION = "0.5.0"
 end

data/lib/factory_strategist.rb

@@ -1,23 +1,4 @@
 # frozen_string_literal: true
 
 require_relative "factory_strategist/version"
-require "rspec"
-require "factory_bot"
-
-# Settings to see which method is best
-module FactoryStrategist
-  RSpec.configure do |config|
-    config.before(:suite) do |_ex|
-      FactoryBot::Syntax::Methods.alias_method :create, :build_stubbed
-    end
-
-    config.after(:example) do |ex|
-      case ex.exception
-      when RSpec::Expectations::ExpectationNotMetError
-        # no-op
-      when nil
-        p "#{ex.location} create can be replaced to build_stubbed"
-      end
-    end
-  end
-end
+require_relative "factory_strategist/configure" if ENV["FATORYSTRATEGIST"]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_strategist
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Keiko Kaneko
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-09-24 00:00:00.000000000 Z
+date: 2021-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: factory_bot
@@ -17,7 +17,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -25,13 +25,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -88,6 +88,8 @@ files:
 - bin/setup
 - factory_strategist.gemspec
 - lib/factory_strategist.rb
+- lib/factory_strategist/configure.rb
+- lib/factory_strategist/proc_parser.rb
 - lib/factory_strategist/version.rb
 homepage: https://github.com/neko314/factory_strategist
 licenses: