factory_sloth 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cefc242e547927b9e8805b2dd4be60905f4dd5e484a5b42da6699e3c104879e8
-  data.tar.gz: 60c06cc54a40a35b4a72850d636510af0883071760fd88b5587091e1866de261
+  metadata.gz: 3550aaf57e03aa0da8d68264bab3c4a0a17ed264995859f34cc641e7e376b51b
+  data.tar.gz: d947f5e3533b24b7740d509b5e9b8f3a832a6c535eb81f859ba7c562127c3e5a
 SHA512:
-  metadata.gz: c96fcd9841cd70fc952f6f503bd2e84024a2bf786fd132805f0badff7b5208f720be9cc36a73981d77f65fa932e256d7b4ecf2c08e59425ce811e10c61f2813a
-  data.tar.gz: 885c2928964f3dff1e041a4fa09b3c85a13a452e3168a6985754b0ec6fae01c1cc550001f76808451d02ee477bdcb82b1d2c10dd82576f95b1555b2eab325dcb
+  metadata.gz: e9abcbc30c854da1ec58f4ab292ab6ed9a851dcbd11bd00291b2902bdec14ec79c21145033c2a984b7243831dd27b426bf5e33f6e9d22272d673a9ff2f61dd97
+  data.tar.gz: '03280bc6477e646583c5af49d46e8bacbf611387181c3e0625e007c019170b697151a78fbd1698a859358a512f483a9949f3b6b27006fe92fc85fd10ccb2b149'

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [Unreleased]
 
+## [1.2.0] - 2023-05-16
+
+### Added
+
+- Added support for magic comments `# sloth:disable`, `# sloth:enable`
+
 ## [1.1.0] - 2023-05-16
 
 ### Added

data/README.md

@@ -60,6 +60,9 @@ The `conflict` case is rare. It only happens if individual examples were green a
 
 - only works with RSpec so far
 - downgrades create calls that never run (e.g. in skipped examples)
+- downgrades create calls that are only checked for an absence of effects
+  - e.g. `a = create(:a); b = create(:b); expect(Record.filtered).to eq [b]`
+  - `# sloth:disable` / `# sloth:enable` comments can be used to control this
 
 ## Development
 

data/lib/factory_sloth/create_call_finder.rb

@@ -7,29 +7,44 @@ class FactorySloth::CreateCallFinder < Ripper
     new(code).tap(&:parse).locations
   end
 
-  def initialize(...)
+  def initialize(code, ...)
     super
+    @code = code
+    @disabled = false
     @locations = []
   end
   private_class_method :new
 
+  def store_location(loc)
+    @locations << loc if loc.instance_of?(Array) && !@disabled
+  end
+
   def on_ident(name, *)
     [lineno, column] if %w[create create_list create_pair].include?(name)
   end
 
   def on_call(mod, _, loc, *)
-    @locations << loc if loc.instance_of?(Array) && mod == 'FactoryBot'
+    store_location(loc) if mod == 'FactoryBot'
   end
 
   def on_command_call(mod, _, loc, *)
-    @locations << loc if loc.instance_of?(Array) && mod == 'FactoryBot'
+    store_location(loc) if mod == 'FactoryBot'
+  end
+
+  def on_comment(text, *)
+    return unless /sloth:(?<directive>disable|enable)/ =~ text
+
+    directive == 'disable' &&
+      @locations.reject! { |loc| loc.first == lineno } ||
+      (@lines ||= @code.lines)[lineno - 1].match?(/^\s*#/) &&
+      (@disabled = directive != 'enable')
   end
 
   def on_fcall(loc, *)
-    @locations << loc if loc.instance_of?(Array)
+    store_location(loc)
   end
 
   def on_vcall(loc, *)
-    @locations << loc if loc.instance_of?(Array)
+    store_location(loc)
   end
 end

data/lib/factory_sloth/version.rb

@@ -1,3 +1,3 @@
 module FactorySloth
-  VERSION = '1.1.0'
+  VERSION = '1.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: factory_sloth
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Janosch Müller