factory_girl_remote_strategy 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1da2ce9b34391189b1ac43cd32de2a39a2a4c92
-  data.tar.gz: c60a3580d849e86c768bf99fccd4b107ba62fa56
+  metadata.gz: ce58337e23b72366c09ab620b0d6c70ce38da4e7
+  data.tar.gz: f7882563ab29647fcb1409f99359ca4b8f4aa45c
 SHA512:
-  metadata.gz: fd350cf6b42a8774bc7e4e35bababb7819b4d49fa7f196b70653b1e8774a8e27f7ea04143a89675820aa479dab04993320e921945261172bf753f4c2ec432764
-  data.tar.gz: 6f5ecd9152aed7283bcb5de63972ea32d055fcc2436f81ba695340247798ef0c34d50d073d32b2fa4383df9b75b3dd45f34b393ce59f020e9ca8a3b83e381d4d
+  metadata.gz: 77531f5ee48247c23d5b8ae304988d1dad2e2d1a76e07ffc0a69a80c2b0c0f2ef04f7fa070f6a0fc247da726523355b3b5cdf16843210b14d2f28de4f69ce4c1
+  data.tar.gz: cc7d8714e9c337663e87d775564e1974c6be33e481d5939e73d66c10789e168e4b020c3c2e99efe3f8d8adfbc708cf732e078e7d3ca2adf1278d1c9c2f0c1342

data/lib/factory_girl_remote_strategy/version.rb

@@ -1,3 +1,3 @@
 module FactoryGirlRemoteStrategy
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/lib/factory_girl_remote_strategy.rb

@@ -61,14 +61,27 @@ module FactoryGirl
         "#{entity.class.site}#{entity.class.prefix}#{entity.class.collection_name}/#{entity.id}.json"
       end
 
-      def collection_url(collection)
-        (collection.first.is_a?(Class) ? collection.first : collection.first.class).instance_eval { "#{site}#{prefix}#{collection_name}.json" }
+      def collection_url(collection, params = {})
+        (collection.first.is_a?(Class) ? collection.first : collection.first.class).instance_eval { "#{site}#{prefix}#{collection_name}.json#{'?' if params.any?}#{params.to_query}" }
+      end
+    end
+  end
+
+  class RemoteNotFoundStrategy < RemoteStrategy
+    def result(evaluation)
+      @strategy.result(evaluation).tap do |e|
+        body = { errors: [{ code: 'resource_not_found',
+          message: "Couldn't find #{e.class} with #{e.class.primary_key}=#{e.public_send(e.class.primary_key)}" } ] }.to_json
+        FakeWeb.register_uri(:get, self.class.entity_url(e), body: body, status: 404)
+        remote_search(e.class, search: { :"#{e.class.primary_key}_eq" => e.public_send(e.class.primary_key) }) # empty search
+        remote_search(e.class, search: { :"#{e.class.primary_key}_in" => [e.public_send(e.class.primary_key)] }) # empty search
       end
     end
   end
 end
 
 FactoryGirl.register_strategy(:remote, FactoryGirl::RemoteStrategy)
+FactoryGirl.register_strategy(:remote_not_found, FactoryGirl::RemoteNotFoundStrategy)
 
 ##
 # Helper method for register search url with provided params and serialized collection as response.
@@ -76,6 +89,6 @@ FactoryGirl.register_strategy(:remote, FactoryGirl::RemoteStrategy)
 def remote_search(*args)
   params = args.extract_options!
   collection = args.flatten
-  FakeWeb.register_uri(:get, "#{FactoryGirl::RemoteStrategy.collection_url(collection)}?#{params.to_query}",
+  FakeWeb.register_uri(:get, FactoryGirl::RemoteStrategy.collection_url(collection, params),
     body: (collection.first.is_a?(Class) ? "[]" : collection.map { |e| FactoryGirl::RemoteStrategy.entity_hash(e) }.to_json))
 end

data/spec/factory_girl_remote_not_found_strategy_spec.rb

@@ -0,0 +1,19 @@
+require "spec_helper"
+
+describe FactoryGirl::RemoteNotFoundStrategy do
+  before { FactoryGirl.remote_not_found(:incident, id: 1) }
+
+  it "registers 404 get url with FakeWeb" do
+    expect { Incident.find(1) }.to raise_error ActiveResource::ResourceNotFound
+  end
+
+  it "registers search by id as one in array request with empty array" do
+    incident = Incident.find(:first, params: { search: { id_in: [1] } })
+    expect(incident).to be_nil
+  end
+
+  it "registers search by id as exact value request with empty array" do
+    incident = Incident.find(:first, params: { search: { id_eq: 1 } })
+    expect(incident).to be_nil
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_girl_remote_strategy
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Alex Avoyants
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-30 00:00:00.000000000 Z
+date: 2014-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -130,6 +130,7 @@ files:
 - spec/factories/postcode.rb
 - spec/factories/user.rb
 - spec/factories/victim.rb
+- spec/factory_girl_remote_not_found_strategy_spec.rb
 - spec/factory_girl_remote_strategy_spec.rb
 - spec/spec_helper.rb
 - spec/support/group.rb
@@ -170,6 +171,7 @@ test_files:
 - spec/factories/postcode.rb
 - spec/factories/user.rb
 - spec/factories/victim.rb
+- spec/factory_girl_remote_not_found_strategy_spec.rb
 - spec/factory_girl_remote_strategy_spec.rb
 - spec/spec_helper.rb
 - spec/support/group.rb