factory_girl 4.2.0 → 4.3.0

data/spec/acceptance/callbacks_spec.rb

@@ -46,6 +46,31 @@ describe "callbacks" do
   end
 end
 
+describe 'callbacks using Symbol#to_proc' do
+  before do
+    define_model('User') do
+      def confirmed?
+        !!@confirmed
+      end
+
+      def confirm!
+        @confirmed = true
+      end
+    end
+
+    FactoryGirl.define do
+      factory :user do
+        after :build, &:confirm!
+      end
+    end
+  end
+
+  it 'runs the callback correctly' do
+    user = FactoryGirl.build(:user)
+    expect(user).to be_confirmed
+  end
+end
+
 describe "callbacks using syntax methods without referencing FactoryGirl explicitly" do
   before do
     define_model("User", first_name: :string, last_name: :string)
@@ -175,3 +200,54 @@ describe 'binding a callback to multiple callbacks' do
     expect(FactoryGirl.build_stubbed(:user, name: 'John Doe').name).to eq 'JOHN DOE'
   end
 end
+
+describe 'global callbacks' do
+  include FactoryGirl::Syntax::Methods
+
+  before do
+    define_model('User', name: :string)
+    define_model('Company', name: :string)
+
+    FactoryGirl.define do
+      after :build do |object|
+        object.name = case object.class.to_s
+                      when 'User' then 'John Doe'
+                      when 'Company' then 'Acme Suppliers'
+                      end
+      end
+
+      after :create do |object|
+        object.name = "#{object.name}!!!"
+      end
+
+      trait :awesome do
+        after :build do |object|
+          object.name = "___#{object.name}___"
+        end
+
+        after :create do |object|
+          object.name = "A#{object.name}Z"
+        end
+      end
+
+      factory :user do
+        after :build do |user|
+          user.name = user.name.downcase
+        end
+      end
+
+      factory :company do
+        after :build do |company|
+          company.name = company.name.upcase
+        end
+      end
+    end
+  end
+
+  it 'triggers after build callbacks for all factories' do
+    expect(build(:user).name).to eq 'john doe'
+    expect(create(:user).name).to eq 'john doe!!!'
+    expect(create(:user, :awesome).name).to eq 'A___john doe___!!!Z'
+    expect(build(:company).name).to eq 'ACME SUPPLIERS'
+  end
+end

data/spec/acceptance/create_pair_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe "create multiple instances" do
+  before do
+    define_model('Post', title: :string, position: :integer)
+
+    FactoryGirl.define do
+      factory(:post) do |post|
+        post.title "Through the Looking Glass"
+        post.position { rand(10**4) }
+      end
+    end
+  end
+
+  context "without default attributes" do
+    subject { FactoryGirl.create_pair(:post) }
+
+    its(:length) { should eq 2 }
+
+    it "creates all the posts" do
+      subject.each do |record|
+        expect(record).not_to be_new_record
+      end
+    end
+
+    it "uses the default factory values" do
+      subject.each do |record|
+        expect(record.title).to eq "Through the Looking Glass"
+      end
+    end
+  end
+end

data/spec/acceptance/defining_methods_inside_a_factory_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe 'defining methods inside FactoryGirl' do
+  it 'raises with a meaningful message' do
+    define_model('User')
+
+    expect do
+      FactoryGirl.define do
+        factory :user do
+          def generate_name
+            'John Doe'
+          end
+        end
+      end
+    end.to raise_error FactoryGirl::MethodDefinitionError, /Defining methods in blocks \(trait or factory\) is not supported \(generate_name\)/
+  end
+end

data/spec/acceptance/definition_camel_string_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe "an instance generated by a factory named a camel case string " do
+  before do
+    define_model("UserModel")
+
+    FactoryGirl.define do
+      factory 'UserModel', class: UserModel
+    end
+  end
+
+  it "registers the UserModel factory" do
+    expect(FactoryGirl.factory_by_name('UserModel')).to be_a(FactoryGirl::Factory)
+  end
+end

data/spec/acceptance/register_strategies_spec.rb

@@ -49,6 +49,14 @@ describe "register custom strategies" do
     expect(inserted_items.length).to eq 2
     expect(inserted_items.map(&:name)).to eq ["Custom strategy", "Custom strategy"]
   end
+
+  it "allows using the *_pair method to build a list using a custom strategy" do
+    FactoryGirl.register_strategy(:insert, custom_strategy)
+
+    inserted_items = FactoryGirl.insert_pair(:named_object)
+    expect(inserted_items.length).to eq 2
+    expect(inserted_items.map(&:name)).to eq ["Custom strategy", "Custom strategy"]
+  end
 end
 
 describe "including FactoryGirl::Syntax::Methods when custom strategies have been declared" do

data/spec/acceptance/syntax_methods_within_dynamic_attributes_spec.rb

@@ -38,4 +38,14 @@ describe "syntax methods within dynamic attributes" do
     expect(FactoryGirl.build(:post).title).to eq "generate result"
     expect(FactoryGirl.attributes_for(:post)[:title]).to be_nil
   end
+
+  it 'allows syntax methods to be used when the block has an arity of 1' do
+    FactoryGirl.define do
+      factory :post_using_block_with_variable, parent: :post do
+        user {|_| build(:user) }
+      end
+    end
+
+    expect(FactoryGirl.build(:post_using_block_with_variable).user).to be_instance_of(User)
+  end
 end

data/spec/factory_girl/callback_spec.rb

@@ -30,7 +30,7 @@ describe FactoryGirl::Callback do
   it "allows valid callback names to be assigned" do
     FactoryGirl.callback_names.each do |callback_name|
       expect { FactoryGirl::Callback.new(callback_name, -> {}) }.
-        to_not raise_error(FactoryGirl::InvalidCallbackNameError)
+        to_not raise_error
     end
   end
 

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: factory_girl
 version: !ruby/object:Gem::Version
-  version: 4.2.0
-  prerelease: 
+  version: 4.3.0
 platform: ruby
 authors:
 - Josh Clayton
@@ -10,28 +9,25 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-18 00:00:00.000000000 Z
+date: 2013-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -39,7 +35,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -47,7 +42,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -55,7 +49,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -63,87 +56,76 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.12.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.12.8
 - !ruby/object:Gem::Dependency
   name: bourne
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -151,7 +133,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -159,38 +140,35 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: ! "factory_girl provides a framework and DSL for defining and\n                      using
-  factories - less error-prone, more explicit, and\n                      all-around
-  easier to work with than fixtures."
+description: |-
+  factory_girl provides a framework and DSL for defining and
+                        using factories - less error-prone, more explicit, and
+                        all-around easier to work with than fixtures.
 email:
 - jclayton@thoughtbot.com
 - jferris@thoughtbot.com
@@ -220,8 +198,6 @@ files:
 - features/step_definitions/factory_girl_steps.rb
 - features/support/env.rb
 - features/support/factories.rb
-- gemfiles/3.0.gemfile
-- gemfiles/3.0.gemfile.lock
 - gemfiles/3.1.gemfile
 - gemfiles/3.1.gemfile.lock
 - gemfiles/3.2.gemfile
@@ -292,8 +268,11 @@ files:
 - spec/acceptance/build_stubbed_spec.rb
 - spec/acceptance/callbacks_spec.rb
 - spec/acceptance/create_list_spec.rb
+- spec/acceptance/create_pair_spec.rb
 - spec/acceptance/create_spec.rb
 - spec/acceptance/define_child_before_parent_spec.rb
+- spec/acceptance/defining_methods_inside_a_factory_spec.rb
+- spec/acceptance/definition_camel_string_spec.rb
 - spec/acceptance/definition_spec.rb
 - spec/acceptance/definition_without_block_spec.rb
 - spec/acceptance/global_initialize_with_spec.rb
@@ -347,28 +326,28 @@ files:
 - spec/support/matchers/trait.rb
 - spec/support/shared_examples/strategy.rb
 homepage: https://github.com/thoughtbot/factory_girl
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.1.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: factory_girl provides a framework and DSL for defining and using model instance
   factories.
 test_files:
@@ -378,8 +357,6 @@ test_files:
 - features/step_definitions/factory_girl_steps.rb
 - features/support/env.rb
 - features/support/factories.rb
-- gemfiles/3.0.gemfile
-- gemfiles/3.0.gemfile.lock
 - gemfiles/3.1.gemfile
 - gemfiles/3.1.gemfile.lock
 - gemfiles/3.2.gemfile
@@ -398,8 +375,11 @@ test_files:
 - spec/acceptance/build_stubbed_spec.rb
 - spec/acceptance/callbacks_spec.rb
 - spec/acceptance/create_list_spec.rb
+- spec/acceptance/create_pair_spec.rb
 - spec/acceptance/create_spec.rb
 - spec/acceptance/define_child_before_parent_spec.rb
+- spec/acceptance/defining_methods_inside_a_factory_spec.rb
+- spec/acceptance/definition_camel_string_spec.rb
 - spec/acceptance/definition_spec.rb
 - spec/acceptance/definition_without_block_spec.rb
 - spec/acceptance/global_initialize_with_spec.rb