factory_bot_rails 5.2.0 → 6.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c41b59df4b5238c0092ff30e2684512f2545e2c81043108c333638c151b46ec1
-  data.tar.gz: 2a466525baf96430e60c79b2b9d0dbd963a53170d666577f147a6124a625568d
+  metadata.gz: 70ac3e65ecb946bde74a107d453206896d96a0bdd02d52f6e9d99cc4b11ace65
+  data.tar.gz: c5478bf4191651ac02e944af9d118f2243b10fd508073b0911c9b165ad6afd1e
 SHA512:
-  metadata.gz: 10f6949faf0b18045da785caeb07e66b18c46269a81e195bb8d1bc32a415b70a59f437be960119b222e218d723dc5dd6358e07ebcdb782494631569d30c866d1
-  data.tar.gz: 294558d462c35ec56ba610faa785ad49375bbf6f580a93df287c17f7a767debc2fb1dcd0812aca44d52d6f1cea0c15c92f8e39ea0e062813509fb302100d61cf
+  metadata.gz: 4ff19ee6c07babb79676b2ecea45b5abc8dcc6af75042409a3a4e373e9db91787b0f0506d626700303414fc9b2e50f355c2757e1ec9289fccdcf14b6239f30e8
+  data.tar.gz: d1a7e2c0c2966eff606e58addc63fe1dba533934fcb45ff1c7399ce5afd5604f1efab1d755e133bcd54f6b12850c76df88108b74df0da19917864e0c94ad8b92

data/CONTRIBUTING.md

@@ -35,5 +35,5 @@ Some things that will increase the chance that your pull request is accepted:
 * Follow our [style guide][style].
 * Write a [good commit message][commit].
 
-[style]: https://github.com/thoughtbot/guides/tree/master/style
+[style]: https://github.com/thoughtbot/guides/tree/main/general
 [commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2008-2019 Joe Ferris and thoughtbot, inc.
+Copyright (c) 2008-2020 Joe Ferris and thoughtbot, inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/NEWS.md

@@ -1,27 +1,90 @@
-factory_bot_rails versioning is synced with factory_bot releases. For this reason
+factory\_bot\_rails versioning is synced with factory\_bot releases. For this reason
 there might not be any notable changes in new versions of this project.
 
 # NEWS
 
+## 6.4.3 (December 29, 2023)
+
+* Changed: allow sequence definitions for ActiveRecord primary keys (Mike
+  Burns).
+* Changed: Support Ruby 3.0+, Rails 6.1+ (Mike Burns)
+* Documentation improvements (obregonia1).
+* Internal: GitHub Actions improvements (Lorenzo Zabot, ydah).
+* Internal: RubyGems points to changelog (Tilo Sloboda).
+* Internal: Bump standard, rake, activerecord, appraisal, rspec-rails (Mike
+  Burns).
+
+## 6.4.2 (November 23, 2023)
+* Fixed: Fix Rails 7.1.2 + monkey-patched ActiveRecord compatibility (Adif
+  Sgaid, Benoit Tigeot)
+* Internal: Test against Rails 7.1 (y-yagi)
+* Internal: Fix links to old files after renaming the main branch to `main`
+  (y-yagi)
+
+## 6.4.0 (November 17, 2023)
+
+* Releasing this for consistency with the factory\_bot dependency.
+
+## 6.3.0 (November 17, 2023)
+
+* Changed: reject sequence definitions for ActiveRecord primary keys (Sean
+  Doyle).
+* Changed: factory\_bot dependency to ~> 6.4 (Mike Burns).
+* Changed: upgrade dependencies (Daniel Colson).
+* Add: `projections.json` for Rails.vim (Caleb Hearth).
+* Docs: fix broken link (Edu Depetris).
+* Docs: mention Rails generator in docs (Edu Depetris).
+* Docs: fix typo (Yudai Takada).
+* Internal: skip Spring version 2.1.1 due to a bug in that release (Christina
+  Entcheva, Daniel Colson).
+* Internal: test against Rails 6.1 (Antonis Berkakis).
+* Internal: test against Ruby 3 (Daniel Colson).
+* Internal: fewer warnings in Cucumber tests (Daniel Colson).
+* Internal: use GitHub Actions for CI (Mathieu Jobin).
+* Internal: a whole bunch of cleanup (Daniel Colson).
+* Internal: fix CI due to a Bundler output change (Mike Burns).
+
+## 6.2.0 (May 7, 2021)
+
+* Changed: factory\_bot dependency to ~> 6.2.0
+
+## 6.1.0 (July 8, 2020)
+
+* Changed: factory\_bot dependency to ~> 6.1.0
+
+## 6.0.0 (June 18, 2020)
+
+* Fixed: generate a plural factory name when the --force-plural flag is provided
+* Changed: factory\_bot dependency to ~> 6.0.0
+* Removed: `"factory_bot.register_reloader"` initializer, now registering the
+  reloader after application initialization
+* Removed: support for EOL versions of Ruby (2.3, 2.4) and Rails (4.2)
+
 ## 5.2.0 (April 26, 2020)
-* Changed: factory_bot dependency to ~> 5.2.0
+
+* Changed: factory\_bot dependency to ~> 5.2.0
 
 ## 5.1.1 (September 24, 2019)
+
 * Fixed: Ensure definitions do not load before I18n is initialized
 
 ## 5.1.0 (September 24, 2019)
-* Changed: factory_bot dependency to ~> 5.1.0
+
+* Changed: factory\_bot dependency to ~> 5.1.0
 
 ## 5.0.2 (April 14, 2019)
+
 * Bugfix: Reload factory\_bot whenever the application changes to avoid holding
   onto stale object references
 * Bugfix: Avoid watching project root when no factory definitions exist
 
 ## 5.0.1 (February 9, 2019)
+
 * Bugfix: Avoid watching files and directories that don't exist (to avoid a
   file watching bug in Rails https://github.com/rails/rails/issues/32700)
 
 ## 5.0.0 (February 1, 2019)
+
 * Added: calling reload! in the Rails console will reload any factory definition files that have changed
 * Added: support for custom generator templates
 * Added: `definition_file_paths` configuration option, making it easier to place factories in custom locations
@@ -30,35 +93,45 @@ there might not be any notable changes in new versions of this project.
 * Removed: support for EOL version of Ruby and Rails
 
 ## 4.11.1 (September 7, 2018)
+
 * Update generator to use dynamic attributes instead of deprecated static attributes
 
 ## 4.11.0 (August 16, 2018)
+
 * No notable changes
 
 ## 4.10.0 (May 25, 2018)
+
 * No notable changes
 
 ## 4.8.2 (October 20, 2017)
+
 * Rename factory\_girl\_rails to factory\_bot\_rails
 
 ## 4.7.0 (April 1, 2016)
+
 * No notable changes
 
 ## 4.6.0 (February 1, 2016)
+
 * No notable changes
 
 ## 4.5.0 (October 17, 2014)
+
 * Improved README
 
 ## 4.4.1 (February 26, 2014)
+
 * Support Spring
 
 ## 4.2.1 (February 8, 2013)
+
 * Fix bug when configuring FG and RSpec fixture directory
 * Remove debugging
 * Require factory\_girl\_rails explicitly in generator
 
 ## 4.2.0 (January 25, 2013)
+
 * Add appraisal and get test suite working reliably with turn gem
 * Support MiniTest
 * Allow a custom directory for factories to be specified

data/README.md

@@ -1,4 +1,4 @@
-# factory_bot_rails [![Build Status][ci-image]][ci] [![Code Climate][grade-image]][grade] [![Gem Version][version-image]][version] [![Reviewed by Hound][hound-image]][hound]
+# factory_bot_rails [![Code Climate][grade-image]][grade] [![Gem Version][version-image]][version]
 
 [factory_bot][fb] is a fixtures replacement with a straightforward definition
 syntax, support for multiple build strategies (saved instances, unsaved
@@ -15,7 +15,7 @@ Check out the [guide](https://github.com/thoughtbot/factory_bot/blob/4-9-0-stabl
 factory\_bot\_rails provides Rails integration for [factory_bot][fb].
 
 Supported Rails versions are listed in [`Appraisals`](Appraisals). Supported
-Ruby versions are listed in [`.travis.yml`](.travis.yml).
+Ruby versions are listed in [`.github/workflows/build.yml`](.github/workflows/build.yml).
 
 ## Download
 
@@ -36,7 +36,7 @@ end
 ```
 
 You may want to configure your test suite to include factory\_bot methods; see
-[configuration](https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#configure-your-test-suite).
+[configuration](https://github.com/thoughtbot/factory_bot/blob/main/GETTING_STARTED.md#configure-your-test-suite).
 
 ### Automatic Factory Definition Loading
 
@@ -144,25 +144,30 @@ Note that factory\_bot\_rails will only use this custom template if you are
 generating each factory in a separate file; it will have no effect if you are
 generating all of your factories in `test/factories.rb` or `spec/factories.rb`.
 
-[default factory template]: https://github.com/thoughtbot/factory_bot_rails/tree/master/lib/generators/factory_bot/model/templates/factories.erb
+Factory\_bot\_rails will add a custom generator:
+
+```shell
+rails generate factory_bot:model NAME [field:type field:type] [options]
+```
+
+[default factory template]: https://github.com/thoughtbot/factory_bot_rails/tree/main/lib/generators/factory_bot/model/templates/factories.erb
 
 ## Contributing
 
 Please see [CONTRIBUTING.md](CONTRIBUTING.md).
 
-factory_bot_rails was originally written by Joe Ferris and is now maintained by Josh
-Clayton. Many improvements and bugfixes were contributed by the [open source
+factory_bot_rails was originally written by Joe Ferris and is maintained by thoughtbot. Many improvements and bugfixes were contributed by the [open source
 community](https://github.com/thoughtbot/factory_bot_rails/graphs/contributors).
 
 ## License
 
-factory_bot_rails is Copyright © 2008-2019 Joe Ferris and thoughtbot. It is free
+factory_bot_rails is Copyright © 2008-2020 Joe Ferris and thoughtbot. It is free
 software, and may be redistributed under the terms specified in the
 [LICENSE](LICENSE) file.
 
 ## About thoughtbot
 
-![thoughtbot](https://thoughtbot.com/logo.png)
+![thoughtbot](https://thoughtbot.com/brand_assets/93:44.svg)
 
 factory_bot_rails is maintained and funded by thoughtbot, inc.
 The names and logos for thoughtbot are trademarks of thoughtbot, inc.
@@ -172,8 +177,6 @@ See [our other projects][community].
 We are [available for hire][hire].
 
 [fb]: https://github.com/thoughtbot/factory_bot
-[ci]: http://travis-ci.org/thoughtbot/factory_bot_rails?branch=master
-[ci-image]: https://secure.travis-ci.org/thoughtbot/factory_bot_rails.svg
 [grade]: https://codeclimate.com/github/thoughtbot/factory_bot_rails
 [grade-image]: https://codeclimate.com/github/thoughtbot/factory_bot_rails.svg
 [community]: https://thoughtbot.com/community?utm_source=github

data/lib/factory_bot_rails/factory_validator.rb

@@ -0,0 +1,23 @@
+module FactoryBotRails
+  class FactoryValidator
+    def initialize(validators = [])
+      @validators = Array(validators)
+    end
+
+    def add_validator(validator)
+      @validators << validator
+    end
+
+    def run
+      ActiveSupport::Notifications.subscribe("factory_bot.compile_factory", &validate_compiled_factory)
+    end
+
+    private
+
+    def validate_compiled_factory
+      proc do |event|
+        @validators.each { |validator| validator.validate!(event.payload) }
+      end
+    end
+  end
+end

data/lib/factory_bot_rails/generators/non_rspec_generator.rb

@@ -9,7 +9,7 @@ module FactoryBotRails
         @generators.test_framework(
           test_framework,
           fixture: false,
-          fixture_replacement: :factory_bot,
+          fixture_replacement: :factory_bot
         )
       end
 

data/lib/factory_bot_rails/generators/null_generator.rb

@@ -1,7 +1,7 @@
 module FactoryBotRails
   module Generators
     class NullGenerator
-      def initialize(generators)
+      def initialize(*)
       end
 
       def run

data/lib/factory_bot_rails/generators/rspec_generator.rb

@@ -8,7 +8,7 @@ module FactoryBotRails
       def run
         @generators.fixture_replacement(
           fixture_replacement_setting,
-          dir: factory_bot_directory,
+          dir: factory_bot_directory
         )
       end
 

data/lib/factory_bot_rails/railtie.rb

@@ -3,12 +3,14 @@
 require "factory_bot"
 require "factory_bot_rails/generator"
 require "factory_bot_rails/reloader"
+require "factory_bot_rails/factory_validator"
 require "rails"
 
 module FactoryBotRails
   class Railtie < Rails::Railtie
     config.factory_bot = ActiveSupport::OrderedOptions.new
     config.factory_bot.definition_file_paths = FactoryBot.definition_file_paths
+    config.factory_bot.validator = FactoryBotRails::FactoryValidator.new
 
     initializer "factory_bot.set_fixture_replacement" do
       Generator.new(config).run
@@ -18,12 +20,10 @@ module FactoryBotRails
       FactoryBot.definition_file_paths = definition_file_paths
     end
 
-    initializer "factory_bot.register_reloader" do |app|
-      Reloader.new(app, config).run
-    end
-
-    config.after_initialize do
-      FactoryBot.reload
+    config.after_initialize do |app|
+      FactoryBot.find_definitions
+      Reloader.new(app).run
+      app.config.factory_bot.validator.run
     end
 
     private

data/lib/factory_bot_rails/reloader.rb

@@ -4,9 +4,8 @@ require "factory_bot_rails/definition_file_paths"
 
 module FactoryBotRails
   class Reloader
-    def initialize(app, config)
+    def initialize(app)
       @app = app
-      @config = config
       @paths = DefinitionFilePaths.new(FactoryBot.definition_file_paths)
     end
 
@@ -18,7 +17,7 @@ module FactoryBotRails
 
     private
 
-    attr_reader :app, :config
+    attr_reader :app
 
     def build_reloader
       reloader_class.new(@paths.files, @paths.directories) do
@@ -31,12 +30,8 @@ module FactoryBotRails
     end
 
     def register_reloader(reloader)
-      closed_over_app = app
-
-      config.to_prepare do
-        if closed_over_app.initialized?
-          reloader.execute
-        end
+      app.reloader.to_prepare do
+        reloader.execute
       end
 
       app.reloaders << reloader

data/lib/generators/factory_bot/model/model_generator.rb

@@ -8,21 +8,21 @@ module FactoryBot
         :attributes,
         type: :array,
         default: [],
-        banner: "field:type field:type",
+        banner: "field:type field:type"
       )
 
       class_option(
         :dir,
         type: :string,
         default: "test/factories",
-        desc: "The directory or file root where factories belong",
+        desc: "The directory or file root where factories belong"
       )
 
       class_option(
         :suffix,
         type: :string,
         default: nil,
-        desc: "Suffix to add factory file",
+        desc: "Suffix to add factory file"
       )
 
       def create_fixture_file
@@ -43,7 +43,7 @@ module FactoryBot
         insert_into_file(
           factories_file,
           factory_definition,
-          after: "FactoryBot.define do\n",
+          after: "FactoryBot.define do\n"
         )
       end
 
@@ -54,17 +54,17 @@ module FactoryBot
 
       def factory_definition
         <<~RUBY
-            factory :#{singular_table_name}#{explicit_class_option} do
-          #{factory_attributes.gsub(/^/, '    ')}
+            factory :#{factory_name}#{explicit_class_option} do
+          #{factory_attributes.gsub(/^/, "    ")}
             end
 
         RUBY
       end
 
       def factory_attributes
-        attributes.map do |attribute|
+        attributes.map { |attribute|
           "#{attribute.name} { #{attribute.default.inspect} }"
-        end.join("\n")
+        }.join("\n")
       end
 
       def filename

data/lib/generators/factory_bot.rb

@@ -2,20 +2,24 @@ require "rails/generators/named_base"
 
 module FactoryBot
   module Generators
-    class Base < Rails::Generators::NamedBase #:nodoc:
+    class Base < Rails::Generators::NamedBase # :nodoc:
       def self.source_root
         path = File.join(
           File.dirname(__FILE__),
           "factory_bot",
           generator_name,
-          "templates",
+          "templates"
         )
 
         File.expand_path(path)
       end
 
+      def factory_name
+        class_name.gsub("::", "").underscore
+      end
+
       def explicit_class_option
-        return if class_name == singular_table_name.camelize
+        return if class_name.underscore == factory_name
 
         ", class: '#{class_name}'"
       end

data/lib/rails/projections.json

@@ -0,0 +1,26 @@
+{
+  "spec/factories/*.rb": {
+    "alternate": "app/models/{singular}.rb",
+    "collection": "model",
+    "command": "factory",
+    "template": [
+      "FactoryBot.define do",
+      "  factory :{singular} do",
+      "  end",
+      "end"
+    ],
+    "test": "spec/models/{singular}_spec.rb"
+  },
+  "test/factories/*.rb": {
+    "alternate": "app/models/{singular}.rb",
+    "collection": "model",
+    "command": "factory",
+    "template": [
+      "FactoryBot.define do",
+      "  factory :{singular} do",
+      "  end",
+      "end"
+    ],
+    "test": "test/models/{singular}_test.rb"
+  }
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_bot_rails
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 6.4.3
 platform: ruby
 authors:
 - Joe Ferris
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-26 00:00:00.000000000 Z
+date: 2023-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: factory_bot
@@ -16,30 +16,58 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: '6.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: '6.4'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.0.0
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.0.0
 description: factory_bot_rails provides integration between factory_bot and rails
-  4.2 or newer
+  5.0 or newer
 email: jferris@thoughtbot.com
 executables: []
 extensions: []
@@ -51,6 +79,7 @@ files:
 - README.md
 - lib/factory_bot_rails.rb
 - lib/factory_bot_rails/definition_file_paths.rb
+- lib/factory_bot_rails/factory_validator.rb
 - lib/factory_bot_rails/generator.rb
 - lib/factory_bot_rails/generators/non_rspec_generator.rb
 - lib/factory_bot_rails/generators/null_generator.rb
@@ -60,11 +89,13 @@ files:
 - lib/generators/factory_bot.rb
 - lib/generators/factory_bot/model/model_generator.rb
 - lib/generators/factory_bot/model/templates/factories.erb
+- lib/rails/projections.json
 homepage: https://github.com/thoughtbot/factory_bot_rails
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  changelog_uri: https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -79,9 +110,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
-summary: factory_bot_rails provides integration between factory_bot and rails 4.2
+summary: factory_bot_rails provides integration between factory_bot and rails 5.0
   or newer
 test_files: []