factory_bot_rails 5.0.0 → 5.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cb1373ed349326df96513782505d2e7e19171d063633723785fa8b19d004334e
-  data.tar.gz: 85afaa7e96c4196ac2104b8d7937b55840e53ec18752809b885f23fb3b9d3a7f
+  metadata.gz: c41b59df4b5238c0092ff30e2684512f2545e2c81043108c333638c151b46ec1
+  data.tar.gz: 2a466525baf96430e60c79b2b9d0dbd963a53170d666577f147a6124a625568d
 SHA512:
-  metadata.gz: 7fc069195491977c8a878d8368db76a25cd3085f767fb1275de049a3a4d5acd88d68c5684b8d5c0d935a5d720ddaaf393d4304147ae357c4a0488c16009a9b4a
-  data.tar.gz: 884ac558b9f118f6883b09241e58d08b42fdb85d6f18c3ade81699caad2769c43e47384da9e43219e1f5956b0a57e91899800d6c4bebc45cf751bb4007f305c9
+  metadata.gz: 10f6949faf0b18045da785caeb07e66b18c46269a81e195bb8d1bc32a415b70a59f437be960119b222e218d723dc5dd6358e07ebcdb782494631569d30c866d1
+  data.tar.gz: 294558d462c35ec56ba610faa785ad49375bbf6f580a93df287c17f7a767debc2fb1dcd0812aca44d52d6f1cea0c15c92f8e39ea0e062813509fb302100d61cf

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2008-2013 Joe Ferris and thoughtbot, inc.
+Copyright (c) 2008-2019 Joe Ferris and thoughtbot, inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/NEWS.md

@@ -0,0 +1,64 @@
+factory_bot_rails versioning is synced with factory_bot releases. For this reason
+there might not be any notable changes in new versions of this project.
+
+# NEWS
+
+## 5.2.0 (April 26, 2020)
+* Changed: factory_bot dependency to ~> 5.2.0
+
+## 5.1.1 (September 24, 2019)
+* Fixed: Ensure definitions do not load before I18n is initialized
+
+## 5.1.0 (September 24, 2019)
+* Changed: factory_bot dependency to ~> 5.1.0
+
+## 5.0.2 (April 14, 2019)
+* Bugfix: Reload factory\_bot whenever the application changes to avoid holding
+  onto stale object references
+* Bugfix: Avoid watching project root when no factory definitions exist
+
+## 5.0.1 (February 9, 2019)
+* Bugfix: Avoid watching files and directories that don't exist (to avoid a
+  file watching bug in Rails https://github.com/rails/rails/issues/32700)
+
+## 5.0.0 (February 1, 2019)
+* Added: calling reload! in the Rails console will reload any factory definition files that have changed
+* Added: support for custom generator templates
+* Added: `definition_file_paths` configuration option, making it easier to place factories in custom locations
+* Changed: namespaced models are now generated inside a directory matching the namespace
+* Changed: added newline between factories generated into the same file
+* Removed: support for EOL version of Ruby and Rails
+
+## 4.11.1 (September 7, 2018)
+* Update generator to use dynamic attributes instead of deprecated static attributes
+
+## 4.11.0 (August 16, 2018)
+* No notable changes
+
+## 4.10.0 (May 25, 2018)
+* No notable changes
+
+## 4.8.2 (October 20, 2017)
+* Rename factory\_girl\_rails to factory\_bot\_rails
+
+## 4.7.0 (April 1, 2016)
+* No notable changes
+
+## 4.6.0 (February 1, 2016)
+* No notable changes
+
+## 4.5.0 (October 17, 2014)
+* Improved README
+
+## 4.4.1 (February 26, 2014)
+* Support Spring
+
+## 4.2.1 (February 8, 2013)
+* Fix bug when configuring FG and RSpec fixture directory
+* Remove debugging
+* Require factory\_girl\_rails explicitly in generator
+
+## 4.2.0 (January 25, 2013)
+* Add appraisal and get test suite working reliably with turn gem
+* Support MiniTest
+* Allow a custom directory for factories to be specified

data/README.md

@@ -66,9 +66,14 @@ This will cause factory\_bot\_rails to automatically load factories in
 It is possible to use this setting to share factories from a gem:
 
 ```rb
+begin
+  require 'factory_bot_rails'
+rescue LoadError
+end
+
 class MyEngine < ::Rails::Engine
-  config.factory_bot.definition_file_paths =
-    File.expand_path('../factories', __FILE__) if defined?(FactoryBotRails)
+  config.factory_bot.definition_file_paths +=
+    [File.expand_path('../factories', __FILE__)] if defined?(FactoryBotRails)
 end
 ```
 
@@ -109,7 +114,7 @@ end
 ```
 
 Note that factory\_bot\_rails will not automatically load files in custom
-locations unless you add them to `config.factory_bot.defintion_file_paths` as
+locations unless you add them to `config.factory_bot.definition_file_paths` as
 well.
 
 The suffix option allows you to customize the name of the generated file with a
@@ -151,7 +156,7 @@ community](https://github.com/thoughtbot/factory_bot_rails/graphs/contributors).
 
 ## License
 
-factory_bot_rails is Copyright © 2008-2016 Joe Ferris and thoughtbot. It is free
+factory_bot_rails is Copyright © 2008-2019 Joe Ferris and thoughtbot. It is free
 software, and may be redistributed under the terms specified in the
 [LICENSE](LICENSE) file.
 

data/lib/factory_bot_rails/definition_file_paths.rb

@@ -2,8 +2,6 @@
 
 module FactoryBotRails
   class DefinitionFilePaths
-    attr_reader :files, :directories
-
     def initialize(definition_file_paths)
       @files = []
       @directories = {}
@@ -13,5 +11,17 @@ module FactoryBotRails
         @directories[path.to_s] = [:rb]
       end
     end
+
+    def directories
+      @directories.select { |path| Dir.exist?(path) }
+    end
+
+    def files
+      @files.select { |file| File.exist?(file) }
+    end
+
+    def any?
+      directories.any? || files.any?
+    end
   end
 end

data/lib/factory_bot_rails/railtie.rb

@@ -23,7 +23,7 @@ module FactoryBotRails
     end
 
     config.after_initialize do
-      FactoryBot.find_definitions
+      FactoryBot.reload
     end
 
     private

data/lib/factory_bot_rails/reloader.rb

@@ -7,9 +7,12 @@ module FactoryBotRails
     def initialize(app, config)
       @app = app
       @config = config
+      @paths = DefinitionFilePaths.new(FactoryBot.definition_file_paths)
     end
 
     def run
+      return unless @paths.any?
+
       register_reloader(build_reloader)
     end
 
@@ -18,9 +21,7 @@ module FactoryBotRails
     attr_reader :app, :config
 
     def build_reloader
-      paths = DefinitionFilePaths.new(FactoryBot.definition_file_paths)
-
-      reloader_class.new(paths.files, paths.directories) do
+      reloader_class.new(@paths.files, @paths.directories) do
         FactoryBot.reload
       end
     end
@@ -30,8 +31,12 @@ module FactoryBotRails
     end
 
     def register_reloader(reloader)
+      closed_over_app = app
+
       config.to_prepare do
-        reloader.execute_if_updated
+        if closed_over_app.initialized?
+          reloader.execute
+        end
       end
 
       app.reloaders << reloader

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_bot_rails
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.2.0
 platform: ruby
 authors:
 - Joe Ferris
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-01 00:00:00.000000000 Z
+date: 2020-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: factory_bot
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 5.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 5.2.0
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -47,7 +47,7 @@ extra_rdoc_files: []
 files:
 - CONTRIBUTING.md
 - LICENSE
-- NEWS
+- NEWS.md
 - README.md
 - lib/factory_bot_rails.rb
 - lib/factory_bot_rails/definition_file_paths.rb
@@ -79,7 +79,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: factory_bot_rails provides integration between factory_bot and rails 4.2

data/NEWS

@@ -1,44 +0,0 @@
-factory_bot_rails versioning is synced with factory_bot releases. For this reason
-there might not be any notable changes in new versions of this project.
-
-5.0.0
-  Added: calling reload! in the Rails console will reload any factory definition files that have changed
-  Added: support for custom generator templates
-  Added: definition_file_paths configuration option, making it easier to place factories in custom locations
-  Changed: namespaced models are now generated inside a directory matching the namespace
-  Changed: added newline between factories generated into the same file
-  Removed: support for EOL version of Ruby and Rails
-
-4.11.1 (September 7, 2018)
-  Update generator to use dynamic attributes instead of deprecated static attributes
-
-4.11.0 (August 16, 2018)
-  No notable changes
-
-4.10.0 (May 25, 2018)
-  No notable changes
-
-4.8.2 (October 20, 2017)
-  Rename factory_girl_rails to factory_bot_rails
-
-4.7.0 (April 1, 2016)
-  No notable changes
-
-4.6.0 (February 1, 2016)
-  No notable changes
-
-4.5.0 (October 17, 2014)
-  Improved README
-
-4.4.1 (February 26, 2014)
-  Support Spring
-
-4.2.1 (February 8, 2013)
-  Fix bug when configuring FG and RSpec fixture directory
-  Remove debugging
-  Require factory_girl_rails explicitly in generator
-
-4.2.0 (January 25, 2013)
-  Add appraisal and get test suite working reliably with turn gem
-  Support MiniTest
-  Allow a custom directory for factories to be specified