factory_bot_instrumentation 3.2.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3ffdbe89a6d52f2e42501cda7e16486837898cc3e98b11eecc4259f4c62ca13
-  data.tar.gz: ea11aa96c68c2d8b0b5d82b93a1b4b2f1d558c2cf5a3180ff39f4bd2733d840e
+  metadata.gz: '08e3d4ce4136029c07728a5cab9d09cd70971a0309b19f2c7a45d1d803394b5c'
+  data.tar.gz: b60890e825ea6a95308ca8000e462cffaecaa2b314b9d8de097b117c7d0ee461
 SHA512:
-  metadata.gz: 1f3bac980f8316e752de81f09afc1434a26eff5778d4906910de50efcc3f2a0a5ae2b6ebaa8e4e62b590380c6de08c8961df56fe1a8915c126da495c853407e8
-  data.tar.gz: d4d79cfd4b72f5ca9d9d54afe4f684837ce68bf1b99f789d07d52fd52f03319a6549bac8ddfdf98234776fbdfff933ea3630912e792104a625819031c70a9829
+  metadata.gz: 7e638032848f7d4f2f601c64a6616a269471f55b133fedb275e2053ddc9167bae2913e48b9b36f30fad5748c6ef6dbe514fd0fa55285f79f94e12f1f9c96cd16
+  data.tar.gz: 58b99a21082090a8ad4d2e30ce3bafd242f87253c73e12278259d128097f4a7f0a6c191d88122caecced2e71179653132b81ab81d63197e9b519744832a49480

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 * TODO: Replace this bullet point with an actual description of a change.
 
+### 3.2.1 (26 June 2026)
+
+* Disabled parameter wrapping to silence spurious unpermitted parameter log
+  warnings ([#49](https://github.com/hausgold/factory_bot_instrumentation/pull/49))
+
 ### 3.2.0 (19 June 2026)
 
 * Improved the title and navigation title on the Instrumentation UI ([#48](https://github.com/hausgold/factory_bot_instrumentation/pull/48))

data/app/controllers/factory_bot/instrumentation/root_controller.rb

@@ -4,6 +4,13 @@ module FactoryBot
   module Instrumentation
     # The Instrumentation engine controller with frontend and API actions.
     class RootController < FactoryBot::Instrumentation::ApplicationController
+      # Disable Rails' parameter wrapping. For JSON requests it would nest
+      # a copy of the request body under a +root+ key (derived from this
+      # controller's name). There is no +Root+ model to map onto, so the
+      # wrapper only duplicates the parameters and adds a spurious
+      # "Unpermitted parameters: :root" log warning.
+      wrap_parameters false
+
       # Show the instrumentation frontend which features the output of
       # configured dynamic seeds scenarios. The frontend allows humans to
       # generate new seed data on the fly.
@@ -52,14 +59,15 @@ module FactoryBot
       #
       # @return [Array<Mixed>] the FactoryBot options
       def factory_params
-        data = params.permit(:factory, traits: [])
-
-        overwrite = if Rails::VERSION::MAJOR >= 5
-                      params.to_unsafe_h.fetch(:overwrite, {})
-                            .deep_symbolize_keys
-                    else
-                      params.fetch('overwrite', {}).deep_symbolize_keys
-                    end
+        # Read the open-ended +overwrite+ hash unfiltered, as its keys and
+        # values are arbitrary and cannot be described with strong
+        # parameters.
+        overwrite = params.to_unsafe_h.fetch(:overwrite, {})
+                          .deep_symbolize_keys
+        # Strip +overwrite+ before permitting the rest, otherwise it would
+        # be reported as a spurious "Unpermitted parameters: :overwrite"
+        # log warning.
+        data = params.except(:overwrite).permit(:factory, traits: [])
 
         [
           data.fetch(:factory).to_sym,

data/lib/factory_bot/instrumentation/version.rb

@@ -4,7 +4,7 @@ module FactoryBot
   # The gem version details.
   module Instrumentation
     # The version of the +factory_bot_instrumentation+ gem
-    VERSION = '3.2.0'
+    VERSION = '3.2.1'
 
     class << self
       # Returns the version of gem as a string.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: factory_bot_instrumentation
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Hermann Mayer