factory_bot_instrumentation 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 32b62f67039dbe0cd562eaf5ea41336866bce49cac7153b0abb86858a6ecf5e0
-  data.tar.gz: 3efc8629cced06d8d68da53aaaaa6ba1280d5b25be43b71b9d930fbd9f1424e5
+  metadata.gz: fdad0623324b5fb131122851c3cfb7862cc7c69e5ed6d545b49cd4ffb953ff14
+  data.tar.gz: 54f7c93ae468fa246e118bdc47cefdf4a4db0ac31b4e1754bc99dd72364997bc
 SHA512:
-  metadata.gz: 8b8deb694372a595010a82a314234e4f0b5a2c5342c6ebb5568a497fe677530d54d2d4ea6443ef5f2154cc1fc601d1367e755035cb06c4fb26c39d06947b4ae1
-  data.tar.gz: 47b5760d942fcc51e5fc5d6df7c3fc9dfe8ed1a0b0ce593224aba027e925c7124239e0dbf28a222d143102dd6a16e593fa84c51446cd8c75b5b1cf4e50dc5d35
+  metadata.gz: c05415a4d45673ccf2857b1747896c8581c5c726d54ebb0d7dc59788bcbbef4791762b2099daa7e9b09b45e523cc709260e0884b52aca6d62b5c3a7375056fc2
+  data.tar.gz: 36907744056f4c477ff9b8fdc43f69a2560d757d70f9b43d3fcef7bf3493a2fef11084b069d84662ce8633c5c12c45d70cc12d177757f43989121be60b1deb32

data/.rubocop.yml

@@ -8,7 +8,7 @@ Documentation:
 
 AllCops:
   DisplayCopNames: true
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
   Exclude:
     - db/schema.rb
     - bin/**/*

data/.travis.yml

@@ -9,7 +9,6 @@ rvm:
   - 2.6
   - 2.5
   - 2.4
-  - 2.3
 
 gemfile:
   - gemfiles/rails_4.gemfile

data/Appraisals

@@ -1,5 +1,6 @@
 appraise 'rails-4' do
   gem 'rails', '~> 4.2.11'
+  gem 'rails-api', '~> 0.4.1'
 end
 
 appraise 'rails-5.0' do

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+### 0.3.0
+
+* Removed CI support for Ruby 2.3 (it never worked before)
+* Fixed the overwrite params bug on Rails 4.2
+* Added a test suite for the engine
+
 ### 0.2.0
 
 * Removed the Gemfile locks and added the to the ignore list

data/README.md

@@ -48,6 +48,14 @@ Add this line to your application's Gemfile:
 gem 'factory_bot_instrumentation'
 ```
 
+**Heads up!** In case you use Rails 4.2, you need to add the
+[rails-api](https://github.com/rails-api/rails-api) gem as well, because this
+feature was first introduced with Rails 5.0.
+
+```ruby
+gem 'rails-api'
+```
+
 And then execute:
 
 ```bash
@@ -107,20 +115,20 @@ FactoryBot.define do
 
     trait :with_friend do
       after(:create) do |user, elevator|
-        FactoryBot.create(:lead,
-                           *elevator.lead_traits.map(&:to_sym),
-                           friends: [user],
-                           **elevator.friend_overwrites)
+        FactoryBot.create(:user,
+                          *elevator.friend_traits.map(&:to_sym),
+                          friends: [user],
+                          **elevator.friend_overwrites)
       end
     end
 
     trait :with_friends do
       after(:create) do |user, elevator|
         FactoryBot.create_list(:user,
-                                elevator.leads_amount,
-                                *elevator.lead_traits.map(&:to_sym),
-                                friends: [user],
-                                **elevator.friend_overwrites)
+                               elevator.friends_amount,
+                               *elevator.friend_traits.map(&:to_sym),
+                               friends: [user],
+                               **elevator.friend_overwrites)
       end
     end
   end

data/Rakefile

@@ -1,8 +1,26 @@
 # frozen_string_literal: true
 
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
+ENV['DISABLE_DATABASE_ENVIRONMENT_CHECK'] = '1'
+
+require 'bundler/setup'
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 
-RSpec::Core::RakeTask.new(:spec)
+APP_RAKEFILE = File.expand_path('../spec/dummy/Rakefile', __FILE__)
+load 'rails/tasks/engine.rake'
+
+Bundler::GemHelper.install_tasks
+
+Dir[File.join(File.dirname(__FILE__), 'tasks/**/*.rake')].each {|f| load f }
+
+require 'rspec/core'
+require 'rspec/core/rake_task'
+
+desc 'Run all specs in spec directory (excluding plugin specs)'
+RSpec::Core::RakeTask.new(spec: [
+  'db:drop', 'db:create', 'db:migrate', 'db:setup'
+])
 
 task default: :spec

data/app/controllers/factory_bot/instrumentation/root_controller.rb

@@ -56,7 +56,13 @@ module FactoryBot::Instrumentation
     # @return [Array<Mixed>] the FactoryBot options
     def factory_params
       data = params.permit(:factory, traits: [])
-      overwrite = params.to_unsafe_h.fetch(:overwrite, {}).deep_symbolize_keys
+
+      if Rails::VERSION::MAJOR >= 5
+        overwrite = params.to_unsafe_h.fetch(:overwrite, {})
+                          .deep_symbolize_keys
+      else
+        overwrite = params.fetch('overwrite', {}).deep_symbolize_keys
+      end
 
       [
         data.fetch(:factory).to_sym,

data/docker-compose.yml

@@ -1,7 +1,7 @@
 version: "3"
 services:
   test:
-    image: ruby:2.3
+    image: ruby:2.4
     network_mode: bridge
     working_dir: /app
     volumes:

data/factory_bot_instrumentation.gemspec

@@ -25,9 +25,9 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'factory_bot'
 
   spec.add_development_dependency 'bundler', '>= 1.16', '< 3'
-  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rspec-rails', '~> 3.8'
   spec.add_development_dependency 'simplecov', '~> 0.15'
   spec.add_development_dependency 'timecop', '~> 0.9.1'
-  spec.add_development_dependency 'sqlite3'
+  spec.add_development_dependency 'sqlite3', '~> 1.3.6'
   spec.add_development_dependency 'appraisal'
 end

data/gemfiles/rails_4.gemfile

@@ -3,5 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails", "~> 4.2.11"
+gem "rails-api", "~> 0.4.1"
 
 gemspec path: "../"

data/lib/factory_bot/instrumentation/version.rb

@@ -2,6 +2,6 @@
 
 module FactoryBot
   module Instrumentation
-    VERSION = '0.2.0'.freeze
+    VERSION = '0.3.0'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factory_bot_instrumentation
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Hermann Mayer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-03-22 00:00:00.000000000 Z
+date: 2019-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -59,19 +59,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -104,16 +104,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -203,7 +203,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: Allow your testers to generate test data on demand