factory_bot 6.4.2 → 6.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5f21ea97d90ed0a9c175d1ff2b04961bcf38fa981c2957ac3c9fd77fa7e2612
-  data.tar.gz: 4698bcccd79fe5252ec751637f7f86b1e0810b2d9d5b52a69fb1d7dd5d238894
+  metadata.gz: 6c4ecc28ea64e833dbf0f8b745343006acddb3375381ade459e6e9d970b34730
+  data.tar.gz: 04ae226f770eea6f4dcc76b199d901c3574e9098f62a857d1ad257147c1f7b4c
 SHA512:
-  metadata.gz: 74a79d529f84cece38fe558e1f6c9cb3213d9038e1b853bbe378ce86f3ce6c8168f057a438039670275845530122bb28e41cd8a5669a6f14a2886bfd20201c41
-  data.tar.gz: d2b13eb9ca94da825becc7fb04a0535dfb72547375b2b824a6c447dec27a0426d37907a88de95b80f2b78d412fc7f8290311d102ad31bbcafcee4c78a24babf5
+  metadata.gz: 3e3364ba162e34e4c24c0381bf5bf7720c5c888e476930cf7c15d0a83bd0d359f3213eb17148bd937d1ae581011bf6b6c63cb80538f8a9e59ec4165971ed0011
+  data.tar.gz: 30837bf0ba98458de0056c02bd401ce2c8aa2ead83c3a33431fecbabf29a429531874705e89df71378d8a326c3d73e08dae71c0968acab540a0fc2f68095178b

data/NEWS.md

@@ -1,5 +1,22 @@
 # News
 
+## 6.4.5 (December 29, 2023)
+
+  * Changed: Support Ruby 3.0+, Rails 6.1+ (Mike Burns).
+
+## 6.4.4 (December 27, 2023)
+
+  * Internal: Remove observer dependency (Earlopain).
+
+## 6.4.3 (December 26, 2023)
+
+  * Fix: Support models without ID setters in build_stubbed (Olivier Bellone).
+  * Fix: Explicit observer dependency (Oleg Antonyan).
+  * Internal: Add Rails 7.1 to CI (Olivier Bellone).
+  * Internal: Bump github actions/checkout to v4 (Lorenzo Zabot)
+  * Internal: Stop passing disable-error_highlight in CI (Mike Burns).
+  * Internal: Relax the exception message check (Mike Burns).
+
 ## 6.4.2 (November 22, 2023)
 
   * Fix: top-level traits pass their class to ActiveSupport::Notifications

data/lib/factory_bot/decorator.rb

@@ -6,24 +6,12 @@ module FactoryBot
       @component = component
     end
 
-    if ::Gem::Version.new(::RUBY_VERSION) >= ::Gem::Version.new("2.7")
-      class_eval(<<~RUBY, __FILE__, __LINE__ + 1)
-          def method_missing(...) # rubocop:disable Style/MethodMissingSuper, Style/MissingRespondToMissing
-          @component.send(...)
-        end
-
-        def send(...)
-          __send__(...)
-        end
-      RUBY
-    else
-      def method_missing(name, *args, &block) # rubocop:disable Style/MissingRespondToMissing
-        @component.send(name, *args, &block)
-      end
+    def method_missing(...) # rubocop:disable Style/MethodMissingSuper
+      @component.send(...)
+    end
 
-      def send(symbol, *args, &block)
-        __send__(symbol, *args, &block)
-      end
+    def send(...)
+      __send__(...)
     end
 
     def respond_to_missing?(name, include_private = false)

data/lib/factory_bot/definition_proxy.rb

@@ -119,8 +119,8 @@ module FactoryBot
     #   end
     #
     # Except that no globally available sequence will be defined.
-    def sequence(name, *args, &block)
-      sequence = Sequence.new(name, *args, &block)
+    def sequence(name, ...)
+      sequence = Sequence.new(name, ...)
       FactoryBot::Internal.register_inline_sequence(sequence)
       add_attribute(name) { increment_sequence(sequence) }
     end

data/lib/factory_bot/evaluation.rb

@@ -1,13 +1,10 @@
-require "observer"
-
 module FactoryBot
   class Evaluation
-    include Observable
-
-    def initialize(evaluator, attribute_assigner, to_create)
+    def initialize(evaluator, attribute_assigner, to_create, observer)
       @evaluator = evaluator
       @attribute_assigner = attribute_assigner
       @to_create = to_create
+      @observer = observer
     end
 
     delegate :object, :hash, to: :@attribute_assigner
@@ -20,8 +17,7 @@ module FactoryBot
     end
 
     def notify(name, result_instance)
-      changed
-      notify_observers(name, result_instance)
+      @observer.update(name, result_instance)
     end
   end
 end

data/lib/factory_bot/evaluator.rb

@@ -35,14 +35,13 @@ module FactoryBot
 
     attr_accessor :instance
 
-    def method_missing(method_name, *args, &block)
+    def method_missing(method_name, ...)
       if @instance.respond_to?(method_name)
-        @instance.send(method_name, *args, &block)
+        @instance.send(method_name, ...)
       else
-        SyntaxRunner.new.send(method_name, *args, &block)
+        SyntaxRunner.new.send(method_name, ...)
       end
     end
-    ruby2_keywords :method_missing if respond_to?(:ruby2_keywords, true)
 
     def respond_to_missing?(method_name, _include_private = false)
       @instance.respond_to?(method_name) || SyntaxRunner.new.respond_to?(method_name)

data/lib/factory_bot/factory.rb

@@ -36,9 +36,9 @@ module FactoryBot
       evaluator = evaluator_class.new(strategy, overrides.symbolize_keys)
       attribute_assigner = AttributeAssigner.new(evaluator, build_class, &compiled_constructor)
 
+      observer = CallbacksObserver.new(callbacks, evaluator)
       evaluation =
-        Evaluation.new(evaluator, attribute_assigner, compiled_to_create)
-      evaluation.add_observer(CallbacksObserver.new(callbacks, evaluator))
+        Evaluation.new(evaluator, attribute_assigner, compiled_to_create, observer)
 
       strategy.result(evaluation).tap(&block)
     end

data/lib/factory_bot/strategy/stub.rb

@@ -83,8 +83,9 @@ module FactoryBot
       end
 
       def has_settable_id?(result_instance)
-        !result_instance.class.respond_to?(:primary_key) ||
-          result_instance.class.primary_key
+        result_instance.respond_to?(:id=) &&
+          (!result_instance.class.respond_to?(:primary_key) ||
+          result_instance.class.primary_key)
       end
 
       def uuid_primary_key?(result_instance)

data/lib/factory_bot/syntax/default.rb

@@ -25,8 +25,8 @@ module FactoryBot
           end
         end
 
-        def sequence(name, *args, &block)
-          Internal.register_sequence(Sequence.new(name, *args, &block))
+        def sequence(name, ...)
+          Internal.register_sequence(Sequence.new(name, ...))
         end
 
         def trait(name, &block)

data/lib/factory_bot/version.rb

@@ -1,3 +1,3 @@
 module FactoryBot
-  VERSION = "6.4.2".freeze
+  VERSION = "6.4.5".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: factory_bot
 version: !ruby/object:Gem::Version
-  version: 6.4.2
+  version: 6.4.5
 platform: ruby
 authors:
 - Josh Clayton
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-22 00:00:00.000000000 Z
+date: 2023-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport