factory_bot 6.4.2 → 6.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5f21ea97d90ed0a9c175d1ff2b04961bcf38fa981c2957ac3c9fd77fa7e2612
-  data.tar.gz: 4698bcccd79fe5252ec751637f7f86b1e0810b2d9d5b52a69fb1d7dd5d238894
+  metadata.gz: 29f358b07e7a913b68e774a5d6fb07f5108e46250555d3813ac2a592debcfb17
+  data.tar.gz: 0afcfa66f242dbb8c9631d3c9d64dc72436245915f91f7706502f04e2cea2cde
 SHA512:
-  metadata.gz: 74a79d529f84cece38fe558e1f6c9cb3213d9038e1b853bbe378ce86f3ce6c8168f057a438039670275845530122bb28e41cd8a5669a6f14a2886bfd20201c41
-  data.tar.gz: d2b13eb9ca94da825becc7fb04a0535dfb72547375b2b824a6c447dec27a0426d37907a88de95b80f2b78d412fc7f8290311d102ad31bbcafcee4c78a24babf5
+  metadata.gz: 0c7ce4439447ed2079e6db42b8b75711a7113b327bdb3d776d24465f05b2ce633e47edf544dec6ab3cfd78857d6858296f5bf47e477556c2f135cf544731b8a8
+  data.tar.gz: 54b78dbafda5253abed5be787658d01424956e3271b6615d24f461dc5be7866f2c7d94c9014cebbb87b033894b42e21c859a30c793e08c742be454005c1f5f36

data/NEWS.md

@@ -1,5 +1,18 @@
 # News
 
+## 6.4.4 (December 27, 2023)
+
+  * Internal: Remove observer dependency (Earlopain).
+
+## 6.4.3 (December 26, 2023)
+
+  * Fix: Support models without ID setters in build_stubbed (Olivier Bellone).
+  * Fix: Explicit observer dependency (Oleg Antonyan).
+  * Internal: Add Rails 7.1 to CI (Olivier Bellone).
+  * Internal: Bump github actions/checkout to v4 (Lorenzo Zabot)
+  * Internal: Stop passing disable-error_highlight in CI (Mike Burns).
+  * Internal: Relax the exception message check (Mike Burns).
+
 ## 6.4.2 (November 22, 2023)
 
   * Fix: top-level traits pass their class to ActiveSupport::Notifications

data/lib/factory_bot/evaluation.rb

@@ -1,13 +1,10 @@
-require "observer"
-
 module FactoryBot
   class Evaluation
-    include Observable
-
-    def initialize(evaluator, attribute_assigner, to_create)
+    def initialize(evaluator, attribute_assigner, to_create, observer)
       @evaluator = evaluator
       @attribute_assigner = attribute_assigner
       @to_create = to_create
+      @observer = observer
     end
 
     delegate :object, :hash, to: :@attribute_assigner
@@ -20,8 +17,7 @@ module FactoryBot
     end
 
     def notify(name, result_instance)
-      changed
-      notify_observers(name, result_instance)
+      @observer.update(name, result_instance)
     end
   end
 end

data/lib/factory_bot/factory.rb

@@ -36,9 +36,9 @@ module FactoryBot
       evaluator = evaluator_class.new(strategy, overrides.symbolize_keys)
       attribute_assigner = AttributeAssigner.new(evaluator, build_class, &compiled_constructor)
 
+      observer = CallbacksObserver.new(callbacks, evaluator)
       evaluation =
-        Evaluation.new(evaluator, attribute_assigner, compiled_to_create)
-      evaluation.add_observer(CallbacksObserver.new(callbacks, evaluator))
+        Evaluation.new(evaluator, attribute_assigner, compiled_to_create, observer)
 
       strategy.result(evaluation).tap(&block)
     end

data/lib/factory_bot/strategy/stub.rb

@@ -83,8 +83,9 @@ module FactoryBot
       end
 
       def has_settable_id?(result_instance)
-        !result_instance.class.respond_to?(:primary_key) ||
-          result_instance.class.primary_key
+        result_instance.respond_to?(:id=) &&
+          (!result_instance.class.respond_to?(:primary_key) ||
+          result_instance.class.primary_key)
       end
 
       def uuid_primary_key?(result_instance)

data/lib/factory_bot/version.rb

@@ -1,3 +1,3 @@
 module FactoryBot
-  VERSION = "6.4.2".freeze
+  VERSION = "6.4.4".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: factory_bot
 version: !ruby/object:Gem::Version
-  version: 6.4.2
+  version: 6.4.4
 platform: ruby
 authors:
 - Josh Clayton
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-22 00:00:00.000000000 Z
+date: 2023-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport