factory_bot 4.10.0 → 4.11.0

data/NEWS

@@ -1,3 +1,8 @@
+4.11.0 (August, 15, 2018)
+  Bugfix: Do not raise error for valid build_stubbed methods: decrement, increment, and toggle
+  Bugfix: Do not add timestamps with build_stubbed for objects that shouldn't have timestamps
+  Deprecate static attributes
+
 4.10.0 (May 25, 2018)
   Allow sequences to be rewound
 

data/README.md

@@ -1,4 +1,4 @@
-# factory_bot [![Build Status](https://travis-ci.org/thoughtbot/factory_bot.svg)](http://travis-ci.org/thoughtbot/factory_bot?branch=master) [![Code Climate](https://codeclimate.com/github/thoughtbot/factory_bot/badges/gpa.svg)](https://codeclimate.com/github/thoughtbot/factory_bot)
+# factory_bot [![Build Status][ci-image]][ci] [![Code Climate][grade-image]][grade] [![Gem Version][version-image]][version] [![Reviewed by Hound][hound-badge-image]][hound]
 
 factory_bot is a fixtures replacement with a straightforward definition syntax, support for multiple build strategies (saved instances, unsaved instances, attribute hashes, and stubbed objects), and support for multiple factories for the same class (user, admin_user, and so on), including factory inheritance.
 
@@ -103,4 +103,12 @@ See [our other projects][community] or
 [hire us][hire] to design, develop, and grow your product.
 
 [community]: https://thoughtbot.com/community?utm_source=github
-[hire]: https://thoughtbot.com?utm_source=github
+[hire]: https://thoughtbot.com/hire-us?utm_source=github
+[ci-image]: https://travis-ci.org/thoughtbot/factory_bot.svg
+[ci]: http://travis-ci.org/thoughtbot/factory_bot?branch=master
+[grade-image]: https://codeclimate.com/github/thoughtbot/factory_bot/badges/gpa.svg
+[grade]: https://codeclimate.com/github/thoughtbot/factory_bot
+[version-image]: https://badge.fury.io/rb/factory_bot.svg
+[version]: https://badge.fury.io/rb/factory_bot
+[hound-badge-image]: https://img.shields.io/badge/Reviewed_by-Hound-8E64B0.svg
+[hound]: https://houndci.com

data/lib/factory_bot/definition_proxy.rb

@@ -45,6 +45,7 @@ module FactoryBot
       declaration = if block_given?
         Declaration::Dynamic.new(name, @ignore, block)
       else
+        warn_static_attribute_deprecation(name, value)
         Declaration::Static.new(name, value, @ignore)
       end
 
@@ -170,5 +171,31 @@ module FactoryBot
     def initialize_with(&block)
       @definition.define_constructor(&block)
     end
+
+    private
+
+    def warn_static_attribute_deprecation(name, value)
+      attribute_caller = caller(2)
+
+      if attribute_caller[0].include?("method_missing")
+        attribute_caller = caller(3)
+      end
+
+      ActiveSupport::Deprecation.warn(<<-MSG, attribute_caller)
+Static attributes will be removed in FactoryBot 5.0. Please use dynamic
+attributes instead by wrapping the attribute value in a block:
+
+#{name} { #{value.inspect} }
+
+To automatically update from static attributes to dynamic ones,
+install rubocop-rspec and run:
+
+rubocop \\
+  --require rubocop-rspec \\
+  --only FactoryBot/AttributeDefinedStatically \\
+  --auto-correct
+
+      MSG
+    end
   end
 end

data/lib/factory_bot/strategy/stub.rb

@@ -6,17 +6,14 @@ module FactoryBot
       DISABLED_PERSISTENCE_METHODS = [
         :connection,
         :decrement!,
-        :decrement,
         :delete,
         :destroy!,
         :destroy,
         :increment!,
-        :increment,
         :reload,
         :save!,
         :save,
         :toggle!,
-        :toggle,
         :touch,
         :update!,
         :update,
@@ -69,9 +66,8 @@ module FactoryBot
         end
 
         created_at_missing_default = result_instance.respond_to?(:created_at) && !result_instance.created_at
-        result_instance_missing_created_at = !result_instance.respond_to?(:created_at)
 
-        if created_at_missing_default || result_instance_missing_created_at
+        if created_at_missing_default
           result_instance.instance_eval do
             def created_at
               @created_at ||= Time.now.in_time_zone
@@ -81,9 +77,8 @@ module FactoryBot
 
         has_updated_at = result_instance.respond_to?(:updated_at)
         updated_at_no_default = has_updated_at && !result_instance.updated_at
-        result_instance_missing_updated_at = !has_updated_at
 
-        if updated_at_no_default || result_instance_missing_updated_at
+        if updated_at_no_default
           result_instance.instance_eval do
             def updated_at
               @updated_at ||= Time.current

data/lib/factory_bot/version.rb

@@ -1,3 +1,3 @@
 module FactoryBot
-  VERSION = "4.10.0".freeze
+  VERSION = "4.11.0".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: factory_bot
 version: !ruby/object:Gem::Version
-  version: 4.10.0
+  version: 4.11.0
 platform: ruby
 authors:
 - Josh Clayton
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-25 00:00:00.000000000 Z
+date: 2018-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -26,117 +26,117 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: rspec-its
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
-  name: cucumber
+  name: aruba
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.15
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.15
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: timecop
+  name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.15
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.15
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: aruba
+  name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -151,10 +151,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: |-
-  factory_bot provides a framework and DSL for defining and
-                        using factories - less error-prone, more explicit, and
-                        all-around easier to work with than fixtures.
+description: factory_bot provides a framework and DSL for defining and using factories
+  - less error-prone, more explicit, and all-around easier to work with than fixtures.
 email:
 - jclayton@thoughtbot.com
 - jferris@thoughtbot.com
@@ -162,37 +160,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".autotest"
-- ".gitignore"
-- ".rspec"
-- ".simplecov"
-- ".travis.yml"
-- ".yardopts"
-- Appraisals
 - CONTRIBUTING.md
 - GETTING_STARTED.md
-- Gemfile
-- Gemfile.lock
 - LICENSE
 - NAME.md
 - NEWS
 - README.md
-- Rakefile
-- cucumber.yml
-- factory_bot.gemspec
-- factory_girl.gemspec
-- gemfiles/3.2.gemfile
-- gemfiles/3.2.gemfile.lock
-- gemfiles/4.0.gemfile
-- gemfiles/4.0.gemfile.lock
-- gemfiles/4.1.gemfile
-- gemfiles/4.1.gemfile.lock
-- gemfiles/4.2.gemfile
-- gemfiles/4.2.gemfile.lock
-- gemfiles/5.0.gemfile
-- gemfiles/5.0.gemfile.lock
-- gemfiles/5.1.gemfile
-- gemfiles/5.1.gemfile.lock
 - lib/factory_bot.rb
 - lib/factory_bot/aliases.rb
 - lib/factory_bot/attribute.rb
@@ -246,7 +219,6 @@ files:
 - lib/factory_bot/syntax_runner.rb
 - lib/factory_bot/trait.rb
 - lib/factory_bot/version.rb
-- lib/factory_girl.rb
 homepage: https://github.com/thoughtbot/factory_bot
 licenses:
 - MIT
@@ -267,7 +239,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: factory_bot provides a framework and DSL for defining and using model instance

data/.autotest

@@ -1,9 +0,0 @@
-Autotest.add_hook :initialize do |at|
-  at.clear_mappings
-
-  at.add_mapping(%r{^test/.*_test\.rb$})              {|f, _| [f] }
-  at.add_mapping(%r{^lib/factory_girl/(.*)\.rb$})     {|_, m| ["test/#{m[1]}_test.rb",
-                                                               "test/integration_test.rb"] }
-  at.add_mapping(%r{^test/(test_helper|models)\.rb$}) { at.files_matching %r{^test/.*_test\.rb$} }
-  at.add_mapping(%r{^lib/.*\.rb$})                    { at.files_matching %r{^test/.*_test\.rb$} }
-end

data/.gitignore

@@ -1,10 +0,0 @@
-*.swp
-test.db
-factory_girl-*.gem
-factory_bot-*.gem
-doc
-.yardoc
-coverage
-.bundle
-tmp
-bin

data/.rspec

@@ -1,3 +0,0 @@
---format progress
---color
---require spec_helper

data/.simplecov

@@ -1,4 +0,0 @@
-SimpleCov.start do
-  add_filter "/spec/"
-  add_filter "/tmp/"
-end

data/.travis.yml

@@ -1,58 +0,0 @@
-rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.9
-  - 2.2.8
-  - 2.3.5
-  - 2.4.2
-  - ruby-head
-  - rbx-2
-before_install:
-  - gem update --system
-  - gem update bundler
-  - gem cleanup bundler
-install: "bundle install --jobs 8"
-script: "bundle exec rake"
-gemfile:
-  - gemfiles/3.2.gemfile
-  - gemfiles/4.0.gemfile
-  - gemfiles/4.1.gemfile
-  - gemfiles/4.2.gemfile
-  - gemfiles/5.0.gemfile
-  - gemfiles/5.1.gemfile
-matrix:
-  fast_finish: true
-  exclude:
-    - rvm: 1.9.3
-      gemfile: gemfiles/5.0.gemfile
-    - rvm: 1.9.3
-      gemfile: gemfiles/5.1.gemfile
-    - rvm: 2.0.0
-      gemfile: gemfiles/5.0.gemfile
-    - rvm: 2.0.0
-      gemfile: gemfiles/5.1.gemfile
-    - rvm: 2.1.9
-      gemfile: gemfiles/5.0.gemfile
-    - rvm: 2.1.9
-      gemfile: gemfiles/5.1.gemfile
-    - rvm: 2.4.2
-      gemfile: gemfiles/3.2.gemfile
-    - rvm: 2.4.2
-      gemfile: gemfiles/4.0.gemfile
-    - rvm: 2.4.2
-      gemfile: gemfiles/4.1.gemfile
-    - rvm: ruby-head
-      gemfile: gemfiles/3.2.gemfile
-    - rvm: ruby-head
-      gemfile: gemfiles/4.0.gemfile
-    - rvm: ruby-head
-      gemfile: gemfiles/4.1.gemfile
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: rbx-2
-branches:
-  only:
-    - master
-
-sudo: false
-cache: bundler

data/.yardopts

@@ -1,5 +0,0 @@
-lib/**/*.rb
--
-GETTING_STARTED.md
-CONTRIBUTING.md
-LICENSE