facterdb 1.21.0 → 1.22.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2eb4a0ef3ea51589a1169786819a8e293903dac86676bddacbc29b5b2b3d322
-  data.tar.gz: 169ecc3c6f906b44a737760edcf640fd611407214d222f56e58553b32b02fffe
+  metadata.gz: 064fc9f55c20e14820ef7ae63c273ebd3b12b8db7590f1f22987fb28f69c6479
+  data.tar.gz: 11779b051bc32a2a176dbe1f48a8dbaa266cb5a1f818867b9adece142164759f
 SHA512:
-  metadata.gz: 0c5b8bf1d3122f3e46bbe3455e8ca9ccc647b4d70fda8c8887105b84ce6d78be1cbdc8d96f42048a49ae1eedd53cd7c009cf0c305063d00cc77abec2e30d34cc
-  data.tar.gz: 92a68e65046056b941395ed9904779841aec32949946d137b8ba6e94242eb97ed612210f2aae916abb4cec644112efb92ab7edd5b5c0a7aba8d131b0e50c3442
+  metadata.gz: 93bce49fa6eb30353697e027f1b798cef99238a402842660cdbc9e998f62aa89294c287595b938bd89509b09cea0679a2638527aac3aa4c1fecbf74e5dedbdae
+  data.tar.gz: a64b89e9cb5077e53fd18815f142638915ff79c98e12c92c58343bcd3bec40532326c2474ba653fcd62f597f7c07580787b467d8341dd244706915f83a310c35

data/.github/dependabot.yml

@@ -0,0 +1,17 @@
+version: 2
+updates:
+# raise PRs for gem updates
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: daily
+    time: "13:00"
+  open-pull-requests-limit: 10
+
+# Maintain dependencies for GitHub Actions
+- package-ecosystem: github-actions
+  directory: "/"
+  schedule:
+    interval: daily
+    time: "13:00"
+  open-pull-requests-limit: 10

data/.github/workflows/release.yml

@@ -10,11 +10,11 @@ jobs:
     runs-on: ubuntu-latest
     if: github.repository == 'voxpupuli/facterdb'
     steps:
-      - uses: actions/checkout@v2
-      - name: Install Ruby 3.0
+      - uses: actions/checkout@v4
+      - name: Install Ruby 3.2
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.0'
+          ruby-version: '3.2'
         env:
           BUNDLE_WITHOUT: release
       - name: Build gem

data/.github/workflows/test.yml

@@ -1,24 +1,38 @@
 name: Test
 
 on:
-  - pull_request
-  - push
+  pull_request: {}
+  push:
+    branches:
+      - master
 
 jobs:
+  rubocop:
+    env:
+      BUNDLE_WITHOUT: release
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.2"
+          bundler-cache: true
+      - name: Run Rubocop
+        run: bundle exec rake rubocop
+
   test:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         ruby:
-          - '2.5'
-          - '2.6'
           - '2.7'
           - '3.0'
           - '3.1'
           - '3.2'
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Install Ruby ${{ matrix.ruby }}
         uses: ruby/setup-ruby@v1
         with:
@@ -30,3 +44,12 @@ jobs:
         run: bundle exec rake spec
       - name: Build gem
         run: gem build *.gemspec
+
+  tests:
+    needs:
+      - rubocop
+      - test
+    runs-on: ubuntu-latest
+    name: Test suite
+    steps:
+      - run: echo Test suite completed

data/.rubocop.yml

@@ -0,0 +1,5 @@
+---
+inherit_from: .rubocop_todo.yml
+
+inherit_gem:
+  voxpupuli-rubocop: rubocop.yml

data/.rubocop_todo.yml

@@ -0,0 +1,239 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-06-21 07:47:32 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Exclude:
+    - 'Gemfile'
+    - 'facts/Gemfile'
+
+# Offense count: 1
+# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
+Lint/DuplicateBranch:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowNil.
+Lint/SuppressedException:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 3
+Lint/UselessAssignment:
+  Exclude:
+    - 'spec/facts_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
+Naming/MethodParameterName:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/facterdb.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Performance/MapCompact:
+  Exclude:
+    - 'lib/facterdb.rb'
+
+# Offense count: 7
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Performance/StringInclude:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 3
+# Configuration parameters: Prefixes, AllowedPatterns.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/facterdb_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: IgnoredMetadata.
+RSpec/DescribeClass:
+  Exclude:
+    - '**/spec/features/**/*'
+    - '**/spec/requests/**/*'
+    - '**/spec/routing/**/*'
+    - '**/spec/system/**/*'
+    - '**/spec/views/**/*'
+    - 'spec/facts_spec.rb'
+
+# Offense count: 12
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: SkipBlocks, EnforcedStyle.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/facterdb_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: CountAsOne.
+RSpec/ExampleLength:
+  Max: 9
+
+# Offense count: 1
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/FilePath:
+  Exclude:
+    - 'spec/facterdb_spec.rb'
+
+# Offense count: 4
+# Configuration parameters: Max.
+RSpec/IndexedLet:
+  Exclude:
+    - 'spec/facterdb_spec.rb'
+
+# Offense count: 4
+RSpec/MultipleExpectations:
+  Max: 7
+
+# Offense count: 11
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 6
+
+# Offense count: 11
+# Configuration parameters: AllowedGroups.
+RSpec/NestedGroups:
+  Max: 4
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
+# SupportedStyles: inflected, explicit
+RSpec/PredicateMatcher:
+  Exclude:
+    - 'spec/facterdb_spec.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: MinBranchesCount.
+Style/CaseLikeIf:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/facterdb.rb'
+
+# Offense count: 2
+# Configuration parameters: AllowedConstants.
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/facterdb.rb'
+    - 'lib/facterdb/bin.rb'
+
+# Offense count: 13
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'bin/facterdb'
+    - 'facterdb.gemspec'
+    - 'facts/Gemfile'
+    - 'facts/Vagrantfile'
+    - 'lib/facterdb.rb'
+    - 'lib/facterdb/bin.rb'
+    - 'lib/facterdb/version.rb'
+    - 'rakelib/rhel_alts.rake'
+    - 'spec/facterdb_spec.rb'
+    - 'spec/facts_spec.rb'
+    - 'spec/spec_helper.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedReceivers.
+# AllowedReceivers: Thread.current
+Style/HashEachMethods:
+  Exclude:
+    - 'spec/facts_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/HashTransformKeys:
+  Exclude:
+    - 'lib/facterdb.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/facterdb.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/MapToHash:
+  Exclude:
+    - 'lib/facterdb.rb'
+
+# Offense count: 1
+Style/MixinUsage:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'facts/Vagrantfile'
+    - 'lib/facterdb/version.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'Rakefile'
+
+# Offense count: 1
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/facterdb.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/SlicingWithRange:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'lib/facterdb.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
+# AllowedMethods: define_method
+Style/SymbolProc:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 179

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## [1.22.0](https://rubygems.org/gems/facterdb/versions/1.22.0) (2023-11-13)
+
+[Full Changelog](https://github.com/voxpupuli/facterdb/compare/1.21.0...1.22.0)
+
+**Implemented enhancements:**
+
+- fedora38 facts [\#287](https://github.com/voxpupuli/facterdb/pull/287) ([hbrown-uiowa](https://github.com/hbrown-uiowa))
+- Add facts for Debian 12 [\#283](https://github.com/voxpupuli/facterdb/pull/283) ([TheMeier](https://github.com/TheMeier))
+- Adding windows servers for Facter 4.3 and 4.4 [\#273](https://github.com/voxpupuli/facterdb/pull/273) ([davidsandilands](https://github.com/davidsandilands))
+- new facts for 4.3 and 4.4 and a few stragglers for 4.1 [\#272](https://github.com/voxpupuli/facterdb/pull/272) ([hbrown-uiowa](https://github.com/hbrown-uiowa))
+- Introduce RuboCop [\#267](https://github.com/voxpupuli/facterdb/pull/267) ([bastelfreak](https://github.com/bastelfreak))
+
+**Fixed bugs:**
+
+- Correct class documentation [\#281](https://github.com/voxpupuli/facterdb/pull/281) ([ekohl](https://github.com/ekohl))
+
 ## [1.21.0](https://rubygems.org/gems/facterdb/versions/1.21.0) (2023-01-25)
 
 [Full Changelog](https://github.com/voxpupuli/facterdb/compare/1.20.0...1.21.0)

data/Gemfile

@@ -2,11 +2,7 @@ source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 
 gemspec
 
-if facterversion = ENV['FACTER_GEM_VERSION']
-  gem 'facter', facterversion, :require => false
-else
-  gem 'facter', :require => false
-end
+gem 'facter', ENV.fetch('FACTER_GEM_VERSION', nil), require: false
 
 group :development do
   gem 'github_changelog_generator', '>= 1.16.4'