facter 4.0.9.pre → 4.0.10.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7bcb47b3d2864a886a00c54df529a748c9ec915e918f519f959ccca282f71fd9
-  data.tar.gz: 22e86bb46282e704dc18a6f38cc9985d3ad52586090dd7e824a0d3f15295a15a
+  metadata.gz: e7baf6d5b1b24f41a21f9ef4854a86a894ad3fb46d47b3eeac21a1d1fe785493
+  data.tar.gz: 3d925266d7ad956951a7157de64c3cee79a42098821cfc63c5b868397a5c0e2e
 SHA512:
-  metadata.gz: 6ec6ac1b3a3f3baeaa5082e02b33fc3fb4733c3c269621edb2ada6cb5d46316e52f24a9d73840ac6af781eae91fb0f202b2ed3b17f394f23ad03057c75b37627
-  data.tar.gz: 0e88c62fb9f0d503ad8cb255465b6fa4ba8fdc6ba104251cd0cc858b2e32788a52780125e8813ac24a23bcdad054401242937a899bacfc546a10511042aba4f4
+  metadata.gz: b785aebebb84571e18b779e1bed3c7ea6f79fda7fe01476595b1c12a6c79a817243c65cdfe44eaac11ef58f591f99ab94c5200a4646b5bd893c51dd3d6c187dc
+  data.tar.gz: a813e1da2e65bdbbe816b5bccd25cb90f2c2c0bca737329b964a4eecb6743a6f385c9399ce11f755a8686e2b8ce5279df7fb9a1aa8e79b45a2c66b03c25eea10

data/.github/workflows/rtc.yml

@@ -0,0 +1,11 @@
+---
+name: RuboCop TODO checker
+
+on: [pull_request]
+
+jobs:
+  rtc:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - uses: gimmyxd/rtc-action@0.0.5

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 1000`
-# on 2020-03-05 10:38:09 +0200 using RuboCop version 0.74.0.
+# on 2020-03-16 18:39:58 +0200 using RuboCop version 0.74.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -29,7 +29,7 @@ RSpec/AnyInstance:
     - 'spec/framework/core/options/options_validator_spec.rb'
     - 'spec/mocks/util.rb'
 
-# Offense count: 72
+# Offense count: 70
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -41,7 +41,6 @@ RSpec/ContextWording:
     - 'spec/facter/fact_filter_spec.rb'
     - 'spec/facter/facter_spec.rb'
     - 'spec/facter/facts/macosx/is_virtual_spec.rb'
-    - 'spec/facter/resolvers/linux/networking_linux_resolver_spec.rb'
     - 'spec/facter/resolvers/solaris/current_zone_resolver_spec.rb'
     - 'spec/facter/resolvers/solaris/solaris_release_resolver_spec.rb'
     - 'spec/facter/resolvers/solaris/zfs_resolver_spec.rb'
@@ -55,38 +54,13 @@ RSpec/ContextWording:
     - 'spec/framework/core/options_spec.rb'
     - 'spec/framework/formatters/legacy_fact_formatter_spec.rb'
 
-# Offense count: 82
+# Offense count: 31
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/custom_facts/core/execution/fact_manager_spec.rb'
     - 'spec/facter/facts/aix/load_averages_spec.rb'
     - 'spec/facter/facts/macosx/filesystems_spec.rb'
-    - 'spec/facter/facts/macosx/identity/gid_spec.rb'
-    - 'spec/facter/facts/macosx/identity/group_spec.rb'
     - 'spec/facter/facts/macosx/identity/privileged_spec.rb'
-    - 'spec/facter/facts/macosx/identity/uid_spec.rb'
-    - 'spec/facter/facts/macosx/identity/user_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/boot_mode_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/boot_rom_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/boot_volume_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/computer_name_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/cores_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/hardware_uuid_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/kernel_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/l2_cache_per_core_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/l3_cache_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/memory_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/model_identifier_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/model_name_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/processor_name_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/processor_speed_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/processors_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/secure_virtual_memory_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/serial_number_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/smc_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/system_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/uptime_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/username_spec.rb'
     - 'spec/facter/resolvers/aix/ffi_helper_spec.rb'
     - 'spec/facter/resolvers/lpar_resolver_spec.rb'
     - 'spec/facter/resolvers/solaris/current_zone_resolver_spec.rb'
@@ -97,7 +71,7 @@ RSpec/ExpectInHook:
     - 'spec/facter/resolvers/wpar_resolver_spec.rb'
     - 'spec/framework/config/config_reader_spec.rb'
 
-# Offense count: 80
+# Offense count: 79
 # Configuration parameters: CustomTransform, IgnoreMethods.
 RSpec/FilePath:
   Exclude:
@@ -133,7 +107,6 @@ RSpec/FilePath:
     - 'spec/facter/resolvers/filesystems_resolver_spec.rb'
     - 'spec/facter/resolvers/fips_enabled_resolver_spec.rb'
     - 'spec/facter/resolvers/identity_resolver_spec.rb'
-    - 'spec/facter/resolvers/linux/networking_linux_resolver_spec.rb'
     - 'spec/facter/resolvers/load_averages_resolver_spec.rb'
     - 'spec/facter/resolvers/macosx/dmi_resolver_spec.rb'
     - 'spec/facter/resolvers/memory_resolver_spec.rb'
@@ -206,7 +179,7 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/facter/resolvers/macosx/mountpoints_resolver_spec.rb'
     - 'spec/facter/resolvers/utils/windows/network_utils_spec.rb'
 
-# Offense count: 409
+# Offense count: 326
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
@@ -244,40 +217,18 @@ RSpec/MessageSpies:
     - 'spec/facter/facts/debian/networking/interfaces_spec.rb'
     - 'spec/facter/facts/debian/networking/ip_spec.rb'
     - 'spec/facter/facts/debian/networking/primary_spec.rb'
-    - 'spec/facter/facts/debian/os/architecture_spec.rb'
     - 'spec/facter/facts/debian/os/family_spec.rb'
-    - 'spec/facter/facts/debian/os/name_spec.rb'
-    - 'spec/facter/facts/debian/os/release_spec.rb'
     - 'spec/facter/facts/debian/ruby/version_spec.rb'
-    - 'spec/facter/facts/el/disks_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/available_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/total_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/used_spec.rb'
-    - 'spec/facter/facts/el/memory/system/available_spec.rb'
-    - 'spec/facter/facts/el/memory/system/total_spec.rb'
-    - 'spec/facter/facts/el/memory/system/used_spec.rb'
     - 'spec/facter/facts/el/networking/domain_spec.rb'
     - 'spec/facter/facts/el/networking/fqdn_spec.rb'
     - 'spec/facter/facts/el/networking/hostname_spec.rb'
     - 'spec/facter/facts/el/networking/interfaces_spec.rb'
     - 'spec/facter/facts/el/networking/ip_spec.rb'
     - 'spec/facter/facts/el/networking/primary_spec.rb'
-    - 'spec/facter/facts/el/os/architecture_spec.rb'
-    - 'spec/facter/facts/el/os/name_spec.rb'
-    - 'spec/facter/facts/el/os/release_spec.rb'
-    - 'spec/facter/facts/el/ruby/version_spec.rb'
     - 'spec/facter/facts/macosx/filesystems_spec.rb'
-    - 'spec/facter/facts/macosx/identity/gid_spec.rb'
-    - 'spec/facter/facts/macosx/identity/group_spec.rb'
     - 'spec/facter/facts/macosx/identity/privileged_spec.rb'
-    - 'spec/facter/facts/macosx/identity/uid_spec.rb'
-    - 'spec/facter/facts/macosx/identity/user_spec.rb'
     - 'spec/facter/facts/macosx/is_virtual_spec.rb'
-    - 'spec/facter/facts/macosx/memory/swap/available_spec.rb'
-    - 'spec/facter/facts/macosx/memory/swap/total_spec.rb'
     - 'spec/facter/facts/macosx/memory/swap/used_spec.rb'
-    - 'spec/facter/facts/macosx/memory/system/available_spec.rb'
-    - 'spec/facter/facts/macosx/memory/system/total_spec.rb'
     - 'spec/facter/facts/macosx/memory/system/used_spec.rb'
     - 'spec/facter/facts/macosx/mountpoints_spec.rb'
     - 'spec/facter/facts/macosx/networking/domain_spec.rb'
@@ -287,27 +238,6 @@ RSpec/MessageSpies:
     - 'spec/facter/facts/macosx/os/family_spec.rb'
     - 'spec/facter/facts/macosx/os/name_spec.rb'
     - 'spec/facter/facts/macosx/ruby/version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/boot_mode_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/boot_rom_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/boot_volume_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/computer_name_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/cores_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/hardware_uuid_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/kernel_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/l2_cache_per_core_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/l3_cache_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/memory_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/model_identifier_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/model_name_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/processor_name_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/processor_speed_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/processors_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/secure_virtual_memory_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/serial_number_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/smc_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/system_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/uptime_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/username_spec.rb'
     - 'spec/facter/facts/sles/facterversion_spec.rb'
     - 'spec/facter/facts/sles/networking/domain_spec.rb'
     - 'spec/facter/facts/sles/networking/fqdn_spec.rb'
@@ -318,7 +248,6 @@ RSpec/MessageSpies:
     - 'spec/facter/facts/sles/os/architecture_spec.rb'
     - 'spec/facter/facts/sles/os/name_spec.rb'
     - 'spec/facter/facts/sles/os/release_spec.rb'
-    - 'spec/facter/facts/sles/ruby/version_spec.rb'
     - 'spec/facter/facts/solaris/facterversion_spec.rb'
     - 'spec/facter/facts/solaris/networking/domain_spec.rb'
     - 'spec/facter/facts/solaris/networking/fqdn_spec.rb'
@@ -335,7 +264,6 @@ RSpec/MessageSpies:
     - 'spec/facter/facts/windows/dmi/product/uuid_spec.rb'
     - 'spec/facter/facts/windows/fips_enabled_spec.rb'
     - 'spec/facter/facts/windows/identity/user_spec.rb'
-    - 'spec/facter/facts/windows/interfaces_spec.rb'
     - 'spec/facter/facts/windows/ipaddress6_interfaces_spec.rb'
     - 'spec/facter/facts/windows/ipaddress_interfaces_spec.rb'
     - 'spec/facter/facts/windows/macaddress_interfaces_spec.rb'
@@ -368,7 +296,6 @@ RSpec/MessageSpies:
     - 'spec/facter/facts/windows/os/windows/product_name_spec.rb'
     - 'spec/facter/facts/windows/os/windows/release_id_spec.rb'
     - 'spec/facter/facts/windows/os/windows/system32_spec.rb'
-    - 'spec/facter/facts/windows/processor_spec.rb'
     - 'spec/facter/facts/windows/processors/count_spec.rb'
     - 'spec/facter/facts/windows/processors/isa_spec.rb'
     - 'spec/facter/facts/windows/processors/physicalcount_spec.rb'
@@ -391,35 +318,31 @@ RSpec/MessageSpies:
     - 'spec/framework/core/fact_loaders/external_fact_loader_spec.rb'
     - 'spec/framework/detector/os_detector_spec.rb'
 
-# Offense count: 142
+# Offense count: 122
 # Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 9
 
-# Offense count: 250
+# Offense count: 177
 # Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Exclude:
-    - 'spec/custom_facts/core/aggregate_spec.rb'
     - 'spec/custom_facts/core/execution/fact_manager_spec.rb'
     - 'spec/custom_facts/core/execution/posix_spec.rb'
     - 'spec/custom_facts/core/execution/windows_spec.rb'
     - 'spec/custom_facts/core/execution_spec.rb'
     - 'spec/custom_facts/core/logging_spec.rb'
     - 'spec/custom_facts/core/resolvable_spec.rb'
-    - 'spec/custom_facts/core/suitable_spec.rb'
     - 'spec/custom_facts/util/directory_loader_spec.rb'
     - 'spec/custom_facts/util/fact_spec.rb'
     - 'spec/custom_facts/util/normalization_spec.rb'
-    - 'spec/custom_facts/util/resolution_spec.rb'
-    - 'spec/facter/resolvers/linux/networking_linux_resolver_spec.rb'
     - 'spec/framework/core/options_spec.rb'
 
-# Offense count: 22
+# Offense count: 29
 RSpec/NestedGroups:
   Max: 4
 
-# Offense count: 39
+# Offense count: 33
 RSpec/SubjectStub:
   Exclude:
     - 'spec/custom_facts/core/aggregate_spec.rb'
@@ -431,7 +354,7 @@ RSpec/SubjectStub:
     - 'spec/custom_facts/util/fact_spec.rb'
     - 'spec/custom_facts/util/resolution_spec.rb'
 
-# Offense count: 349
+# Offense count: 246
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
@@ -442,7 +365,6 @@ RSpec/VerifiedDoubles:
     - 'spec/custom_facts/util/fact_spec.rb'
     - 'spec/custom_facts/util/resolution_spec.rb'
     - 'spec/facter/facter_spec.rb'
-    - 'spec/facter/facts/aix/augeas/version_spec.rb'
     - 'spec/facter/facts/aix/facterversion_spec.rb'
     - 'spec/facter/facts/aix/kernel_spec.rb'
     - 'spec/facter/facts/aix/kernelmajversion_spec.rb'
@@ -459,138 +381,37 @@ RSpec/VerifiedDoubles:
     - 'spec/facter/facts/debian/kernelmajversion_spec.rb'
     - 'spec/facter/facts/debian/kernelrelease_spec.rb'
     - 'spec/facter/facts/debian/kernelversion_spec.rb'
-    - 'spec/facter/facts/debian/os/distro_spec.rb'
-    - 'spec/facter/facts/debian/os/hardware_spec.rb'
-    - 'spec/facter/facts/debian/os/selinux_spec.rb'
     - 'spec/facter/facts/debian/path_spec.rb'
-    - 'spec/facter/facts/debian/ruby/platform_spec.rb'
-    - 'spec/facter/facts/debian/ruby/sitedir_spec.rb'
-    - 'spec/facter/facts/debian/timezone_spec.rb'
     - 'spec/facter/facts/el/facterversion_spec.rb'
     - 'spec/facter/facts/el/kernel_spec.rb'
     - 'spec/facter/facts/el/kernelmajversion_spec.rb'
     - 'spec/facter/facts/el/kernelrelease_spec.rb'
     - 'spec/facter/facts/el/kernelversion_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/available_bytes_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/available_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/capacity_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/total_bytes_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/total_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/used_bytes_spec.rb'
-    - 'spec/facter/facts/el/memory/swap/used_spec.rb'
-    - 'spec/facter/facts/el/memory/system/available_bytes_spec.rb'
-    - 'spec/facter/facts/el/memory/system/available_spec.rb'
-    - 'spec/facter/facts/el/memory/system/capacity_spec.rb'
-    - 'spec/facter/facts/el/memory/system/total_bytes_spec.rb'
-    - 'spec/facter/facts/el/memory/system/total_spec.rb'
-    - 'spec/facter/facts/el/memory/system/used_bytes_spec.rb'
-    - 'spec/facter/facts/el/memory/system/used_spec.rb'
-    - 'spec/facter/facts/el/os/hardware_spec.rb'
-    - 'spec/facter/facts/el/os/selinux_spec.rb'
     - 'spec/facter/facts/el/path_spec.rb'
-    - 'spec/facter/facts/el/processors/count_spec.rb'
-    - 'spec/facter/facts/el/processors/isa_spec.rb'
-    - 'spec/facter/facts/el/processors/models_spec.rb'
-    - 'spec/facter/facts/el/processors/physicalcount_spec.rb'
-    - 'spec/facter/facts/el/ruby/platform_spec.rb'
-    - 'spec/facter/facts/el/ruby/sitedir_spec.rb'
-    - 'spec/facter/facts/el/system_uptime/days_spec.rb'
-    - 'spec/facter/facts/el/system_uptime/hours_spec.rb'
-    - 'spec/facter/facts/el/system_uptime/seconds_spec.rb'
-    - 'spec/facter/facts/el/system_uptime/uptime_spec.rb'
-    - 'spec/facter/facts/el/timezone_spec.rb'
-    - 'spec/facter/facts/macosx/augeas_spec.rb'
-    - 'spec/facter/facts/macosx/dmi/product/name_spec.rb'
     - 'spec/facter/facts/macosx/facterversion_spec.rb'
     - 'spec/facter/facts/macosx/filesystems_spec.rb'
-    - 'spec/facter/facts/macosx/identity/gid_spec.rb'
-    - 'spec/facter/facts/macosx/identity/group_spec.rb'
     - 'spec/facter/facts/macosx/identity/privileged_spec.rb'
-    - 'spec/facter/facts/macosx/identity/uid_spec.rb'
-    - 'spec/facter/facts/macosx/identity/user_spec.rb'
     - 'spec/facter/facts/macosx/kernel_spec.rb'
     - 'spec/facter/facts/macosx/kernelmajversion_spec.rb'
     - 'spec/facter/facts/macosx/kernelrelease_spec.rb'
     - 'spec/facter/facts/macosx/kernelversion_spec.rb'
-    - 'spec/facter/facts/macosx/memory/swap/available_bytes_spec.rb'
-    - 'spec/facter/facts/macosx/memory/swap/available_spec.rb'
     - 'spec/facter/facts/macosx/memory/swap/capacity_spec.rb'
-    - 'spec/facter/facts/macosx/memory/swap/encrypted_spec.rb'
-    - 'spec/facter/facts/macosx/memory/swap/total_bytes_spec.rb'
-    - 'spec/facter/facts/macosx/memory/swap/total_spec.rb'
     - 'spec/facter/facts/macosx/memory/swap/used_bytes_spec.rb'
     - 'spec/facter/facts/macosx/memory/swap/used_spec.rb'
-    - 'spec/facter/facts/macosx/memory/system/available_bytes_spec.rb'
-    - 'spec/facter/facts/macosx/memory/system/available_spec.rb'
     - 'spec/facter/facts/macosx/memory/system/capacity_spec.rb'
-    - 'spec/facter/facts/macosx/memory/system/total_bytes_spec.rb'
-    - 'spec/facter/facts/macosx/memory/system/total_spec.rb'
     - 'spec/facter/facts/macosx/memory/system/used_bytes_spec.rb'
     - 'spec/facter/facts/macosx/memory/system/used_spec.rb'
-    - 'spec/facter/facts/macosx/os/hardware_spec.rb'
-    - 'spec/facter/facts/macosx/os/release_spec.rb'
     - 'spec/facter/facts/macosx/path_spec.rb'
-    - 'spec/facter/facts/macosx/ruby/platform_spec.rb'
-    - 'spec/facter/facts/macosx/ruby/sitedir_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/boot_mode_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/boot_rom_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/boot_volume_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/computer_name_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/cores_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/hardware_uuid_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/kernel_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/l2_cache_per_core_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/l3_cache_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/memory_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/model_identifier_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/model_name_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/processor_name_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/processor_speed_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/processors_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/secure_virtual_memory_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/serial_number_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/smc_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/system_version_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/uptime_spec.rb'
-    - 'spec/facter/facts/macosx/system_profiler/username_spec.rb'
-    - 'spec/facter/facts/macosx/system_uptime/days_spec.rb'
-    - 'spec/facter/facts/macosx/system_uptime/hours_spec.rb'
-    - 'spec/facter/facts/macosx/system_uptime/seconds_spec.rb'
-    - 'spec/facter/facts/macosx/system_uptime/uptime_spec.rb'
-    - 'spec/facter/facts/macosx/timezone_spec.rb'
     - 'spec/facter/facts/sles/kernel_spec.rb'
     - 'spec/facter/facts/sles/kernelmajversion_spec.rb'
     - 'spec/facter/facts/sles/kernelrelease_spec.rb'
     - 'spec/facter/facts/sles/kernelversion_spec.rb'
-    - 'spec/facter/facts/sles/memory/swap/available_bytes_spec.rb'
-    - 'spec/facter/facts/sles/memory/swap/available_spec.rb'
-    - 'spec/facter/facts/sles/memory/swap/capacity_spec.rb'
-    - 'spec/facter/facts/sles/memory/swap/total_bytes_spec.rb'
-    - 'spec/facter/facts/sles/memory/swap/total_spec.rb'
-    - 'spec/facter/facts/sles/memory/swap/used_bytes_spec.rb'
-    - 'spec/facter/facts/sles/memory/swap/used_spec.rb'
-    - 'spec/facter/facts/sles/memory/system/available_bytes_spec.rb'
-    - 'spec/facter/facts/sles/memory/system/available_spec.rb'
-    - 'spec/facter/facts/sles/memory/system/capacity_spec.rb'
-    - 'spec/facter/facts/sles/memory/system/total_bytes_spec.rb'
-    - 'spec/facter/facts/sles/memory/system/total_spec.rb'
-    - 'spec/facter/facts/sles/memory/system/used_bytes_spec.rb'
-    - 'spec/facter/facts/sles/memory/system/used_spec.rb'
-    - 'spec/facter/facts/sles/os/hardware_spec.rb'
-    - 'spec/facter/facts/sles/os/selinux_spec.rb'
     - 'spec/facter/facts/sles/path_spec.rb'
-    - 'spec/facter/facts/sles/ruby/platform_spec.rb'
-    - 'spec/facter/facts/sles/ruby/sitedir_spec.rb'
-    - 'spec/facter/facts/sles/ssh_spec.rb'
-    - 'spec/facter/facts/sles/timezone_spec.rb'
     - 'spec/facter/facts/solaris/kernel_spec.rb'
     - 'spec/facter/facts/solaris/kernelmajversion_spec.rb'
     - 'spec/facter/facts/solaris/kernelrelease_spec.rb'
     - 'spec/facter/facts/solaris/kernelversion_spec.rb'
-    - 'spec/facter/facts/solaris/os/hardware_spec.rb'
     - 'spec/facter/facts/solaris/path_spec.rb'
-    - 'spec/facter/facts/solaris/solaris_zones/current_spec.rb'
-    - 'spec/facter/facts/solaris/solaris_zones/zone_spec.rb'
     - 'spec/facter/facts/windows/dmi/product/serial_number_spec.rb'
     - 'spec/facter/facts/windows/facterversion_spec.rb'
     - 'spec/facter/facts/windows/hypervisors/hyperv_spec.rb'
@@ -608,7 +429,6 @@ RSpec/VerifiedDoubles:
     - 'spec/facter/facts/windows/networking/primary_spec.rb'
     - 'spec/facter/facts/windows/path_spec.rb'
     - 'spec/facter/facts/windows/processors/models_spec.rb'
-    - 'spec/facter/facts/windows/timezone_spec.rb'
     - 'spec/facter/facts/windows/virtualization/is_virtual_spec.rb'
     - 'spec/facter/facts/windows/virtualization/virtual_spec.rb'
     - 'spec/facter/query_parser_spec.rb'

data/VERSION

@@ -1 +1 @@
-4.0.9.pre
+4.0.10.pre

data/facter.gemspec

@@ -44,6 +44,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rubocop-rspec', '~> 1.38'
   spec.add_development_dependency 'rubycritic', '~> 4.1.0'
   spec.add_development_dependency 'sys-filesystem', '~> 1.3'
+  spec.add_development_dependency 'yard', '~> 0.9'
 
   spec.add_runtime_dependency 'hocon', '~> 1.3'
   spec.add_runtime_dependency 'thor', ['>= 1.0.1', '< 2.0']

data/lib/custom_facts/core/aggregate.rb

@@ -49,12 +49,10 @@ module LegacyFacter
       end
 
       def options(options)
-        @name = options.delete(:name) if options[:name]
-
-        @timeout = options.delete(:timeout) if options.key?(:timeout)
-
-        @weight = options.delete(:has_weight) if options.key?(:has_weight)
-
+        accepted_option = %i[name timeout weight fact_type]
+        accepted_option.each do |option_name|
+          instance_variable_set("@#{option_name}", options.delete(option_name)) if options.key?(option_name)
+        end
         raise ArgumentError, "Invalid aggregate options #{options.keys.inspect}" unless options.keys.empty?
       end
 

data/lib/custom_facts/core/execution.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module LegacyFacter
+module Facter
   module Core
     module Execution
       # require_relative 'execution/base'

data/lib/custom_facts/core/execution/base.rb

@@ -42,45 +42,36 @@ module LegacyFacter
 
             if expanded_command.nil?
               if on_fail == :raise
-                raise LegacyFacter::Core::Execution::ExecutionFailure.new,
+                raise Facter::Core::Execution::ExecutionFailure.new,
                       "Could not execute '#{command}': command not found"
               end
 
               return on_fail
             end
 
-            out = ''
-
             begin
-              wait_for_child = true
-              out = `#{expanded_command}`.chomp
-              wait_for_child = false
+              out, stderr, _status_ = Open3.capture3(expanded_command.to_s)
+              log_stderr_from_file(stderr, expanded_command)
             rescue StandardError => e
               return on_fail unless on_fail == :raise
 
-              raise LegacyFacter::Core::Execution::ExecutionFailure.new,
+              raise Facter::Core::Execution::ExecutionFailure.new,
                     "Failed while executing '#{expanded_command}': #{e.message}"
-            ensure
-              if wait_for_child
-                # We need to ensure that if this command exits early then any spawned
-                # children will be reaped. Process execution is frequently
-                # terminated using Timeout.timeout but since the timeout isn't in
-                # this scope we can't rescue the raised exception. The best that
-                # we can do is determine if the child has exited, and if it hasn't
-                # then we need to spawn a thread to wait for the child.
-                #
-                # Due to the limitations of Ruby 1.8 there aren't good ways to
-                # asynchronously run a command and grab the PID of that command
-                # using the standard library. The best we can do is blindly wait
-                # on all processes and hope for the best. This issue is described
-                # at https://tickets.puppetlabs.com/browse/FACT-150
-                Thread.new { Process.waitall }
-              end
             end
 
-            out
+            out.strip
           end
         end
+
+        private
+
+        def log_stderr_from_file(msg, command)
+          return if !msg || msg.empty?
+
+          file_name = command.split('/').last
+          logger = Facter::Log.new(file_name)
+          logger.warn(msg.strip)
+        end
       end
     end
   end