facter 4.0.29 → 4.0.34

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -1,13 +0,0 @@
-PLEASE LABEL YOUR PULL REQUEST ACCORDINGLY!
-
-Choose only one of the following:
-
-"backwards-incompatible" - use this label for PRs that breaks some old functionality
-
-"feature" - use this label for new added functionality
-
-"bugfix" - use this label for PRs that contain fixes
-
-"maintenance" - use this label for PRs that contain trivial changes (eg. changes in unit tests)
-
-Also please add "community" additional label if you're part of puppet community (special attention will be provided for those PRs).

data/.github/actions/presuite.rb

@@ -1,139 +0,0 @@
-require 'open3'
-
-def install_bundler
-  message('INSTALL BUNDLER')
-  run('gem install bundler')
-end
-
-def install_facter_3_dependencies
-  message('INSTALL FACTER 3 ACCEPTANCE DEPENDENCIES')
-  run('bundle install')
-end
-
-def initialize_beaker
-  beaker_platform_with_options = platform_with_options(beaker_platform)
-
-  message('BEAKER INITIALIZE')
-  run("beaker init -h #{beaker_platform_with_options} -o #{File.join('config', 'aio', 'options.rb')}")
-
-  message('BEAKER PROVISION')
-  run('beaker provision')
-end
-
-def beaker_platform
-  {
-      'ubuntu-18.04' => 'ubuntu1804-64a',
-      'ubuntu-16.04' => 'ubuntu1604-64a',
-      'ubuntu-20.04' => 'ubuntu2004-64a',
-      'macos-10.15' => 'osx1015-64a',
-      'windows-2016' => 'windows2016-64a',
-      'windows-2019' => 'windows2019-64a'
-  }[HOST_PLATFORM]
-end
-
-def platform_with_options(platform)
-  return "\"#{platform}{hypervisor=none,hostname=localhost,is_cygwin=false}\"" if platform.include? 'windows'
-  "#{platform}{hypervisor=none\\,hostname=localhost}"
-end
-
-def install_puppet_agent
-  message('INSTALL PUPPET AGENT')
-
-  beaker_puppet_root, _ = run('bundle info beaker-puppet --path')
-  presuite_file_path = File.join(beaker_puppet_root.chomp, 'setup', 'aio', '010_Install_Puppet_Agent.rb')
-
-  run("beaker exec pre-suite --pre-suite #{presuite_file_path} --preserve-state", './', env_path_var)
-end
-
-def puppet_bin_dir
-  linux_puppet_bin_dir = '/opt/puppetlabs/puppet/bin'
-  windows_puppet_bin_dir = 'C:\\Program Files\\Puppet Labs\\Puppet\\bin'
-
-  (HOST_PLATFORM.include? 'windows') ? windows_puppet_bin_dir : linux_puppet_bin_dir
-end
-
-def puppet_command
-  return '/opt/puppetlabs/puppet/bin/puppet' unless HOST_PLATFORM.include? 'windows'
-  "\"C:\\Program Files\\Puppet Labs\\Puppet\\bin\\puppet\""
-end
-
-def gem_command
-  return '/opt/puppetlabs/puppet/bin/gem' unless HOST_PLATFORM.include? 'windows'
-  "\"C:\\Program Files\\Puppet Labs\\Puppet\\puppet\\bin\\gem\""
-end
-
-def env_path_var
-  (HOST_PLATFORM.include? 'windows') ? { 'PATH' => "#{puppet_bin_dir};#{ENV['PATH']}" } : {}
-end
-
-def replace_facter_3_with_facter_4
-  message('SET FACTER 4 FLAG TO TRUE')
-  run("#{puppet_command} config set facterng true")
-
-  install_latest_facter_4(gem_command)
-
-  message('CHANGE FACTER 3 WITH FACTER 4')
-
-  extension = (HOST_PLATFORM.include? 'windows') ? '.bat' : ''
-  run("mv facter-ng#{extension} facter#{extension}", puppet_bin_dir)
-end
-
-
-def install_latest_facter_4(gem_command)
-  message('BUILD FACTER 4 LATEST AGENT GEM')
-  run("#{gem_command} build agent/facter-ng.gemspec", ENV['FACTER_4_ROOT'])
-
-  message('UNINSTALL DEFAULT FACTER 4 AGENT GEM')
-  run("#{gem_command} uninstall facter-ng")
-
-  message('INSTALL FACTER 4 GEM')
-  run("#{gem_command} install -f facter-ng-*.gem", ENV['FACTER_4_ROOT'])
-end
-
-def run_acceptance_tests
-  message('RUN ACCEPTANCE TESTS')
-
-  run('beaker exec tests --test-tag-exclude=server,facter_3 --test-tag-or=risk:high,audit:high', './', env_path_var)
-end
-
-def message(message)
-  message_length = message.length
-  total_length = 130
-  lines_length = (total_length - message_length) / 2
-  result = ('-' * lines_length + ' ' + message + ' ' + '-' * lines_length)[0, total_length]
-  puts "\n\n#{result}\n\n"
-end
-
-def run(command, dir = './', env = {})
-  puts command
-  output = ''
-  status = 0
-  Open3.popen2e(env, command, chdir: dir) do |_stdin, stdout_and_err, wait_thr|
-    stdout_and_err.each do |line|
-      puts line
-      output += line
-    end
-    status = wait_thr.value
-  end
-  [output, status]
-end
-
-ENV['DEBIAN_DISABLE_RUBYGEMS_INTEGRATION'] = 'no_warnings'
-FACTER_3_ACCEPTANCE_PATH = File.join(ENV['FACTER_3_ROOT'], 'acceptance')
-HOST_PLATFORM = ARGV[0]
-
-install_bundler
-
-Dir.chdir(FACTER_3_ACCEPTANCE_PATH) { install_facter_3_dependencies }
-
-Dir.chdir(FACTER_3_ACCEPTANCE_PATH) do
-  initialize_beaker
-  install_puppet_agent
-end
-
-replace_facter_3_with_facter_4
-
-Dir.chdir(FACTER_3_ACCEPTANCE_PATH) do
-  _, status = run_acceptance_tests
-  exit(status.exitstatus)
-end

data/.github/workflows/acceptance_tests.yml

@@ -1,65 +0,0 @@
----
-name: Acceptance tests
-
-on:
-  push:
-    branches:
-      - 4.x
-  pull_request:
-    branches:
-      - 4.x
-
-jobs:
-  acceptance_tests:
-    name: Platform
-    strategy:
-      matrix:
-        os: [windows-2016, windows-2019, ubuntu-16.04, ubuntu-18.04, ubuntu-20.04, macos-10.15]
-    runs-on: ${{ matrix.os }}
-    env:
-      FACTER_3_ROOT: facter_3
-      FACTER_4_ROOT: facter_4
-      SHA: latest
-
-    steps:
-      - name: Checkout current PR
-        uses: actions/checkout@v2
-        with:
-          path: facter_4
-
-      - name: Clone facter 3 repo
-        uses: actions/checkout@v2
-        with:
-          repository: puppetlabs/facter
-          ref: github_acceptance_tests
-          path: facter_3
-
-      - name: Install Ruby 2.6
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: '2.6'
-
-      - name: Fix common Linux and MacOs permissions
-        if: runner.os != 'Windows'
-        run: sudo chmod a-w /opt
-
-      - name: Fix Linux permissions
-        if: runner.os == 'Linux'
-        run: |
-          sudo chmod a-w /home/runner /usr/share &&
-          sudo chmod -R a-w /usr/share/rust /home/runner/.config /home/linuxbrew
-
-      - name: Instal dhclient for Linux
-        if: runner.os == 'Linux'
-        run: |
-          sudo apt install dhcpcd5
-          sudo dhclient
-
-      - name: Run acceptance tests on Linux like platform
-        if: runner.os != 'Windows'
-        run: sudo -E "PATH=$PATH" ruby $FACTER_4_ROOT/.github/actions/presuite.rb ${{ matrix.os }}
-
-      - name: Run acceptance tests on Windows like platform
-        if: runner.os == 'Windows'
-        run: ruby $Env:FACTER_4_ROOT/.github/actions/presuite.rb ${{ matrix.os }}
-

data/.github/workflows/checks.yaml

@@ -1,54 +0,0 @@
----
-name: Checks
-
-on:
-  push:
-    branches:
-      - 4.x
-  pull_request:
-    branches:
-      - 4.x
-
-jobs:
-  rubocop_checks:
-    runs-on: ubuntu-18.04
-    name: RuboCop
-    steps:
-      - name: Checkout current PR
-        uses: actions/checkout@v2
-
-      - name: Rubocop checks
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 2.6
-      - run: bundle install --jobs 3 --retry 3
-      - run: bundle exec rubocop --parallel
-
-  rtc:
-    runs-on: ubuntu-latest
-    name: RuboCop TODO
-    steps:
-      - uses: actions/checkout@v1
-      - uses: gimmyxd/rtc-action@0.2.1
-        env:
-          RTC_TOKEN: ${{ secrets.RTC_TOKEN }}
-          UPDATE_PR: false
-
-          # forces the job to fail if there are any new offences
-          FORCE_ERROR_EXIT: true
-
-  commit_checks:
-    runs-on: ubuntu-18.04
-    name: commit message
-    steps:
-      - name: Checkout current PR
-        uses: actions/checkout@v2
-        with:
-          fetch-depth: 2
-
-      - name: Commit message checks
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 2.6
-      - run: bundle install --jobs 3 --retry 3
-      - run: bundle exec rake commits

data/.github/workflows/coverage.yaml

@@ -1,33 +0,0 @@
----
-name: Coverage
-
-on:
-  push:
-    branches:
-      - 4.x
-
-jobs:
-  coverage_checks:
-    runs-on: ubuntu-18.04
-    name: coverage
-    steps:
-      - name: Checkout current PR
-        uses: actions/checkout@v2
-
-      - name: Setup Code Climate test-reporter
-        run: |
-          curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-          chmod +x ./cc-test-reporter
-          ./cc-test-reporter before-build
-
-      - name: Generate coverage
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 2.6
-      - run: bundle install --jobs 3 --retry 3
-      - run: bundle exec rake spec
-
-      - name: Publish code coverage
-        run: |
-          export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
-          ./cc-test-reporter after-build -r ${{secrets.CC_TEST_REPORTER_ID}}

data/.github/workflows/unit_tests.yaml

@@ -1,43 +0,0 @@
----
-name: Unit tests
-
-on:
-  push:
-    branches:
-      - 4.x
-  pull_request:
-    branches:
-      - 4.x
-
-jobs:
-  linux_unit_tests:
-    name: Ruby version
-    strategy:
-      matrix:
-        ruby: [ 2.3, 2.7, jruby ]
-    runs-on: ubuntu-18.04
-    steps:
-      - name: Checkout current PR
-        uses: actions/checkout@v2
-
-      - name: Rspec checks
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-      - run: gem update bundler
-      - run: bundle install --jobs 3 --retry 3
-      - run: bundle exec rake spec
-
-  windows_unit_tests:
-    runs-on: windows-2019
-    steps:
-      - name: Checkout current PR
-        uses: actions/checkout@v2
-
-      - name: Rspec checks
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 2.7
-      - run: gem update bundler
-      - run: bundle install --jobs 3 --retry 3
-      - run: bundle exec rake spec

data/.gitignore

@@ -1,57 +0,0 @@
-*.gem
-*.rbc
-/.config
-/coverage/
-/InstalledFiles
-/pkg/
-/spec/reports/
-/spec/examples.txt
-/test/tmp/
-/test/version_tmp/
-/tmp/
-
-# Used by dotenv library to load environment variables.
-# .env
-
-## Specific to RubyMotion:
-.dat*
-.repl_history
-build/
-*.bridgesupport
-build-iPhoneOS/
-build-iPhoneSimulator/
-
-## Specific to RubyMotion (use of CocoaPods):
-#
-# We recommend against adding the Pods directory to your .gitignore. However
-# you should judge for yourself, the pros and cons are mentioned at:
-# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
-#
-# vendor/Pods/
-
-## Documentation cache and generated files:
-/.yardoc/
-/_yardoc/
-/doc/
-/rdoc/
-
-## Environment normalization:
-/.bundle/
-/vendor/bundle
-/lib/bundler/man/
-
-## Logs
-*.log
-
-# for a library or gem, you might want to ignore these files since the code is
-# intended to run in multiple environments; otherwise, check them in:
-# Gemfile.lock
-# .ruby-version
-# .ruby-gemset
-
-# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
-.rvmrc
-
-.rspec_status
-Gemfile.lock
-Gemfile.local

data/.jrubyrc

@@ -1,2 +0,0 @@
-cli.debug=true
-debug.fullTrace=true

data/.rspec

@@ -1,2 +0,0 @@
---color
---require spec_helper

data/.rubocop.yml

@@ -1,170 +0,0 @@
----
-inherit_from: .rubocop_todo.yml
-
-AllCops:
-  TargetRubyVersion: 2.3
-  Exclude:
-    - acceptance/**/*
-
-require:
-  - rubocop-performance
-  - rubocop-rspec
-
-Layout/LineLength:
-  Max: 120
-
-Lint/RescueException:
-  Exclude:
-    - 'lib/custom_facts/util/parser.rb'
-
-Lint/RaiseException:
-  Enabled: true
-
-Lint/StructNewOverride:
-  Enabled: true
-
-Metrics/MethodLength:
-  Max: 20
-  Exclude:
-    - 'lib/custom_facts/util/values.rb'
-    - 'lib/custom_facts/util/confine.rb'
-    - 'lib/custom_facts/core/execution/windows.rb'
-    - 'lib/custom_facts/core/execution/base.rb'
-    - 'lib/framework/detector/os_detector.rb'
-    - 'lib/resolvers/bsd/ffi/ffi_helper.rb'
-
-Metrics/ModuleLength:
-  Max: 100
-  Exclude:
-    - 'lib/facter.rb'
-    - 'lib/facter-ng.rb'
-
-Metrics/BlockLength:
-  Exclude:
-    - !ruby/regexp /(?:(?!.+_spec.rb).)*$/
-
-Naming/ClassAndModuleCamelCase:
-  Exclude:
-    - 'spec/mocks/**/*'
-
-Metrics/AbcSize:
-  Max: 16
-  Exclude:
-    - 'spec/custom_facts/util/parser_spec.rb'
-    - 'spec/custom_facts/core/logging_spec.rb'
-    - 'lib/custom_facts/util/values.rb'
-    - 'lib/custom_facts/util/loader.rb'
-    - 'lib/custom_facts/util/confine.rb'
-    - 'lib/custom_facts/util/confine.rb'
-    - 'lib/custom_facts/core/execution/windows.rb'
-    - 'lib/custom_facts/core/execution/base.rb'
-    - 'lib/custom_facts/core/resolvable.rb'
-    - 'lib/resolvers/bsd/ffi/ffi_helper.rb'
-
-Metrics/PerceivedComplexity:
-  Exclude:
-    - 'lib/custom_facts/util/values.rb'
-    - 'lib/custom_facts/util/confine.rb'
-    - 'lib/custom_facts/core/execution/windows.rb'
-    - 'lib/custom_facts/core/execution/posix.rb'
-
-Metrics/CyclomaticComplexity:
-  Exclude:
-    - 'lib/custom_facts/util/values.rb'
-    - 'lib/custom_facts/util/confine.rb'
-    - 'lib/custom_facts/core/execution/windows.rb'
-    - 'lib/custom_facts/core/execution/posix.rb'
-    - 'lib/framework/detector/os_detector.rb'
-
-Metrics/ClassLength:
-  Exclude:
-    - 'lib/custom_facts/util/fact.rb'
-    - 'lib/resolvers/windows/networking_resolver.rb'
-    - 'lib/custom_facts/util/collection.rb'
-    - 'lib/framework/core/options/option_store.rb'
-    - 'lib/framework/cli/cli.rb'
-    - 'lib/resolvers/networking_linux_resolver.rb'
-    - 'lib/framework/core/cache_manager.rb'
-
-Naming/AccessorMethodName:
-  Exclude:
-    - 'lib/custom_facts/core/suitable.rb'
-
-Naming/MethodName:
-  Exclude:
-    - 'spec/mocks/**/*'
-
-Naming/PredicateName:
-  Exclude:
-    - 'lib/custom_facts/core/suitable.rb'
-
-Naming/FileName:
-  Exclude:
-    - 'lib/facter.rb'
-    - 'agent/lib/facter-ng.rb'
-
-RSpec/ExampleLength:
-  Enabled: false
-
-RSpec/DescribedClass:
-  EnforcedStyle: explicit
-
-RSpec/NestedGroups:
-  Max: 5
-
-Style/Documentation:
-  Enabled: false
-
-Style/ClassVars:
-  Exclude:
-    - !ruby/regexp /(?:(?!.+_resolver.rb).)*$/
-
-Style/FrozenStringLiteralComment:
-  Exclude:
-    - 'spec/custom_facts/util/normalization_spec.rb'
-    - 'spec/custom_facts/shared_contexts/platform.rb'
-    - 'spec/custom_facts/core/execution/windows_spec.rb'
-    - 'spec/custom_facts/core/execution/posix_spec.rb'
-    - 'lib/custom_facts/util/resolution.rb'
-    - 'lib/custom_facts/core/execution/windows.rb'
-    - 'lib/custom_facts/core/execution/posix.rb'
-
-Style/TrivialAccessors:
-  AllowDSLWriters: true
-
-Style/CaseEquality:
-  Exclude:
-    - 'spec/custom_facts/util/confine_spec.rb'
-    - 'lib/custom_facts/util/confine.rb'
-
-Style/DoubleNegation:
-  Exclude:
-    - 'lib/custom_facts/util/confine.rb'
-    - 'lib/custom_facts/util/confine.rb'
-    - 'lib/custom_facts/core/execution/windows.rb'
-    - 'lib/custom_facts/core/execution/posix.rb'
-
-Style/MethodMissingSuper:
-  Exclude:
-    - 'lib/facter.rb'
-
-Style/MissingRespondToMissing:
-  Exclude:
-    - 'lib/facter.rb'
-
-Style/StderrPuts:
-  Exclude:
-    - 'lib/custom_facts/core/logging.rb'
-
-Style/ModuleFunction:
-  Exclude:
-    - 'lib/custom_facts/core/logging.rb'
-
-Style/HashEachMethods:
-  Enabled: false  # not implemted in ruby 2.3
-
-Style/HashTransformKeys:
-  Enabled: false  # not implemted in ruby 2.3
-
-Style/HashTransformValues:
-  Enabled: false  # not implemted in ruby 2.3