facter 2.1.0 → 2.2.0

data/spec/unit/operatingsystem/sunos_spec.rb

@@ -0,0 +1,144 @@
+require 'spec_helper'
+require 'facter/operatingsystem/sunos'
+
+describe Facter::Operatingsystem::SunOS do
+  subject { described_class.new }
+
+  describe "Operating system fact" do
+    it "should be Nexenta if /etc/debian_version is present" do
+      FileTest.expects(:exists?).with("/etc/debian_version").returns true
+      os = subject.get_operatingsystem
+      expect(os).to eq "Nexenta"
+    end
+
+    it "should be Solaris if /etc/debian_version is missing and uname -v failed to match" do
+      FileTest.expects(:exists?).with("/etc/debian_version").returns false
+      os = subject.get_operatingsystem
+      expect(os).to eq "Solaris"
+    end
+
+    {
+      "SmartOS"     => "joyent_20120629T002039Z",
+      "OmniOS"      => "omnios-dda4bb3",
+      "OpenIndiana" => "oi_151a",
+    }.each_pair do |distribution, string|
+      it "should be #{distribution} if uname -v is '#{string}'" do
+        Facter::Core::Execution.expects(:exec).with('uname -v').returns(string)
+        os = subject.get_operatingsystem
+        expect(os).to eq distribution
+      end
+    end
+  end
+
+  describe "Osfamily fact" do
+    it "should return Solaris" do
+      osfamily = subject.get_osfamily
+      expect(osfamily).to eq "Solaris"
+    end
+  end
+
+  describe "Operatingsystemrelease fact" do
+    {
+      'Solaris 8 s28_38shwp2 SPARC'                  => '28',
+      'Solaris 8 6/00 s28s_u1wos_08 SPARC'           => '28_u1',
+      'Solaris 8 10/00 s28s_u2wos_11b SPARC'         => '28_u2',
+      'Solaris 8 1/01 s28s_u3wos_08 SPARC'           => '28_u3',
+      'Solaris 8 4/01 s28s_u4wos_08 SPARC'           => '28_u4',
+      'Solaris 8 7/01 s28s_u5wos_08 SPARC'           => '28_u5',
+      'Solaris 8 10/01 s28s_u6wos_08a SPARC'         => '28_u6',
+      'Solaris 8 2/02 s28s_u7wos_08a SPARC'          => '28_u7',
+      'Solaris 8 HW 12/02 s28s_hw1wos_06a SPARC'     => '28',
+      'Solaris 8 HW 5/03 s28s_hw2wos_06a SPARC'      => '28',
+      'Solaris 8 HW 7/03 s28s_hw3wos_05a SPARC'      => '28',
+      'Solaris 8 2/04 s28s_hw4wos_05a SPARC'         => '28',
+      'Solaris 9 s9_58shwpl3 SPARC'                  => '9',
+      'Solaris 9 9/02 s9s_u1wos_08b SPARC'           => '9_u1',
+      'Solaris 9 12/02 s9s_u2wos_10 SPARC'           => '9_u2',
+      'Solaris 9 4/03 s9s_u3wos_08 SPARC'            => '9_u3',
+      'Solaris 9 8/03 s9s_u4wos_08a SPARC'           => '9_u4',
+      'Solaris 9 12/03 s9s_u5wos_08b SPARC'          => '9_u5',
+      'Solaris 9 4/04 s9s_u6wos_08a SPARC'           => '9_u6',
+      'Solaris 9 9/04 s9s_u7wos_09 SPARC'            => '9_u7',
+      'Solaris 9 9/05 s9s_u8wos_05 SPARC'            => '9_u8',
+      'Solaris 9 9/05 HW s9s_u9wos_06b SPARC'        => '9_u9',
+      'Solaris 10 3/05 s10_74L2a SPARC'              => '10',
+      'Solaris 10 3/05 HW1 s10s_wos_74L2a SPARC'     => '10',
+      'Solaris 10 3/05 HW2 s10s_hw2wos_05 SPARC'     => '10',
+      'Solaris 10 1/06 s10s_u1wos_19a SPARC'         => '10_u1',
+      'Solaris 10 6/06 s10s_u2wos_09a SPARC'         => '10_u2',
+      'Solaris 10 11/06 s10s_u3wos_10 SPARC'         => '10_u3',
+      'Solaris 10 8/07 s10s_u4wos_12b SPARC'         => '10_u4',
+      'Solaris 10 5/08 s10s_u5wos_10 SPARC'          => '10_u5',
+      'Solaris 10 10/08 s10s_u6wos_07b SPARC'        => '10_u6',
+      'Solaris 10 5/09 s10s_u7wos_08 SPARC'          => '10_u7',
+      'Solaris 10 10/09 s10s_u8wos_08a SPARC'        => '10_u8',
+      'Oracle Solaris 10 9/10 s10s_u9wos_14a SPARC'  => '10_u9',
+      'Oracle Solaris 10 8/11 s10s_u10wos_17b SPARC' => '10_u10',
+      'Solaris 10 3/05 HW1 s10x_wos_74L2a X86'       => '10',
+      'Solaris 10 1/06 s10x_u1wos_19a X86'           => '10_u1',
+      'Solaris 10 6/06 s10x_u2wos_09a X86'           => '10_u2',
+      'Solaris 10 11/06 s10x_u3wos_10 X86'           => '10_u3',
+      'Solaris 10 8/07 s10x_u4wos_12b X86'           => '10_u4',
+      'Solaris 10 5/08 s10x_u5wos_10 X86'            => '10_u5',
+      'Solaris 10 10/08 s10x_u6wos_07b X86'          => '10_u6',
+      'Solaris 10 5/09 s10x_u7wos_08 X86'            => '10_u7',
+      'Solaris 10 10/09 s10x_u8wos_08a X86'          => '10_u8',
+      'Oracle Solaris 10 9/10 s10x_u9wos_14a X86'    => '10_u9',
+      'Oracle Solaris 10 9/10 s10x_u9wos_14a X86'    => '10_u9',
+      'Oracle Solaris 10 8/11 s10x_u10wos_17b X86'   => '10_u10',
+      'Oracle Solaris 11 11/11 X86'                  => '11 11/11',
+      'Oracle Solaris 11.1 SPARC'                    => '11.1'
+    }.each do |fakeinput, expected_output|
+      it "should be able to parse a release of #{fakeinput}" do
+        Facter::Util::FileRead.expects(:read).with("/etc/release").returns fakeinput
+        release = subject.get_operatingsystemrelease
+        expect(release).to eq expected_output
+      end
+    end
+
+    context "malformed /etc/release files" do
+      it "should fallback to the kernelrelease fact if /etc/release is empty" do
+        Facter::Util::FileRead.expects(:read).with('/etc/release').returns("")
+        release = subject.get_operatingsystemrelease
+        expect(release).to eq Facter.fact(:kernelrelease).value
+      end
+
+      it "should fallback to the kernelrelease fact if /etc/release is not present" do
+        Facter::Util::FileRead.expects(:read).with('/etc/release').returns false
+        release = subject.get_operatingsystemrelease
+        expect(release).to eq Facter.fact(:kernelrelease).value
+      end
+
+      it "should fallback to the kernelrelease fact if /etc/release cannot be parsed" do
+        Facter::Util::FileRead.expects(:read).with('/etc/release').returns 'some future release string'
+        release = subject.get_operatingsystemrelease
+        expect(release).to eq Facter.fact(:kernelrelease).value
+      end
+    end
+  end
+
+  describe "Operatingsystemmajrelease fact" do
+    before :each do
+      Facter.fact(:kernel).stubs(:value).returns("SunOS")
+      subject.expects(:get_operatingsystem).returns("Solaris")
+    end
+
+    it "should correctly derive from operatingsystemrelease on solaris 10" do
+      subject.expects(:get_operatingsystemrelease).returns("10_u8")
+      release = subject.get_operatingsystemmajrelease
+      expect(release).to eq "10"
+    end
+
+    it "should correctly derive from operatingsystemrelease on solaris 11 (old version scheme)" do
+      subject.expects(:get_operatingsystemrelease).returns("11 11/11")
+      release = subject.get_operatingsystemmajrelease
+      expect(release).to eq "11"
+    end
+
+    it "should correctly derive from operatingsystemrelease on solaris 11 (new version scheme)" do
+      subject.expects(:get_operatingsystemrelease).returns("11.1")
+      release = subject.get_operatingsystemmajrelease
+      expect(release).to eq "11"
+    end
+  end
+end

data/spec/unit/operatingsystem/vmkernel_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+require 'facter/operatingsystem/vmkernel'
+
+describe Facter::Operatingsystem::VMkernel do
+  subject { described_class.new }
+
+  describe "Operating system fact" do
+    it "should be ESXi" do
+      os = subject.get_operatingsystem
+      expect(os).to eq "ESXi"
+    end
+  end
+end

data/spec/unit/operatingsystem/windows_spec.rb

@@ -0,0 +1,68 @@
+require 'spec_helper'
+require 'facter/operatingsystem/windows'
+
+describe Facter::Operatingsystem::Windows do
+  require 'facter/util/wmi'
+  subject { described_class.new }
+
+  describe "Operatingsystemrelease fact" do
+    before do
+      Facter.fact(:kernel).stubs(:value).returns("windows")
+    end
+
+    {
+      ['5.2.3790', 1] => "XP",
+      ['6.0.6002', 1] => "Vista",
+      ['6.0.6002', 2] => "2008",
+      ['6.0.6002', 3] => "2008",
+      ['6.1.7601', 1] => "7",
+      ['6.1.7601', 2] => "2008 R2",
+      ['6.1.7601', 3] => "2008 R2",
+      ['6.2.9200', 1] => "8",
+      ['6.2.9200', 2] => "2012",
+      ['6.2.9200', 3] => "2012",
+    }.each do |os_values, expected_output|
+      it "should be #{expected_output}  with Version #{os_values[0]}  and ProductType #{os_values[1]}" do
+        os = mock('os', :version => os_values[0], :producttype => os_values[1])
+        Facter::Util::WMI.expects(:execquery).returns([os])
+        release = subject.get_operatingsystemrelease
+        expect(release).to eq expected_output
+      end
+    end
+
+    {
+      ['5.2.3790', 2, ""]   => "2003",
+      ['5.2.3790', 2, "R2"] => "2003 R2",
+      ['5.2.3790', 3, ""]   => "2003",
+      ['5.2.3790', 3, "R2"] => "2003 R2",
+    }.each do |os_values, expected_output|
+      it "should be #{expected_output}  with Version #{os_values[0]}  and ProductType #{os_values[1]} and OtherTypeDescription #{os_values[2]}" do
+        os = mock('os', :version => os_values[0], :producttype => os_values[1], :othertypedescription => os_values[2])
+        Facter::Util::WMI.expects(:execquery).returns([os])
+        release = subject.get_operatingsystemrelease
+        expect(release).to eq expected_output
+      end
+    end
+
+    it "reports '2003' if the WMI method othertypedescription does not exist" do
+      os = mock('os', :version => '5.2.3790', :producttype => 2)
+      os.stubs(:othertypedescription).raises(NoMethodError)
+      Facter::Util::WMI.expects(:execquery).returns([os])
+      release = subject.get_operatingsystemrelease
+      expect(release).to eq "2003"
+    end
+
+    context "Unknown Windows version" do
+      before :each do
+        Facter.fact(:kernelrelease).stubs(:value).returns("X.Y.ZZZZ")
+      end
+
+      it "should be kernel version value with unknown values " do
+        os = mock('os', :version => "X.Y.ZZZZ")
+        Facter::Util::WMI.expects(:execquery).returns([os])
+        release = subject.get_operatingsystemrelease
+        expect(release).to eq "X.Y.ZZZZ"
+      end
+    end
+  end
+end

data/spec/unit/operatingsystem_spec.rb

@@ -3,158 +3,15 @@
 require 'spec_helper'
 
 describe "Operating System fact" do
-
-  before :each do
-    FileTest.stubs(:exists?).returns false
-  end
-
-  it "should default to the kernel name" do
-    Facter.fact(:kernel).stubs(:value).returns("Nutmeg")
-
-    Facter.fact(:operatingsystem).value.should == "Nutmeg"
-  end
-  it "should be ESXi for VMkernel" do
-     Facter.fact(:kernel).stubs(:value).returns("VMkernel")
-
-     Facter.fact(:operatingsystem).value.should == "ESXi"
-  end
-
-  describe "on Solaris variants" do
-    before :each do
-      Facter.fact(:kernel).stubs(:value).returns("SunOS")
-    end
-
-    it "should be Nexenta if /etc/debian_version is present" do
-      FileTest.expects(:exists?).with("/etc/debian_version").returns true
-      Facter.fact(:operatingsystem).value.should == "Nexenta"
-    end
-
-    it "should be Solaris if /etc/debian_version is missing and uname -v failed to match" do
-      FileTest.expects(:exists?).with("/etc/debian_version").returns false
-      Facter.fact(:operatingsystem).value.should == "Solaris"
-    end
-
-    {
-      "SmartOS"     => "joyent_20120629T002039Z",
-      "OmniOS"      => "omnios-dda4bb3",
-      "OpenIndiana" => "oi_151a",
-    }.each_pair do |distribution, string|
-      it "should be #{distribution} if uname -v is '#{string}'" do
-        Facter::Core::Execution.stubs(:exec).with('uname -v').returns(string)
-        Facter.fact(:operatingsystem).value.should == distribution
-      end
-    end
-  end
-
-  describe "on Linux" do
-    before :each do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
-
-      # Always stub lsbdistid by default, so tests work on Ubuntu
-      Facter.stubs(:value).with(:lsbdistid).returns(nil)
-    end
-
-    {
-      "Debian"      => "/etc/debian_version",
-      "Gentoo"      => "/etc/gentoo-release",
-      "Fedora"      => "/etc/fedora-release",
-      "Mageia"      => "/etc/mageia-release",
-      "Mandriva"    => "/etc/mandriva-release",
-      "Mandrake"    => "/etc/mandrake-release",
-      "MeeGo"       => "/etc/meego-release",
-      "Archlinux"   => "/etc/arch-release",
-      "OracleLinux" => "/etc/oracle-release",
-      "OpenWrt"     => "/etc/openwrt_release",
-      "Alpine"      => "/etc/alpine-release",
-      "VMWareESX"   => "/etc/vmware-release",
-      "Bluewhite64" => "/etc/bluewhite64-version",
-      "Slamd64"     => "/etc/slamd64-version",
-      "Slackware"   => "/etc/slackware-version",
-      "Amazon"      => "/etc/system-release",
-    }.each_pair do |distribution, releasefile|
-      it "should be #{distribution} if #{releasefile} exists" do
-        FileTest.expects(:exists?).with(releasefile).returns true
-        Facter.fact(:operatingsystem).value.should == distribution
-      end
-    end
-
-    describe "depending on LSB release information" do
-      before :each do
-        Facter.collection.internal_loader.load(:lsb)
-      end
-
-      it "on Ubuntu should use the lsbdistid fact" do
-        FileUtils.stubs(:exists?).with("/etc/debian_version").returns true
-
-        Facter.stubs(:value).with(:lsbdistid).returns("Ubuntu")
-        Facter.fact(:operatingsystem).value.should == "Ubuntu"
-      end
-
-      it "on LinuxMint should use the lsbdistid fact" do
-        FileUtils.stubs(:exists?).with("/etc/debian_version").returns true
-
-        Facter.stubs(:value).with(:lsbdistid).returns("LinuxMint")
-        Facter.fact(:operatingsystem).value.should == "LinuxMint"
-      end
-
-    end
-
-
-    # Check distributions that rely on the contents of /etc/redhat-release
-    {
-      "RedHat"     => "Red Hat Enterprise Linux Server release 6.0 (Santiago)",
-      "CentOS"     => "CentOS release 5.6 (Final)",
-      "Scientific" => "Scientific Linux release 6.0 (Carbon)",
-      "SLC"        => "Scientific Linux CERN SLC release 5.7 (Boron)",
-      "Ascendos"   => "Ascendos release 6.0 (Nameless)",
-      "CloudLinux" => "CloudLinux Server release 5.5",
-      "XenServer"  => "XenServer release 5.6.0-31188p (xenenterprise)",
-    }.each_pair do |operatingsystem, string|
-      it "should be #{operatingsystem} based on /etc/redhat-release contents #{string}" do
-        FileTest.expects(:exists?).with("/etc/redhat-release").returns true
-        File.expects(:read).with("/etc/redhat-release").returns string
-
-        Facter.fact(:operatingsystem).value.should == operatingsystem
-      end
-    end
-
-    describe "Oracle variant" do
-      it "should be OVS if /etc/ovs-release exists" do
-        Facter.stubs(:value).with(:lsbdistid)
-        FileTest.expects(:exists?).with("/etc/enterprise-release").returns true
-        FileTest.expects(:exists?).with("/etc/ovs-release").returns true
-        Facter.fact(:operatingsystem).value.should == "OVS"
-      end
-
-      it "should be OEL if /etc/ovs-release doesn't exist" do
-        FileTest.expects(:exists?).with("/etc/enterprise-release").returns true
-        FileTest.expects(:exists?).with("/etc/ovs-release").returns false
-        Facter.fact(:operatingsystem).value.should == "OEL"
-      end
-    end
-
-    it "should identify VMWare ESX" do
-      Facter.stubs(:value).with(:lsbdistid).returns(nil)
-
-      FileTest.expects(:exists?).with("/etc/vmware-release").returns true
-      Facter.fact(:operatingsystem).value.should == "VMWareESX"
-    end
-
-    it "should differentiate between Scientific Linux CERN and Scientific Linux" do
-      FileTest.expects(:exists?).with("/etc/redhat-release").returns true
-      File.expects(:read).with("/etc/redhat-release").returns("Scientific Linux CERN SLC 5.7 (Boron)")
-      Facter.fact(:operatingsystem).value.should == "SLC"
-    end
-
-    it "should identify Cumulus Linux" do
-      Facter::Util::Operatingsystem.expects(:os_release).returns({'NAME' => 'Cumulus Linux'})
-      Facter.fact(:operatingsystem).value.should == "CumulusLinux"
-    end
-
-    it "should not use '/etc/os-release' on platforms other than Cumulus Linux" do
-      Facter::Util::Operatingsystem.expects(:os_release).returns({'NAME' => 'Debian GNU/Linux'})
-      FileTest.expects(:exists?).with('/etc/debian_version').returns true
-      Facter.fact(:operatingsystem).value.should == "Debian"
-    end
+  let(:os_hash) { { "name"         => "SomeOS",
+                    "family"       => "SomeFamily",
+                    "release"      => "1.2.3",
+                    "releasemajor" => "1",
+                   }
+                 }
+
+  it "should use the 'operatingsystem' key from the 'os' fact" do
+    Facter.fact("os").stubs(:value).returns(os_hash)
+    Facter.fact(:operatingsystem).value.should eq "SomeOS"
   end
 end

data/spec/unit/operatingsystemmajrelease_spec.rb

@@ -1,38 +1,21 @@
 #! /usr/bin/env ruby -S rspec
+
 require 'spec_helper'
-require 'facter'
 
 describe "OS Major Release fact" do
-  ['Amazon','CentOS','CloudLinux','Debian','Fedora','OEL','OracleLinux','OVS','RedHat','Scientific','SLC','CumulusLinux'].each do |operatingsystem|
-    context "on #{operatingsystem} operatingsystems" do
-      it "should be derived from operatingsystemrelease" do
-        Facter.fact(:kernel).stubs(:value).returns("Linux")
-        Facter.fact(:operatingsystem).stubs(:value).returns(operatingsystem)
-        Facter.fact(:operatingsystemrelease).stubs(:value).returns("6.3")
-        Facter.fact(:operatingsystemmajrelease).value.should == "6"
-      end
-    end
-  end
-
-  context "on Solaris operatingsystems" do
-    before :each do
-      Facter.fact(:kernel).stubs(:value).returns("SunOS")
-      Facter.fact(:operatingsystem).stubs(:value).returns("Solaris")
-    end
-
-    it "should correctly derive from operatingsystemrelease on solaris 10" do
-      Facter.fact(:operatingsystemrelease).expects(:value).returns("10_u8")
-      Facter.fact(:operatingsystemmajrelease).value.should == "10"
-    end
-
-    it "should correctly derive from operatingsystemrelease on solaris 11 (old version scheme)" do
-      Facter.fact(:operatingsystemrelease).expects(:value).returns("11 11/11")
-      Facter.fact(:operatingsystemmajrelease).value.should == "11"
-    end
+  let(:os_hash) { { "name"    => "SomeOS",
+                    "family"  => "SomeFamily",
+                    "release" => {
+                      "major" => "1",
+                      "minor" => "2",
+                      "full"  => "1.2.3"
+                    }
+                  }
+                }
 
-    it "should correctly derive from operatingsystemrelease on solaris 11 (new version scheme)" do
-      Facter.fact(:operatingsystemrelease).expects(:value).returns("11.1")
-      Facter.fact(:operatingsystemmajrelease).value.should == "11"
-    end
+  it "should use the 'major' key of the 'release' key from the 'os' fact" do
+    Facter.fact(:operatingsystem).stubs(:value).returns("Amazon")
+    Facter.fact("os").stubs(:value).returns(os_hash)
+    Facter.fact(:operatingsystemmajrelease).value.should eq "1"
   end
 end