facter 1.7.2 → 1.7.3.rc1

data/spec/unit/ipaddress_spec.rb

@@ -3,34 +3,112 @@
 require 'spec_helper'
 require 'facter/util/ip'
 
-shared_examples_for "ifconfig output" do |platform, address, fixture|
-  it "correctly on #{platform}" do
-    Facter::Util::IP.stubs(:exec_ifconfig).returns(my_fixture_read(fixture))
-    subject.value.should == address
+describe "ipaddress fact" do
+  before do
+    Facter.collection.internal_loader.load(:ipaddress)
   end
-end
 
-RSpec.configure do |config|
-  config.alias_it_should_behave_like_to :example_behavior_for, "parses"
-end
+  context 'using `ifconfig`' do
+    before :each do
+      Facter.fact(:hostname).stubs(:value)
+    end
 
-describe "The ipaddress fact" do
-  subject do
-    Facter.collection.internal_loader.load(:ipaddress)
-    Facter.fact(:ipaddress)
+    context "on Linux" do
+      before :each do
+        Facter.fact(:kernel).stubs(:value).returns("Linux")
+      end
+
+      def expect_ifconfig_parse(address, fixture)
+        Facter::Util::IP.stubs(:exec_ifconfig).returns(my_fixture_read(fixture))
+        Facter.fact(:ipaddress).value.should == address
+      end
+
+      it "parses correctly on Ubuntu 12.04" do
+        expect_ifconfig_parse "10.87.80.110", "ifconfig_ubuntu_1204.txt"
+      end
+
+      it "parses correctly on Fedora 17" do
+        expect_ifconfig_parse "131.252.209.153", "ifconfig_net_tools_1.60.txt"
+      end
+
+      it "parses a real address over multiple loopback addresses" do
+        expect_ifconfig_parse "10.0.222.20", "ifconfig_multiple_127_addresses.txt"
+      end
+
+      it "parses nothing with a non-english locale" do
+        expect_ifconfig_parse nil, "ifconfig_non_english_locale.txt"
+      end
+    end
   end
-  context "on Linux" do
+
+  context "on Windows" do
+    require 'facter/util/wmi'
+    require 'facter/util/registry'
+    require 'facter/util/ip/windows'
+    require 'facter_spec/windows_network'
+
+    include FacterSpec::WindowsNetwork
+
     before :each do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
+      Facter.fact(:kernel).stubs(:value).returns(:windows)
+      Facter.fact(:kernelrelease).stubs(:value).returns('6.1.7601')
+      Facter::Util::Registry.stubs(:hklm_read).returns(nic_bindings)
     end
 
-    example_behavior_for "ifconfig output",
-      "Ubuntu 12.04", "10.87.80.110", "ifconfig_ubuntu_1204.txt"
-    example_behavior_for "ifconfig output",
-      "Fedora 17", "131.252.209.153", "ifconfig_net_tools_1.60.txt"
-    example_behavior_for "ifconfig output",
-      "Linux with multiple loopback addresses",
-      "10.0.222.20",
-      "ifconfig_multiple_127_addresses.txt"
+    it "should do what when VPN is turned on?"
+
+    context "when you have no active network adapter" do
+      it "should return nil if there are no active (or any) network adapters" do
+        Facter::Util::WMI.expects(:execquery).with(Facter::Util::IP::Windows::WMI_IP_INFO_QUERY).returns([])
+        Facter::Util::Resolution.stubs(:exec)
+
+        Facter.value(:ipaddress).should == nil
+      end
+    end
+
+    context "when you have one network adapter" do
+      it "should return the ip address properly" do
+        nic = given_a_valid_windows_nic_with_ipv4_and_ipv6
+        Facter::Util::WMI.expects(:execquery).returns([nic])
+
+        Facter.value(:ipaddress).should == ipAddress0
+      end
+    end
+
+    context "when you have more than one network adapter" do
+      it "should return the ip of the adapter with the lowest IP connection metric (best connection)" do
+        nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+        nics[:nic1].expects(:IPConnectionMetric).returns(5)
+        Facter::Util::WMI.expects(:execquery).returns(nics.values)
+
+        Facter.value(:ipaddress).should == ipAddress1
+      end
+
+      it "should return the ip of the adapter with the lowest IP connection metric (best connection) that has ipv4 enabled" do
+        nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+        nics[:nic1].expects(:IPConnectionMetric).returns(5)
+        nics[:nic1].expects(:IPAddress).returns([ipv6Address1])
+        Facter::Util::WMI.expects(:execquery).returns(nics.values)
+
+        Facter.value(:ipaddress).should == ipAddress0
+      end
+
+      context "when the IP connection metric is the same" do
+        it "should return the ip of the adapter with the lowest binding order" do
+          nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+          Facter::Util::WMI.expects(:execquery).returns(nics.values)
+
+          Facter.value(:ipaddress).should == ipAddress0
+        end
+
+        it "should return the ip of the adapter with the lowest binding order even if the adapter is not first" do
+          nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+          Facter::Util::WMI.expects(:execquery).returns(nics.values)
+          Facter::Util::Registry.stubs(:hklm_read).returns(["\\Device\\#{settingId1}", "\\Device\\#{settingId0}" ])
+
+          Facter.value(:ipaddress).should == ipAddress1
+        end
+      end
+    end
   end
 end

data/spec/unit/macaddress_spec.rb

@@ -8,10 +8,6 @@ def ifconfig_fixture(filename)
   File.read(fixtures('ifconfig', filename))
 end
 
-def netsh_fixture(filename)
-  File.read(fixtures('netsh', filename))
-end
-
 describe "macaddress fact" do
   include FacterSpec::ConfigHelper
 

data/spec/unit/memory_spec.rb

@@ -3,15 +3,15 @@
 require 'spec_helper'
 
 describe "Memory facts" do
-  after do
+  before(:each) do
+    Facter.collection.internal_loader.load(:memory)
+  end
+
+  after(:each) do
     Facter.clear
   end
 
   describe "when returning scaled sizes" do
-    before(:each) do
-      Facter.collection.internal_loader.load(:memory)
-    end
-
     [  "memorysize",
        "memoryfree",
        "swapsize",
@@ -46,6 +46,7 @@ describe "Memory facts" do
 
   describe "on Darwin" do
     before(:each) do
+      Facter.clear
       Facter.fact(:kernel).stubs(:value).returns("Darwin")
       Facter::Util::Resolution.stubs(:exec).with('sysctl -n hw.memsize').returns('8589934592')
       sample_vm_stat = <<VMSTAT
@@ -515,8 +516,8 @@ SWAP
   end
 
   it "should use the memorysize fact for the memorytotal fact" do
-    Facter.fact("memorysize").expects(:value).once.returns "yay"
+    Facter.fact("memorysize").expects(:value).once.returns "16.00 GB"
     Facter::Util::Resolution.expects(:exec).never
-    Facter.fact("memorytotal").value.should == "yay"
+    Facter.fact(:memorytotal).value.should == "16.00 GB"
   end
 end

data/spec/unit/netmask_spec.rb

@@ -13,12 +13,12 @@ shared_examples_for "netmask from ifconfig output" do |platform, address, fixtur
   end
 end
 
-describe "netmask fact" do
-  before :each do
-    Facter.fact(:kernel).stubs(:value).returns("Linux")
-  end
-
+describe "The netmask fact" do
   context "on Linux" do
+    before :each do
+      Facter.fact(:kernel).stubs(:value).returns("Linux")
+    end
+
     example_behavior_for "netmask from ifconfig output",
       "Archlinux (net-tools 1.60)", "255.255.255.0",
       "ifconfig_net_tools_1.60.txt"
@@ -26,4 +26,61 @@ describe "netmask fact" do
       "Ubuntu 12.04", "255.255.255.255",
       "ifconfig_ubuntu_1204.txt"
   end
+
+  context "on Windows" do
+    require 'facter/util/wmi'
+    require 'facter/util/registry'
+    require 'facter_spec/windows_network'
+
+    include FacterSpec::WindowsNetwork
+
+    before :each do
+      Facter.fact(:kernel).stubs(:value).returns(:windows)
+      Facter::Util::Registry.stubs(:hklm_read).returns(nic_bindings)
+    end
+
+    describe "when you have no active network adapter" do
+      it "should return nil if there are no active (or any) network adapters" do
+        Facter::Util::WMI.expects(:execquery).returns([])
+
+        Facter.value(:netmask).should == nil
+      end
+    end
+
+    describe "when you have one network adapter" do
+      it "should return properly" do
+        nic = given_a_valid_windows_nic_with_ipv4_and_ipv6
+        Facter::Util::WMI.expects(:execquery).returns([nic])
+
+        Facter.value(:netmask).should == subnet0
+      end
+    end
+
+    describe "when you have more than one network adapter" do
+      it "should return the netmask of the adapter with the lowest IP connection metric (best connection)" do
+        nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+        nics[:nic1].expects(:IPConnectionMetric).returns(5)
+        Facter::Util::WMI.expects(:execquery).returns(nics.values)
+
+        Facter.value(:netmask).should == subnet1
+      end
+
+      context "when the IP connection metric is the same" do
+        it "should return the netmask of the adapter with the lowest binding order" do
+          nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+          Facter::Util::WMI.expects(:execquery).returns(nics.values)
+
+          Facter.value(:netmask).should == subnet0
+        end
+
+        it "should return the netmask of the adapter with the lowest binding even if the adapter is not first" do
+          nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+          Facter::Util::WMI.expects(:execquery).returns(nics.values)
+          Facter::Util::Registry.stubs(:hklm_read).returns(["\\Device\\#{settingId1}", "\\Device\\#{settingId0}" ])
+
+          Facter.value(:netmask).should == subnet1
+        end
+      end
+    end
+  end
 end

data/spec/unit/util/ip/windows_spec.rb

@@ -0,0 +1,48 @@
+# encoding: UTF-8
+
+require 'spec_helper'
+require 'facter/util/ip/windows'
+
+describe Facter::Util::IP::Windows do
+  before :each do
+    Facter.fact(:kernel).stubs(:value).returns('windows')
+  end
+
+  describe ".to_s" do
+    let(:to_s) { described_class.to_s }
+
+    it { to_s.should eq 'windows' }
+  end
+
+  describe ".convert_netmask_from_hex?" do
+    let :convert_netmask_from_hex? do
+      described_class.convert_netmask_from_hex?
+    end
+
+    it { convert_netmask_from_hex?.should be false }
+  end
+
+  describe ".bonding_master" do
+    let(:bonding_master) { described_class.bonding_master('eth0') }
+
+    pending("porting to Windows") do
+      it { bonding_master.should be_nil }
+    end
+  end
+
+  describe ".interfaces" do
+    let(:name)       { 'Local Area Connection' }
+    let(:index)      { 7 }
+    let(:nic_config) { mock('nic_config', :Index => index) }
+    let(:nic)        { mock('nic', :NetConnectionId => name ) }
+
+    it "should return an array of only connected interfaces" do
+      Facter::Util::WMI.expects(:execquery).with(Facter::Util::IP::Windows::WMI_IP_INFO_QUERY).
+        returns([nic_config])
+      Facter::Util::WMI.expects(:execquery).with("SELECT * FROM Win32_NetworkAdapter WHERE Index = #{index}").
+        returns([nic])
+
+      described_class.interfaces.should == [name]
+    end
+  end
+end

data/spec/unit/util/ip_spec.rb

@@ -52,8 +52,8 @@ describe Facter::Util::IP do
 
   it "should return a list of only connected interfaces on Windows" do
     Facter.fact(:kernel).stubs(:value).returns("windows")
-    windows_netsh = my_fixture_read("windows_netsh_all_interfaces")
-    Facter::Util::IP.stubs(:get_all_interface_output).returns(windows_netsh)
+
+    Facter::Util::IP::Windows.expects(:interfaces).returns(["Loopback Pseudo-Interface 1", "Local Area Connection", "Teredo Tunneling Pseudo-Interface"])
     Facter::Util::IP.get_interfaces().should == ["Loopback Pseudo-Interface 1", "Local Area Connection", "Teredo Tunneling Pseudo-Interface"]
   end
 
@@ -373,41 +373,29 @@ describe Facter::Util::IP do
   end
 
   describe "on Windows" do
+    require 'facter/util/ip/windows'
+
     before :each do
       Facter.stubs(:value).with(:kernel).returns("windows")
     end
 
     it "should return ipaddress information" do
-      windows_netsh = my_fixture_read("windows_netsh_single_interface")
-
-      Facter::Util::IP.expects(:get_output_for_interface_and_label).with("Local Area Connection", "ipaddress").returns(windows_netsh)
+      Facter::Util::IP::Windows.expects(:value_for_interface_and_label).with("Local Area Connection", "ipaddress").returns('172.16.138.216')
 
       Facter::Util::IP.get_interface_value("Local Area Connection", "ipaddress").should == "172.16.138.216"
     end
 
-    it "should return a human readable netmask" do
-      windows_netsh = my_fixture_read("windows_netsh_single_interface")
-
-      Facter::Util::IP.expects(:get_output_for_interface_and_label).with("Local Area Connection", "netmask").returns(windows_netsh)
-
-      Facter::Util::IP.get_interface_value("Local Area Connection", "netmask").should == "255.255.255.0"
-    end
-
     it "should return network information" do
-      windows_netsh = my_fixture_read("windows_netsh_single_interface")
-
-      Facter::Util::IP.stubs(:get_output_for_interface_and_label).with("Local Area Connection", "ipaddress").returns(windows_netsh)
-      Facter::Util::IP.stubs(:get_output_for_interface_and_label).with("Local Area Connection", "netmask").returns(windows_netsh)
+      Facter::Util::IP::Windows.expects(:value_for_interface_and_label).with("Local Area Connection", "ipaddress").returns('172.16.138.216')
+      Facter::Util::IP::Windows.expects(:value_for_interface_and_label).with("Local Area Connection", "netmask").returns('255.255.255.0')
 
       Facter::Util::IP.get_network_value("Local Area Connection").should == "172.16.138.0"
     end
 
     it "should return ipaddress6 information" do
-      windows_netsh = my_fixture_read("windows_netsh_single_interface6")
-
-      Facter::Util::IP.expects(:get_output_for_interface_and_label).with("Teredo Tunneling Pseudo-Interface", "ipaddress6").returns(windows_netsh)
+      Facter::Util::IP::Windows.expects(:value_for_interface_and_label).with("Local Area Connection", "ipaddress6").returns("2001:0:4137:9e76:2087:77a:53ef:7527")
 
-      Facter::Util::IP.get_interface_value("Teredo Tunneling Pseudo-Interface", "ipaddress6").should == "2001:0:4137:9e76:2087:77a:53ef:7527"
+      Facter::Util::IP.get_interface_value("Local Area Connection", "ipaddress6").should == "2001:0:4137:9e76:2087:77a:53ef:7527"
     end
   end
 

data/spec/unit/util/macaddress_spec.rb

@@ -81,19 +81,61 @@ describe "Darwin", :unless => Facter::Util::Config.is_windows? do
   end
 end
 
-describe "Windows" do
-  it "should return the first macaddress" do
-    Facter.fact(:kernel).stubs(:value).returns("windows")
+describe "The macaddress fact" do
+  context "on Windows" do
+    require 'facter/util/wmi'
+    require 'facter/util/registry'
+    require 'facter_spec/windows_network'
 
-    nic = stubs 'nic'
-    nic.stubs(:MacAddress).returns("00:0C:29:0C:9E:9F")
+    include FacterSpec::WindowsNetwork
 
-    nic2 = stubs 'nic'
-    nic2.stubs(:MacAddress).returns("00:0C:29:0C:9E:AF")
+    before :each do
+      Facter.fact(:kernel).stubs(:value).returns(:windows)
+      Facter::Util::Registry.stubs(:hklm_read).returns(nic_bindings)
+    end
 
-    require 'facter/util/wmi'
-    Facter::Util::WMI.stubs(:execquery).with("select MACAddress from Win32_NetworkAdapterConfiguration where IPEnabled = True").returns([nic, nic2])
+    describe "when you have no active network adapter" do
+      it "should return nil if there are no active (or any) network adapters" do
+        Facter::Util::WMI.expects(:execquery).returns([])
+
+        Facter.value(:macaddress).should == nil
+      end
+    end
+
+    describe "when you have one network adapter" do
+      it "should return properly" do
+        nic = given_a_valid_windows_nic_with_ipv4_and_ipv6
+        Facter::Util::WMI.expects(:execquery).returns([nic])
+
+        Facter.value(:macaddress).should == macAddress0
+      end
+    end
 
-    Facter.fact(:macaddress).value.should == "00:0C:29:0C:9E:9F"
+    describe "when you have more than one network adapter" do
+      it "should return the macaddress of the adapter with the lowest IP connection metric (best connection)" do
+        nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+        nics[:nic1].expects(:IPConnectionMetric).returns(5)
+        Facter::Util::WMI.expects(:execquery).returns(nics.values)
+
+        Facter.value(:macaddress).should == macAddress1
+      end
+
+      context "when the IP connection metric is the same" do
+        it "should return the macaddress of the adapter with the lowest binding order" do
+          nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+          Facter::Util::WMI.expects(:execquery).returns(nics.values)
+
+          Facter.value(:macaddress).should == macAddress0
+        end
+
+        it "should return the macaddress of the adapter with the lowest MACAddress when multiple adapters have the same IP connection metric when the lowest MACAddress is not first" do
+          nics = given_two_valid_windows_nics_with_ipv4_and_ipv6
+          Facter::Util::WMI.expects(:execquery).returns(nics.values)
+          Facter::Util::Registry.stubs(:hklm_read).returns(["\\Device\\#{settingId1}", "\\Device\\#{settingId0}" ])
+
+          Facter.value(:macaddress).should == macAddress1
+        end
+      end
+    end
   end
 end

data/spec/unit/util/parser_spec.rb

@@ -1,7 +1,6 @@
 #!/usr/bin/env ruby
 
 require 'spec_helper'
-
 require 'facter/util/parser'
 require 'tempfile'
 require 'tmpdir.rb'
@@ -121,12 +120,42 @@ describe Facter::Util::Parser do
         Facter::Util::Parser.parser_for(cmd)
       end
 
-      it "should return no results" do
-        parser.results.should be_nil
+      it "should not parse a directory" do
+        File.stubs(:file?).with(cmd).returns(false)
+        Facter::Util::Parser.parser_for(cmd).results.should be_nil
+      end
+
+      it "should return the data properly" do
+        File.stubs(:file?).with(cmd).returns(true)
+        parser.results.should == data
       end
     end
   end
 
+  describe "powershell parser" do
+    let :ps1 do "/tmp/foo.ps1" end
+    let :data_in_ps1 do "one=two\nthree=four\n" end
+
+    before :each do
+      Facter::Util::Config.stubs(:is_windows?).returns(true)
+      Facter::Util::Resolution.stubs(:exec).returns(data_in_ps1)
+    end
+
+    let :parser do
+      Facter::Util::Parser.parser_for(ps1)
+    end
+
+    it "should not parse a directory" do
+      File.stubs(:file?).with(ps1).returns(false)
+      Facter::Util::Parser.parser_for(ps1).results.should be_nil
+    end
+
+    it "should return data properly" do
+      File.stubs(:file?).with(ps1).returns(true)
+      parser.results.should == data
+    end
+  end
+
   describe "nothing parser" do
     it "uses the nothing parser when there is no other parser" do
       Facter::Util::Parser.parser_for("this.is.not.valid").results.should be_nil