facter 1.6.18 → 1.7.0.rc1

data/spec/unit/util/solaris_zones_spec.rb

@@ -0,0 +1,127 @@
+require 'spec_helper'
+require 'facter/util/solaris_zones'
+
+describe Facter::Util::SolarisZones do
+  let :zone_list do
+    zone_list = <<-EOF
+0:global:running:/::native:shared
+-:local:configured:/::native:shared
+-:zoneA:stopped:/::native:shared
+    EOF
+  end
+
+  let :zone_list2 do
+    zone_list = <<-EOF
+0:global:running:/::native:shared
+-:local:configured:/::native:shared
+-:zoneB:stopped:/::native:shared
+-:zoneC:stopped:/::native:shared
+    EOF
+  end
+
+  subject do
+    described_class.new(:zoneadm_output => zone_list)
+  end
+
+  describe '.add_facts' do
+    before :each do
+      zones = described_class.new(:zoneadm_output => zone_list)
+      zones.send(:parse!)
+      zones.stubs(:refresh)
+      described_class.stubs(:new).returns(zones)
+    end
+
+    it 'defines the zones fact' do
+      described_class.add_facts
+      Facter.fact(:zones).value.should == 3
+    end
+
+    it 'defines a fact for each attribute of a zone' do
+      described_class.add_facts
+      [:id, :name, :status, :path, :uuid, :brand, :iptype].each do |attr|
+        Facter.fact("zone_local_#{attr}".intern).
+          should be_a_kind_of Facter::Util::Fact
+      end
+    end
+  end
+
+  describe '#refresh' do
+    it 'executes the zoneadm_cmd' do
+      Facter::Util::Resolution.expects(:exec).with(subject.zoneadm_cmd).returns(zone_list)
+      subject.refresh
+    end
+  end
+
+  describe 'multiple facts sharing a single model' do
+    context 'when zones is resolved for the first time' do
+      it 'counts the number of zones' do
+        given_initial_zone_facts
+        Facter.fact(:zones).value.should == 3
+      end
+      it 'defines facts for zoneA' do
+        given_initial_zone_facts
+        Facter.fact(:zone_zoneA_id).value.should == '-'
+      end
+      it 'does not define facts for zoneB' do
+        given_initial_zone_facts
+        Facter.fact(:zone_zoneB_id).should be_nil
+      end
+      it 'uses a single read of the system information for all of the dynamically generated zone facts' do
+        given_initial_zone_facts # <= single read happens here
+
+        Facter::Util::Resolution.expects(:exec).never
+        Facter.fact(:zone_zoneA_id).value
+        Facter.fact(:zone_local_id).value
+      end
+    end
+    context 'when all facts have been flushed after zones was resolved once' do
+      it 'updates the number of zones' do
+        given_initial_zone_facts
+        when_facts_have_been_resolved_then_flushed
+
+        Facter.fact(:zones).value.should == 4
+      end
+      it 'stops resolving a value for a zone that no longer exists' do
+        given_initial_zone_facts
+        when_facts_have_been_resolved_then_flushed
+
+        Facter.fact(:zone_zoneA_id).value.should be_nil
+        Facter.fact(:zone_zoneA_status).value.should be_nil
+        Facter.fact(:zone_zoneA_path).value.should be_nil
+      end
+      it 'defines facts for new zones' do
+        given_initial_zone_facts
+        when_facts_have_been_resolved_then_flushed
+
+        Facter.fact(:zone_zoneB_id).should be_nil
+        Facter.fact(:zones).value
+        Facter.fact(:zone_zoneB_id).value.should be_a_kind_of String
+      end
+      it 'uses a single read of the system information for all of the dynamically generated zone facts' do
+        given_initial_zone_facts
+        when_facts_have_been_resolved_then_flushed
+
+        Facter::Util::Resolution.expects(:exec).once.returns(zone_list2)
+        Facter.fact(:zones).value
+        Facter.fact(:zone_zoneA_id).value
+        Facter.fact(:zone_local_id).value
+      end
+
+    end
+  end
+
+  def given_initial_zone_facts
+    Facter::Util::Resolution.stubs(:exec).
+      with(subject.zoneadm_cmd).
+      returns(zone_list)
+    described_class.add_facts
+  end
+
+  def when_facts_have_been_resolved_then_flushed
+    Facter.fact(:zones).value
+    Facter.fact(:zone_zoneA_id).value
+    Facter.fact(:zone_local_id).value
+    Facter::Util::Resolution.stubs(:exec).returns(zone_list2)
+    Facter.flush
+  end
+end

data/spec/unit/util/virtual_spec.rb

@@ -81,6 +81,44 @@ describe Facter::Util::Virtual do
     Facter::Util::Virtual.should_not be_vserver
   end
 
+  it "should identify kvm" do
+    Facter::Util::Virtual.stubs(:kvm?).returns(true)
+    Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns("something")
+    Facter::Util::Virtual.kvm_type().should == "kvm"
+  end
+
+  it "should be able to detect RHEV via sysfs on Linux" do
+    # Fake files are always hard to stub. :/
+    File.stubs(:read).with("/sys/devices/virtual/dmi/id/product_name").
+      returns("RHEV Hypervisor")
+
+    Facter::Util::Virtual.should be_rhev
+  end
+
+  it "should be able to detect RHEV via sysfs on Linux improperly" do
+    # Fake files are always hard to stub. :/
+    File.stubs(:read).with("/sys/devices/virtual/dmi/id/product_name").
+      returns("something else")
+
+    Facter::Util::Virtual.should_not be_rhev
+  end
+
+  it "should be able to detect ovirt via sysfs on Linux" do
+    # Fake files are always hard to stub. :/
+    File.stubs(:read).with("/sys/devices/virtual/dmi/id/product_name").
+      returns("oVirt Node")
+
+    Facter::Util::Virtual.should be_ovirt
+  end
+
+  it "should be able to detect ovirt via sysfs on Linux improperly" do
+    # Fake files are always hard to stub. :/
+    File.stubs(:read).with("/sys/devices/virtual/dmi/id/product_name").
+      returns("something else")
+
+    Facter::Util::Virtual.should_not be_ovirt
+  end
+
   fixture_path = fixtures('virtual', 'proc_self_status')
 
   test_cases = [
@@ -181,4 +219,20 @@ describe Facter::Util::Virtual do
     Facter::Util::Resolution.stubs(:exec).with("/usr/bin/getconf MACHINE_MODEL").returns('ia64 hp server rx660')
     Facter::Util::Virtual.should_not be_hpvm
   end
+
+  it "should be able to detect virtualbox via sysfs on Linux" do
+    # Fake files are always hard to stub. :/
+    File.stubs(:read).with("/sys/devices/virtual/dmi/id/product_name").
+      returns("VirtualBox")
+
+    Facter::Util::Virtual.should be_virtualbox
+  end
+
+  it "should be able to detect virtualbox via sysfs on Linux improperly" do
+    # Fake files are always hard to stub. :/
+    File.stubs(:read).with("/sys/devices/virtual/dmi/id/product_name").
+      returns("HP-Oracle-Sun-VMWare-funky-town")
+
+    Facter::Util::Virtual.should_not be_virtualbox
+  end
 end

data/spec/unit/version_spec.rb

@@ -0,0 +1,42 @@
+require "spec_helper"
+require "facter/version"
+require 'pathname'
+
+describe "Facter.version Public API" do
+  before :each do
+    Facter.instance_eval do
+      if @facter_version
+        @facter_version = nil
+      end
+    end
+  end
+
+  context "without a VERSION file" do
+    before :each do
+      Facter.stubs(:read_version_file).returns(nil)
+    end
+
+    it "is Facter::FACTERVERSION" do
+      Facter.version.should == Facter::FACTERVERSION
+    end
+    it "respects the version= setter" do
+      Facter.version = '1.2.3'
+      Facter.version.should == '1.2.3'
+    end
+  end
+
+  context "with a VERSION file" do
+    it "is the content of the file" do
+      Facter.expects(:read_version_file).with() do |path|
+        pathname = Pathname.new(path)
+        pathname.basename.to_s == "VERSION"
+      end.returns('1.6.14-6-gea42046')
+
+      Facter.version.should == '1.6.14-6-gea42046'
+    end
+    it "respects the version= setter" do
+      Facter.version = '1.2.3'
+      Facter.version.should == '1.2.3'
+    end
+  end
+end

data/spec/unit/virtual_spec.rb

@@ -14,6 +14,8 @@ describe "Virtual fact" do
     Facter::Util::Virtual.stubs(:hpvm?).returns(false)
     Facter::Util::Virtual.stubs(:zlinux?).returns(false)
     Facter::Util::Virtual.stubs(:virt_what).returns(nil)
+    Facter::Util::Virtual.stubs(:rhev?).returns(false)
+    Facter::Util::Virtual.stubs(:ovirt?).returns(false)
     Facter::Util::Virtual.stubs(:virtualbox?).returns(false)
   end
 
@@ -46,26 +48,26 @@ describe "Virtual fact" do
   end
 
   describe "on Darwin" do
-    it "should be parallels with Parallels vendor id" do
+    before do
       Facter.fact(:kernel).stubs(:value).returns("Darwin")
+    end
+
+    it "should be parallels with Parallels vendor id" do
       Facter::Util::Macosx.stubs(:profiler_data).returns({ "spdisplays_vendor-id" => "0x1ab8" })
       Facter.fact(:virtual).value.should == "parallels"
     end
 
     it "should be parallels with Parallels vendor name" do
-      Facter.fact(:kernel).stubs(:value).returns("Darwin")
       Facter::Util::Macosx.stubs(:profiler_data).returns({ "spdisplays_vendor" => "Parallels" })
       Facter.fact(:virtual).value.should == "parallels"
     end
 
     it "should be vmware with VMWare vendor id" do
-      Facter.fact(:kernel).stubs(:value).returns("Darwin")
       Facter::Util::Macosx.stubs(:profiler_data).returns({ "spdisplays_vendor-id" => "0x15ad" })
       Facter.fact(:virtual).value.should == "vmware"
     end
 
     it "should be vmware with VMWare vendor name" do
-      Facter.fact(:kernel).stubs(:value).returns("Darwin")
       Facter::Util::Macosx.stubs(:profiler_data).returns({ "spdisplays_vendor" => "VMWare" })
       Facter.fact(:virtual).value.should == "vmware"
     end
@@ -73,9 +75,11 @@ describe "Virtual fact" do
 
   describe "on Linux" do
     before(:each) do
+      Facter.fact(:kernel).stubs(:value).returns("Linux")
+      Facter.fact(:operatingsystem).stubs(:value).returns("Linux")
+
       Facter::Util::Resolution.stubs(:exec).with("vmware -v").returns false
-      Facter.fact(:operatingsystem).stubs(:value).returns(true)
-      # Ensure the tests don't fail on Xen
+
       FileTest.stubs(:exists?).with("/proc/sys/xen").returns false
       FileTest.stubs(:exists?).with("/sys/bus/xen").returns false
       FileTest.stubs(:exists?).with("/proc/xen").returns false
@@ -83,103 +87,133 @@ describe "Virtual fact" do
     end
 
     it "should be parallels with Parallels vendor id from lspci 2>/dev/null" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Virtual.stubs(:lspci).returns("01:00.0 VGA compatible controller: Unknown device 1ab8:4005")
       Facter.fact(:virtual).value.should == "parallels"
     end
 
     it "should be parallels with Parallels vendor name from lspci 2>/dev/null" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Virtual.stubs(:lspci).returns("01:00.0 VGA compatible controller: Parallels Display Adapter")
       Facter.fact(:virtual).value.should == "parallels"
     end
 
     it "should be vmware with VMware vendor name from lspci 2>/dev/null" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns("00:0f.0 VGA compatible controller: VMware Inc [VMware SVGA II] PCI Display Adapter")
       Facter.fact(:virtual).value.should == "vmware"
     end
 
     it "should be virtualbox with VirtualBox vendor name from lspci 2>/dev/null" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns("00:02.0 VGA compatible controller: InnoTek Systemberatung GmbH VirtualBox Graphics Adapter")
       Facter.fact(:virtual).value.should == "virtualbox"
     end
 
     it "should be vmware with VMWare vendor name from dmidecode" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns("On Board Device 1 Information\nType: Video\nStatus: Disabled\nDescription: VMware SVGA II")
       Facter.fact(:virtual).value.should == "vmware"
     end
 
     it "should be xen0 with xen dom0 files in /proc" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
-      Facter.fact(:operatingsystem).stubs(:value).returns("Linux")
       Facter.fact(:hardwaremodel).stubs(:value).returns("i386")
       Facter::Util::Virtual.expects(:xen?).returns(true)
-      FileTest.expects(:exists?).with("/proc/xen/xsd_kva").returns(true)
+      FileTest.expects(:exists?).with("/dev/xen/evtchn").returns(true)
       Facter.fact(:virtual).value.should == "xen0"
     end
 
     it "should be xenu with xen domU files in /proc" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
-      Facter.fact(:operatingsystem).stubs(:value).returns("Linux")
       Facter.fact(:hardwaremodel).stubs(:value).returns("i386")
       Facter::Util::Virtual.expects(:xen?).returns(true)
-      FileTest.expects(:exists?).with("/proc/xen/xsd_kva").returns(false)
-      FileTest.expects(:exists?).with("/proc/xen/capabilities").returns(true)
+      FileTest.expects(:exists?).with("/dev/xen/evtchn").returns(false)
+      FileTest.expects(:exists?).with("/proc/xen").returns(true)
       Facter.fact(:virtual).value.should == "xenu"
     end
 
     it "should be xenhvm with Xen HVM vendor name from lspci 2>/dev/null" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns("00:03.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01)")
       Facter.fact(:virtual).value.should == "xenhvm"
     end
 
     it "should be xenhvm with Xen HVM vendor name from dmidecode" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns("System Information\nManufacturer: Xen\nProduct Name: HVM domU")
       Facter.fact(:virtual).value.should == "xenhvm"
     end
 
     it "should be parallels with Parallels vendor name from dmidecode" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns("On Board Device Information\nType: Video\nStatus: Disabled\nDescription: Parallels Video Adapter")
       Facter.fact(:virtual).value.should == "parallels"
     end
 
     it "should be virtualbox with VirtualBox vendor name from dmidecode" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns("BIOS Information\nVendor: innotek GmbH\nVersion: VirtualBox\n\nSystem Information\nManufacturer: innotek GmbH\nProduct Name: VirtualBox\nFamily: Virtual Machine")
       Facter.fact(:virtual).value.should == "virtualbox"
     end
 
-    it "should be hyperv with Microsoft vendor name from lspci 2>/dev/null" do
+    it "should be rhev with RHEV Hypervisor product name from dmidecode" do
+      Facter.fact(:kernel).stubs(:value).returns("Linux")
+      Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
+      Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns("Product Name: RHEV Hypervisor")
+      Facter.fact(:virtual).value.should == "rhev"
+    end
+
+    it "should be ovirt with oVirt Node product name from dmidecode" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
+      Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
+      Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns("Product Name: oVirt Node")
+      Facter.fact(:virtual).value.should == "ovirt"
+    end
+
+    it "should be hyperv with Microsoft vendor name from lspci 2>/dev/null" do
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns("00:08.0 VGA compatible controller: Microsoft Corporation Hyper-V virtual VGA")
       Facter.fact(:virtual).value.should == "hyperv"
     end
 
     it "should be hyperv with Microsoft vendor name from dmidecode" do
-      Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns("System Information\nManufacturer: Microsoft Corporation\nProduct Name: Virtual Machine")
       Facter.fact(:virtual).value.should == "hyperv"
     end
+
+    context "In Google Compute Engine" do
+      before :each do
+        Facter.fact(:kernel).stubs(:value).returns("Linux")
+      end
+
+      context "Without /sys/firmware/dmi/entries/1-0/raw" do
+        before :each do
+          Facter::Util::Virtual.stubs(:read_sysfs_dmi_entries).returns(nil)
+        end
+
+        it "should be gce with gce vendor name from lspci 2>/dev/null" do
+          Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns("00:05.0 Class 8007: Google, Inc. Device 6442")
+          Facter.fact(:virtual).value.should == "gce"
+        end
+      end
+
+      context "With /sys/firmware/dmi/entries/1-0/raw" do
+        let :sysfs_dmi_raw do
+          my_fixture_read('sysfs_dmi_entries_raw.txt')
+        end
+
+        before :each do
+          Facter::Util::Virtual.stubs(:read_sysfs_dmi_entries).returns(sysfs_dmi_raw)
+        end
+
+        it "(#17612) is 'gce'" do
+          Facter.fact(:virtual).value.should == "gce"
+        end
+      end
+    end
   end
 
   describe "on Solaris" do
     before(:each) do
       Facter::Util::Resolution.stubs(:exec).with("vmware -v").returns false
+      Facter.fact(:kernel).stubs(:value).returns("SunOS")
     end
 
     it "should be vmware with VMWare vendor name from prtdiag" do
-      Facter.fact(:kernel).stubs(:value).returns("SunOS")
       Facter.fact(:hardwaremodel).stubs(:value).returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns(nil)
@@ -188,7 +222,6 @@ describe "Virtual fact" do
     end
 
     it "should be parallels with Parallels vendor name from prtdiag" do
-      Facter.fact(:kernel).stubs(:value).returns("SunOS")
       Facter.fact(:hardwaremodel).stubs(:value).returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns(nil)
@@ -197,7 +230,6 @@ describe "Virtual fact" do
     end
 
     it "should be virtualbox with VirtualBox vendor name from prtdiag" do
-      Facter.fact(:kernel).stubs(:value).returns("SunOS")
       Facter.fact(:hardwaremodel).stubs(:value).returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('lspci 2>/dev/null').returns(nil)
       Facter::Util::Resolution.stubs(:exec).with('dmidecode').returns(nil)
@@ -236,6 +268,37 @@ describe "Virtual fact" do
     end
   end
 
+  describe "on Windows" do
+    require 'facter/util/wmi'
+    before do
+      Facter.fact(:kernel).stubs(:value).returns("windows")
+    end
+
+    it "should be kvm with KVM model name from Win32_ComputerSystem" do
+      computersystem = mock('computersystem', :model => 'KVM')
+      Facter::Util::WMI.expects(:execquery).returns([computersystem])
+      Facter.fact(:virtual).value.should == "kvm"
+    end
+
+    it "should be hyperv with Virtual Machine model name and Microsoft Corporation manufacturer from Win32_ComputerSystem" do
+      computersystem = mock('computersystem', :manufacturer => 'Microsoft Corporation', :model => 'Virtual Machine')
+      Facter::Util::WMI.expects(:execquery).returns([computersystem])
+      Facter.fact(:virtual).value.should == "hyperv"
+    end
+
+    it "should be virtualbox with VirtualBox model name from Win32_ComputerSystem" do
+      computersystem = mock('computersystem', :model => 'VirtualBox')
+      Facter::Util::WMI.expects(:execquery).returns([computersystem])
+      Facter.fact(:virtual).value.should == "virtualbox"
+    end
+
+    it "should be vmware with VMware like model name from Win32_ComputerSystem" do
+      computersystem = mock('computersystem', :model => 'VMware Virtual Platform')
+      Facter::Util::WMI.expects(:execquery).returns([computersystem])
+      Facter.fact(:virtual).value.should == "vmware"
+    end
+  end
+
   describe "with the virt-what command available (#8210)" do
     describe "when the output of virt-what disagrees with lower weight facts" do
       virt_what_map = {
@@ -367,4 +430,16 @@ describe "is_virtual fact" do
     Facter.fact(:virtual).stubs(:value).returns("hyperv")
     Facter.fact(:is_virtual).value.should == "true"
   end
+
+  it "should be true when running on rhev" do
+    Facter.fact(:kernel).stubs(:value).returns("Linux")
+    Facter.fact(:virtual).stubs(:value).returns("rhev")
+    Facter.fact(:is_virtual).value.should == "true"
+  end
+
+  it "should be true when running on ovirt" do
+    Facter.fact(:kernel).stubs(:value).returns("Linux")
+    Facter.fact(:virtual).stubs(:value).returns("ovirt")
+    Facter.fact(:is_virtual).value.should == "true"
+  end
 end