factbase 0.4.0 → 0.5.0

data/test/factbase/test_to_yaml.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# Copyright (c) 2024 Yegor Bugayenko
+# Copyright (c) 2024-2025 Yegor Bugayenko
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the 'Software'), to deal
@@ -27,7 +27,7 @@ require_relative '../../lib/factbase/to_yaml'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
-# Copyright:: Copyright (c) 2024 Yegor Bugayenko
+# Copyright:: Copyright (c) 2024-2025 Yegor Bugayenko
 # License:: MIT
 class TestToYAML < Minitest::Test
   def test_simple_rendering
@@ -51,6 +51,6 @@ class TestToYAML < Minitest::Test
     f.a = 256
     f.c = 10
     yaml = Factbase::ToYAML.new(fb).yaml
-    assert(yaml.include?("a: 256\n  b: 42\n  c: 10"), yaml)
+    assert_includes(yaml, "a: 256\n  b: 42\n  c: 10", yaml)
   end
 end

data/test/test__helper.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# Copyright (c) 2024 Yegor Bugayenko
+# Copyright (c) 2024-2025 Yegor Bugayenko
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the 'Software'), to deal
@@ -37,6 +37,6 @@ Minitest::Reporters.use! [Minitest::Reporters::SpecReporter.new]
 class Minitest::Test
   def fact(map = {})
     require 'factbase/fact'
-    Factbase::Fact.new(Mutex.new, map)
+    Factbase::Fact.new(Factbase.new, Mutex.new, map)
   end
 end

data/test/test_factbase.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# Copyright (c) 2024 Yegor Bugayenko
+# Copyright (c) 2024-2025 Yegor Bugayenko
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the 'Software'), to deal
@@ -22,6 +22,7 @@
 
 require 'minitest/autorun'
 require 'loog'
+require 'threads'
 require_relative '../lib/factbase'
 require_relative '../lib/factbase/rules'
 require_relative '../lib/factbase/inv'
@@ -30,7 +31,7 @@ require_relative '../lib/factbase/looged'
 
 # Factbase main module test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
-# Copyright:: Copyright (c) 2024 Yegor Bugayenko
+# Copyright:: Copyright (c) 2024-2025 Yegor Bugayenko
 # License:: MIT
 class TestFactbase < Minitest::Test
   def test_injects_data_correctly
@@ -48,13 +49,22 @@ class TestFactbase < Minitest::Test
     assert_equal([2, 3], maps[1]['bar'])
   end
 
+  def test_query_many_times
+    fb = Factbase.new
+    total = 5
+    total.times { fb.insert }
+    total.times do
+      assert_equal(5, fb.query('(always)').each.to_a.size)
+    end
+  end
+
   def test_simple_setting
     fb = Factbase.new
     fb.insert
     fb.insert.bar = 88
     found = 0
     fb.query('(exists bar)').each do |f|
-      assert(42, f.bar.positive?)
+      assert_predicate(f.bar, :positive?)
       f.foo = 42
       assert_equal(42, f.foo)
       found += 1
@@ -87,17 +97,17 @@ class TestFactbase < Minitest::Test
       File.binwrite(f.path, f1.export)
       f2.import(File.binread(f.path))
     end
-    assert_equal(1, f2.query('(eq foo 42)').each.to_a.count)
+    assert_equal(1, f2.query('(eq foo 42)').each.to_a.size)
   end
 
   def test_reads_from_empty_file
     fb = Factbase.new
     Tempfile.open do |f|
       File.binwrite(f.path, '')
-      assert(
-        assert_raises do
+      assert_includes(
+        assert_raises(StandardError) do
           fb.import(File.binread(f.path))
-        end.message.include?('cannot load a factbase')
+        end.message, 'cannot load a factbase'
       )
     end
   end
@@ -121,10 +131,10 @@ class TestFactbase < Minitest::Test
 
   def test_txn_returns_boolean
     fb = Factbase.new
-    assert(fb.txn { true }.is_a?(FalseClass))
-    assert(fb.txn(&:insert).is_a?(TrueClass))
+    assert_kind_of(FalseClass, fb.txn { true })
+    assert_kind_of(TrueClass, fb.txn(&:insert))
     assert(fb.txn { |fbt| fbt.insert.bar = 42 })
-    assert(!fb.txn { |fbt| fbt.query('(always)').each.to_a })
+    refute(fb.txn { |fbt| fbt.query('(always)').each.to_a })
     assert(fb.txn { |fbt| fbt.query('(always)').each { |f| f.hello = 33 } })
     assert(fb.txn { |fbt| fbt.query('(always)').each.to_a[0].zzz = 33 })
   end
@@ -136,13 +146,13 @@ class TestFactbase < Minitest::Test
       fbt.insert.z = 42
     end
     assert_equal(2, fb.size)
-    assert(
-      assert_raises do
+    assert_includes(
+      assert_raises(StandardError) do
         fb.txn do |fbt|
           fbt.insert.foo = 42
           throw 'intentionally'
         end
-      end.message.include?('intentionally')
+      end.message, 'intentionally'
     )
     assert_equal(2, fb.size)
   end
@@ -163,12 +173,12 @@ class TestFactbase < Minitest::Test
     fb.insert.bar = 3
     fb.insert.foo = 5
     assert_equal(2, fb.size)
-    assert(
-      assert_raises do
+    assert_includes(
+      assert_raises(StandardError) do
         fb.txn do |fbt|
           fbt.insert.foo = 42
         end
-      end.message.include?('oops')
+      end.message, 'oops'
     )
     assert_equal(2, fb.size)
   end
@@ -185,7 +195,7 @@ class TestFactbase < Minitest::Test
       d.txn do |fbt|
         fbt.insert.bar = 455
       end
-      assert_raises do
+      assert_raises(StandardError) do
         d.txn do |fbt|
           fbt.insert
           throw 'oops'
@@ -216,7 +226,177 @@ class TestFactbase < Minitest::Test
         fbt.insert.bar = 33
         raise Factbase::Rollback
       end
-    assert(!modified)
+    refute(modified)
     assert_equal(0, fb.query('(always)').each.to_a.size)
   end
+
+  def test_concurrent_inserts
+    fb = Factbase.new
+    Threads.new(100).assert do
+      fact = fb.insert
+      fact.foo = 42
+      fact.bar = 49
+      fact.value = fact.foo * fact.bar
+    end
+    assert_equal(100, fb.size)
+    assert_equal(100, fb.query('(eq foo 42)').each.to_a.size)
+    assert_equal(100, fb.query('(eq bar 49)').each.to_a.size)
+    assert_equal(100, fb.query("(eq value #{42 * 49})").each.to_a.size)
+  end
+
+  def test_different_values_when_concurrent_inserts
+    fb = Factbase.new
+    Threads.new(100).assert do |i|
+      fb.insert.foo = i
+    end
+    assert_equal(100, fb.size)
+    Threads.new(100) do |i|
+      f = fb.query("(eq foo #{i})").each.to_a
+      assert_equal(1, f.count)
+      assert_equal(i, f.first.foo)
+    end
+  end
+
+  # @todo #98:1h I assumed that the test `test_different_properties_when_concurrent_inserts` would be passed.
+  # I see like this:
+  # ```
+  # [2024-08-22 21:14:53.962] ERROR -- Expected: 1
+  # Actual: 0: nil
+  # [2024-08-22 21:14:53.962] ERROR -- Expected: 1
+  # Actual: 0: nil
+  # test_different_properties_when_concurrent_inserts              ERROR (0.01s)
+  # Minitest::UnexpectedError:         RuntimeError: Only 0 out of 5 threads completed successfully
+  #           /home/suban/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/threads-0.4.0/lib/threads.rb:73:in `assert'
+  #           test/test_factbase.rb:265:in `test_different_properties_when_concurrent_inserts'
+  # ```
+  def test_different_properties_when_concurrent_inserts
+    skip('Does not work')
+    fb = Factbase.new
+    Threads.new(5).assert do |i|
+      fb.insert.send(:"prop_#{i}=", i)
+    end
+    assert_equal(5, fb.size)
+    Threads.new(5).assert do |i|
+      prop = "prop_#{i}"
+      f = fb.query("(eq #{prop} #{i})").each.to_a
+      assert_equal(1, f.count)
+      assert_equal(i, f.first.send(prop.to_sym))
+    end
+  end
+
+  # @todo #98:1h I assumed that the test `test_concurrent_transactions_inserts` would be passed.
+  # I see like this:
+  # ```
+  # Expected: 100
+  # Actual: 99
+  # D:/a/factbase/factbase/test/test_factbase.rb:281:in `test_concurrent_transactions_inserts'
+  # ```
+  # See details here https://github.com/yegor256/factbase/actions/runs/10492255419/job/29068637032
+  def test_concurrent_transactions_inserts
+    skip('Does not work')
+    fb = Factbase.new
+    Threads.new(100).assert do |i|
+      fb.txn do |fbt|
+        fact = fbt.insert
+        fact.thread_id = i
+      end
+    end
+    assert_equal(100, fb.size)
+    assert_equal(100, fb.query('(exists thread_id)').each.to_a.size)
+  end
+
+  def test_concurrent_transactions_with_rollbacks
+    fb = Factbase.new
+    Threads.new(100).assert do |i|
+      fb.txn do |fbt|
+        fact = fbt.insert
+        fact.thread_id = i
+        raise Factbase::Rollback
+      end
+    end
+    assert_equal(0, fb.size)
+  end
+
+  def test_concurrent_transactions_successful
+    fb = Factbase.new
+    Threads.new(100).assert do |i|
+      fb.txn do |fbt|
+        fact = fbt.insert
+        fact.thread_id = i
+        fact.value = i * 10
+      end
+    end
+    facts = fb.query('(exists thread_id)').each.to_a
+    assert_equal(100, facts.size)
+    facts.each do |fact|
+      assert_equal(fact.value, fact.thread_id * 10)
+    end
+  end
+
+  # @todo #98:1h I assumed that the test `test_concurrent_queries` would be passed.
+  # I see like this:
+  # ```
+  # [2024-08-22 17:40:19.224] ERROR -- Expected: [0, 1]
+  # Actual: [0, 0]: nil
+  # [2024-08-22 17:40:19.224] ERROR -- Expected: [0, 1]
+  # Actual: [0, 0]: nil
+  # test_concurrent_queries                                        ERROR (0.00s)
+  # Minitest::UnexpectedError:         RuntimeError: Only 0 out of 2 threads completed successfully
+  #           /home/suban/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/threads-0.4.0/lib/threads.rb:73:in `assert'
+  #           test/test_factbase.rb:329:in `test_concurrent_queries'
+  # ```
+  def test_concurrent_queries
+    skip('Does not work')
+    fb = Factbase.new
+    Threads.new(2).assert do |i|
+      fact = fb.insert
+      fact.thread_id = i
+      fact.value = i * 10
+    end
+    Threads.new(2).assert do
+      results = fb.query('(exists thread_id)').each.to_a
+      assert_equal(2, results.size)
+
+      thread_ids = results.map(&:thread_id)
+      assert_equal((0..1).to_a, thread_ids.sort)
+    end
+  end
+
+  def test_export_import_concurrent
+    fb = Factbase.new
+    Threads.new(100).assert do
+      fact = fb.insert
+      fact.value = 42
+    end
+    Threads.new(5).assert do
+      new_fb = Factbase.new
+      new_fb.import(fb.export)
+      assert_equal(fb.size, new_fb.size)
+      facts = fb.query('(eq value 42)').each.to_a
+      assert_equal(100, facts.size)
+      facts.each do |fact|
+        new_fact = new_fb.query("(eq value #{fact.value})").each.to_a.first
+        assert_equal(fact.value, new_fact.value)
+      end
+    end
+  end
+
+  def test_dup_concurrent
+    fb = Factbase.new
+    mutex = Mutex.new
+    Threads.new(100).assert do
+      fact = fb.insert
+      fact.foo = 42
+    end
+    fbs = []
+    Threads.new(100).assert do
+      mutex.synchronize do
+        fbs << fb.dup
+      end
+    end
+    assert_equal(100, fbs.size)
+    fbs.each do |factbase|
+      assert_equal(100, factbase.query('(eq foo 42)').each.to_a.size)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: factbase
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Yegor Bugayenko
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-12 00:00:00.000000000 Z
+date: 2025-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace
@@ -137,6 +137,7 @@ files:
 - ".0pdd.yml"
 - ".gitattributes"
 - ".github/workflows/actionlint.yml"
+- ".github/workflows/benchmark.yml"
 - ".github/workflows/codecov.yml"
 - ".github/workflows/copyrights.yml"
 - ".github/workflows/markdown-lint.yml"
@@ -155,6 +156,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- benchmarks/simple.rb
 - factbase.gemspec
 - lib/factbase.rb
 - lib/factbase/accum.rb
@@ -164,10 +166,12 @@ files:
 - lib/factbase/looged.rb
 - lib/factbase/pre.rb
 - lib/factbase/query.rb
+- lib/factbase/query_once.rb
 - lib/factbase/rules.rb
 - lib/factbase/syntax.rb
 - lib/factbase/tee.rb
 - lib/factbase/term.rb
+- lib/factbase/term_once.rb
 - lib/factbase/terms/aggregates.rb
 - lib/factbase/terms/aliases.rb
 - lib/factbase/terms/casting.rb
@@ -186,9 +190,12 @@ files:
 - test/factbase/terms/test_aggregates.rb
 - test/factbase/terms/test_aliases.rb
 - test/factbase/terms/test_casting.rb
+- test/factbase/terms/test_debug.rb
 - test/factbase/terms/test_defn.rb
 - test/factbase/terms/test_logical.rb
 - test/factbase/terms/test_math.rb
+- test/factbase/terms/test_meta.rb
+- test/factbase/terms/test_ordering.rb
 - test/factbase/terms/test_strings.rb
 - test/factbase/terms/test_system.rb
 - test/factbase/test_accum.rb
@@ -212,7 +219,7 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--charset=UTF-8"
 require_paths:
@@ -229,7 +236,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.4.10
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Factbase
 test_files: []